* [PATCH 0/2] exec: Cover gen-icount.h in MAINTAINERS, add missing exec-all.h header
@ 2021-04-22 6:41 Philippe Mathieu-Daudé
2021-04-22 6:41 ` [PATCH 1/2] MAINTAINERS: Add include/exec/gen-icount.h to 'Main Loop' section Philippe Mathieu-Daudé
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-04-22 6:41 UTC (permalink / raw)
To: qemu-devel
Cc: Richard Henderson, Philippe Mathieu-Daudé,
Pavel Dovgalyuk, Emilio G . Cota, Paolo Bonzini,
Alex Bennée
include/exec/gen-icount.h is listed as unmaintained.
Add it to Main Loop (or should it be TCG? softmmu/icount.c
is already there).
Add the missing "exec/exec-all.h" header.
Philippe Mathieu-Daudé (2):
MAINTAINERS: Add include/exec/gen-icount.h to 'Main Loop' section
exec/gen-icount.h: Add missing "exec/exec-all.h" include
include/exec/gen-icount.h | 1 +
MAINTAINERS | 1 +
2 files changed, 2 insertions(+)
--
2.26.3
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] MAINTAINERS: Add include/exec/gen-icount.h to 'Main Loop' section
2021-04-22 6:41 [PATCH 0/2] exec: Cover gen-icount.h in MAINTAINERS, add missing exec-all.h header Philippe Mathieu-Daudé
@ 2021-04-22 6:41 ` Philippe Mathieu-Daudé
2021-04-22 6:41 ` [PATCH 2/2] exec/gen-icount.h: Add missing "exec/exec-all.h" include Philippe Mathieu-Daudé
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-04-22 6:41 UTC (permalink / raw)
To: qemu-devel
Cc: Richard Henderson, Philippe Mathieu-Daudé,
Pavel Dovgalyuk, Emilio G . Cota, Paolo Bonzini,
Alex Bennée
As the 'Main Loop' section covers softmmu/icount.c,
add "exec/gen-icount.h" there too.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 36055f14c59..b91419ef08d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2445,6 +2445,7 @@ F: ui/cocoa.m
Main loop
M: Paolo Bonzini <pbonzini@redhat.com>
S: Maintained
+F: include/exec/gen-icount.h
F: include/qemu/main-loop.h
F: include/sysemu/runstate.h
F: include/sysemu/runstate-action.h
--
2.26.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] exec/gen-icount.h: Add missing "exec/exec-all.h" include
2021-04-22 6:41 [PATCH 0/2] exec: Cover gen-icount.h in MAINTAINERS, add missing exec-all.h header Philippe Mathieu-Daudé
2021-04-22 6:41 ` [PATCH 1/2] MAINTAINERS: Add include/exec/gen-icount.h to 'Main Loop' section Philippe Mathieu-Daudé
@ 2021-04-22 6:41 ` Philippe Mathieu-Daudé
2021-05-02 16:23 ` [PATCH 0/2] exec: Cover gen-icount.h in MAINTAINERS, add missing exec-all.h header Philippe Mathieu-Daudé
2021-05-02 16:31 ` Richard Henderson
3 siblings, 0 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-04-22 6:41 UTC (permalink / raw)
To: qemu-devel
Cc: Richard Henderson, Philippe Mathieu-Daudé,
Pavel Dovgalyuk, Emilio G . Cota, Paolo Bonzini,
Alex Bennée
When including "exec/gen-icount.h" we get:
include/exec/gen-icount.h: In function ‘gen_tb_start’:
include/exec/gen-icount.h:40:9: error: implicit declaration of function ‘tb_cflags’ [-Werror=implicit-function-declaration]
40 | if (tb_cflags(tb) & CF_USE_ICOUNT) {
| ^~~~~~~~~
include/exec/gen-icount.h:40:9: error: nested extern declaration of ‘tb_cflags’ [-Werror=nested-externs]
include/exec/gen-icount.h:40:25: error: ‘CF_USE_ICOUNT’ undeclared (first use in this function); did you mean ‘CPU_COUNT’?
40 | if (tb_cflags(tb) & CF_USE_ICOUNT) {
| ^~~~~~~~~~~~~
| CPU_COUNT
Since tb_cflags() is declared in "exec/exec-all.h", include this
header in "exec/gen-icount.h".
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
include/exec/gen-icount.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/exec/gen-icount.h b/include/exec/gen-icount.h
index 298e01eef49..467529d84c5 100644
--- a/include/exec/gen-icount.h
+++ b/include/exec/gen-icount.h
@@ -1,6 +1,7 @@
#ifndef GEN_ICOUNT_H
#define GEN_ICOUNT_H
+#include "exec/exec-all.h"
#include "qemu/timer.h"
/* Helpers for instruction counting code generation. */
--
2.26.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 0/2] exec: Cover gen-icount.h in MAINTAINERS, add missing exec-all.h header
2021-04-22 6:41 [PATCH 0/2] exec: Cover gen-icount.h in MAINTAINERS, add missing exec-all.h header Philippe Mathieu-Daudé
2021-04-22 6:41 ` [PATCH 1/2] MAINTAINERS: Add include/exec/gen-icount.h to 'Main Loop' section Philippe Mathieu-Daudé
2021-04-22 6:41 ` [PATCH 2/2] exec/gen-icount.h: Add missing "exec/exec-all.h" include Philippe Mathieu-Daudé
@ 2021-05-02 16:23 ` Philippe Mathieu-Daudé
2021-05-02 16:31 ` Richard Henderson
3 siblings, 0 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-05-02 16:23 UTC (permalink / raw)
To: qemu-devel
Cc: Alex Bennée, Paolo Bonzini, Pavel Dovgalyuk,
Emilio G . Cota, Richard Henderson
ping?
On 4/22/21 8:41 AM, Philippe Mathieu-Daudé wrote:
> include/exec/gen-icount.h is listed as unmaintained.
> Add it to Main Loop (or should it be TCG? softmmu/icount.c
> is already there).
>
> Add the missing "exec/exec-all.h" header.
>
> Philippe Mathieu-Daudé (2):
> MAINTAINERS: Add include/exec/gen-icount.h to 'Main Loop' section
> exec/gen-icount.h: Add missing "exec/exec-all.h" include
>
> include/exec/gen-icount.h | 1 +
> MAINTAINERS | 1 +
> 2 files changed, 2 insertions(+)
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 0/2] exec: Cover gen-icount.h in MAINTAINERS, add missing exec-all.h header
2021-04-22 6:41 [PATCH 0/2] exec: Cover gen-icount.h in MAINTAINERS, add missing exec-all.h header Philippe Mathieu-Daudé
` (2 preceding siblings ...)
2021-05-02 16:23 ` [PATCH 0/2] exec: Cover gen-icount.h in MAINTAINERS, add missing exec-all.h header Philippe Mathieu-Daudé
@ 2021-05-02 16:31 ` Richard Henderson
3 siblings, 0 replies; 5+ messages in thread
From: Richard Henderson @ 2021-05-02 16:31 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Paolo Bonzini, Pavel Dovgalyuk, Emilio G . Cota, Alex Bennée
On 4/21/21 11:41 PM, Philippe Mathieu-Daudé wrote:
> Philippe Mathieu-Daudé (2):
> MAINTAINERS: Add include/exec/gen-icount.h to 'Main Loop' section
> exec/gen-icount.h: Add missing "exec/exec-all.h" include
Queued, thanks.
r~
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-05-02 17:07 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-22 6:41 [PATCH 0/2] exec: Cover gen-icount.h in MAINTAINERS, add missing exec-all.h header Philippe Mathieu-Daudé
2021-04-22 6:41 ` [PATCH 1/2] MAINTAINERS: Add include/exec/gen-icount.h to 'Main Loop' section Philippe Mathieu-Daudé
2021-04-22 6:41 ` [PATCH 2/2] exec/gen-icount.h: Add missing "exec/exec-all.h" include Philippe Mathieu-Daudé
2021-05-02 16:23 ` [PATCH 0/2] exec: Cover gen-icount.h in MAINTAINERS, add missing exec-all.h header Philippe Mathieu-Daudé
2021-05-02 16:31 ` Richard Henderson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.