All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sherry Sun <sherry.sun@nxp.com>
To: gregkh@linuxfoundation.org, jirislaby@kernel.org
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-imx@nxp.com
Subject: [PATCH 1/2] tty: serial: fsl_lpuart: fix the potential bug of division or modulo by zero
Date: Mon, 26 Apr 2021 15:49:34 +0800	[thread overview]
Message-ID: <20210426074935.11131-2-sherry.sun@nxp.com> (raw)
In-Reply-To: <20210426074935.11131-1-sherry.sun@nxp.com>

This issue is reported by Coverity Check.
In lpuart32_console_get_options, division or modulo by zero may results
in undefined behavior.

Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
---
 drivers/tty/serial/fsl_lpuart.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c
index 794035041744..777d54b593f8 100644
--- a/drivers/tty/serial/fsl_lpuart.c
+++ b/drivers/tty/serial/fsl_lpuart.c
@@ -2414,6 +2414,9 @@ lpuart32_console_get_options(struct lpuart_port *sport, int *baud,
 
 	bd = lpuart32_read(&sport->port, UARTBAUD);
 	bd &= UARTBAUD_SBR_MASK;
+	if (!bd)
+		return;
+
 	sbr = bd;
 	uartclk = lpuart_get_baud_clk_rate(sport);
 	/*
-- 
2.17.1


  reply	other threads:[~2021-04-26  7:57 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-26  7:49 [PATCH 0/2] Fix two coverity issues in fsl_lpuart.c Sherry Sun
2021-04-26  7:49 ` Sherry Sun [this message]
2021-04-26  8:08   ` [PATCH 1/2] tty: serial: fsl_lpuart: fix the potential bug of division or modulo by zero Greg KH
2021-04-26 11:30     ` Sherry Sun
2021-04-26 11:34       ` Greg KH
2021-04-26 11:51         ` Sherry Sun
2021-04-26 12:23           ` Greg KH
2021-04-26 12:50             ` Sherry Sun
2021-04-26  7:49 ` [PATCH 2/2] tty: serial: fsl_lpuart: fix the potential bug of dereference null return value Sherry Sun
2021-04-26  8:09   ` Greg KH
2021-04-26 11:39     ` Sherry Sun
2021-04-26 11:57       ` Fabio Estevam
2021-04-26 12:09         ` Sherry Sun
2021-04-26 12:15           ` Fabio Estevam
2021-04-26 12:48             ` Sherry Sun
2021-04-26 12:22       ` Greg KH
2021-04-26 12:46         ` Sherry Sun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210426074935.11131-2-sherry.sun@nxp.com \
    --to=sherry.sun@nxp.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.