All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabio Estevam <festevam@gmail.com>
To: Sherry Sun <sherry.sun@nxp.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	"jirislaby@kernel.org" <jirislaby@kernel.org>,
	"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH 2/2] tty: serial: fsl_lpuart: fix the potential bug of dereference null return value
Date: Mon, 26 Apr 2021 08:57:38 -0300	[thread overview]
Message-ID: <CAOMZO5Bmv2CVZeJbwLhZcH7pb7Tb9FhCrPSjhkbaJO8vYtRHLw@mail.gmail.com> (raw)
In-Reply-To: <AM0PR04MB4947DAD4EAA84FEAA5A2B28A92429@AM0PR04MB4947.eurprd04.prod.outlook.com>

Hi Sherry,

On Mon, Apr 26, 2021 at 8:39 AM Sherry Sun <sherry.sun@nxp.com> wrote:

> > > +   if (!sdata)
> > > +           return -ENODEV;
> >
> > How can sdata be NULL?
>
> Is it possible that a case forgot to set sdata? Then the value will be NULL, such as { .compatible = "fsl,imx8qxp-lpuart",  }.
> So I added the patch to avoid the kernel crash when run to sdata->reg_off directly. But I am not sure does it make sense.

sdata comes directly from of_device_get_match_data().

This driver only runs on DT platforms and the only way of being probed
is when a compatible string matches, so it is not possible that sdata
can be NULL.

  reply	other threads:[~2021-04-26 11:57 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-26  7:49 [PATCH 0/2] Fix two coverity issues in fsl_lpuart.c Sherry Sun
2021-04-26  7:49 ` [PATCH 1/2] tty: serial: fsl_lpuart: fix the potential bug of division or modulo by zero Sherry Sun
2021-04-26  8:08   ` Greg KH
2021-04-26 11:30     ` Sherry Sun
2021-04-26 11:34       ` Greg KH
2021-04-26 11:51         ` Sherry Sun
2021-04-26 12:23           ` Greg KH
2021-04-26 12:50             ` Sherry Sun
2021-04-26  7:49 ` [PATCH 2/2] tty: serial: fsl_lpuart: fix the potential bug of dereference null return value Sherry Sun
2021-04-26  8:09   ` Greg KH
2021-04-26 11:39     ` Sherry Sun
2021-04-26 11:57       ` Fabio Estevam [this message]
2021-04-26 12:09         ` Sherry Sun
2021-04-26 12:15           ` Fabio Estevam
2021-04-26 12:48             ` Sherry Sun
2021-04-26 12:22       ` Greg KH
2021-04-26 12:46         ` Sherry Sun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOMZO5Bmv2CVZeJbwLhZcH7pb7Tb9FhCrPSjhkbaJO8vYtRHLw@mail.gmail.com \
    --to=festevam@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=sherry.sun@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.