From: Fabio Estevam <festevam@gmail.com>
To: Sherry Sun <sherry.sun@nxp.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
"jirislaby@kernel.org" <jirislaby@kernel.org>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH 2/2] tty: serial: fsl_lpuart: fix the potential bug of dereference null return value
Date: Mon, 26 Apr 2021 09:15:51 -0300 [thread overview]
Message-ID: <CAOMZO5DXLoy-PRQW0sYXf+eDOZ1=XqKsC-hcNWMKLg9K2oGQQg@mail.gmail.com> (raw)
In-Reply-To: <AM0PR04MB49472A690A93C06CE27FFC4692429@AM0PR04MB4947.eurprd04.prod.outlook.com>
On Mon, Apr 26, 2021 at 9:09 AM Sherry Sun <sherry.sun@nxp.com> wrote:
> Thanks for your reply.
> I guess you mean the of_match_table will not be NULL since it contains compatible, right?
> But for the lpuart data -- struct lpuart_soc_data, won’t it meet the NULL case? such as { .compatible = "fsl,imx8qxp-lpuart", }.
> Here of_device_id won’t be NULL, but lpuart_soc_data Is NULL.
In linux-next we have:
static const struct of_device_id lpuart_dt_ids[] = {
{ .compatible = "fsl,vf610-lpuart", .data = &vf_data, },
{ .compatible = "fsl,ls1021a-lpuart", .data = &ls1021a_data, },
{ .compatible = "fsl,ls1028a-lpuart", .data = &ls1028a_data, },
{ .compatible = "fsl,imx7ulp-lpuart", .data = &imx7ulp_data, },
{ .compatible = "fsl,imx8qxp-lpuart", .data = &imx8qxp_data, },
{ /* sentinel */ }
};
All compatible entries have a .data field populated.
How sdata can be NULL?
next prev parent reply other threads:[~2021-04-26 12:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-26 7:49 [PATCH 0/2] Fix two coverity issues in fsl_lpuart.c Sherry Sun
2021-04-26 7:49 ` [PATCH 1/2] tty: serial: fsl_lpuart: fix the potential bug of division or modulo by zero Sherry Sun
2021-04-26 8:08 ` Greg KH
2021-04-26 11:30 ` Sherry Sun
2021-04-26 11:34 ` Greg KH
2021-04-26 11:51 ` Sherry Sun
2021-04-26 12:23 ` Greg KH
2021-04-26 12:50 ` Sherry Sun
2021-04-26 7:49 ` [PATCH 2/2] tty: serial: fsl_lpuart: fix the potential bug of dereference null return value Sherry Sun
2021-04-26 8:09 ` Greg KH
2021-04-26 11:39 ` Sherry Sun
2021-04-26 11:57 ` Fabio Estevam
2021-04-26 12:09 ` Sherry Sun
2021-04-26 12:15 ` Fabio Estevam [this message]
2021-04-26 12:48 ` Sherry Sun
2021-04-26 12:22 ` Greg KH
2021-04-26 12:46 ` Sherry Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOMZO5DXLoy-PRQW0sYXf+eDOZ1=XqKsC-hcNWMKLg9K2oGQQg@mail.gmail.com' \
--to=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sherry.sun@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.