* [PATCH] drm/amdkfd: Add Aldebaran gws support
@ 2021-04-27 19:56 Harish Kasiviswanathan
2021-04-27 22:17 ` Greathouse, Joseph
0 siblings, 1 reply; 4+ messages in thread
From: Harish Kasiviswanathan @ 2021-04-27 19:56 UTC (permalink / raw)
To: amd-gfx, joseph.greathouse; +Cc: Harish Kasiviswanathan
v2: updated MEC FW version after validating gws with debugger
Signed-off-by: Harish Kasiviswanathan <Harish.Kasiviswanathan@amd.com>
---
drivers/gpu/drm/amd/amdkfd/kfd_device.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
index 348fd3e49017..ae3cabb47a26 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_device.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
@@ -699,7 +699,9 @@ static int kfd_gws_init(struct kfd_dev *kfd)
&& kfd->device_info->asic_family <= CHIP_RAVEN
&& kfd->mec2_fw_version >= 0x1b3)
|| (kfd->device_info->asic_family == CHIP_ARCTURUS
- && kfd->mec2_fw_version >= 0x30))
+ && kfd->mec2_fw_version >= 0x30)
+ || (kfd->device_info->asic_family == CHIP_ALDEBARAN
+ && kfd->mec2_fw_version >= 0x28))
ret = amdgpu_amdkfd_alloc_gws(kfd->kgd,
amdgpu_amdkfd_get_num_gws(kfd->kgd), &kfd->gws);
--
2.25.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [PATCH] drm/amdkfd: Add Aldebaran gws support
2021-04-27 19:56 [PATCH] drm/amdkfd: Add Aldebaran gws support Harish Kasiviswanathan
@ 2021-04-27 22:17 ` Greathouse, Joseph
0 siblings, 0 replies; 4+ messages in thread
From: Greathouse, Joseph @ 2021-04-27 22:17 UTC (permalink / raw)
To: Kasiviswanathan, Harish, amd-gfx
> -----Original Message-----
> From: Kasiviswanathan, Harish <Harish.Kasiviswanathan@amd.com>
> Sent: Tuesday, April 27, 2021 2:57 PM
> To: amd-gfx@lists.freedesktop.org; Greathouse, Joseph <Joseph.Greathouse@amd.com>
> Cc: Kasiviswanathan, Harish <Harish.Kasiviswanathan@amd.com>
> Subject: [PATCH] drm/amdkfd: Add Aldebaran gws support
>
> v2: updated MEC FW version after validating gws with debugger
>
> Signed-off-by: Harish Kasiviswanathan <Harish.Kasiviswanathan@amd.com>
Reviewed-by: Joseph Greathouse <Joseph.Greathouse@amd.com>
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_device.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
> index 348fd3e49017..ae3cabb47a26 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_device.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
> @@ -699,7 +699,9 @@ static int kfd_gws_init(struct kfd_dev *kfd)
> && kfd->device_info->asic_family <= CHIP_RAVEN
> && kfd->mec2_fw_version >= 0x1b3)
> || (kfd->device_info->asic_family == CHIP_ARCTURUS
> - && kfd->mec2_fw_version >= 0x30))
> + && kfd->mec2_fw_version >= 0x30)
> + || (kfd->device_info->asic_family == CHIP_ALDEBARAN
> + && kfd->mec2_fw_version >= 0x28))
> ret = amdgpu_amdkfd_alloc_gws(kfd->kgd,
> amdgpu_amdkfd_get_num_gws(kfd->kgd), &kfd->gws);
>
> --
> 2.25.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] drm/amdkfd: Add Aldebaran gws support
@ 2021-04-22 2:01 Harish Kasiviswanathan
2021-04-22 2:11 ` Felix Kuehling
0 siblings, 1 reply; 4+ messages in thread
From: Harish Kasiviswanathan @ 2021-04-22 2:01 UTC (permalink / raw)
To: amd-gfx, Joseph.Greathouse; +Cc: Harish Kasiviswanathan
Signed-off-by: Harish Kasiviswanathan <Harish.Kasiviswanathan@amd.com>
---
drivers/gpu/drm/amd/amdkfd/kfd_device.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
index b31bae91fbd0..bc57b07523e0 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_device.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
@@ -698,7 +698,9 @@ static int kfd_gws_init(struct kfd_dev *kfd)
&& kfd->device_info->asic_family <= CHIP_RAVEN
&& kfd->mec2_fw_version >= 0x1b3)
|| (kfd->device_info->asic_family == CHIP_ARCTURUS
- && kfd->mec2_fw_version >= 0x30))
+ && kfd->mec2_fw_version >= 0x30)
+ || (kfd->device_info->asic_family == CHIP_ALDEBARAN
+ && kfd->mec2_fw_version >= 0x27))
ret = amdgpu_amdkfd_alloc_gws(kfd->kgd,
amdgpu_amdkfd_get_num_gws(kfd->kgd), &kfd->gws);
--
2.25.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amdkfd: Add Aldebaran gws support
2021-04-22 2:01 Harish Kasiviswanathan
@ 2021-04-22 2:11 ` Felix Kuehling
0 siblings, 0 replies; 4+ messages in thread
From: Felix Kuehling @ 2021-04-22 2:11 UTC (permalink / raw)
To: Harish Kasiviswanathan, amd-gfx, Joseph.Greathouse
On 2021-04-21 10:01 p.m., Harish Kasiviswanathan wrote:
> Signed-off-by: Harish Kasiviswanathan <Harish.Kasiviswanathan@amd.com>
Acked-by: Felix Kuehling <Felix.Kuehling@amd.com>
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_device.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
> index b31bae91fbd0..bc57b07523e0 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_device.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
> @@ -698,7 +698,9 @@ static int kfd_gws_init(struct kfd_dev *kfd)
> && kfd->device_info->asic_family <= CHIP_RAVEN
> && kfd->mec2_fw_version >= 0x1b3)
> || (kfd->device_info->asic_family == CHIP_ARCTURUS
> - && kfd->mec2_fw_version >= 0x30))
> + && kfd->mec2_fw_version >= 0x30)
> + || (kfd->device_info->asic_family == CHIP_ALDEBARAN
> + && kfd->mec2_fw_version >= 0x27))
> ret = amdgpu_amdkfd_alloc_gws(kfd->kgd,
> amdgpu_amdkfd_get_num_gws(kfd->kgd), &kfd->gws);
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-04-27 22:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-27 19:56 [PATCH] drm/amdkfd: Add Aldebaran gws support Harish Kasiviswanathan
2021-04-27 22:17 ` Greathouse, Joseph
-- strict thread matches above, loose matches on Subject: below --
2021-04-22 2:01 Harish Kasiviswanathan
2021-04-22 2:11 ` Felix Kuehling
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.