* [LTP] [PATCH v3] commands/lsmod01.sh: Replace tst_res with tst_brk
@ 2021-04-29 2:09 Zhao Gongyi
2021-04-29 6:52 ` Petr Vorel
2021-04-29 17:12 ` Petr Vorel
0 siblings, 2 replies; 3+ messages in thread
From: Zhao Gongyi @ 2021-04-29 2:09 UTC (permalink / raw)
To: ltp
We need replace tst_res with tst_brk to terminate the test immediately since
there is no sence to go on.
Signed-off-by: Zhao Gongyi <zhaogongyi@huawei.com>
---
v2->v3: split into two separate commits
testcases/commands/lsmod/lsmod01.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/testcases/commands/lsmod/lsmod01.sh b/testcases/commands/lsmod/lsmod01.sh
index 2e044c718..4ed91eca5 100755
--- a/testcases/commands/lsmod/lsmod01.sh
+++ b/testcases/commands/lsmod/lsmod01.sh
@@ -23,7 +23,7 @@ setup()
tst_require_cmds insmod
insmod "$TST_MODPATH"
if [ $? -ne 0 ]; then
- tst_res TBROK "insmod failed"
+ tst_brk TBROK "insmod failed"
return
fi
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [LTP] [PATCH v3] commands/lsmod01.sh: Replace tst_res with tst_brk
2021-04-29 2:09 [LTP] [PATCH v3] commands/lsmod01.sh: Replace tst_res with tst_brk Zhao Gongyi
@ 2021-04-29 6:52 ` Petr Vorel
2021-04-29 17:12 ` Petr Vorel
1 sibling, 0 replies; 3+ messages in thread
From: Petr Vorel @ 2021-04-29 6:52 UTC (permalink / raw)
To: ltp
Hi,
> We need replace tst_res with tst_brk to terminate the test immediately since
> there is no sence to go on.
> Signed-off-by: Zhao Gongyi <zhaogongyi@huawei.com>
> ---
> v2->v3: split into two separate commits
> testcases/commands/lsmod/lsmod01.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/testcases/commands/lsmod/lsmod01.sh b/testcases/commands/lsmod/lsmod01.sh
> index 2e044c718..4ed91eca5 100755
> --- a/testcases/commands/lsmod/lsmod01.sh
> +++ b/testcases/commands/lsmod/lsmod01.sh
> @@ -23,7 +23,7 @@ setup()
> tst_require_cmds insmod
> insmod "$TST_MODPATH"
> if [ $? -ne 0 ]; then
> - tst_res TBROK "insmod failed"
> + tst_brk TBROK "insmod failed"
> return
There does not need to be return (in cleanup function tst_brk just prints
warning and continues, but elsewhere it just quits).
I'll fix that during merge.
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Kind regards,
Petr
^ permalink raw reply [flat|nested] 3+ messages in thread
* [LTP] [PATCH v3] commands/lsmod01.sh: Replace tst_res with tst_brk
2021-04-29 2:09 [LTP] [PATCH v3] commands/lsmod01.sh: Replace tst_res with tst_brk Zhao Gongyi
2021-04-29 6:52 ` Petr Vorel
@ 2021-04-29 17:12 ` Petr Vorel
1 sibling, 0 replies; 3+ messages in thread
From: Petr Vorel @ 2021-04-29 17:12 UTC (permalink / raw)
To: ltp
Hi,
> +++ b/testcases/commands/lsmod/lsmod01.sh
> @@ -23,7 +23,7 @@ setup()
> tst_require_cmds insmod
> insmod "$TST_MODPATH"
> if [ $? -ne 0 ]; then
> - tst_res TBROK "insmod failed"
> + tst_brk TBROK "insmod failed"
I replace whole block with ROD and merged. Thanks!
Kind regards,
Petr
> return
> fi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-29 17:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-29 2:09 [LTP] [PATCH v3] commands/lsmod01.sh: Replace tst_res with tst_brk Zhao Gongyi
2021-04-29 6:52 ` Petr Vorel
2021-04-29 17:12 ` Petr Vorel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.