* [PATCH] drm/i915: Use might_alloc() @ 2021-04-29 2:13 ` Bernard Zhao 0 siblings, 0 replies; 14+ messages in thread From: Bernard Zhao @ 2021-04-29 2:13 UTC (permalink / raw) To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, David Airlie, Daniel Vetter, intel-gfx, dri-devel, linux-kernel Cc: Bernard Zhao This maybe uses lockdep through the fs_reclaim annotations. Signed-off-by: Bernard Zhao <bernard@vivo.com> --- drivers/gpu/drm/i915/i915_request.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c index 9165971c3c47..7e1aa540aa0d 100644 --- a/drivers/gpu/drm/i915/i915_request.c +++ b/drivers/gpu/drm/i915/i915_request.c @@ -928,7 +928,7 @@ __i915_request_create(struct intel_context *ce, gfp_t gfp) u32 seqno; int ret; - might_sleep_if(gfpflags_allow_blocking(gfp)); + might_alloc(gfp); /* Check that the caller provided an already pinned context */ __intel_context_pin(ce); -- 2.31.0 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [Intel-gfx] [PATCH] drm/i915: Use might_alloc() @ 2021-04-29 2:13 ` Bernard Zhao 0 siblings, 0 replies; 14+ messages in thread From: Bernard Zhao @ 2021-04-29 2:13 UTC (permalink / raw) To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, David Airlie, Daniel Vetter, intel-gfx, dri-devel, linux-kernel Cc: Bernard Zhao This maybe uses lockdep through the fs_reclaim annotations. Signed-off-by: Bernard Zhao <bernard@vivo.com> --- drivers/gpu/drm/i915/i915_request.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c index 9165971c3c47..7e1aa540aa0d 100644 --- a/drivers/gpu/drm/i915/i915_request.c +++ b/drivers/gpu/drm/i915/i915_request.c @@ -928,7 +928,7 @@ __i915_request_create(struct intel_context *ce, gfp_t gfp) u32 seqno; int ret; - might_sleep_if(gfpflags_allow_blocking(gfp)); + might_alloc(gfp); /* Check that the caller provided an already pinned context */ __intel_context_pin(ce); -- 2.31.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH] drm/i915: Use might_alloc() @ 2021-04-29 2:13 ` Bernard Zhao 0 siblings, 0 replies; 14+ messages in thread From: Bernard Zhao @ 2021-04-29 2:13 UTC (permalink / raw) To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, David Airlie, Daniel Vetter, intel-gfx, dri-devel, linux-kernel Cc: Bernard Zhao This maybe uses lockdep through the fs_reclaim annotations. Signed-off-by: Bernard Zhao <bernard@vivo.com> --- drivers/gpu/drm/i915/i915_request.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c index 9165971c3c47..7e1aa540aa0d 100644 --- a/drivers/gpu/drm/i915/i915_request.c +++ b/drivers/gpu/drm/i915/i915_request.c @@ -928,7 +928,7 @@ __i915_request_create(struct intel_context *ce, gfp_t gfp) u32 seqno; int ret; - might_sleep_if(gfpflags_allow_blocking(gfp)); + might_alloc(gfp); /* Check that the caller provided an already pinned context */ __intel_context_pin(ce); -- 2.31.0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Use might_alloc() (rev2) 2021-04-29 2:13 ` Bernard Zhao (?) (?) @ 2021-04-29 18:00 ` Patchwork -1 siblings, 0 replies; 14+ messages in thread From: Patchwork @ 2021-04-29 18:00 UTC (permalink / raw) To: Bernard Zhao; +Cc: intel-gfx [-- Attachment #1.1: Type: text/plain, Size: 3163 bytes --] == Series Details == Series: drm/i915: Use might_alloc() (rev2) URL : https://patchwork.freedesktop.org/series/89653/ State : success == Summary == CI Bug Log - changes from CI_DRM_10027 -> Patchwork_20036 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/index.html Known issues ------------ Here are the changes found in Patchwork_20036 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@amdgpu/amd_prime@amd-to-i915: - fi-tgl-y: NOTRUN -> [SKIP][1] ([fdo#109315] / [i915#2575]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/fi-tgl-y/igt@amdgpu/amd_prime@amd-to-i915.html #### Possible fixes #### * igt@gem_exec_suspend@basic-s3: - fi-tgl-u2: [FAIL][2] ([i915#1888]) -> [PASS][3] [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10027/fi-tgl-u2/igt@gem_exec_suspend@basic-s3.html [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/fi-tgl-u2/igt@gem_exec_suspend@basic-s3.html * igt@i915_selftest@live@gt_heartbeat: - {fi-jsl-1}: [DMESG-WARN][4] ([i915#1222]) -> [PASS][5] [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10027/fi-jsl-1/igt@i915_selftest@live@gt_heartbeat.html [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/fi-jsl-1/igt@i915_selftest@live@gt_heartbeat.html * igt@kms_frontbuffer_tracking@basic: - {fi-rkl-11500t}: [SKIP][6] ([i915#1849] / [i915#3180]) -> [PASS][7] [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10027/fi-rkl-11500t/igt@kms_frontbuffer_tracking@basic.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/fi-rkl-11500t/igt@kms_frontbuffer_tracking@basic.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315 [i915#1222]: https://gitlab.freedesktop.org/drm/intel/issues/1222 [i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849 [i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888 [i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575 [i915#3180]: https://gitlab.freedesktop.org/drm/intel/issues/3180 [i915#3303]: https://gitlab.freedesktop.org/drm/intel/issues/3303 Participating hosts (44 -> 40) ------------------------------ Missing (4): fi-ilk-m540 fi-bsw-cyan fi-bdw-samus fi-hsw-4200u Build changes ------------- * Linux: CI_DRM_10027 -> Patchwork_20036 CI-20190529: 20190529 CI_DRM_10027: 1748cb1e8bdf543570b86f39487b171ad4c1f896 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_6077: 126a3f6fc0e97786e2819085efc84e741093aed5 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_20036: f804f5bedd3e90360fa2a7292bea3bc39f2c51f6 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == f804f5bedd3e drm/i915: Use might_alloc() == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/index.html [-- Attachment #1.2: Type: text/html, Size: 3782 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 14+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Use might_alloc() (rev2) 2021-04-29 2:13 ` Bernard Zhao ` (2 preceding siblings ...) (?) @ 2021-04-29 21:18 ` Patchwork -1 siblings, 0 replies; 14+ messages in thread From: Patchwork @ 2021-04-29 21:18 UTC (permalink / raw) To: Bernard Zhao; +Cc: intel-gfx [-- Attachment #1.1: Type: text/plain, Size: 30257 bytes --] == Series Details == Series: drm/i915: Use might_alloc() (rev2) URL : https://patchwork.freedesktop.org/series/89653/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10027_full -> Patchwork_20036_full ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with Patchwork_20036_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_20036_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_20036_full: ### IGT changes ### #### Possible regressions #### * igt@gem_exec_schedule@wide@vecs0: - shard-skl: [PASS][1] -> [INCOMPLETE][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10027/shard-skl8/igt@gem_exec_schedule@wide@vecs0.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-skl2/igt@gem_exec_schedule@wide@vecs0.html Known issues ------------ Here are the changes found in Patchwork_20036_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_ctx_persistence@legacy-engines-hostile@vebox: - shard-apl: NOTRUN -> [FAIL][3] ([i915#2410]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-apl8/igt@gem_ctx_persistence@legacy-engines-hostile@vebox.html * igt@gem_ctx_persistence@legacy-engines-queued: - shard-snb: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#1099]) +1 similar issue [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-snb6/igt@gem_ctx_persistence@legacy-engines-queued.html * igt@gem_ctx_persistence@many-contexts: - shard-tglb: [PASS][5] -> [FAIL][6] ([i915#2410]) +1 similar issue [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10027/shard-tglb6/igt@gem_ctx_persistence@many-contexts.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-tglb6/igt@gem_ctx_persistence@many-contexts.html * igt@gem_ctx_ringsize@active@bcs0: - shard-skl: NOTRUN -> [INCOMPLETE][7] ([i915#3316]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-skl5/igt@gem_ctx_ringsize@active@bcs0.html * igt@gem_eio@unwedge-stress: - shard-tglb: [PASS][8] -> [TIMEOUT][9] ([i915#2369] / [i915#3063]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10027/shard-tglb8/igt@gem_eio@unwedge-stress.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-tglb5/igt@gem_eio@unwedge-stress.html * igt@gem_exec_fair@basic-pace-share@rcs0: - shard-glk: [PASS][10] -> [FAIL][11] ([i915#2842]) [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10027/shard-glk9/igt@gem_exec_fair@basic-pace-share@rcs0.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-glk4/igt@gem_exec_fair@basic-pace-share@rcs0.html * igt@gem_exec_fair@basic-pace-solo@rcs0: - shard-kbl: [PASS][12] -> [FAIL][13] ([i915#2842]) [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10027/shard-kbl7/igt@gem_exec_fair@basic-pace-solo@rcs0.html [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-kbl2/igt@gem_exec_fair@basic-pace-solo@rcs0.html * igt@gem_exec_fair@basic-pace@vcs0: - shard-iclb: [PASS][14] -> [FAIL][15] ([i915#2842]) +1 similar issue [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10027/shard-iclb4/igt@gem_exec_fair@basic-pace@vcs0.html [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-iclb8/igt@gem_exec_fair@basic-pace@vcs0.html * igt@gem_exec_suspend@basic-s3: - shard-apl: NOTRUN -> [DMESG-WARN][16] ([i915#180]) [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-apl8/igt@gem_exec_suspend@basic-s3.html * igt@gem_mmap_gtt@big-copy: - shard-glk: [PASS][17] -> [FAIL][18] ([i915#307]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10027/shard-glk7/igt@gem_mmap_gtt@big-copy.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-glk8/igt@gem_mmap_gtt@big-copy.html * igt@gem_ppgtt@flink-and-close-vma-leak: - shard-skl: [PASS][19] -> [FAIL][20] ([i915#644]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10027/shard-skl4/igt@gem_ppgtt@flink-and-close-vma-leak.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-skl7/igt@gem_ppgtt@flink-and-close-vma-leak.html * igt@gem_userptr_blits@dmabuf-sync: - shard-apl: NOTRUN -> [SKIP][21] ([fdo#109271] / [i915#3323]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-apl6/igt@gem_userptr_blits@dmabuf-sync.html * igt@gem_userptr_blits@set-cache-level: - shard-apl: NOTRUN -> [FAIL][22] ([i915#3324]) [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-apl8/igt@gem_userptr_blits@set-cache-level.html * igt@gem_userptr_blits@vma-merge: - shard-snb: NOTRUN -> [FAIL][23] ([i915#2724]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-snb5/igt@gem_userptr_blits@vma-merge.html - shard-apl: NOTRUN -> [FAIL][24] ([i915#3318]) [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-apl6/igt@gem_userptr_blits@vma-merge.html * igt@gem_vm_create@destroy-race: - shard-tglb: [PASS][25] -> [TIMEOUT][26] ([i915#2795]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10027/shard-tglb6/igt@gem_vm_create@destroy-race.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-tglb6/igt@gem_vm_create@destroy-race.html * igt@gem_workarounds@suspend-resume: - shard-apl: [PASS][27] -> [DMESG-WARN][28] ([i915#180]) +2 similar issues [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10027/shard-apl3/igt@gem_workarounds@suspend-resume.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-apl1/igt@gem_workarounds@suspend-resume.html * igt@gen9_exec_parse@batch-invalid-length: - shard-snb: NOTRUN -> [SKIP][29] ([fdo#109271]) +411 similar issues [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-snb5/igt@gen9_exec_parse@batch-invalid-length.html * igt@i915_selftest@live@hangcheck: - shard-snb: [PASS][30] -> [INCOMPLETE][31] ([i915#2782]) [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10027/shard-snb2/igt@i915_selftest@live@hangcheck.html [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-snb6/igt@i915_selftest@live@hangcheck.html * igt@i915_suspend@sysfs-reader: - shard-kbl: [PASS][32] -> [INCOMPLETE][33] ([i915#155]) [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10027/shard-kbl7/igt@i915_suspend@sysfs-reader.html [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-kbl2/igt@i915_suspend@sysfs-reader.html * igt@kms_big_fb@yf-tiled-addfb: - shard-tglb: NOTRUN -> [SKIP][34] ([fdo#111615]) [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-tglb8/igt@kms_big_fb@yf-tiled-addfb.html * igt@kms_big_joiner@invalid-modeset: - shard-skl: NOTRUN -> [SKIP][35] ([fdo#109271] / [i915#2705]) [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-skl1/igt@kms_big_joiner@invalid-modeset.html * igt@kms_ccs@pipe-c-ccs-on-another-bo: - shard-skl: NOTRUN -> [SKIP][36] ([fdo#109271] / [fdo#111304]) +1 similar issue [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-skl6/igt@kms_ccs@pipe-c-ccs-on-another-bo.html * igt@kms_chamelium@vga-hpd: - shard-apl: NOTRUN -> [SKIP][37] ([fdo#109271] / [fdo#111827]) +19 similar issues [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-apl2/igt@kms_chamelium@vga-hpd.html * igt@kms_chamelium@vga-hpd-for-each-pipe: - shard-skl: NOTRUN -> [SKIP][38] ([fdo#109271] / [fdo#111827]) +14 similar issues [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-skl8/igt@kms_chamelium@vga-hpd-for-each-pipe.html * igt@kms_color@pipe-c-ctm-blue-to-red: - shard-skl: [PASS][39] -> [DMESG-WARN][40] ([i915#1982]) [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10027/shard-skl10/igt@kms_color@pipe-c-ctm-blue-to-red.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-skl8/igt@kms_color@pipe-c-ctm-blue-to-red.html * igt@kms_color_chamelium@pipe-a-degamma: - shard-kbl: NOTRUN -> [SKIP][41] ([fdo#109271] / [fdo#111827]) +7 similar issues [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-kbl1/igt@kms_color_chamelium@pipe-a-degamma.html * igt@kms_color_chamelium@pipe-a-gamma: - shard-tglb: NOTRUN -> [SKIP][42] ([fdo#109284] / [fdo#111827]) [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-tglb8/igt@kms_color_chamelium@pipe-a-gamma.html * igt@kms_color_chamelium@pipe-d-degamma: - shard-glk: NOTRUN -> [SKIP][43] ([fdo#109271] / [fdo#111827]) +4 similar issues [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-glk8/igt@kms_color_chamelium@pipe-d-degamma.html * igt@kms_color_chamelium@pipe-invalid-ctm-matrix-sizes: - shard-snb: NOTRUN -> [SKIP][44] ([fdo#109271] / [fdo#111827]) +23 similar issues [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-snb6/igt@kms_color_chamelium@pipe-invalid-ctm-matrix-sizes.html * igt@kms_content_protection@atomic-dpms: - shard-apl: NOTRUN -> [TIMEOUT][45] ([i915#1319]) +1 similar issue [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-apl1/igt@kms_content_protection@atomic-dpms.html * igt@kms_cursor_crc@pipe-a-cursor-32x32-rapid-movement: - shard-tglb: NOTRUN -> [SKIP][46] ([i915#3319]) [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-tglb8/igt@kms_cursor_crc@pipe-a-cursor-32x32-rapid-movement.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions: - shard-skl: [PASS][47] -> [FAIL][48] ([i915#2346]) [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10027/shard-skl2/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-skl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html * igt@kms_flip@2x-flip-vs-modeset-vs-hang: - shard-kbl: NOTRUN -> [SKIP][49] ([fdo#109271]) +71 similar issues [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-kbl2/igt@kms_flip@2x-flip-vs-modeset-vs-hang.html * igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1: - shard-skl: NOTRUN -> [FAIL][50] ([i915#79]) +1 similar issue [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-skl8/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html * igt@kms_flip@flip-vs-expired-vblank@c-edp1: - shard-skl: [PASS][51] -> [FAIL][52] ([i915#79]) [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10027/shard-skl9/igt@kms_flip@flip-vs-expired-vblank@c-edp1.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-skl5/igt@kms_flip@flip-vs-expired-vblank@c-edp1.html * igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile: - shard-skl: NOTRUN -> [SKIP][53] ([fdo#109271] / [i915#2642]) [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-skl1/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile.html * igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs: - shard-skl: NOTRUN -> [SKIP][54] ([fdo#109271] / [i915#2672]) [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-skl6/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs.html * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-blt: - shard-skl: NOTRUN -> [SKIP][55] ([fdo#109271]) +169 similar issues [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-skl7/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-blt.html * igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-cpu: - shard-glk: NOTRUN -> [SKIP][56] ([fdo#109271]) +28 similar issues [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-glk8/igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-cpu.html * igt@kms_hdr@bpc-switch-dpms: - shard-skl: NOTRUN -> [FAIL][57] ([i915#1188]) [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-skl6/igt@kms_hdr@bpc-switch-dpms.html * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d: - shard-apl: NOTRUN -> [SKIP][58] ([fdo#109271] / [i915#533]) +2 similar issues [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-apl7/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html * igt@kms_pipe_crc_basic@hang-read-crc-pipe-d: - shard-kbl: NOTRUN -> [SKIP][59] ([fdo#109271] / [i915#533]) [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-kbl3/igt@kms_pipe_crc_basic@hang-read-crc-pipe-d.html * igt@kms_pipe_crc_basic@read-crc-pipe-d: - shard-glk: NOTRUN -> [SKIP][60] ([fdo#109271] / [i915#533]) [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-glk8/igt@kms_pipe_crc_basic@read-crc-pipe-d.html * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d: - shard-skl: NOTRUN -> [SKIP][61] ([fdo#109271] / [i915#533]) +2 similar issues [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-skl1/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d.html * igt@kms_plane_alpha_blend@pipe-a-alpha-7efc: - shard-apl: NOTRUN -> [FAIL][62] ([fdo#108145] / [i915#265]) +2 similar issues [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-apl6/igt@kms_plane_alpha_blend@pipe-a-alpha-7efc.html * igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb: - shard-skl: NOTRUN -> [FAIL][63] ([i915#265]) [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-skl6/igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb.html * igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb: - shard-apl: NOTRUN -> [FAIL][64] ([i915#265]) [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-apl1/igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb.html - shard-kbl: NOTRUN -> [FAIL][65] ([i915#265]) [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-kbl1/igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb.html * igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max: - shard-glk: NOTRUN -> [FAIL][66] ([fdo#108145] / [i915#265]) [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-glk8/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max.html * igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min: - shard-skl: NOTRUN -> [FAIL][67] ([fdo#108145] / [i915#265]) [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-skl8/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html * igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping: - shard-apl: NOTRUN -> [SKIP][68] ([fdo#109271] / [i915#2733]) [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-apl8/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping.html * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3: - shard-kbl: NOTRUN -> [SKIP][69] ([fdo#109271] / [i915#658]) +1 similar issue [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-kbl1/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3.html * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3: - shard-apl: NOTRUN -> [SKIP][70] ([fdo#109271] / [i915#658]) +5 similar issues [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-apl2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3.html * igt@kms_psr2_sf@plane-move-sf-dmg-area-0: - shard-glk: NOTRUN -> [SKIP][71] ([fdo#109271] / [i915#658]) [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-glk8/igt@kms_psr2_sf@plane-move-sf-dmg-area-0.html * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5: - shard-skl: NOTRUN -> [SKIP][72] ([fdo#109271] / [i915#658]) +4 similar issues [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-skl1/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5.html * igt@kms_psr@psr2_basic: - shard-iclb: [PASS][73] -> [SKIP][74] ([fdo#109441]) +1 similar issue [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10027/shard-iclb2/igt@kms_psr@psr2_basic.html [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-iclb6/igt@kms_psr@psr2_basic.html * igt@kms_psr@psr2_sprite_render: - shard-tglb: NOTRUN -> [FAIL][75] ([i915#132]) [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-tglb8/igt@kms_psr@psr2_sprite_render.html * igt@kms_vblank@pipe-d-wait-forked-hang: - shard-apl: NOTRUN -> [SKIP][76] ([fdo#109271]) +244 similar issues [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-apl1/igt@kms_vblank@pipe-d-wait-forked-hang.html * igt@kms_writeback@writeback-fb-id: - shard-kbl: NOTRUN -> [SKIP][77] ([fdo#109271] / [i915#2437]) [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-kbl3/igt@kms_writeback@writeback-fb-id.html - shard-skl: NOTRUN -> [SKIP][78] ([fdo#109271] / [i915#2437]) [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-skl4/igt@kms_writeback@writeback-fb-id.html * igt@kms_writeback@writeback-pixel-formats: - shard-apl: NOTRUN -> [SKIP][79] ([fdo#109271] / [i915#2437]) [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-apl7/igt@kms_writeback@writeback-pixel-formats.html * igt@sysfs_clients@fair-7: - shard-apl: NOTRUN -> [SKIP][80] ([fdo#109271] / [i915#2994]) +3 similar issues [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-apl7/igt@sysfs_clients@fair-7.html * igt@sysfs_clients@sema-10: - shard-skl: NOTRUN -> [SKIP][81] ([fdo#109271] / [i915#2994]) +1 similar issue [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-skl1/igt@sysfs_clients@sema-10.html * igt@sysfs_clients@split-50: - shard-kbl: NOTRUN -> [SKIP][82] ([fdo#109271] / [i915#2994]) +1 similar issue [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-kbl2/igt@sysfs_clients@split-50.html #### Possible fixes #### * igt@gem_eio@in-flight-internal-immediate: - shard-skl: [DMESG-WARN][83] -> [PASS][84] [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10027/shard-skl6/igt@gem_eio@in-flight-internal-immediate.html [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-skl10/igt@gem_eio@in-flight-internal-immediate.html * igt@gem_exec_fair@basic-none-share@rcs0: - shard-tglb: [FAIL][85] ([i915#2842]) -> [PASS][86] [85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10027/shard-tglb2/igt@gem_exec_fair@basic-none-share@rcs0.html [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-tglb7/igt@gem_exec_fair@basic-none-share@rcs0.html * igt@gem_exec_fair@basic-throttle@rcs0: - shard-glk: [FAIL][87] ([i915#2842]) -> [PASS][88] [87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10027/shard-glk6/igt@gem_exec_fair@basic-throttle@rcs0.html [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-glk6/igt@gem_exec_fair@basic-throttle@rcs0.html * igt@gem_mmap_gtt@big-copy-odd: - shard-glk: [FAIL][89] ([i915#307]) -> [PASS][90] [89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10027/shard-glk9/igt@gem_mmap_gtt@big-copy-odd.html [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-glk6/igt@gem_mmap_gtt@big-copy-odd.html * igt@gem_mmap_gtt@cpuset-big-copy-xy: - shard-iclb: [FAIL][91] ([i915#2428]) -> [PASS][92] [91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10027/shard-iclb1/igt@gem_mmap_gtt@cpuset-big-copy-xy.html [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-iclb1/igt@gem_mmap_gtt@cpuset-big-copy-xy.html * igt@gen9_exec_parse@allowed-single: - shard-skl: [DMESG-WARN][93] ([i915#1436] / [i915#716]) -> [PASS][94] [93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10027/shard-skl2/igt@gen9_exec_parse@allowed-single.html [94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-skl1/igt@gen9_exec_parse@allowed-single.html * igt@i915_pm_dc@dc9-dpms: - shard-apl: [FAIL][95] ([i915#3343]) -> [PASS][96] [95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10027/shard-apl3/igt@i915_pm_dc@dc9-dpms.html [96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-apl1/igt@i915_pm_dc@dc9-dpms.html * igt@kms_cursor_edge_walk@pipe-c-64x64-top-edge: - shard-skl: [DMESG-WARN][97] ([i915#1982]) -> [PASS][98] [97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10027/shard-skl9/igt@kms_cursor_edge_walk@pipe-c-64x64-top-edge.html [98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-skl5/igt@kms_cursor_edge_walk@pipe-c-64x64-top-edge.html * igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy: - shard-skl: [FAIL][99] ([i915#2346]) -> [PASS][100] [99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10027/shard-skl1/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy.html [100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-skl8/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy.html * igt@kms_fbcon_fbt@fbc-suspend: - shard-kbl: [INCOMPLETE][101] ([i915#155] / [i915#180] / [i915#636]) -> [PASS][102] [101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10027/shard-kbl2/igt@kms_fbcon_fbt@fbc-suspend.html [102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-kbl1/igt@kms_fbcon_fbt@fbc-suspend.html * igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ac-hdmi-a1-hdmi-a2: - shard-glk: [FAIL][103] ([i915#79]) -> [PASS][104] [103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10027/shard-glk6/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ac-hdmi-a1-hdmi-a2.html [104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-glk6/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ac-hdmi-a1-hdmi-a2.html * igt@kms_flip@flip-vs-suspend-interruptible@b-edp1: - shard-skl: [INCOMPLETE][105] ([i915#198]) -> [PASS][106] [105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10027/shard-skl7/igt@kms_flip@flip-vs-suspend-interruptible@b-edp1.html [106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-skl4/igt@kms_flip@flip-vs-suspend-interruptible@b-edp1.html * igt@kms_flip@flip-vs-suspend-interruptible@c-dp1: - shard-kbl: [DMESG-WARN][107] ([i915#180]) -> [PASS][108] +2 similar issues [107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10027/shard-kbl2/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html [108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-kbl3/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html * igt@kms_flip@wf_vblank-ts-check-interruptible@a-edp1: - shard-skl: [FAIL][109] ([i915#2122]) -> [PASS][110] [109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10027/shard-skl7/igt@kms_flip@wf_vblank-ts-check-interruptible@a-edp1.html [110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-skl4/igt@kms_flip@wf_vblank-ts-check-interruptible@a-edp1.html * igt@kms_hdr@bpc-switch-suspend: - shard-skl: [FAIL][111] ([i915#1188]) -> [PASS][112] [111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10027/shard-skl10/igt@kms_hdr@bpc-switch-suspend.html [112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-skl8/igt@kms_hdr@bpc-switch-suspend.html * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc: - shard-skl: [FAIL][113] ([fdo#108145] / [i915#265]) -> [PASS][114] +2 similar issues [113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10027/shard-skl6/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html [114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-skl10/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html * igt@kms_psr@psr2_cursor_blt: - shard-iclb: [SKIP][115] ([fdo#109441]) -> [PASS][116] +1 similar issue [115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10027/shard-iclb5/igt@kms_psr@psr2_cursor_blt.html [116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html * igt@perf@blocking: - shard-skl: [FAIL][117] ([i915#1542]) -> [PASS][118] [117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10027/shard-skl8/igt@perf@blocking.html [118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-skl2/igt@perf@blocking.html #### Warnings #### * igt@i915_pm_dc@dc3co-vpb-simulation: - shard-iclb: [SKIP][119] ([i915#658]) -> [SKIP][120] ([i915#588]) [119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10027/shard-iclb5/igt@i915_pm_dc@dc3co-vpb-simulation.html [120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-iclb2/igt@i915_pm_dc@dc3co-vpb-simulation.html * igt@i915_pm_rc6_residency@rc6-idle: - shard-iclb: [WARN][121] ([i915#2681] / [i915#2684]) -> [WARN][122] ([i915#1804] / [i915#2684]) [121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10027/shard-iclb1/igt@i915_pm_rc6_residency@rc6-idle.html [122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-iclb7/igt@i915_pm_rc6_residency@rc6-idle.html * igt@kms_dp_dsc@basic-dsc-enable-edp: - shard-iclb: [DMESG-WARN][123] ([i915#1226]) -> [SKIP][124] ([fdo#109349]) [123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10027/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html [124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-iclb6/igt@kms_dp_dsc@basic-dsc-enable-edp.html * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2: - shard-iclb: [SKIP][125] ([i915#658]) -> [SKIP][126] ([i915#2920]) [125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10027/shard-iclb8/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2.html [126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-iclb2/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2.html * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3: - shard-iclb: [SKIP][127] ([i915#2920]) -> [SKIP][128] ([i915#658]) [127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10027/shard-iclb2/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3.html [128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-iclb6/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3.html * igt@runner@aborted: - shard-kbl: ([FAIL][129], [FAIL][130], [FAIL][131], [FAIL][132], [FAIL][133], [FAIL][134]) ([i915#180] / [i915#2292] / [i915#2505] / [i915#3002] / [i915#92]) -> ([FAIL][135], [FAIL][136], [FAIL][137]) ([i915#180] / [i915#2505] / [i915#3002]) [129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10027/shard-kbl3/igt@runner@aborted.html [130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10027/shard-kbl7/igt@runner@aborted.html [131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10027/shard-kbl2/igt@runner@aborted.html [132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10027/shard-kbl6/igt@runner@aborted.html [133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10027/shard-kbl6/igt@runner@aborted.html [134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10027/shard-kbl2/igt@runner@aborted.html [135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-kbl6/igt@runner@aborted.html [136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-kbl6/igt@runner@aborted.html [137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-kbl4/igt@runner@aborted.html - shard-apl: ([FAIL][138], [FAIL][139]) ([fdo#109271] / [i915#180] / [i915#3002]) -> ([FAIL][140], [FAIL][141], [FAIL][142], [FAIL][143], [FAIL][144]) ([fdo#109271] / [i915#1610] / [i915#180] / [i915#1814] / [i915#3002]) [138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10027/shard-apl8/igt@runner@aborted.html [139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10027/shard-apl8/igt@runner@aborted.html [140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-apl3/igt@runner@aborted.html [141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-apl8/igt@runner@aborted.html [142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-apl8/igt@runner@aborted.html [143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-apl1/igt@runner@aborted.html [144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/shard-apl6/igt@runner@aborted.html - shard-skl: ([FAIL][145], [FAIL][146], [FAIL][147], [FAIL][148], [FAIL][149], [FAIL][150]) ([i915#1436] / [i915#1814] / [i915#2029] / [i915#3002]) -> ([FAIL][151], [FAIL][152], [FAIL][153], [FAIL][154]) ([i915#2029] / [i915#3002] / [i915#3254]) [145]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10027/shard-skl3/igt@runner@aborted.html [146]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10027/shard-skl10/igt@runner@aborted.html [147]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10027/shard-skl4/igt@runne == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20036/index.html [-- Attachment #1.2: Type: text/html, Size: 33911 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH] drm/i915: Use might_alloc() @ 2021-04-29 2:42 ` Bernard Zhao 0 siblings, 0 replies; 14+ messages in thread From: Bernard Zhao @ 2021-04-29 2:42 UTC (permalink / raw) To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, David Airlie, Daniel Vetter, intel-gfx, dri-devel, linux-kernel Cc: Bernard Zhao This maybe used lockdep through the fs_reclaim annotations. Signed-off-by: Bernard Zhao <bernard@vivo.com> --- drivers/gpu/drm/i915/i915_sw_fence.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_sw_fence.c b/drivers/gpu/drm/i915/i915_sw_fence.c index 2744558f3050..cc1b49cabb6c 100644 --- a/drivers/gpu/drm/i915/i915_sw_fence.c +++ b/drivers/gpu/drm/i915/i915_sw_fence.c @@ -341,7 +341,7 @@ static int __i915_sw_fence_await_sw_fence(struct i915_sw_fence *fence, unsigned long flags; debug_fence_assert(fence); - might_sleep_if(gfpflags_allow_blocking(gfp)); + might_alloc(gfp); if (i915_sw_fence_done(signaler)) { i915_sw_fence_set_error_once(fence, signaler->error); @@ -477,7 +477,7 @@ int i915_sw_fence_await_dma_fence(struct i915_sw_fence *fence, int ret; debug_fence_assert(fence); - might_sleep_if(gfpflags_allow_blocking(gfp)); + might_alloc(gfp); if (dma_fence_is_signaled(dma)) { i915_sw_fence_set_error_once(fence, dma->error); @@ -576,7 +576,7 @@ int i915_sw_fence_await_reservation(struct i915_sw_fence *fence, int ret = 0, pending; debug_fence_assert(fence); - might_sleep_if(gfpflags_allow_blocking(gfp)); + might_alloc(gfp); if (write) { struct dma_fence **shared; -- 2.31.0 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH] drm/i915: Use might_alloc() @ 2021-04-29 2:42 ` Bernard Zhao 0 siblings, 0 replies; 14+ messages in thread From: Bernard Zhao @ 2021-04-29 2:42 UTC (permalink / raw) To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, David Airlie, Daniel Vetter, intel-gfx, dri-devel, linux-kernel Cc: Bernard Zhao This maybe used lockdep through the fs_reclaim annotations. Signed-off-by: Bernard Zhao <bernard@vivo.com> --- drivers/gpu/drm/i915/i915_sw_fence.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_sw_fence.c b/drivers/gpu/drm/i915/i915_sw_fence.c index 2744558f3050..cc1b49cabb6c 100644 --- a/drivers/gpu/drm/i915/i915_sw_fence.c +++ b/drivers/gpu/drm/i915/i915_sw_fence.c @@ -341,7 +341,7 @@ static int __i915_sw_fence_await_sw_fence(struct i915_sw_fence *fence, unsigned long flags; debug_fence_assert(fence); - might_sleep_if(gfpflags_allow_blocking(gfp)); + might_alloc(gfp); if (i915_sw_fence_done(signaler)) { i915_sw_fence_set_error_once(fence, signaler->error); @@ -477,7 +477,7 @@ int i915_sw_fence_await_dma_fence(struct i915_sw_fence *fence, int ret; debug_fence_assert(fence); - might_sleep_if(gfpflags_allow_blocking(gfp)); + might_alloc(gfp); if (dma_fence_is_signaled(dma)) { i915_sw_fence_set_error_once(fence, dma->error); @@ -576,7 +576,7 @@ int i915_sw_fence_await_reservation(struct i915_sw_fence *fence, int ret = 0, pending; debug_fence_assert(fence); - might_sleep_if(gfpflags_allow_blocking(gfp)); + might_alloc(gfp); if (write) { struct dma_fence **shared; -- 2.31.0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH] drm/i915: Use might_alloc() 2021-04-29 2:42 ` Bernard Zhao (?) @ 2021-04-29 16:31 ` kernel test robot -1 siblings, 0 replies; 14+ messages in thread From: kernel test robot @ 2021-04-29 16:31 UTC (permalink / raw) To: Bernard Zhao, Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, David Airlie, Daniel Vetter, intel-gfx, dri-devel, linux-kernel Cc: kbuild-all, Bernard Zhao [-- Attachment #1: Type: text/plain, Size: 3420 bytes --] Hi Bernard, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on v5.12 next-20210429] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Bernard-Zhao/drm-i915-Use-might_alloc/20210429-104516 base: git://anongit.freedesktop.org/drm-intel for-linux-next config: x86_64-rhel-8.3-kselftests (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/9fbd0c1741ce06241105d753ff3432ab55f3e94a git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Bernard-Zhao/drm-i915-Use-might_alloc/20210429-104516 git checkout 9fbd0c1741ce06241105d753ff3432ab55f3e94a # save the attached .config to linux build tree make W=1 W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All errors (new ones prefixed by >>): drivers/gpu/drm/i915/i915_sw_fence.c: In function '__i915_sw_fence_await_sw_fence': >> drivers/gpu/drm/i915/i915_sw_fence.c:344:2: error: implicit declaration of function 'might_alloc'; did you mean 'might_lock'? [-Werror=implicit-function-declaration] 344 | might_alloc(gfp); | ^~~~~~~~~~~ | might_lock cc1: some warnings being treated as errors vim +344 drivers/gpu/drm/i915/i915_sw_fence.c 335 336 static int __i915_sw_fence_await_sw_fence(struct i915_sw_fence *fence, 337 struct i915_sw_fence *signaler, 338 wait_queue_entry_t *wq, gfp_t gfp) 339 { 340 unsigned int pending; 341 unsigned long flags; 342 343 debug_fence_assert(fence); > 344 might_alloc(gfp); 345 346 if (i915_sw_fence_done(signaler)) { 347 i915_sw_fence_set_error_once(fence, signaler->error); 348 return 0; 349 } 350 351 debug_fence_assert(signaler); 352 353 /* The dependency graph must be acyclic. */ 354 if (unlikely(i915_sw_fence_check_if_after(fence, signaler))) 355 return -EINVAL; 356 357 pending = I915_SW_FENCE_FLAG_FENCE; 358 if (!wq) { 359 wq = kmalloc(sizeof(*wq), gfp); 360 if (!wq) { 361 if (!gfpflags_allow_blocking(gfp)) 362 return -ENOMEM; 363 364 i915_sw_fence_wait(signaler); 365 i915_sw_fence_set_error_once(fence, signaler->error); 366 return 0; 367 } 368 369 pending |= I915_SW_FENCE_FLAG_ALLOC; 370 } 371 372 INIT_LIST_HEAD(&wq->entry); 373 wq->flags = pending; 374 wq->func = i915_sw_fence_wake; 375 wq->private = fence; 376 377 i915_sw_fence_await(fence); 378 379 spin_lock_irqsave(&signaler->wait.lock, flags); 380 if (likely(!i915_sw_fence_done(signaler))) { 381 __add_wait_queue_entry_tail(&signaler->wait, wq); 382 pending = 1; 383 } else { 384 i915_sw_fence_wake(wq, 0, signaler->error, NULL); 385 pending = 0; 386 } 387 spin_unlock_irqrestore(&signaler->wait.lock, flags); 388 389 return pending; 390 } 391 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 41499 bytes --] ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] drm/i915: Use might_alloc() @ 2021-04-29 16:31 ` kernel test robot 0 siblings, 0 replies; 14+ messages in thread From: kernel test robot @ 2021-04-29 16:31 UTC (permalink / raw) To: kbuild-all [-- Attachment #1: Type: text/plain, Size: 3520 bytes --] Hi Bernard, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on v5.12 next-20210429] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Bernard-Zhao/drm-i915-Use-might_alloc/20210429-104516 base: git://anongit.freedesktop.org/drm-intel for-linux-next config: x86_64-rhel-8.3-kselftests (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/9fbd0c1741ce06241105d753ff3432ab55f3e94a git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Bernard-Zhao/drm-i915-Use-might_alloc/20210429-104516 git checkout 9fbd0c1741ce06241105d753ff3432ab55f3e94a # save the attached .config to linux build tree make W=1 W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All errors (new ones prefixed by >>): drivers/gpu/drm/i915/i915_sw_fence.c: In function '__i915_sw_fence_await_sw_fence': >> drivers/gpu/drm/i915/i915_sw_fence.c:344:2: error: implicit declaration of function 'might_alloc'; did you mean 'might_lock'? [-Werror=implicit-function-declaration] 344 | might_alloc(gfp); | ^~~~~~~~~~~ | might_lock cc1: some warnings being treated as errors vim +344 drivers/gpu/drm/i915/i915_sw_fence.c 335 336 static int __i915_sw_fence_await_sw_fence(struct i915_sw_fence *fence, 337 struct i915_sw_fence *signaler, 338 wait_queue_entry_t *wq, gfp_t gfp) 339 { 340 unsigned int pending; 341 unsigned long flags; 342 343 debug_fence_assert(fence); > 344 might_alloc(gfp); 345 346 if (i915_sw_fence_done(signaler)) { 347 i915_sw_fence_set_error_once(fence, signaler->error); 348 return 0; 349 } 350 351 debug_fence_assert(signaler); 352 353 /* The dependency graph must be acyclic. */ 354 if (unlikely(i915_sw_fence_check_if_after(fence, signaler))) 355 return -EINVAL; 356 357 pending = I915_SW_FENCE_FLAG_FENCE; 358 if (!wq) { 359 wq = kmalloc(sizeof(*wq), gfp); 360 if (!wq) { 361 if (!gfpflags_allow_blocking(gfp)) 362 return -ENOMEM; 363 364 i915_sw_fence_wait(signaler); 365 i915_sw_fence_set_error_once(fence, signaler->error); 366 return 0; 367 } 368 369 pending |= I915_SW_FENCE_FLAG_ALLOC; 370 } 371 372 INIT_LIST_HEAD(&wq->entry); 373 wq->flags = pending; 374 wq->func = i915_sw_fence_wake; 375 wq->private = fence; 376 377 i915_sw_fence_await(fence); 378 379 spin_lock_irqsave(&signaler->wait.lock, flags); 380 if (likely(!i915_sw_fence_done(signaler))) { 381 __add_wait_queue_entry_tail(&signaler->wait, wq); 382 pending = 1; 383 } else { 384 i915_sw_fence_wake(wq, 0, signaler->error, NULL); 385 pending = 0; 386 } 387 spin_unlock_irqrestore(&signaler->wait.lock, flags); 388 389 return pending; 390 } 391 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org [-- Attachment #2: config.gz --] [-- Type: application/gzip, Size: 41499 bytes --] ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] drm/i915: Use might_alloc() @ 2021-04-29 16:31 ` kernel test robot 0 siblings, 0 replies; 14+ messages in thread From: kernel test robot @ 2021-04-29 16:31 UTC (permalink / raw) To: Bernard Zhao, Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, David Airlie, Daniel Vetter, intel-gfx, dri-devel, linux-kernel Cc: Bernard Zhao, kbuild-all [-- Attachment #1: Type: text/plain, Size: 3420 bytes --] Hi Bernard, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on v5.12 next-20210429] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Bernard-Zhao/drm-i915-Use-might_alloc/20210429-104516 base: git://anongit.freedesktop.org/drm-intel for-linux-next config: x86_64-rhel-8.3-kselftests (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/9fbd0c1741ce06241105d753ff3432ab55f3e94a git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Bernard-Zhao/drm-i915-Use-might_alloc/20210429-104516 git checkout 9fbd0c1741ce06241105d753ff3432ab55f3e94a # save the attached .config to linux build tree make W=1 W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All errors (new ones prefixed by >>): drivers/gpu/drm/i915/i915_sw_fence.c: In function '__i915_sw_fence_await_sw_fence': >> drivers/gpu/drm/i915/i915_sw_fence.c:344:2: error: implicit declaration of function 'might_alloc'; did you mean 'might_lock'? [-Werror=implicit-function-declaration] 344 | might_alloc(gfp); | ^~~~~~~~~~~ | might_lock cc1: some warnings being treated as errors vim +344 drivers/gpu/drm/i915/i915_sw_fence.c 335 336 static int __i915_sw_fence_await_sw_fence(struct i915_sw_fence *fence, 337 struct i915_sw_fence *signaler, 338 wait_queue_entry_t *wq, gfp_t gfp) 339 { 340 unsigned int pending; 341 unsigned long flags; 342 343 debug_fence_assert(fence); > 344 might_alloc(gfp); 345 346 if (i915_sw_fence_done(signaler)) { 347 i915_sw_fence_set_error_once(fence, signaler->error); 348 return 0; 349 } 350 351 debug_fence_assert(signaler); 352 353 /* The dependency graph must be acyclic. */ 354 if (unlikely(i915_sw_fence_check_if_after(fence, signaler))) 355 return -EINVAL; 356 357 pending = I915_SW_FENCE_FLAG_FENCE; 358 if (!wq) { 359 wq = kmalloc(sizeof(*wq), gfp); 360 if (!wq) { 361 if (!gfpflags_allow_blocking(gfp)) 362 return -ENOMEM; 363 364 i915_sw_fence_wait(signaler); 365 i915_sw_fence_set_error_once(fence, signaler->error); 366 return 0; 367 } 368 369 pending |= I915_SW_FENCE_FLAG_ALLOC; 370 } 371 372 INIT_LIST_HEAD(&wq->entry); 373 wq->flags = pending; 374 wq->func = i915_sw_fence_wake; 375 wq->private = fence; 376 377 i915_sw_fence_await(fence); 378 379 spin_lock_irqsave(&signaler->wait.lock, flags); 380 if (likely(!i915_sw_fence_done(signaler))) { 381 __add_wait_queue_entry_tail(&signaler->wait, wq); 382 pending = 1; 383 } else { 384 i915_sw_fence_wake(wq, 0, signaler->error, NULL); 385 pending = 0; 386 } 387 spin_unlock_irqrestore(&signaler->wait.lock, flags); 388 389 return pending; 390 } 391 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 41499 bytes --] [-- Attachment #3: Type: text/plain, Size: 160 bytes --] _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] drm/i915: Use might_alloc() 2021-04-29 16:31 ` kernel test robot (?) @ 2021-04-30 17:42 ` Daniel Vetter -1 siblings, 0 replies; 14+ messages in thread From: Daniel Vetter @ 2021-04-30 17:42 UTC (permalink / raw) To: kernel test robot Cc: Bernard Zhao, Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, David Airlie, Daniel Vetter, intel-gfx, dri-devel, linux-kernel, kbuild-all On Fri, Apr 30, 2021 at 12:31:27AM +0800, kernel test robot wrote: > Hi Bernard, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on drm-intel/for-linux-next] > [also build test ERROR on v5.12 next-20210429] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: https://github.com/0day-ci/linux/commits/Bernard-Zhao/drm-i915-Use-might_alloc/20210429-104516 > base: git://anongit.freedesktop.org/drm-intel for-linux-next > config: x86_64-rhel-8.3-kselftests (attached as .config) > compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 > reproduce (this is a W=1 build): > # https://github.com/0day-ci/linux/commit/9fbd0c1741ce06241105d753ff3432ab55f3e94a > git remote add linux-review https://github.com/0day-ci/linux > git fetch --no-tags linux-review Bernard-Zhao/drm-i915-Use-might_alloc/20210429-104516 > git checkout 9fbd0c1741ce06241105d753ff3432ab55f3e94a > # save the attached .config to linux build tree > make W=1 W=1 ARCH=x86_64 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp@intel.com> > > All errors (new ones prefixed by >>): > > drivers/gpu/drm/i915/i915_sw_fence.c: In function '__i915_sw_fence_await_sw_fence': > >> drivers/gpu/drm/i915/i915_sw_fence.c:344:2: error: implicit declaration of function 'might_alloc'; did you mean 'might_lock'? [-Werror=implicit-function-declaration] > 344 | might_alloc(gfp); > | ^~~~~~~~~~~ > | might_lock > cc1: some warnings being treated as errors I think you're missing an include or something. The other patch you've done seems good, I queued that up in drm-intel-gt-next for 5.14. Thanks, Daniel > > > vim +344 drivers/gpu/drm/i915/i915_sw_fence.c > > 335 > 336 static int __i915_sw_fence_await_sw_fence(struct i915_sw_fence *fence, > 337 struct i915_sw_fence *signaler, > 338 wait_queue_entry_t *wq, gfp_t gfp) > 339 { > 340 unsigned int pending; > 341 unsigned long flags; > 342 > 343 debug_fence_assert(fence); > > 344 might_alloc(gfp); > 345 > 346 if (i915_sw_fence_done(signaler)) { > 347 i915_sw_fence_set_error_once(fence, signaler->error); > 348 return 0; > 349 } > 350 > 351 debug_fence_assert(signaler); > 352 > 353 /* The dependency graph must be acyclic. */ > 354 if (unlikely(i915_sw_fence_check_if_after(fence, signaler))) > 355 return -EINVAL; > 356 > 357 pending = I915_SW_FENCE_FLAG_FENCE; > 358 if (!wq) { > 359 wq = kmalloc(sizeof(*wq), gfp); > 360 if (!wq) { > 361 if (!gfpflags_allow_blocking(gfp)) > 362 return -ENOMEM; > 363 > 364 i915_sw_fence_wait(signaler); > 365 i915_sw_fence_set_error_once(fence, signaler->error); > 366 return 0; > 367 } > 368 > 369 pending |= I915_SW_FENCE_FLAG_ALLOC; > 370 } > 371 > 372 INIT_LIST_HEAD(&wq->entry); > 373 wq->flags = pending; > 374 wq->func = i915_sw_fence_wake; > 375 wq->private = fence; > 376 > 377 i915_sw_fence_await(fence); > 378 > 379 spin_lock_irqsave(&signaler->wait.lock, flags); > 380 if (likely(!i915_sw_fence_done(signaler))) { > 381 __add_wait_queue_entry_tail(&signaler->wait, wq); > 382 pending = 1; > 383 } else { > 384 i915_sw_fence_wake(wq, 0, signaler->error, NULL); > 385 pending = 0; > 386 } > 387 spin_unlock_irqrestore(&signaler->wait.lock, flags); > 388 > 389 return pending; > 390 } > 391 > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] drm/i915: Use might_alloc() @ 2021-04-30 17:42 ` Daniel Vetter 0 siblings, 0 replies; 14+ messages in thread From: Daniel Vetter @ 2021-04-30 17:42 UTC (permalink / raw) To: kbuild-all [-- Attachment #1: Type: text/plain, Size: 4028 bytes --] On Fri, Apr 30, 2021 at 12:31:27AM +0800, kernel test robot wrote: > Hi Bernard, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on drm-intel/for-linux-next] > [also build test ERROR on v5.12 next-20210429] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: https://github.com/0day-ci/linux/commits/Bernard-Zhao/drm-i915-Use-might_alloc/20210429-104516 > base: git://anongit.freedesktop.org/drm-intel for-linux-next > config: x86_64-rhel-8.3-kselftests (attached as .config) > compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 > reproduce (this is a W=1 build): > # https://github.com/0day-ci/linux/commit/9fbd0c1741ce06241105d753ff3432ab55f3e94a > git remote add linux-review https://github.com/0day-ci/linux > git fetch --no-tags linux-review Bernard-Zhao/drm-i915-Use-might_alloc/20210429-104516 > git checkout 9fbd0c1741ce06241105d753ff3432ab55f3e94a > # save the attached .config to linux build tree > make W=1 W=1 ARCH=x86_64 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp@intel.com> > > All errors (new ones prefixed by >>): > > drivers/gpu/drm/i915/i915_sw_fence.c: In function '__i915_sw_fence_await_sw_fence': > >> drivers/gpu/drm/i915/i915_sw_fence.c:344:2: error: implicit declaration of function 'might_alloc'; did you mean 'might_lock'? [-Werror=implicit-function-declaration] > 344 | might_alloc(gfp); > | ^~~~~~~~~~~ > | might_lock > cc1: some warnings being treated as errors I think you're missing an include or something. The other patch you've done seems good, I queued that up in drm-intel-gt-next for 5.14. Thanks, Daniel > > > vim +344 drivers/gpu/drm/i915/i915_sw_fence.c > > 335 > 336 static int __i915_sw_fence_await_sw_fence(struct i915_sw_fence *fence, > 337 struct i915_sw_fence *signaler, > 338 wait_queue_entry_t *wq, gfp_t gfp) > 339 { > 340 unsigned int pending; > 341 unsigned long flags; > 342 > 343 debug_fence_assert(fence); > > 344 might_alloc(gfp); > 345 > 346 if (i915_sw_fence_done(signaler)) { > 347 i915_sw_fence_set_error_once(fence, signaler->error); > 348 return 0; > 349 } > 350 > 351 debug_fence_assert(signaler); > 352 > 353 /* The dependency graph must be acyclic. */ > 354 if (unlikely(i915_sw_fence_check_if_after(fence, signaler))) > 355 return -EINVAL; > 356 > 357 pending = I915_SW_FENCE_FLAG_FENCE; > 358 if (!wq) { > 359 wq = kmalloc(sizeof(*wq), gfp); > 360 if (!wq) { > 361 if (!gfpflags_allow_blocking(gfp)) > 362 return -ENOMEM; > 363 > 364 i915_sw_fence_wait(signaler); > 365 i915_sw_fence_set_error_once(fence, signaler->error); > 366 return 0; > 367 } > 368 > 369 pending |= I915_SW_FENCE_FLAG_ALLOC; > 370 } > 371 > 372 INIT_LIST_HEAD(&wq->entry); > 373 wq->flags = pending; > 374 wq->func = i915_sw_fence_wake; > 375 wq->private = fence; > 376 > 377 i915_sw_fence_await(fence); > 378 > 379 spin_lock_irqsave(&signaler->wait.lock, flags); > 380 if (likely(!i915_sw_fence_done(signaler))) { > 381 __add_wait_queue_entry_tail(&signaler->wait, wq); > 382 pending = 1; > 383 } else { > 384 i915_sw_fence_wake(wq, 0, signaler->error, NULL); > 385 pending = 0; > 386 } > 387 spin_unlock_irqrestore(&signaler->wait.lock, flags); > 388 > 389 return pending; > 390 } > 391 > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] drm/i915: Use might_alloc() @ 2021-04-30 17:42 ` Daniel Vetter 0 siblings, 0 replies; 14+ messages in thread From: Daniel Vetter @ 2021-04-30 17:42 UTC (permalink / raw) To: kernel test robot Cc: kbuild-all, David Airlie, Bernard Zhao, intel-gfx, linux-kernel, dri-devel, Rodrigo Vivi On Fri, Apr 30, 2021 at 12:31:27AM +0800, kernel test robot wrote: > Hi Bernard, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on drm-intel/for-linux-next] > [also build test ERROR on v5.12 next-20210429] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: https://github.com/0day-ci/linux/commits/Bernard-Zhao/drm-i915-Use-might_alloc/20210429-104516 > base: git://anongit.freedesktop.org/drm-intel for-linux-next > config: x86_64-rhel-8.3-kselftests (attached as .config) > compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 > reproduce (this is a W=1 build): > # https://github.com/0day-ci/linux/commit/9fbd0c1741ce06241105d753ff3432ab55f3e94a > git remote add linux-review https://github.com/0day-ci/linux > git fetch --no-tags linux-review Bernard-Zhao/drm-i915-Use-might_alloc/20210429-104516 > git checkout 9fbd0c1741ce06241105d753ff3432ab55f3e94a > # save the attached .config to linux build tree > make W=1 W=1 ARCH=x86_64 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp@intel.com> > > All errors (new ones prefixed by >>): > > drivers/gpu/drm/i915/i915_sw_fence.c: In function '__i915_sw_fence_await_sw_fence': > >> drivers/gpu/drm/i915/i915_sw_fence.c:344:2: error: implicit declaration of function 'might_alloc'; did you mean 'might_lock'? [-Werror=implicit-function-declaration] > 344 | might_alloc(gfp); > | ^~~~~~~~~~~ > | might_lock > cc1: some warnings being treated as errors I think you're missing an include or something. The other patch you've done seems good, I queued that up in drm-intel-gt-next for 5.14. Thanks, Daniel > > > vim +344 drivers/gpu/drm/i915/i915_sw_fence.c > > 335 > 336 static int __i915_sw_fence_await_sw_fence(struct i915_sw_fence *fence, > 337 struct i915_sw_fence *signaler, > 338 wait_queue_entry_t *wq, gfp_t gfp) > 339 { > 340 unsigned int pending; > 341 unsigned long flags; > 342 > 343 debug_fence_assert(fence); > > 344 might_alloc(gfp); > 345 > 346 if (i915_sw_fence_done(signaler)) { > 347 i915_sw_fence_set_error_once(fence, signaler->error); > 348 return 0; > 349 } > 350 > 351 debug_fence_assert(signaler); > 352 > 353 /* The dependency graph must be acyclic. */ > 354 if (unlikely(i915_sw_fence_check_if_after(fence, signaler))) > 355 return -EINVAL; > 356 > 357 pending = I915_SW_FENCE_FLAG_FENCE; > 358 if (!wq) { > 359 wq = kmalloc(sizeof(*wq), gfp); > 360 if (!wq) { > 361 if (!gfpflags_allow_blocking(gfp)) > 362 return -ENOMEM; > 363 > 364 i915_sw_fence_wait(signaler); > 365 i915_sw_fence_set_error_once(fence, signaler->error); > 366 return 0; > 367 } > 368 > 369 pending |= I915_SW_FENCE_FLAG_ALLOC; > 370 } > 371 > 372 INIT_LIST_HEAD(&wq->entry); > 373 wq->flags = pending; > 374 wq->func = i915_sw_fence_wake; > 375 wq->private = fence; > 376 > 377 i915_sw_fence_await(fence); > 378 > 379 spin_lock_irqsave(&signaler->wait.lock, flags); > 380 if (likely(!i915_sw_fence_done(signaler))) { > 381 __add_wait_queue_entry_tail(&signaler->wait, wq); > 382 pending = 1; > 383 } else { > 384 i915_sw_fence_wake(wq, 0, signaler->error, NULL); > 385 pending = 0; > 386 } > 387 spin_unlock_irqrestore(&signaler->wait.lock, flags); > 388 > 389 return pending; > 390 } > 391 > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] drm/i915: Use might_alloc() 2021-04-30 17:42 ` Daniel Vetter (?) (?) @ 2021-05-07 7:35 ` Bernard -1 siblings, 0 replies; 14+ messages in thread From: Bernard @ 2021-05-07 7:35 UTC (permalink / raw) To: kbuild-all [-- Attachment #1: Type: text/plain, Size: 4781 bytes --] From: Daniel Vetter <daniel@ffwll.ch> Date: 2021-05-01 01:42:20 To: kernel test robot <lkp@intel.com> Cc: Bernard Zhao <bernard@vivo.com>,Jani Nikula <jani.nikula@linux.intel.com>,Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,Rodrigo Vivi <rodrigo.vivi@intel.com>,David Airlie <airlied@linux.ie>,Daniel Vetter <daniel@ffwll.ch>,intel-gfx(a)lists.freedesktop.org,dri-devel(a)lists.freedesktop.org,linux-kernel(a)vger.kernel.org,kbuild-all(a)lists.01.org Subject: Re: [PATCH] drm/i915: Use might_alloc()>On Fri, Apr 30, 2021 at 12:31:27AM +0800, kernel test robot wrote: >> Hi Bernard, >> >> Thank you for the patch! Yet something to improve: >> >> [auto build test ERROR on drm-intel/for-linux-next] >> [also build test ERROR on v5.12 next-20210429] >> [If your patch is applied to the wrong git tree, kindly drop us a note. >> And when submitting patch, we suggest to use '--base' as documented in >> https://git-scm.com/docs/git-format-patch] >> >> url: https://github.com/0day-ci/linux/commits/Bernard-Zhao/drm-i915-Use-might_alloc/20210429-104516 >> base: git://anongit.freedesktop.org/drm-intel for-linux-next >> config: x86_64-rhel-8.3-kselftests (attached as .config) >> compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 >> reproduce (this is a W=1 build): >> # https://github.com/0day-ci/linux/commit/9fbd0c1741ce06241105d753ff3432ab55f3e94a >> git remote add linux-review https://github.com/0day-ci/linux >> git fetch --no-tags linux-review Bernard-Zhao/drm-i915-Use-might_alloc/20210429-104516 >> git checkout 9fbd0c1741ce06241105d753ff3432ab55f3e94a >> # save the attached .config to linux build tree >> make W=1 W=1 ARCH=x86_64 >> >> If you fix the issue, kindly add following tag as appropriate >> Reported-by: kernel test robot <lkp@intel.com> >> >> All errors (new ones prefixed by >>): >> >> drivers/gpu/drm/i915/i915_sw_fence.c: In function '__i915_sw_fence_await_sw_fence': >> >> drivers/gpu/drm/i915/i915_sw_fence.c:344:2: error: implicit declaration of function 'might_alloc'; did you mean 'might_lock'? [-Werror=implicit-function-declaration] >> 344 | might_alloc(gfp); >> | ^~~~~~~~~~~ >> | might_lock >> cc1: some warnings being treated as errors > >I think you're missing an include or something. The other patch you've >done seems good, I queued that up in drm-intel-gt-next for 5.14. > >Thanks, Daniel Hi It looks like I did not include the header file <linux/sched/mm.h> I will resubmit one patch, thanks! BR//Bernard >> >> >> vim +344 drivers/gpu/drm/i915/i915_sw_fence.c >> >> 335 >> 336 static int __i915_sw_fence_await_sw_fence(struct i915_sw_fence *fence, >> 337 struct i915_sw_fence *signaler, >> 338 wait_queue_entry_t *wq, gfp_t gfp) >> 339 { >> 340 unsigned int pending; >> 341 unsigned long flags; >> 342 >> 343 debug_fence_assert(fence); >> > 344 might_alloc(gfp); >> 345 >> 346 if (i915_sw_fence_done(signaler)) { >> 347 i915_sw_fence_set_error_once(fence, signaler->error); >> 348 return 0; >> 349 } >> 350 >> 351 debug_fence_assert(signaler); >> 352 >> 353 /* The dependency graph must be acyclic. */ >> 354 if (unlikely(i915_sw_fence_check_if_after(fence, signaler))) >> 355 return -EINVAL; >> 356 >> 357 pending = I915_SW_FENCE_FLAG_FENCE; >> 358 if (!wq) { >> 359 wq = kmalloc(sizeof(*wq), gfp); >> 360 if (!wq) { >> 361 if (!gfpflags_allow_blocking(gfp)) >> 362 return -ENOMEM; >> 363 >> 364 i915_sw_fence_wait(signaler); >> 365 i915_sw_fence_set_error_once(fence, signaler->error); >> 366 return 0; >> 367 } >> 368 >> 369 pending |= I915_SW_FENCE_FLAG_ALLOC; >> 370 } >> 371 >> 372 INIT_LIST_HEAD(&wq->entry); >> 373 wq->flags = pending; >> 374 wq->func = i915_sw_fence_wake; >> 375 wq->private = fence; >> 376 >> 377 i915_sw_fence_await(fence); >> 378 >> 379 spin_lock_irqsave(&signaler->wait.lock, flags); >> 380 if (likely(!i915_sw_fence_done(signaler))) { >> 381 __add_wait_queue_entry_tail(&signaler->wait, wq); >> 382 pending = 1; >> 383 } else { >> 384 i915_sw_fence_wake(wq, 0, signaler->error, NULL); >> 385 pending = 0; >> 386 } >> 387 spin_unlock_irqrestore(&signaler->wait.lock, flags); >> 388 >> 389 return pending; >> 390 } >> 391 >> >> --- >> 0-DAY CI Kernel Test Service, Intel Corporation >> https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org > > > >-- >Daniel Vetter >Software Engineer, Intel Corporation >http://blog.ffwll.ch ^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2021-05-07 7:35 UTC | newest] Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-04-29 2:13 [PATCH] drm/i915: Use might_alloc() Bernard Zhao 2021-04-29 2:13 ` [Intel-gfx] " Bernard Zhao 2021-04-29 2:13 ` Bernard Zhao 2021-04-29 18:00 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Use might_alloc() (rev2) Patchwork 2021-04-29 21:18 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 2021-04-29 2:42 [PATCH] drm/i915: Use might_alloc() Bernard Zhao 2021-04-29 2:42 ` Bernard Zhao 2021-04-29 16:31 ` kernel test robot 2021-04-29 16:31 ` kernel test robot 2021-04-29 16:31 ` kernel test robot 2021-04-30 17:42 ` Daniel Vetter 2021-04-30 17:42 ` Daniel Vetter 2021-04-30 17:42 ` Daniel Vetter 2021-05-07 7:35 ` Bernard
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.