From: "Marek Behún" <kabel@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "Pali Rohár" <pali@kernel.org>,
"Gregory CLEMENT" <gregory.clement@bootlin.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 mvebu + mvebu/dt64 1/6] firmware: turris-mox-rwtm: fix reply status decoding function
Date: Wed, 5 May 2021 18:04:33 +0200 [thread overview]
Message-ID: <20210505180433.550178c8@thinkpad> (raw)
In-Reply-To: <YI/rGQfWdMdanPcN@lunn.ch>
On Mon, 3 May 2021 14:22:49 +0200
Andrew Lunn <andrew@lunn.ch> wrote:
> On Thu, Apr 29, 2021 at 10:36:31AM +0200, Pali Rohár wrote:
> > From: Marek Behún <kabel@kernel.org>
> >
> > The status decoding function mox_get_status() currently contains a dead
> > code path: if the error status is not MBOX_STS_SUCCESS, it always
> > returns -EIO, so the comparison to MBOX_STS_FAIL is never executed and
> > we don't get the actual error code sent by the firmware.
> >
> > Fix this.
> >
> > Signed-off-by: Marek Behún <kabel@kernel.org>
> > Fixes: 389711b37493 ("firmware: Add Turris Mox rWTM firmware driver")
>
> You have put a fixes tag here, meaning you want it in stable? How does
> dead code elimination fulfil the stable requirements?
>
> Do any of these changes contain real fixes?
>
> Andrew
Andrew, this is not dead code elimination. Rather it is that there is
dead code path due to an incorrect check. By correcting the check, the
dead code path becomes alive and starts reporting errors correctly.
This fix is nedeed in stable so that stable will report errors
correctly.
Marek
WARNING: multiple messages have this Message-ID (diff)
From: "Marek Behún" <kabel@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "Pali Rohár" <pali@kernel.org>,
"Gregory CLEMENT" <gregory.clement@bootlin.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 mvebu + mvebu/dt64 1/6] firmware: turris-mox-rwtm: fix reply status decoding function
Date: Wed, 5 May 2021 18:04:33 +0200 [thread overview]
Message-ID: <20210505180433.550178c8@thinkpad> (raw)
In-Reply-To: <YI/rGQfWdMdanPcN@lunn.ch>
On Mon, 3 May 2021 14:22:49 +0200
Andrew Lunn <andrew@lunn.ch> wrote:
> On Thu, Apr 29, 2021 at 10:36:31AM +0200, Pali Rohár wrote:
> > From: Marek Behún <kabel@kernel.org>
> >
> > The status decoding function mox_get_status() currently contains a dead
> > code path: if the error status is not MBOX_STS_SUCCESS, it always
> > returns -EIO, so the comparison to MBOX_STS_FAIL is never executed and
> > we don't get the actual error code sent by the firmware.
> >
> > Fix this.
> >
> > Signed-off-by: Marek Behún <kabel@kernel.org>
> > Fixes: 389711b37493 ("firmware: Add Turris Mox rWTM firmware driver")
>
> You have put a fixes tag here, meaning you want it in stable? How does
> dead code elimination fulfil the stable requirements?
>
> Do any of these changes contain real fixes?
>
> Andrew
Andrew, this is not dead code elimination. Rather it is that there is
dead code path due to an incorrect check. By correcting the check, the
dead code path becomes alive and starts reporting errors correctly.
This fix is nedeed in stable so that stable will report errors
correctly.
Marek
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-05 16:04 UTC|newest]
Thread overview: 107+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 15:37 [PATCH mvebu + mvebu/dt64 1/4] firmware: turris-mox-rwtm: fix reply status decoding function Marek Behún
2021-03-08 15:37 ` [PATCH mvebu + mvebu/dt64 2/4] firmware: turris-mox-rwtm: report failures better Marek Behún
2021-03-08 15:37 ` [PATCH mvebu + mvebu/dt64 3/4] firmware: turris-mox-rwtm: fail probing when firmware does not support hwrng Marek Behún
2021-03-08 15:37 ` [PATCH mvebu + mvebu/dt64 4/4] arm64: dts: marvell: armada-37xx: move firmware node to generic dtsi file Marek Behún
2021-03-08 15:37 ` Marek Behún
2021-03-12 8:58 ` Gregory CLEMENT
2021-03-12 8:58 ` Gregory CLEMENT
2021-03-12 9:10 ` Marek Behún
2021-03-12 9:10 ` Marek Behún
2021-03-12 14:48 ` Andrew Lunn
2021-03-12 14:48 ` Andrew Lunn
2021-03-12 15:17 ` Marek Behún
2021-03-12 15:17 ` Marek Behún
2021-03-12 15:53 ` Andrew Lunn
2021-03-12 15:53 ` Andrew Lunn
2021-03-12 16:18 ` Pali Rohár
2021-03-12 16:18 ` Pali Rohár
2021-03-12 16:32 ` Marek Behún
2021-03-12 16:32 ` Marek Behún
2021-03-15 10:14 ` Pali Rohár
2021-03-15 10:14 ` Pali Rohár
2021-03-15 12:08 ` Andrew Lunn
2021-03-15 12:08 ` Andrew Lunn
2021-04-26 18:36 ` Pali Rohár
2021-04-26 18:36 ` Pali Rohár
2021-04-26 19:52 ` Andrew Lunn
2021-04-26 19:52 ` Andrew Lunn
2021-04-29 8:36 ` [PATCH v2 mvebu + mvebu/dt64 1/6] firmware: turris-mox-rwtm: fix reply status decoding function Pali Rohár
2021-04-29 8:36 ` Pali Rohár
2021-04-29 8:36 ` [PATCH v2 mvebu + mvebu/dt64 2/6] firmware: turris-mox-rwtm: report failures better Pali Rohár
2021-04-29 8:36 ` Pali Rohár
2021-04-29 8:36 ` [PATCH v2 mvebu + mvebu/dt64 3/6] firmware: turris-mox-rwtm: fail probing when firmware does not support hwrng Pali Rohár
2021-04-29 8:36 ` Pali Rohár
2021-04-29 8:36 ` [PATCH v2 mvebu + mvebu/dt64 4/6] firmware: turris-mox-rwtm: show message about HWRNG registration Pali Rohár
2021-04-29 8:36 ` Pali Rohár
2021-04-29 8:36 ` [PATCH v2 mvebu + mvebu/dt64 5/6] firmware: turris-mox-rwtm: add marvell,armada-3700-rwtm-firmware compatible string Pali Rohár
2021-04-29 8:36 ` [PATCH v2 mvebu + mvebu/dt64 5/6] firmware: turris-mox-rwtm: add marvell, armada-3700-rwtm-firmware " Pali Rohár
2021-04-29 8:36 ` [PATCH v2 mvebu + mvebu/dt64 6/6] arm64: dts: marvell: armada-37xx: move firmware node to generic dtsi file Pali Rohár
2021-04-29 8:36 ` Pali Rohár
2021-05-03 12:22 ` [PATCH v2 mvebu + mvebu/dt64 1/6] firmware: turris-mox-rwtm: fix reply status decoding function Andrew Lunn
2021-05-03 12:22 ` Andrew Lunn
2021-05-05 16:04 ` Marek Behún [this message]
2021-05-05 16:04 ` Marek Behún
2021-05-05 16:20 ` Andrew Lunn
2021-05-05 16:20 ` Andrew Lunn
2021-05-11 21:46 ` Pali Rohár
2021-05-11 21:46 ` Pali Rohár
2021-05-06 9:07 ` [PATCH v3 " Pali Rohár
2021-05-06 9:07 ` Pali Rohár
2021-05-06 9:07 ` [PATCH v3 mvebu + mvebu/dt64 2/6] firmware: turris-mox-rwtm: report failures better Pali Rohár
2021-05-06 9:07 ` Pali Rohár
2021-05-06 9:07 ` [PATCH v3 mvebu + mvebu/dt64 3/6] firmware: turris-mox-rwtm: fail probing when firmware does not support hwrng Pali Rohár
2021-05-06 9:07 ` Pali Rohár
2021-05-12 0:56 ` Andrew Lunn
2021-05-12 0:56 ` Andrew Lunn
2021-05-20 11:38 ` Pali Rohár
2021-05-20 11:38 ` Pali Rohár
2021-05-06 9:08 ` [PATCH v3 mvebu + mvebu/dt64 4/6] firmware: turris-mox-rwtm: show message about HWRNG registration Pali Rohár
2021-05-06 9:08 ` Pali Rohár
2021-05-06 9:08 ` [PATCH v3 mvebu + mvebu/dt64 5/6] firmware: turris-mox-rwtm: add marvell,armada-3700-rwtm-firmware compatible string Pali Rohár
2021-05-06 9:08 ` [PATCH v3 mvebu + mvebu/dt64 5/6] firmware: turris-mox-rwtm: add marvell, armada-3700-rwtm-firmware " Pali Rohár
2021-05-06 9:08 ` [PATCH v3 mvebu + mvebu/dt64 6/6] arm64: dts: marvell: armada-37xx: move firmware node to generic dtsi file Pali Rohár
2021-05-06 9:08 ` Pali Rohár
2021-05-12 0:59 ` Andrew Lunn
2021-05-12 0:59 ` Andrew Lunn
2021-05-20 11:40 ` Pali Rohár
2021-05-20 11:40 ` Pali Rohár
2021-05-12 0:49 ` [PATCH v3 mvebu + mvebu/dt64 1/6] firmware: turris-mox-rwtm: fix reply status decoding function Andrew Lunn
2021-05-12 0:49 ` Andrew Lunn
2021-05-20 11:35 ` [PATCH v4 mvebu 0/4] firmware: turris-mox-rwtm: fixups Pali Rohár
2021-05-20 11:35 ` Pali Rohár
2021-05-20 11:35 ` [PATCH v4 mvebu 1/4] firmware: turris-mox-rwtm: fix reply status decoding function Pali Rohár
2021-05-20 11:35 ` Pali Rohár
2021-05-20 11:35 ` [PATCH v4 mvebu 2/4] firmware: turris-mox-rwtm: report failures better Pali Rohár
2021-05-20 11:35 ` Pali Rohár
2021-05-21 1:38 ` Andrew Lunn
2021-05-21 1:38 ` Andrew Lunn
2021-05-20 11:35 ` [PATCH v4 mvebu 3/4] firmware: turris-mox-rwtm: fail probing when firmware does not support hwrng Pali Rohár
2021-05-20 11:35 ` Pali Rohár
2021-05-21 1:39 ` Andrew Lunn
2021-05-21 1:39 ` Andrew Lunn
2021-05-20 11:35 ` [PATCH v4 mvebu 4/4] firmware: turris-mox-rwtm: show message about HWRNG registration Pali Rohár
2021-05-20 11:35 ` Pali Rohár
2021-05-21 1:40 ` Andrew Lunn
2021-05-21 1:40 ` Andrew Lunn
2021-06-17 13:06 ` [PATCH v4 mvebu 0/4] firmware: turris-mox-rwtm: fixups Gregory CLEMENT
2021-06-17 13:06 ` Gregory CLEMENT
2021-07-07 18:14 ` Pali Rohár
2021-07-07 18:14 ` Pali Rohár
2021-07-23 12:45 ` Gregory CLEMENT
2021-07-23 12:45 ` Gregory CLEMENT
2021-07-23 12:47 ` Pali Rohár
2021-07-23 12:47 ` Pali Rohár
2021-05-20 11:38 ` [PATCH v4 mvebu + mvebu/dt64 0/2] firmware: turris-mox-rwtm: new compatible string Pali Rohár
2021-05-20 11:38 ` Pali Rohár
2021-05-20 11:38 ` [PATCH v4 mvebu + mvebu/dt64 1/2] firmware: turris-mox-rwtm: add marvell,armada-3700-rwtm-firmware " Pali Rohár
2021-05-20 11:38 ` [PATCH v4 mvebu + mvebu/dt64 1/2] firmware: turris-mox-rwtm: add marvell, armada-3700-rwtm-firmware " Pali Rohár
2021-05-21 1:41 ` [PATCH v4 mvebu + mvebu/dt64 1/2] firmware: turris-mox-rwtm: add marvell,armada-3700-rwtm-firmware " Andrew Lunn
2021-05-21 1:41 ` Andrew Lunn
2021-06-17 13:07 ` Gregory CLEMENT
2021-06-17 13:07 ` Gregory CLEMENT
2021-05-20 11:38 ` [PATCH v4 mvebu + mvebu/dt64 2/2] arm64: dts: marvell: armada-37xx: move firmware node to generic dtsi file Pali Rohár
2021-05-20 11:38 ` Pali Rohár
2021-05-21 1:42 ` Andrew Lunn
2021-05-21 1:42 ` Andrew Lunn
2021-06-17 13:08 ` Gregory CLEMENT
2021-06-17 13:08 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210505180433.550178c8@thinkpad \
--to=kabel@kernel.org \
--cc=andrew@lunn.ch \
--cc=gregory.clement@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pali@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.