All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Alain Volmat <alain.volmat@foss.st.com>
Cc: wsa@kernel.org, mark.rutland@arm.com,
	pierre-yves.mordret@foss.st.com, mcoquelin.stm32@gmail.com,
	alexandre.torgue@foss.st.com, linux-i2c@vger.kernel.org,
	devicetree@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, fabrice.gasnier@foss.st.com
Subject: Re: [PATCH v4 1/2] i2c: add binding to mark a bus as supporting SMBus-Alert
Date: Thu, 6 May 2021 19:55:17 -0500	[thread overview]
Message-ID: <20210507005517.GA1098665@robh.at.kernel.org> (raw)
In-Reply-To: <1620220479-2647-2-git-send-email-alain.volmat@foss.st.com>

On Wed, May 05, 2021 at 03:14:38PM +0200, Alain Volmat wrote:
> Since SMBus-Alert is an optional feature of SMBUS which
> requires an additional pin, the smbus binding cannot be
> used to indicate its support.
> 
> Add an additional smbus-alert binding specific for it and
> update the description text of smbus to avoid mentioning
> SMBus-Alert
> 
> Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
> ---
>  Documentation/devicetree/bindings/i2c/i2c.txt | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)

This needs to be added to i2c-bus.yaml too.

Acked-by: Rob Herring <robh@kernel.org>

> 
> diff --git a/Documentation/devicetree/bindings/i2c/i2c.txt b/Documentation/devicetree/bindings/i2c/i2c.txt
> index df41f72afc87..b864916e087f 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c.txt
> @@ -89,8 +89,11 @@ wants to support one of the below features, it should adapt these bindings.
>  
>  - smbus
>  	states that additional SMBus restrictions and features apply to this bus.
> -	Examples of features are SMBusHostNotify and SMBusAlert. Examples of
> -	restrictions are more reserved addresses and timeout definitions.
> +	An example of feature is SMBusHostNotify. Examples of restrictions are
> +	more reserved addresses and timeout definitions.
> +
> +- smbus-alert
> +	states that the optional SMBus-Alert feature apply to this bus.
>  
>  Required properties (per child device)
>  --------------------------------------
> -- 
> 2.7.4
> 

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Alain Volmat <alain.volmat@foss.st.com>
Cc: wsa@kernel.org, mark.rutland@arm.com,
	pierre-yves.mordret@foss.st.com, mcoquelin.stm32@gmail.com,
	alexandre.torgue@foss.st.com, linux-i2c@vger.kernel.org,
	devicetree@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, fabrice.gasnier@foss.st.com
Subject: Re: [PATCH v4 1/2] i2c: add binding to mark a bus as supporting SMBus-Alert
Date: Thu, 6 May 2021 19:55:17 -0500	[thread overview]
Message-ID: <20210507005517.GA1098665@robh.at.kernel.org> (raw)
In-Reply-To: <1620220479-2647-2-git-send-email-alain.volmat@foss.st.com>

On Wed, May 05, 2021 at 03:14:38PM +0200, Alain Volmat wrote:
> Since SMBus-Alert is an optional feature of SMBUS which
> requires an additional pin, the smbus binding cannot be
> used to indicate its support.
> 
> Add an additional smbus-alert binding specific for it and
> update the description text of smbus to avoid mentioning
> SMBus-Alert
> 
> Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
> ---
>  Documentation/devicetree/bindings/i2c/i2c.txt | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)

This needs to be added to i2c-bus.yaml too.

Acked-by: Rob Herring <robh@kernel.org>

> 
> diff --git a/Documentation/devicetree/bindings/i2c/i2c.txt b/Documentation/devicetree/bindings/i2c/i2c.txt
> index df41f72afc87..b864916e087f 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c.txt
> @@ -89,8 +89,11 @@ wants to support one of the below features, it should adapt these bindings.
>  
>  - smbus
>  	states that additional SMBus restrictions and features apply to this bus.
> -	Examples of features are SMBusHostNotify and SMBusAlert. Examples of
> -	restrictions are more reserved addresses and timeout definitions.
> +	An example of feature is SMBusHostNotify. Examples of restrictions are
> +	more reserved addresses and timeout definitions.
> +
> +- smbus-alert
> +	states that the optional SMBus-Alert feature apply to this bus.
>  
>  Required properties (per child device)
>  --------------------------------------
> -- 
> 2.7.4
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-05-07  0:55 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-05 13:14 [PATCH v4 0/2] i2c: stm32f7: add SMBus-Alert support Alain Volmat
2021-05-05 13:14 ` Alain Volmat
2021-05-05 13:14 ` [PATCH v4 1/2] i2c: add binding to mark a bus as supporting SMBus-Alert Alain Volmat
2021-05-05 13:14   ` Alain Volmat
2021-05-07  0:55   ` Rob Herring [this message]
2021-05-07  0:55     ` Rob Herring
2021-05-25 19:47     ` Wolfram Sang
2021-05-25 19:47       ` Wolfram Sang
2021-05-25 19:53   ` Wolfram Sang
2021-05-25 19:53     ` Wolfram Sang
2021-05-05 13:14 ` [PATCH v4 2/2] i2c: stm32f7: add SMBus-Alert support Alain Volmat
2021-05-05 13:14   ` Alain Volmat
2021-05-10  8:02   ` Pierre Yves MORDRET
2021-05-10  8:02     ` Pierre Yves MORDRET
2021-05-25 19:53   ` Wolfram Sang
2021-05-25 19:53     ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210507005517.GA1098665@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=alain.volmat@foss.st.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=devicetree@vger.kernel.org \
    --cc=fabrice.gasnier@foss.st.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mark.rutland@arm.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=pierre-yves.mordret@foss.st.com \
    --cc=wsa@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.