* [PATCH] drm: Declare drm_send_event_helper static.
@ 2021-05-09 13:42 ` Rajat Asthana
0 siblings, 0 replies; 10+ messages in thread
From: Rajat Asthana @ 2021-05-09 13:42 UTC (permalink / raw)
To: maarten.lankhorst, mripard, tzimmermann, airlied, daniel
Cc: dri-devel, linux-kernel, Rajat
From: Rajat <thisisrast7@gmail.com>
Declare drm_send_event_helper as static to fix sparse warning:
> warning: symbol 'drm_send_event_helper' was not declared.
> Should it be static?
Signed-off-by: Rajat <thisisrast7@gmail.com>
---
drivers/gpu/drm/drm_file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c
index 7efbccffc2ea..17f38d873972 100644
--- a/drivers/gpu/drm/drm_file.c
+++ b/drivers/gpu/drm/drm_file.c
@@ -786,7 +786,7 @@ EXPORT_SYMBOL(drm_event_cancel_free);
* The timestamp variant of dma_fence_signal is used when the caller
* sends a valid timestamp.
*/
-void drm_send_event_helper(struct drm_device *dev,
+static void drm_send_event_helper(struct drm_device *dev,
struct drm_pending_event *e, ktime_t timestamp)
{
assert_spin_locked(&dev->event_lock);
--
2.31.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH] drm: Declare drm_send_event_helper static.
@ 2021-05-09 13:42 ` Rajat Asthana
0 siblings, 0 replies; 10+ messages in thread
From: Rajat Asthana @ 2021-05-09 13:42 UTC (permalink / raw)
To: maarten.lankhorst, mripard, tzimmermann, airlied, daniel
Cc: linux-kernel, dri-devel, Rajat
From: Rajat <thisisrast7@gmail.com>
Declare drm_send_event_helper as static to fix sparse warning:
> warning: symbol 'drm_send_event_helper' was not declared.
> Should it be static?
Signed-off-by: Rajat <thisisrast7@gmail.com>
---
drivers/gpu/drm/drm_file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c
index 7efbccffc2ea..17f38d873972 100644
--- a/drivers/gpu/drm/drm_file.c
+++ b/drivers/gpu/drm/drm_file.c
@@ -786,7 +786,7 @@ EXPORT_SYMBOL(drm_event_cancel_free);
* The timestamp variant of dma_fence_signal is used when the caller
* sends a valid timestamp.
*/
-void drm_send_event_helper(struct drm_device *dev,
+static void drm_send_event_helper(struct drm_device *dev,
struct drm_pending_event *e, ktime_t timestamp)
{
assert_spin_locked(&dev->event_lock);
--
2.31.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH] drm: Declare drm_send_event_helper static.
2021-05-09 13:42 ` Rajat Asthana
@ 2021-05-10 12:32 ` Maxime Ripard
-1 siblings, 0 replies; 10+ messages in thread
From: Maxime Ripard @ 2021-05-10 12:32 UTC (permalink / raw)
To: Rajat Asthana
Cc: maarten.lankhorst, tzimmermann, airlied, daniel, dri-devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 408 bytes --]
Hi,
On Sun, May 09, 2021 at 07:12:52PM +0530, Rajat Asthana wrote:
> From: Rajat <thisisrast7@gmail.com>
>
> Declare drm_send_event_helper as static to fix sparse warning:
>
> > warning: symbol 'drm_send_event_helper' was not declared.
> > Should it be static?
>
> Signed-off-by: Rajat <thisisrast7@gmail.com>
Both the Author and Signed-off-by should have your full name
Thanks!
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] drm: Declare drm_send_event_helper static.
@ 2021-05-10 12:32 ` Maxime Ripard
0 siblings, 0 replies; 10+ messages in thread
From: Maxime Ripard @ 2021-05-10 12:32 UTC (permalink / raw)
To: Rajat Asthana; +Cc: tzimmermann, airlied, linux-kernel, dri-devel
[-- Attachment #1: Type: text/plain, Size: 408 bytes --]
Hi,
On Sun, May 09, 2021 at 07:12:52PM +0530, Rajat Asthana wrote:
> From: Rajat <thisisrast7@gmail.com>
>
> Declare drm_send_event_helper as static to fix sparse warning:
>
> > warning: symbol 'drm_send_event_helper' was not declared.
> > Should it be static?
>
> Signed-off-by: Rajat <thisisrast7@gmail.com>
Both the Author and Signed-off-by should have your full name
Thanks!
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2] drm: Declare drm_send_event_helper static.
2021-05-10 12:32 ` Maxime Ripard
@ 2021-05-10 13:16 ` Rajat Asthana
-1 siblings, 0 replies; 10+ messages in thread
From: Rajat Asthana @ 2021-05-10 13:16 UTC (permalink / raw)
To: mripard
Cc: maarten.lankhorst, tzimmermann, airlied, daniel, dri-devel,
linux-kernel, Rajat Asthana
Declare drm_send_event_helper as static to fix sparse warning:
> warning: symbol 'drm_send_event_helper' was not declared.
> Should it be static?
Signed-off-by: Rajat Asthana <thisisrast7@gmail.com>
---
Changes in v2:
Provide full name in Author and Signed-off.
drivers/gpu/drm/drm_file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c
index 7efbccffc2ea..17f38d873972 100644
--- a/drivers/gpu/drm/drm_file.c
+++ b/drivers/gpu/drm/drm_file.c
@@ -786,7 +786,7 @@ EXPORT_SYMBOL(drm_event_cancel_free);
* The timestamp variant of dma_fence_signal is used when the caller
* sends a valid timestamp.
*/
-void drm_send_event_helper(struct drm_device *dev,
+static void drm_send_event_helper(struct drm_device *dev,
struct drm_pending_event *e, ktime_t timestamp)
{
assert_spin_locked(&dev->event_lock);
--
2.31.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH v2] drm: Declare drm_send_event_helper static.
@ 2021-05-10 13:16 ` Rajat Asthana
0 siblings, 0 replies; 10+ messages in thread
From: Rajat Asthana @ 2021-05-10 13:16 UTC (permalink / raw)
To: mripard; +Cc: tzimmermann, airlied, linux-kernel, dri-devel, Rajat Asthana
Declare drm_send_event_helper as static to fix sparse warning:
> warning: symbol 'drm_send_event_helper' was not declared.
> Should it be static?
Signed-off-by: Rajat Asthana <thisisrast7@gmail.com>
---
Changes in v2:
Provide full name in Author and Signed-off.
drivers/gpu/drm/drm_file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c
index 7efbccffc2ea..17f38d873972 100644
--- a/drivers/gpu/drm/drm_file.c
+++ b/drivers/gpu/drm/drm_file.c
@@ -786,7 +786,7 @@ EXPORT_SYMBOL(drm_event_cancel_free);
* The timestamp variant of dma_fence_signal is used when the caller
* sends a valid timestamp.
*/
-void drm_send_event_helper(struct drm_device *dev,
+static void drm_send_event_helper(struct drm_device *dev,
struct drm_pending_event *e, ktime_t timestamp)
{
assert_spin_locked(&dev->event_lock);
--
2.31.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH v2] drm: Declare drm_send_event_helper static.
2021-05-10 13:16 ` Rajat Asthana
@ 2021-05-10 22:35 ` Guenter Roeck
-1 siblings, 0 replies; 10+ messages in thread
From: Guenter Roeck @ 2021-05-10 22:35 UTC (permalink / raw)
To: Rajat Asthana; +Cc: mripard, tzimmermann, airlied, linux-kernel, dri-devel
On Mon, May 10, 2021 at 06:46:16PM +0530, Rajat Asthana wrote:
> Declare drm_send_event_helper as static to fix sparse warning:
>
> > warning: symbol 'drm_send_event_helper' was not declared.
> > Should it be static?
>
> Signed-off-by: Rajat Asthana <thisisrast7@gmail.com>
> ---
> Changes in v2:
> Provide full name in Author and Signed-off.
>
Turns out a variant of this patch [1] has already been accepted.
Guenter
---
[1] https://patchwork.kernel.org/project/dri-devel/patch/20210427105503.10765-1-fmdefrancesco@gmail.com/
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] drm: Declare drm_send_event_helper static
@ 2021-05-05 2:35 ` Guenter Roeck
0 siblings, 0 replies; 10+ messages in thread
From: Guenter Roeck @ 2021-05-05 2:35 UTC (permalink / raw)
To: David Airlie
Cc: Daniel Vetter, dri-devel, linux-kernel, Guenter Roeck, kernel test robot
0-day reports:
drivers/gpu/drm/drm_file.c:789:6: error:
no previous prototype for 'drm_send_event_helper'
Since drm_send_event_helper() is only used locally,
declare it static to fix the problem.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
drivers/gpu/drm/drm_file.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c
index 7efbccffc2ea..def5df9f19e3 100644
--- a/drivers/gpu/drm/drm_file.c
+++ b/drivers/gpu/drm/drm_file.c
@@ -786,8 +786,8 @@ EXPORT_SYMBOL(drm_event_cancel_free);
* The timestamp variant of dma_fence_signal is used when the caller
* sends a valid timestamp.
*/
-void drm_send_event_helper(struct drm_device *dev,
- struct drm_pending_event *e, ktime_t timestamp)
+static void drm_send_event_helper(struct drm_device *dev,
+ struct drm_pending_event *e, ktime_t timestamp)
{
assert_spin_locked(&dev->event_lock);
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH] drm: Declare drm_send_event_helper static
@ 2021-05-05 2:35 ` Guenter Roeck
0 siblings, 0 replies; 10+ messages in thread
From: Guenter Roeck @ 2021-05-05 2:35 UTC (permalink / raw)
To: David Airlie; +Cc: kernel test robot, Guenter Roeck, dri-devel, linux-kernel
0-day reports:
drivers/gpu/drm/drm_file.c:789:6: error:
no previous prototype for 'drm_send_event_helper'
Since drm_send_event_helper() is only used locally,
declare it static to fix the problem.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
drivers/gpu/drm/drm_file.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c
index 7efbccffc2ea..def5df9f19e3 100644
--- a/drivers/gpu/drm/drm_file.c
+++ b/drivers/gpu/drm/drm_file.c
@@ -786,8 +786,8 @@ EXPORT_SYMBOL(drm_event_cancel_free);
* The timestamp variant of dma_fence_signal is used when the caller
* sends a valid timestamp.
*/
-void drm_send_event_helper(struct drm_device *dev,
- struct drm_pending_event *e, ktime_t timestamp)
+static void drm_send_event_helper(struct drm_device *dev,
+ struct drm_pending_event *e, ktime_t timestamp)
{
assert_spin_locked(&dev->event_lock);
--
2.25.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 10+ messages in thread
end of thread, other threads:[~2021-05-10 22:35 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-09 13:42 [PATCH] drm: Declare drm_send_event_helper static Rajat Asthana
2021-05-09 13:42 ` Rajat Asthana
2021-05-10 12:32 ` Maxime Ripard
2021-05-10 12:32 ` Maxime Ripard
2021-05-10 13:16 ` [PATCH v2] " Rajat Asthana
2021-05-10 13:16 ` Rajat Asthana
2021-05-10 22:35 ` Guenter Roeck
2021-05-10 22:35 ` Guenter Roeck
-- strict thread matches above, loose matches on Subject: below --
2021-05-05 2:35 [PATCH] " Guenter Roeck
2021-05-05 2:35 ` Guenter Roeck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.