* [PATCH v3 0/2] remove different PHY fixups - dts part
@ 2021-05-11 4:30 ` Oleksij Rempel
0 siblings, 0 replies; 12+ messages in thread
From: Oleksij Rempel @ 2021-05-11 4:30 UTC (permalink / raw)
To: Shawn Guo, Sascha Hauer, Andrew Lunn, Florian Fainelli, Heiner Kallweit
Cc: Oleksij Rempel, kernel, netdev, linux-arm-kernel, linux-kernel,
linux-imx, Fabio Estevam, David Jander, Russell King,
Philippe Schenker
changes v3:
- split arch and dts changes
changes v2:
- rebase against latest kernel
- fix networking on RIoTBoard
This patch series tries to remove most of the imx6 and imx7 board
specific PHY configuration via fixup, as this breaks the PHYs when
connected to switch chips or USB Ethernet MACs.
Each patch has the possibility to break boards, but contains a
recommendation to fix the problem in a more portable and future-proof
way.
Oleksij Rempel (2):
ARM: dts: imx6: edmqmx6: set phy-mode to RGMII-ID
ARM: dts: imx6dl-riotboard: configure PHY clock and set proper EEE
value
arch/arm/boot/dts/imx6dl-riotboard.dts | 2 ++
arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
--
2.29.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread* [PATCH v3 1/2] ARM: dts: imx6: edmqmx6: set phy-mode to RGMII-ID
2021-05-11 4:30 ` Oleksij Rempel
@ 2021-05-11 4:30 ` Oleksij Rempel
-1 siblings, 0 replies; 12+ messages in thread
From: Oleksij Rempel @ 2021-05-11 4:30 UTC (permalink / raw)
To: Shawn Guo, Sascha Hauer, Andrew Lunn, Florian Fainelli, Heiner Kallweit
Cc: Oleksij Rempel, kernel, netdev, linux-arm-kernel, linux-kernel,
linux-imx, Fabio Estevam, David Jander, Russell King,
Philippe Schenker
Latest kernel is actually using phy-mode property, so set proper value to make
fec interface work again.
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts b/arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts
index fa2307d8ce86..c713ac03b3b9 100644
--- a/arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts
+++ b/arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts
@@ -112,7 +112,7 @@ flash: m25p80@0 {
&fec {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_enet>;
- phy-mode = "rgmii";
+ phy-mode = "rgmii-id";
phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>;
phy-supply = <&vgen2_1v2_eth>;
status = "okay";
--
2.29.2
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH v3 1/2] ARM: dts: imx6: edmqmx6: set phy-mode to RGMII-ID
@ 2021-05-11 4:30 ` Oleksij Rempel
0 siblings, 0 replies; 12+ messages in thread
From: Oleksij Rempel @ 2021-05-11 4:30 UTC (permalink / raw)
To: Shawn Guo, Sascha Hauer, Andrew Lunn, Florian Fainelli, Heiner Kallweit
Cc: Oleksij Rempel, kernel, netdev, linux-arm-kernel, linux-kernel,
linux-imx, Fabio Estevam, David Jander, Russell King,
Philippe Schenker
Latest kernel is actually using phy-mode property, so set proper value to make
fec interface work again.
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts b/arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts
index fa2307d8ce86..c713ac03b3b9 100644
--- a/arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts
+++ b/arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts
@@ -112,7 +112,7 @@ flash: m25p80@0 {
&fec {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_enet>;
- phy-mode = "rgmii";
+ phy-mode = "rgmii-id";
phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>;
phy-supply = <&vgen2_1v2_eth>;
status = "okay";
--
2.29.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH v3 1/2] ARM: dts: imx6: edmqmx6: set phy-mode to RGMII-ID
2021-05-11 4:30 ` Oleksij Rempel
@ 2021-05-11 12:48 ` Andrew Lunn
-1 siblings, 0 replies; 12+ messages in thread
From: Andrew Lunn @ 2021-05-11 12:48 UTC (permalink / raw)
To: Oleksij Rempel
Cc: Shawn Guo, Sascha Hauer, Florian Fainelli, Heiner Kallweit,
kernel, netdev, linux-arm-kernel, linux-kernel, linux-imx,
Fabio Estevam, David Jander, Russell King, Philippe Schenker
On Tue, May 11, 2021 at 06:30:38AM +0200, Oleksij Rempel wrote:
> Latest kernel is actually using phy-mode property, so set proper value to make
> fec interface work again.
>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH v3 1/2] ARM: dts: imx6: edmqmx6: set phy-mode to RGMII-ID
@ 2021-05-11 12:48 ` Andrew Lunn
0 siblings, 0 replies; 12+ messages in thread
From: Andrew Lunn @ 2021-05-11 12:48 UTC (permalink / raw)
To: Oleksij Rempel
Cc: Shawn Guo, Sascha Hauer, Florian Fainelli, Heiner Kallweit,
kernel, netdev, linux-arm-kernel, linux-kernel, linux-imx,
Fabio Estevam, David Jander, Russell King, Philippe Schenker
On Tue, May 11, 2021 at 06:30:38AM +0200, Oleksij Rempel wrote:
> Latest kernel is actually using phy-mode property, so set proper value to make
> fec interface work again.
>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v3 2/2] ARM: dts: imx6dl-riotboard: configure PHY clock and set proper EEE value
2021-05-11 4:30 ` Oleksij Rempel
@ 2021-05-11 4:30 ` Oleksij Rempel
-1 siblings, 0 replies; 12+ messages in thread
From: Oleksij Rempel @ 2021-05-11 4:30 UTC (permalink / raw)
To: Shawn Guo, Sascha Hauer, Andrew Lunn, Florian Fainelli, Heiner Kallweit
Cc: Oleksij Rempel, kernel, netdev, linux-arm-kernel, linux-kernel,
linux-imx, Fabio Estevam, David Jander, Russell King,
Philippe Schenker
Without SoC specific PHY fixups the network interface on this board will
fail to work. Provide missing DT properties to make it work again.
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
arch/arm/boot/dts/imx6dl-riotboard.dts | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/imx6dl-riotboard.dts b/arch/arm/boot/dts/imx6dl-riotboard.dts
index 065d3ab0f50a..e7d9bfbfd0e4 100644
--- a/arch/arm/boot/dts/imx6dl-riotboard.dts
+++ b/arch/arm/boot/dts/imx6dl-riotboard.dts
@@ -106,6 +106,8 @@ rgmii_phy: ethernet-phy@4 {
reset-gpios = <&gpio3 31 GPIO_ACTIVE_LOW>;
reset-assert-us = <10000>;
reset-deassert-us = <1000>;
+ qca,smarteee-tw-us-1g = <24>;
+ qca,clk-out-frequency = <125000000>;
};
};
};
--
2.29.2
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH v3 2/2] ARM: dts: imx6dl-riotboard: configure PHY clock and set proper EEE value
@ 2021-05-11 4:30 ` Oleksij Rempel
0 siblings, 0 replies; 12+ messages in thread
From: Oleksij Rempel @ 2021-05-11 4:30 UTC (permalink / raw)
To: Shawn Guo, Sascha Hauer, Andrew Lunn, Florian Fainelli, Heiner Kallweit
Cc: Oleksij Rempel, kernel, netdev, linux-arm-kernel, linux-kernel,
linux-imx, Fabio Estevam, David Jander, Russell King,
Philippe Schenker
Without SoC specific PHY fixups the network interface on this board will
fail to work. Provide missing DT properties to make it work again.
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
arch/arm/boot/dts/imx6dl-riotboard.dts | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/imx6dl-riotboard.dts b/arch/arm/boot/dts/imx6dl-riotboard.dts
index 065d3ab0f50a..e7d9bfbfd0e4 100644
--- a/arch/arm/boot/dts/imx6dl-riotboard.dts
+++ b/arch/arm/boot/dts/imx6dl-riotboard.dts
@@ -106,6 +106,8 @@ rgmii_phy: ethernet-phy@4 {
reset-gpios = <&gpio3 31 GPIO_ACTIVE_LOW>;
reset-assert-us = <10000>;
reset-deassert-us = <1000>;
+ qca,smarteee-tw-us-1g = <24>;
+ qca,clk-out-frequency = <125000000>;
};
};
};
--
2.29.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH v3 2/2] ARM: dts: imx6dl-riotboard: configure PHY clock and set proper EEE value
2021-05-11 4:30 ` Oleksij Rempel
@ 2021-05-11 12:48 ` Andrew Lunn
-1 siblings, 0 replies; 12+ messages in thread
From: Andrew Lunn @ 2021-05-11 12:48 UTC (permalink / raw)
To: Oleksij Rempel
Cc: Shawn Guo, Sascha Hauer, Florian Fainelli, Heiner Kallweit,
kernel, netdev, linux-arm-kernel, linux-kernel, linux-imx,
Fabio Estevam, David Jander, Russell King, Philippe Schenker
On Tue, May 11, 2021 at 06:30:39AM +0200, Oleksij Rempel wrote:
> Without SoC specific PHY fixups the network interface on this board will
> fail to work. Provide missing DT properties to make it work again.
>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH v3 2/2] ARM: dts: imx6dl-riotboard: configure PHY clock and set proper EEE value
@ 2021-05-11 12:48 ` Andrew Lunn
0 siblings, 0 replies; 12+ messages in thread
From: Andrew Lunn @ 2021-05-11 12:48 UTC (permalink / raw)
To: Oleksij Rempel
Cc: Shawn Guo, Sascha Hauer, Florian Fainelli, Heiner Kallweit,
kernel, netdev, linux-arm-kernel, linux-kernel, linux-imx,
Fabio Estevam, David Jander, Russell King, Philippe Schenker
On Tue, May 11, 2021 at 06:30:39AM +0200, Oleksij Rempel wrote:
> Without SoC specific PHY fixups the network interface on this board will
> fail to work. Provide missing DT properties to make it work again.
>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3 0/2] remove different PHY fixups - dts part
2021-05-11 4:30 ` Oleksij Rempel
@ 2021-05-23 3:25 ` Shawn Guo
-1 siblings, 0 replies; 12+ messages in thread
From: Shawn Guo @ 2021-05-23 3:25 UTC (permalink / raw)
To: Oleksij Rempel
Cc: Sascha Hauer, Andrew Lunn, Florian Fainelli, Heiner Kallweit,
kernel, netdev, linux-arm-kernel, linux-kernel, linux-imx,
Fabio Estevam, David Jander, Russell King, Philippe Schenker
On Tue, May 11, 2021 at 06:30:37AM +0200, Oleksij Rempel wrote:
> changes v3:
> - split arch and dts changes
>
> changes v2:
> - rebase against latest kernel
> - fix networking on RIoTBoard
>
> This patch series tries to remove most of the imx6 and imx7 board
> specific PHY configuration via fixup, as this breaks the PHYs when
> connected to switch chips or USB Ethernet MACs.
>
> Each patch has the possibility to break boards, but contains a
> recommendation to fix the problem in a more portable and future-proof
> way.
>
> Oleksij Rempel (2):
> ARM: dts: imx6: edmqmx6: set phy-mode to RGMII-ID
> ARM: dts: imx6dl-riotboard: configure PHY clock and set proper EEE
> value
Applied both, thanks.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3 0/2] remove different PHY fixups - dts part
@ 2021-05-23 3:25 ` Shawn Guo
0 siblings, 0 replies; 12+ messages in thread
From: Shawn Guo @ 2021-05-23 3:25 UTC (permalink / raw)
To: Oleksij Rempel
Cc: Sascha Hauer, Andrew Lunn, Florian Fainelli, Heiner Kallweit,
kernel, netdev, linux-arm-kernel, linux-kernel, linux-imx,
Fabio Estevam, David Jander, Russell King, Philippe Schenker
On Tue, May 11, 2021 at 06:30:37AM +0200, Oleksij Rempel wrote:
> changes v3:
> - split arch and dts changes
>
> changes v2:
> - rebase against latest kernel
> - fix networking on RIoTBoard
>
> This patch series tries to remove most of the imx6 and imx7 board
> specific PHY configuration via fixup, as this breaks the PHYs when
> connected to switch chips or USB Ethernet MACs.
>
> Each patch has the possibility to break boards, but contains a
> recommendation to fix the problem in a more portable and future-proof
> way.
>
> Oleksij Rempel (2):
> ARM: dts: imx6: edmqmx6: set phy-mode to RGMII-ID
> ARM: dts: imx6dl-riotboard: configure PHY clock and set proper EEE
> value
Applied both, thanks.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread