* [PATCH] ACPI / EC: Fix media keys not working problem on more Asus laptops
@ 2021-05-11 6:38 Jian-Hong Pan
2021-05-17 14:32 ` Rafael J. Wysocki
0 siblings, 1 reply; 8+ messages in thread
From: Jian-Hong Pan @ 2021-05-11 6:38 UTC (permalink / raw)
To: Rafael J . Wysocki, Len Brown
Cc: Chris Chiu, linux-acpi, linux-kernel, linux, Chris Chiu, Jian-Hong Pan
From: Chris Chiu <chiu@endlessm.com>
More ASUS laptops have the _GPE define in the DSDT table with a
different value than the _GPE number in the ECDT.
This is causing media keys not working on ASUS X505BA/BP, X542BA/BP
Add model info to the quirks list.
Signed-off-by: Chris Chiu <chiu@endlessm.com>
Signed-off-by: Jian-Hong Pan <jhp@endlessos.org>
---
drivers/acpi/ec.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
index 13565629ce0a..e8c5da2b964a 100644
--- a/drivers/acpi/ec.c
+++ b/drivers/acpi/ec.c
@@ -1846,6 +1846,22 @@ static const struct dmi_system_id ec_dmi_table[] __initconst = {
DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
DMI_MATCH(DMI_PRODUCT_NAME, "GL702VMK"),}, NULL},
{
+ ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BA", {
+ DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "X505BA"),}, NULL},
+ {
+ ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BP", {
+ DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "X505BP"),}, NULL},
+ {
+ ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BA", {
+ DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "X542BA"),}, NULL},
+ {
+ ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BP", {
+ DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "X542BP"),}, NULL},
+ {
ec_honor_ecdt_gpe, "ASUS X550VXK", {
DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
DMI_MATCH(DMI_PRODUCT_NAME, "X550VXK"),}, NULL},
--
2.31.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] ACPI / EC: Fix media keys not working problem on more Asus laptops
2021-05-11 6:38 [PATCH] ACPI / EC: Fix media keys not working problem on more Asus laptops Jian-Hong Pan
@ 2021-05-17 14:32 ` Rafael J. Wysocki
2021-05-17 14:40 ` Rafael J. Wysocki
0 siblings, 1 reply; 8+ messages in thread
From: Rafael J. Wysocki @ 2021-05-17 14:32 UTC (permalink / raw)
To: Jian-Hong Pan
Cc: Rafael J . Wysocki, Len Brown, Chris Chiu,
ACPI Devel Maling List, Linux Kernel Mailing List, linux,
Chris Chiu
On Tue, May 11, 2021 at 8:40 AM Jian-Hong Pan <jhp@endlessos.org> wrote:
>
> From: Chris Chiu <chiu@endlessm.com>
>
> More ASUS laptops have the _GPE define in the DSDT table with a
> different value than the _GPE number in the ECDT.
>
> This is causing media keys not working on ASUS X505BA/BP, X542BA/BP
>
> Add model info to the quirks list.
>
> Signed-off-by: Chris Chiu <chiu@endlessm.com>
> Signed-off-by: Jian-Hong Pan <jhp@endlessos.org>
> ---
> drivers/acpi/ec.c | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
> index 13565629ce0a..e8c5da2b964a 100644
> --- a/drivers/acpi/ec.c
> +++ b/drivers/acpi/ec.c
> @@ -1846,6 +1846,22 @@ static const struct dmi_system_id ec_dmi_table[] __initconst = {
> DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> DMI_MATCH(DMI_PRODUCT_NAME, "GL702VMK"),}, NULL},
> {
> + ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BA", {
> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "X505BA"),}, NULL},
> + {
> + ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BP", {
> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "X505BP"),}, NULL},
> + {
> + ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BA", {
> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "X542BA"),}, NULL},
> + {
> + ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BP", {
> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "X542BP"),}, NULL},
> + {
> ec_honor_ecdt_gpe, "ASUS X550VXK", {
> DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> DMI_MATCH(DMI_PRODUCT_NAME, "X550VXK"),}, NULL},
> --
Applied as 5.14 material under a different subject ("ACPI: EC: Make
more Asus laptops use ECDT _GPE"), thanks!
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] ACPI / EC: Fix media keys not working problem on more Asus laptops
2021-05-17 14:32 ` Rafael J. Wysocki
@ 2021-05-17 14:40 ` Rafael J. Wysocki
2021-05-19 3:06 ` [PATCH v2] ACPI: EC: Make more Asus laptops use ECDT _GPE Jian-Hong Pan
0 siblings, 1 reply; 8+ messages in thread
From: Rafael J. Wysocki @ 2021-05-17 14:40 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Jian-Hong Pan, Rafael J . Wysocki, Len Brown, Chris Chiu,
ACPI Devel Maling List, Linux Kernel Mailing List, linux
On Mon, May 17, 2021 at 4:32 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
>
> On Tue, May 11, 2021 at 8:40 AM Jian-Hong Pan <jhp@endlessos.org> wrote:
> >
> > From: Chris Chiu <chiu@endlessm.com>
> >
> > More ASUS laptops have the _GPE define in the DSDT table with a
> > different value than the _GPE number in the ECDT.
> >
> > This is causing media keys not working on ASUS X505BA/BP, X542BA/BP
> >
> > Add model info to the quirks list.
> >
> > Signed-off-by: Chris Chiu <chiu@endlessm.com>
> > Signed-off-by: Jian-Hong Pan <jhp@endlessos.org>
> > ---
> > drivers/acpi/ec.c | 16 ++++++++++++++++
> > 1 file changed, 16 insertions(+)
> >
> > diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
> > index 13565629ce0a..e8c5da2b964a 100644
> > --- a/drivers/acpi/ec.c
> > +++ b/drivers/acpi/ec.c
> > @@ -1846,6 +1846,22 @@ static const struct dmi_system_id ec_dmi_table[] __initconst = {
> > DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> > DMI_MATCH(DMI_PRODUCT_NAME, "GL702VMK"),}, NULL},
> > {
> > + ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BA", {
> > + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> > + DMI_MATCH(DMI_PRODUCT_NAME, "X505BA"),}, NULL},
> > + {
> > + ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BP", {
> > + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> > + DMI_MATCH(DMI_PRODUCT_NAME, "X505BP"),}, NULL},
> > + {
> > + ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BA", {
> > + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> > + DMI_MATCH(DMI_PRODUCT_NAME, "X542BA"),}, NULL},
> > + {
> > + ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BP", {
> > + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> > + DMI_MATCH(DMI_PRODUCT_NAME, "X542BP"),}, NULL},
> > + {
> > ec_honor_ecdt_gpe, "ASUS X550VXK", {
> > DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> > DMI_MATCH(DMI_PRODUCT_NAME, "X550VXK"),}, NULL},
> > --
>
> Applied as 5.14 material under a different subject ("ACPI: EC: Make
> more Asus laptops use ECDT _GPE"), thanks!
And dropped, because the chiu@endlessm.com email address is bouncing.
Please resend with a valid email address in the From: field, thanks!
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH v2] ACPI: EC: Make more Asus laptops use ECDT _GPE
2021-05-17 14:40 ` Rafael J. Wysocki
@ 2021-05-19 3:06 ` Jian-Hong Pan
2021-05-19 9:53 ` Rafael J. Wysocki
0 siblings, 1 reply; 8+ messages in thread
From: Jian-Hong Pan @ 2021-05-19 3:06 UTC (permalink / raw)
To: Rafael J . Wysocki
Cc: Len Brown, linux-acpi, linux-kernel, linux, Chris Chiu,
Chris Chiu, Jian-Hong Pan
From: Chris Chiu <chris.chiu@canonical.com>
More ASUS laptops have the _GPE define in the DSDT table with a
different value than the _GPE number in the ECDT.
This is causing media keys not working on ASUS X505BA/BP, X542BA/BP
Add model info to the quirks list.
Signed-off-by: Chris Chiu <chiu@endlessm.com>
Signed-off-by: Jian-Hong Pan <jhp@endlessos.org>
---
v2: Edit the author information with valid email address
drivers/acpi/ec.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
index 13565629ce0a..e8c5da2b964a 100644
--- a/drivers/acpi/ec.c
+++ b/drivers/acpi/ec.c
@@ -1846,6 +1846,22 @@ static const struct dmi_system_id ec_dmi_table[] __initconst = {
DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
DMI_MATCH(DMI_PRODUCT_NAME, "GL702VMK"),}, NULL},
{
+ ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BA", {
+ DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "X505BA"),}, NULL},
+ {
+ ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BP", {
+ DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "X505BP"),}, NULL},
+ {
+ ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BA", {
+ DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "X542BA"),}, NULL},
+ {
+ ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BP", {
+ DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "X542BP"),}, NULL},
+ {
ec_honor_ecdt_gpe, "ASUS X550VXK", {
DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
DMI_MATCH(DMI_PRODUCT_NAME, "X550VXK"),}, NULL},
--
2.31.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH v2] ACPI: EC: Make more Asus laptops use ECDT _GPE
2021-05-19 3:06 ` [PATCH v2] ACPI: EC: Make more Asus laptops use ECDT _GPE Jian-Hong Pan
@ 2021-05-19 9:53 ` Rafael J. Wysocki
2021-05-19 10:10 ` Chris Chiu
0 siblings, 1 reply; 8+ messages in thread
From: Rafael J. Wysocki @ 2021-05-19 9:53 UTC (permalink / raw)
To: Jian-Hong Pan, Chris Chiu
Cc: Rafael J . Wysocki, Len Brown, ACPI Devel Maling List,
Linux Kernel Mailing List, linux, Chris Chiu
On Wed, May 19, 2021 at 5:11 AM Jian-Hong Pan <jhp@endlessos.org> wrote:
>
> From: Chris Chiu <chris.chiu@canonical.com>
>
> More ASUS laptops have the _GPE define in the DSDT table with a
> different value than the _GPE number in the ECDT.
>
> This is causing media keys not working on ASUS X505BA/BP, X542BA/BP
>
> Add model info to the quirks list.
>
> Signed-off-by: Chris Chiu <chiu@endlessm.com>
This has to match the From address.
Chris, can the e-mail address in the S-o-b be changed?
> Signed-off-by: Jian-Hong Pan <jhp@endlessos.org>
> ---
> v2: Edit the author information with valid email address
>
> drivers/acpi/ec.c | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
> index 13565629ce0a..e8c5da2b964a 100644
> --- a/drivers/acpi/ec.c
> +++ b/drivers/acpi/ec.c
> @@ -1846,6 +1846,22 @@ static const struct dmi_system_id ec_dmi_table[] __initconst = {
> DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> DMI_MATCH(DMI_PRODUCT_NAME, "GL702VMK"),}, NULL},
> {
> + ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BA", {
> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "X505BA"),}, NULL},
> + {
> + ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BP", {
> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "X505BP"),}, NULL},
> + {
> + ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BA", {
> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "X542BA"),}, NULL},
> + {
> + ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BP", {
> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "X542BP"),}, NULL},
> + {
> ec_honor_ecdt_gpe, "ASUS X550VXK", {
> DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> DMI_MATCH(DMI_PRODUCT_NAME, "X550VXK"),}, NULL},
> --
> 2.31.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v2] ACPI: EC: Make more Asus laptops use ECDT _GPE
2021-05-19 9:53 ` Rafael J. Wysocki
@ 2021-05-19 10:10 ` Chris Chiu
2021-05-20 3:09 ` [PATCH v3] " Jian-Hong Pan
0 siblings, 1 reply; 8+ messages in thread
From: Chris Chiu @ 2021-05-19 10:10 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Jian-Hong Pan, Len Brown, ACPI Devel Maling List,
Linux Kernel Mailing List, linux, Chris Chiu
On Wed, May 19, 2021 at 5:53 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
>
> On Wed, May 19, 2021 at 5:11 AM Jian-Hong Pan <jhp@endlessos.org> wrote:
> >
> > From: Chris Chiu <chris.chiu@canonical.com>
> >
> > More ASUS laptops have the _GPE define in the DSDT table with a
> > different value than the _GPE number in the ECDT.
> >
> > This is causing media keys not working on ASUS X505BA/BP, X542BA/BP
> >
> > Add model info to the quirks list.
> >
> > Signed-off-by: Chris Chiu <chiu@endlessm.com>
>
> This has to match the From address.
>
> Chris, can the e-mail address in the S-o-b be changed?
>
Sure. I've updated the .mailmap. Jian-Hong, could you help fix the
S-o-b? Thanks.
Chris
> > Signed-off-by: Jian-Hong Pan <jhp@endlessos.org>
> > ---
> > v2: Edit the author information with valid email address
> >
> > drivers/acpi/ec.c | 16 ++++++++++++++++
> > 1 file changed, 16 insertions(+)
> >
> > diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
> > index 13565629ce0a..e8c5da2b964a 100644
> > --- a/drivers/acpi/ec.c
> > +++ b/drivers/acpi/ec.c
> > @@ -1846,6 +1846,22 @@ static const struct dmi_system_id ec_dmi_table[] __initconst = {
> > DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> > DMI_MATCH(DMI_PRODUCT_NAME, "GL702VMK"),}, NULL},
> > {
> > + ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BA", {
> > + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> > + DMI_MATCH(DMI_PRODUCT_NAME, "X505BA"),}, NULL},
> > + {
> > + ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BP", {
> > + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> > + DMI_MATCH(DMI_PRODUCT_NAME, "X505BP"),}, NULL},
> > + {
> > + ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BA", {
> > + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> > + DMI_MATCH(DMI_PRODUCT_NAME, "X542BA"),}, NULL},
> > + {
> > + ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BP", {
> > + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> > + DMI_MATCH(DMI_PRODUCT_NAME, "X542BP"),}, NULL},
> > + {
> > ec_honor_ecdt_gpe, "ASUS X550VXK", {
> > DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> > DMI_MATCH(DMI_PRODUCT_NAME, "X550VXK"),}, NULL},
> > --
> > 2.31.1
> >
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH v3] ACPI: EC: Make more Asus laptops use ECDT _GPE
2021-05-19 10:10 ` Chris Chiu
@ 2021-05-20 3:09 ` Jian-Hong Pan
2021-05-21 17:18 ` Rafael J. Wysocki
0 siblings, 1 reply; 8+ messages in thread
From: Jian-Hong Pan @ 2021-05-20 3:09 UTC (permalink / raw)
To: Rafael J . Wysocki
Cc: Len Brown, linux-acpi, linux-kernel, linux, Chris Chiu, Jian-Hong Pan
From: Chris Chiu <chris.chiu@canonical.com>
More ASUS laptops have the _GPE define in the DSDT table with a
different value than the _GPE number in the ECDT.
This is causing media keys not working on ASUS X505BA/BP, X542BA/BP
Add model info to the quirks list.
Signed-off-by: Chris Chiu <chris.chiu@canonical.com>
Signed-off-by: Jian-Hong Pan <jhp@endlessos.org>
---
v2: Edit the author information with valid email address
v3: Edit Chris' S-o-b with current valid email address
drivers/acpi/ec.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
index 13565629ce0a..e8c5da2b964a 100644
--- a/drivers/acpi/ec.c
+++ b/drivers/acpi/ec.c
@@ -1846,6 +1846,22 @@ static const struct dmi_system_id ec_dmi_table[] __initconst = {
DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
DMI_MATCH(DMI_PRODUCT_NAME, "GL702VMK"),}, NULL},
{
+ ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BA", {
+ DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "X505BA"),}, NULL},
+ {
+ ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BP", {
+ DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "X505BP"),}, NULL},
+ {
+ ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BA", {
+ DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "X542BA"),}, NULL},
+ {
+ ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BP", {
+ DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "X542BP"),}, NULL},
+ {
ec_honor_ecdt_gpe, "ASUS X550VXK", {
DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
DMI_MATCH(DMI_PRODUCT_NAME, "X550VXK"),}, NULL},
--
2.31.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH v3] ACPI: EC: Make more Asus laptops use ECDT _GPE
2021-05-20 3:09 ` [PATCH v3] " Jian-Hong Pan
@ 2021-05-21 17:18 ` Rafael J. Wysocki
0 siblings, 0 replies; 8+ messages in thread
From: Rafael J. Wysocki @ 2021-05-21 17:18 UTC (permalink / raw)
To: Jian-Hong Pan
Cc: Rafael J . Wysocki, Len Brown, ACPI Devel Maling List,
Linux Kernel Mailing List, linux, Chris Chiu
On Thu, May 20, 2021 at 5:13 AM Jian-Hong Pan <jhp@endlessos.org> wrote:
>
> From: Chris Chiu <chris.chiu@canonical.com>
>
> More ASUS laptops have the _GPE define in the DSDT table with a
> different value than the _GPE number in the ECDT.
>
> This is causing media keys not working on ASUS X505BA/BP, X542BA/BP
>
> Add model info to the quirks list.
>
> Signed-off-by: Chris Chiu <chris.chiu@canonical.com>
> Signed-off-by: Jian-Hong Pan <jhp@endlessos.org>
> ---
> v2: Edit the author information with valid email address
>
> v3: Edit Chris' S-o-b with current valid email address
>
> drivers/acpi/ec.c | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
> index 13565629ce0a..e8c5da2b964a 100644
> --- a/drivers/acpi/ec.c
> +++ b/drivers/acpi/ec.c
> @@ -1846,6 +1846,22 @@ static const struct dmi_system_id ec_dmi_table[] __initconst = {
> DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> DMI_MATCH(DMI_PRODUCT_NAME, "GL702VMK"),}, NULL},
> {
> + ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BA", {
> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "X505BA"),}, NULL},
> + {
> + ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BP", {
> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "X505BP"),}, NULL},
> + {
> + ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BA", {
> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "X542BA"),}, NULL},
> + {
> + ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BP", {
> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "X542BP"),}, NULL},
> + {
> ec_honor_ecdt_gpe, "ASUS X550VXK", {
> DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> DMI_MATCH(DMI_PRODUCT_NAME, "X550VXK"),}, NULL},
> --
Applied as 5.14 material, thanks!
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-05-21 17:18 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-11 6:38 [PATCH] ACPI / EC: Fix media keys not working problem on more Asus laptops Jian-Hong Pan
2021-05-17 14:32 ` Rafael J. Wysocki
2021-05-17 14:40 ` Rafael J. Wysocki
2021-05-19 3:06 ` [PATCH v2] ACPI: EC: Make more Asus laptops use ECDT _GPE Jian-Hong Pan
2021-05-19 9:53 ` Rafael J. Wysocki
2021-05-19 10:10 ` Chris Chiu
2021-05-20 3:09 ` [PATCH v3] " Jian-Hong Pan
2021-05-21 17:18 ` Rafael J. Wysocki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.