* [PATCH] fsl-usb: add need_oc_pp_cycle flag for 85xx also
@ 2021-05-07 17:23 Daniel Walker
2021-05-07 17:36 ` Alan Stern
2021-05-13 8:32 ` [PATCH v2] " Gopalakrishnan Santhanam
0 siblings, 2 replies; 5+ messages in thread
From: Daniel Walker @ 2021-05-07 17:23 UTC (permalink / raw)
To: Alan Stern
Cc: HEMANT RAMDASI, Christian Engelmayer, Gopalakrishnan Santhanam,
xe-linux-external, Greg Kroah-Hartman, linux-usb, linux-kernel
From: Gopalakrishnan Santhanam <gsanthan@cisco.com>
Commit e6604a7fd71f9 ("EHCI: Quirk flag for port power handling on overcurrent.")
activated the quirks handling (flag need_oc_pp_cycle) for Freescale 83xx
based boards.
Activate same for 85xx based boards as well.
Cc: xe-linux-external@cisco.com
Signed-off-by: Gopalakrishnan Santhanam <gsanthan@cisco.com>
Signed-off-by: Daniel Walker <danielwa@cisco.com>
---
drivers/usb/host/ehci-fsl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c
index 6f7bd6641694..c7d74c1a23f5 100644
--- a/drivers/usb/host/ehci-fsl.c
+++ b/drivers/usb/host/ehci-fsl.c
@@ -387,7 +387,7 @@ static int ehci_fsl_setup(struct usb_hcd *hcd)
/* EHCI registers start at offset 0x100 */
ehci->caps = hcd->regs + 0x100;
-#ifdef CONFIG_PPC_83xx
+#if defined(CONFIG_PPC_83xx) || defined(CONFIG_PPC_85xx)
/*
* Deal with MPC834X that need port power to be cycled after the power
* fault condition is removed. Otherwise the state machine does not
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] fsl-usb: add need_oc_pp_cycle flag for 85xx also
2021-05-07 17:23 [PATCH] fsl-usb: add need_oc_pp_cycle flag for 85xx also Daniel Walker
@ 2021-05-07 17:36 ` Alan Stern
2021-05-11 13:19 ` Gopalakrishnan Santhanam -X (gsanthan - Altran ACT S.A.S at Cisco)
2021-05-13 8:32 ` [PATCH v2] " Gopalakrishnan Santhanam
1 sibling, 1 reply; 5+ messages in thread
From: Alan Stern @ 2021-05-07 17:36 UTC (permalink / raw)
To: Daniel Walker
Cc: HEMANT RAMDASI, Christian Engelmayer, Gopalakrishnan Santhanam,
xe-linux-external, Greg Kroah-Hartman, linux-usb, linux-kernel
On Fri, May 07, 2021 at 10:23:00AM -0700, Daniel Walker wrote:
> From: Gopalakrishnan Santhanam <gsanthan@cisco.com>
>
> Commit e6604a7fd71f9 ("EHCI: Quirk flag for port power handling on overcurrent.")
> activated the quirks handling (flag need_oc_pp_cycle) for Freescale 83xx
> based boards.
> Activate same for 85xx based boards as well.
>
> Cc: xe-linux-external@cisco.com
> Signed-off-by: Gopalakrishnan Santhanam <gsanthan@cisco.com>
> Signed-off-by: Daniel Walker <danielwa@cisco.com>
> ---
> drivers/usb/host/ehci-fsl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c
> index 6f7bd6641694..c7d74c1a23f5 100644
> --- a/drivers/usb/host/ehci-fsl.c
> +++ b/drivers/usb/host/ehci-fsl.c
> @@ -387,7 +387,7 @@ static int ehci_fsl_setup(struct usb_hcd *hcd)
> /* EHCI registers start at offset 0x100 */
> ehci->caps = hcd->regs + 0x100;
>
> -#ifdef CONFIG_PPC_83xx
> +#if defined(CONFIG_PPC_83xx) || defined(CONFIG_PPC_85xx)
> /*
> * Deal with MPC834X that need port power to be cycled after the power
-------------------------^
Shouldn't this comment be changed as well?
Alan Stern
> * fault condition is removed. Otherwise the state machine does not
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] fsl-usb: add need_oc_pp_cycle flag for 85xx also
2021-05-07 17:36 ` Alan Stern
@ 2021-05-11 13:19 ` Gopalakrishnan Santhanam -X (gsanthan - Altran ACT S.A.S at Cisco)
0 siblings, 0 replies; 5+ messages in thread
From: Gopalakrishnan Santhanam -X (gsanthan - Altran ACT S.A.S at Cisco) @ 2021-05-11 13:19 UTC (permalink / raw)
To: Alan Stern, Daniel Walker (danielwa)
Cc: HEMANT RAMDASI (hramdasi),
Christian Engelmayer, xe-linux-external(mailer list),
Greg Kroah-Hartman, linux-usb, linux-kernel
Hi Alan
Thanks for the review !
Yes we have to change the comment as well.
We will update the comments and resend.
Regards,
Gopal
-----Original Message-----
From: Alan Stern <stern@rowland.harvard.edu>
Sent: Friday, May 7, 2021 11:07 PM
To: Daniel Walker (danielwa) <danielwa@cisco.com>
Cc: HEMANT RAMDASI (hramdasi) <hramdasi@cisco.com>; Christian Engelmayer <christian.engelmayer@frequentis.com>; Gopalakrishnan Santhanam -X (gsanthan - Altran ACT S.A.S at Cisco) <gsanthan@cisco.com>; xe-linux-external(mailer list) <xe-linux-external@cisco.com>; Greg Kroah-Hartman <gregkh@linuxfoundation.org>; linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fsl-usb: add need_oc_pp_cycle flag for 85xx also
On Fri, May 07, 2021 at 10:23:00AM -0700, Daniel Walker wrote:
> From: Gopalakrishnan Santhanam <gsanthan@cisco.com>
>
> Commit e6604a7fd71f9 ("EHCI: Quirk flag for port power handling on
> overcurrent.") activated the quirks handling (flag need_oc_pp_cycle)
> for Freescale 83xx based boards.
> Activate same for 85xx based boards as well.
>
> Cc: xe-linux-external@cisco.com
> Signed-off-by: Gopalakrishnan Santhanam <gsanthan@cisco.com>
> Signed-off-by: Daniel Walker <danielwa@cisco.com>
> ---
> drivers/usb/host/ehci-fsl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c
> index 6f7bd6641694..c7d74c1a23f5 100644
> --- a/drivers/usb/host/ehci-fsl.c
> +++ b/drivers/usb/host/ehci-fsl.c
> @@ -387,7 +387,7 @@ static int ehci_fsl_setup(struct usb_hcd *hcd)
> /* EHCI registers start at offset 0x100 */
> ehci->caps = hcd->regs + 0x100;
>
> -#ifdef CONFIG_PPC_83xx
> +#if defined(CONFIG_PPC_83xx) || defined(CONFIG_PPC_85xx)
> /*
> * Deal with MPC834X that need port power to be cycled after the
> power
-------------------------^
Shouldn't this comment be changed as well?
Alan Stern
> * fault condition is removed. Otherwise the state machine does not
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] fsl-usb: add need_oc_pp_cycle flag for 85xx also
2021-05-07 17:23 [PATCH] fsl-usb: add need_oc_pp_cycle flag for 85xx also Daniel Walker
2021-05-07 17:36 ` Alan Stern
@ 2021-05-13 8:32 ` Gopalakrishnan Santhanam
2021-05-13 14:42 ` Alan Stern
1 sibling, 1 reply; 5+ messages in thread
From: Gopalakrishnan Santhanam @ 2021-05-13 8:32 UTC (permalink / raw)
To: stern
Cc: danielwa, hramdasi, gsanthan, christian.engelmayer,
xe-linux-external, gregkh, linux-usb, linux-kernel
Commit e6604a7fd71f9 ("EHCI: Quirk flag for port power handling
on overcurrent.") activated the quirks handling (flag need_oc_pp_cycle)
for Freescale 83xx based boards.
Activate same for 85xx based boards as well.
Cc: xe-linux-external@cisco.com
Signed-off-by: Gopalakrishnan Santhanam <gsanthan@cisco.com>
Signed-off-by: Daniel Walker <danielwa@cisco.com>
---
drivers/usb/host/ehci-fsl.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c
index 6f7bd6641694..385be30baad3 100644
--- a/drivers/usb/host/ehci-fsl.c
+++ b/drivers/usb/host/ehci-fsl.c
@@ -387,11 +387,11 @@ static int ehci_fsl_setup(struct usb_hcd *hcd)
/* EHCI registers start at offset 0x100 */
ehci->caps = hcd->regs + 0x100;
-#ifdef CONFIG_PPC_83xx
+#if defined(CONFIG_PPC_83xx) || defined(CONFIG_PPC_85xx)
/*
- * Deal with MPC834X that need port power to be cycled after the power
- * fault condition is removed. Otherwise the state machine does not
- * reflect PORTSC[CSC] correctly.
+ * Deal with MPC834X/85XX that need port power to be cycled
+ * after the power fault condition is removed. Otherwise the
+ * state machine does not reflect PORTSC[CSC] correctly.
*/
ehci->need_oc_pp_cycle = 1;
#endif
--
2.26.2.Cisco
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] fsl-usb: add need_oc_pp_cycle flag for 85xx also
2021-05-13 8:32 ` [PATCH v2] " Gopalakrishnan Santhanam
@ 2021-05-13 14:42 ` Alan Stern
0 siblings, 0 replies; 5+ messages in thread
From: Alan Stern @ 2021-05-13 14:42 UTC (permalink / raw)
To: Gopalakrishnan Santhanam
Cc: danielwa, hramdasi, christian.engelmayer, xe-linux-external,
gregkh, linux-usb, linux-kernel
On Thu, May 13, 2021 at 02:02:25PM +0530, Gopalakrishnan Santhanam wrote:
> Commit e6604a7fd71f9 ("EHCI: Quirk flag for port power handling
> on overcurrent.") activated the quirks handling (flag need_oc_pp_cycle)
> for Freescale 83xx based boards.
> Activate same for 85xx based boards as well.
>
> Cc: xe-linux-external@cisco.com
> Signed-off-by: Gopalakrishnan Santhanam <gsanthan@cisco.com>
> Signed-off-by: Daniel Walker <danielwa@cisco.com>
> ---
Acked-by: Alan Stern <stern@rowland.harvard.edu>
> drivers/usb/host/ehci-fsl.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c
> index 6f7bd6641694..385be30baad3 100644
> --- a/drivers/usb/host/ehci-fsl.c
> +++ b/drivers/usb/host/ehci-fsl.c
> @@ -387,11 +387,11 @@ static int ehci_fsl_setup(struct usb_hcd *hcd)
> /* EHCI registers start at offset 0x100 */
> ehci->caps = hcd->regs + 0x100;
>
> -#ifdef CONFIG_PPC_83xx
> +#if defined(CONFIG_PPC_83xx) || defined(CONFIG_PPC_85xx)
> /*
> - * Deal with MPC834X that need port power to be cycled after the power
> - * fault condition is removed. Otherwise the state machine does not
> - * reflect PORTSC[CSC] correctly.
> + * Deal with MPC834X/85XX that need port power to be cycled
> + * after the power fault condition is removed. Otherwise the
> + * state machine does not reflect PORTSC[CSC] correctly.
> */
> ehci->need_oc_pp_cycle = 1;
> #endif
> --
> 2.26.2.Cisco
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-05-13 14:42 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-07 17:23 [PATCH] fsl-usb: add need_oc_pp_cycle flag for 85xx also Daniel Walker
2021-05-07 17:36 ` Alan Stern
2021-05-11 13:19 ` Gopalakrishnan Santhanam -X (gsanthan - Altran ACT S.A.S at Cisco)
2021-05-13 8:32 ` [PATCH v2] " Gopalakrishnan Santhanam
2021-05-13 14:42 ` Alan Stern
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.