Re: [meta-ti][dunfell/master][PATCH] linux-ti-staging: Added DTC_FLAG to Kernel argument to build dtbs with symbols

Re: [meta-ti][dunfell/master][PATCH] linux-ti-staging: Added DTC_FLAG to Kernel argument to build dtbs with symbols

[Nishanth Menon]

On 20:21-20210513, Yogesh Siraswar wrote:
> Added DTC_FLAG (-@) to individual MACHINE configuration to compile dtbs with symbols.
> This fixes the issue where the dtbs are build without symbols causing issue with overlays

70 characters wrap please.

> 
> Signed-off-by: Yogesh Siraswar <yogeshs@ti.com>
> ---
>  conf/machine/am335x-evm.conf                  |  9 +++++++++
>  conf/machine/am335x-hs-evm.conf               |  9 +++++++++
>  conf/machine/am437x-evm.conf                  |  9 +++++++++
>  conf/machine/am437x-hs-evm.conf               |  9 +++++++++
>  conf/machine/am57xx-evm.conf                  |  8 ++++++++
>  conf/machine/am57xx-hs-evm.conf               |  9 +++++++++
>  conf/machine/am65xx-evm.conf                  |  8 ++++++++
>  conf/machine/am65xx-hs-evm.conf               |  9 +++++++++
>  conf/machine/dra7xx-evm.conf                  | 11 +++++++++++
>  conf/machine/dra7xx-hs-evm.conf               |  9 +++++++++
>  conf/machine/j7-evm.conf                      |  9 +++++++++
>  conf/machine/j7-hs-evm.conf                   |  9 +++++++++
>  conf/machine/j7200-evm.conf                   | 10 ++++++++++
>  conf/machine/k2g-evm.conf                     |  9 +++++++++
>  conf/machine/k2g-hs-evm.conf                  |  9 +++++++++
>  recipes-kernel/linux/linux-ti-staging_5.10.bb |  2 +-

how about mainline?

>  16 files changed, 137 insertions(+), 1 deletion(-)
> 
> diff --git a/conf/machine/am335x-evm.conf b/conf/machine/am335x-evm.conf
> index 469c4d37..dc50e686 100644
> --- a/conf/machine/am335x-evm.conf
> +++ b/conf/machine/am335x-evm.conf
> @@ -13,6 +13,15 @@ IMAGE_FSTYPES += "ubifs ubi"
>  SERIAL_CONSOLES = "115200;ttyS0 115200;ttyS3"
>  SERIAL_CONSOLES_CHECK = "${SERIAL_CONSOLES}"
>  
> +#Add DTC_FLAGS to compile DTB with symbols.
> +#Weak assignment so that can be over-written with
> +#EXTRA_DTC_FLAGS = "" in local.conf

We dont need this comment every where, do we?
> +
> +EXTRA_DTC_FLAGS ?= "DTC_FLAGS=-@"
> +
> +KERNEL_EXTRA_ARGS += "${EXTRA_DTC_FLAGS}"

Should'nt this be in a common file
[...]

> diff --git a/recipes-kernel/linux/linux-ti-staging_5.10.bb b/recipes-kernel/linux/linux-ti-staging_5.10.bb
> index 4ec19af7..ee5e6fa1 100644
> --- a/recipes-kernel/linux/linux-ti-staging_5.10.bb
> +++ b/recipes-kernel/linux/linux-ti-staging_5.10.bb
> @@ -25,7 +25,7 @@ SRCREV = "d85aee3e19aa7403bd157d2ae30917e736096a7f"
>  PV = "5.10.30+git${SRCPV}"
>  
>  # Append to the MACHINE_KERNEL_PR so that a new SRCREV will cause a rebuild
> -MACHINE_KERNEL_PR_append = "a"
> +MACHINE_KERNEL_PR_append = "b"
>  PR = "${MACHINE_KERNEL_PR}"
> 

I wonder if this comes here.
KERNEL_EXTRA_ARGS += "${EXTRA_DTC_FLAGS}"

>  KERNEL_GIT_URI = "git://git.ti.com/ti-linux-kernel/ti-linux-kernel.git"
> -- 
> 2.17.1
> 

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

Re: [meta-ti][dunfell/master][PATCH] linux-ti-staging: Added DTC_FLAG to Kernel argument to build dtbs with symbols

[Nishanth Menon]

On 11:18-20210514, Nishanth Menon via lists.yoctoproject.org wrote:
> On 20:21-20210513, Yogesh Siraswar wrote:

[...]

> 
> >  16 files changed, 137 insertions(+), 1 deletion(-)
> > 
> > diff --git a/conf/machine/am335x-evm.conf b/conf/machine/am335x-evm.conf
> > index 469c4d37..dc50e686 100644
> > --- a/conf/machine/am335x-evm.conf
> > +++ b/conf/machine/am335x-evm.conf
> > @@ -13,6 +13,15 @@ IMAGE_FSTYPES += "ubifs ubi"
> >  SERIAL_CONSOLES = "115200;ttyS0 115200;ttyS3"
> >  SERIAL_CONSOLES_CHECK = "${SERIAL_CONSOLES}"
> >  
> > +#Add DTC_FLAGS to compile DTB with symbols.
> > +#Weak assignment so that can be over-written with
> > +#EXTRA_DTC_FLAGS = "" in local.conf
> 
> We dont need this comment every where, do we?
> > +
> > +EXTRA_DTC_FLAGS ?= "DTC_FLAGS=-@"
> > +
> > +KERNEL_EXTRA_ARGS += "${EXTRA_DTC_FLAGS}"
> 
> Should'nt this be in a common file
> [...]


Thinking again - should we make this a little easier in case the future
dtc needs more flags?

a) KERNEL_HAS_OVERLAYS as a single variable defined in machine.confs
b) ti-kernel.inc which introduces KERNEL_EXTRA_ARGS in the style above
(extra_dtc_flags...)
c) include ti-kernel.inc in mainline-linux and linux-ti-staging?

[...]


-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D