All of lore.kernel.org
 help / color / mirror / Atom feed
From: Abhishek Kumar <kuabhs@chromium.org>
To: Johannes Berg <johannes.berg@intel.com>,
	Kalle Valo <kvalo@codeaurora.org>
Cc: briannorris@chromium.org, ath10k@lists.infradead.org,
	linux-wireless@vger.kernel.org,
	Jouni Malinen <jouni@codeaurora.org>,
	Wen Gong <wgong@codeaurora.org>,
	kuabhs@chromium.org, "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: [PATCH] ath10k: remove unused variable in ath10k_htt_rx_h_frag_pn_check
Date: Fri, 14 May 2021 22:07:42 +0000	[thread overview]
Message-ID: <20210514220644.1.Iad576de95836b74aba80a5fc28d7131940eca190@changeid> (raw)

The local variable more_frags in ath10k_htt_rx_h_frag_pn_check is not
used. This patch is to remove that.

Fixes: a1166b2653db ("ath10k: add CCMP PN replay protection for fragmented
frames for PCIe")
Signed-off-by: Abhishek Kumar <kuabhs@chromium.org>
---

 drivers/net/wireless/ath/ath10k/htt_rx.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c
index 7ffb5d5b2a70..adbaeb67eedf 100644
--- a/drivers/net/wireless/ath/ath10k/htt_rx.c
+++ b/drivers/net/wireless/ath/ath10k/htt_rx.c
@@ -1787,7 +1787,6 @@ static bool ath10k_htt_rx_h_frag_pn_check(struct ath10k *ar,
 	struct ath10k_peer *peer;
 	union htt_rx_pn_t *last_pn, new_pn = {0};
 	struct ieee80211_hdr *hdr;
-	bool more_frags;
 	u8 tid, frag_number;
 	u32 seq;
 
@@ -1805,7 +1804,6 @@ static bool ath10k_htt_rx_h_frag_pn_check(struct ath10k *ar,
 
 	last_pn = &peer->frag_tids_last_pn[tid];
 	new_pn.pn48 = ath10k_htt_rx_h_get_pn(ar, skb, offset, enctype);
-	more_frags = ieee80211_has_morefrags(hdr->frame_control);
 	frag_number = le16_to_cpu(hdr->seq_ctrl) & IEEE80211_SCTL_FRAG;
 	seq = (__le16_to_cpu(hdr->seq_ctrl) & IEEE80211_SCTL_SEQ) >> 4;
 
-- 
2.31.1.751.gd2f1c929bd-goog


WARNING: multiple messages have this Message-ID (diff)
From: Abhishek Kumar <kuabhs@chromium.org>
To: Johannes Berg <johannes.berg@intel.com>,
	Kalle Valo <kvalo@codeaurora.org>
Cc: briannorris@chromium.org, ath10k@lists.infradead.org,
	linux-wireless@vger.kernel.org,
	Jouni Malinen <jouni@codeaurora.org>,
	Wen Gong <wgong@codeaurora.org>,
	kuabhs@chromium.org, "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: [PATCH] ath10k: remove unused variable in ath10k_htt_rx_h_frag_pn_check
Date: Fri, 14 May 2021 22:07:42 +0000	[thread overview]
Message-ID: <20210514220644.1.Iad576de95836b74aba80a5fc28d7131940eca190@changeid> (raw)

The local variable more_frags in ath10k_htt_rx_h_frag_pn_check is not
used. This patch is to remove that.

Fixes: a1166b2653db ("ath10k: add CCMP PN replay protection for fragmented
frames for PCIe")
Signed-off-by: Abhishek Kumar <kuabhs@chromium.org>
---

 drivers/net/wireless/ath/ath10k/htt_rx.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c
index 7ffb5d5b2a70..adbaeb67eedf 100644
--- a/drivers/net/wireless/ath/ath10k/htt_rx.c
+++ b/drivers/net/wireless/ath/ath10k/htt_rx.c
@@ -1787,7 +1787,6 @@ static bool ath10k_htt_rx_h_frag_pn_check(struct ath10k *ar,
 	struct ath10k_peer *peer;
 	union htt_rx_pn_t *last_pn, new_pn = {0};
 	struct ieee80211_hdr *hdr;
-	bool more_frags;
 	u8 tid, frag_number;
 	u32 seq;
 
@@ -1805,7 +1804,6 @@ static bool ath10k_htt_rx_h_frag_pn_check(struct ath10k *ar,
 
 	last_pn = &peer->frag_tids_last_pn[tid];
 	new_pn.pn48 = ath10k_htt_rx_h_get_pn(ar, skb, offset, enctype);
-	more_frags = ieee80211_has_morefrags(hdr->frame_control);
 	frag_number = le16_to_cpu(hdr->seq_ctrl) & IEEE80211_SCTL_FRAG;
 	seq = (__le16_to_cpu(hdr->seq_ctrl) & IEEE80211_SCTL_SEQ) >> 4;
 
-- 
2.31.1.751.gd2f1c929bd-goog


_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

             reply	other threads:[~2021-05-14 22:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-14 22:07 Abhishek Kumar [this message]
2021-05-14 22:07 ` [PATCH] ath10k: remove unused variable in ath10k_htt_rx_h_frag_pn_check Abhishek Kumar
2021-06-24  6:13 ` Kalle Valo
2021-06-24  6:13 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210514220644.1.Iad576de95836b74aba80a5fc28d7131940eca190@changeid \
    --to=kuabhs@chromium.org \
    --cc=ath10k@lists.infradead.org \
    --cc=briannorris@chromium.org \
    --cc=davem@davemloft.net \
    --cc=johannes.berg@intel.com \
    --cc=jouni@codeaurora.org \
    --cc=kuba@kernel.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=wgong@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.