* [PATCH] ath10k: remove unused variable in ath10k_htt_rx_h_frag_pn_check
@ 2021-05-14 22:07 ` Abhishek Kumar
0 siblings, 0 replies; 4+ messages in thread
From: Abhishek Kumar @ 2021-05-14 22:07 UTC (permalink / raw)
To: Johannes Berg, Kalle Valo
Cc: briannorris, ath10k, linux-wireless, Jouni Malinen, Wen Gong,
kuabhs, David S. Miller, Jakub Kicinski, linux-kernel, netdev
The local variable more_frags in ath10k_htt_rx_h_frag_pn_check is not
used. This patch is to remove that.
Fixes: a1166b2653db ("ath10k: add CCMP PN replay protection for fragmented
frames for PCIe")
Signed-off-by: Abhishek Kumar <kuabhs@chromium.org>
---
drivers/net/wireless/ath/ath10k/htt_rx.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c
index 7ffb5d5b2a70..adbaeb67eedf 100644
--- a/drivers/net/wireless/ath/ath10k/htt_rx.c
+++ b/drivers/net/wireless/ath/ath10k/htt_rx.c
@@ -1787,7 +1787,6 @@ static bool ath10k_htt_rx_h_frag_pn_check(struct ath10k *ar,
struct ath10k_peer *peer;
union htt_rx_pn_t *last_pn, new_pn = {0};
struct ieee80211_hdr *hdr;
- bool more_frags;
u8 tid, frag_number;
u32 seq;
@@ -1805,7 +1804,6 @@ static bool ath10k_htt_rx_h_frag_pn_check(struct ath10k *ar,
last_pn = &peer->frag_tids_last_pn[tid];
new_pn.pn48 = ath10k_htt_rx_h_get_pn(ar, skb, offset, enctype);
- more_frags = ieee80211_has_morefrags(hdr->frame_control);
frag_number = le16_to_cpu(hdr->seq_ctrl) & IEEE80211_SCTL_FRAG;
seq = (__le16_to_cpu(hdr->seq_ctrl) & IEEE80211_SCTL_SEQ) >> 4;
--
2.31.1.751.gd2f1c929bd-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] ath10k: remove unused variable in ath10k_htt_rx_h_frag_pn_check
@ 2021-05-14 22:07 ` Abhishek Kumar
0 siblings, 0 replies; 4+ messages in thread
From: Abhishek Kumar @ 2021-05-14 22:07 UTC (permalink / raw)
To: Johannes Berg, Kalle Valo
Cc: briannorris, ath10k, linux-wireless, Jouni Malinen, Wen Gong,
kuabhs, David S. Miller, Jakub Kicinski, linux-kernel, netdev
The local variable more_frags in ath10k_htt_rx_h_frag_pn_check is not
used. This patch is to remove that.
Fixes: a1166b2653db ("ath10k: add CCMP PN replay protection for fragmented
frames for PCIe")
Signed-off-by: Abhishek Kumar <kuabhs@chromium.org>
---
drivers/net/wireless/ath/ath10k/htt_rx.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c
index 7ffb5d5b2a70..adbaeb67eedf 100644
--- a/drivers/net/wireless/ath/ath10k/htt_rx.c
+++ b/drivers/net/wireless/ath/ath10k/htt_rx.c
@@ -1787,7 +1787,6 @@ static bool ath10k_htt_rx_h_frag_pn_check(struct ath10k *ar,
struct ath10k_peer *peer;
union htt_rx_pn_t *last_pn, new_pn = {0};
struct ieee80211_hdr *hdr;
- bool more_frags;
u8 tid, frag_number;
u32 seq;
@@ -1805,7 +1804,6 @@ static bool ath10k_htt_rx_h_frag_pn_check(struct ath10k *ar,
last_pn = &peer->frag_tids_last_pn[tid];
new_pn.pn48 = ath10k_htt_rx_h_get_pn(ar, skb, offset, enctype);
- more_frags = ieee80211_has_morefrags(hdr->frame_control);
frag_number = le16_to_cpu(hdr->seq_ctrl) & IEEE80211_SCTL_FRAG;
seq = (__le16_to_cpu(hdr->seq_ctrl) & IEEE80211_SCTL_SEQ) >> 4;
--
2.31.1.751.gd2f1c929bd-goog
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ath10k: remove unused variable in ath10k_htt_rx_h_frag_pn_check
2021-05-14 22:07 ` Abhishek Kumar
(?)
@ 2021-06-24 6:13 ` Kalle Valo
-1 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2021-06-24 6:13 UTC (permalink / raw)
To: Abhishek Kumar
Cc: Johannes Berg, briannorris, ath10k, linux-wireless,
Jouni Malinen, Wen Gong, kuabhs, David S. Miller, Jakub Kicinski,
linux-kernel, netdev
Abhishek Kumar <kuabhs@chromium.org> wrote:
> The local variable more_frags in ath10k_htt_rx_h_frag_pn_check is not
> used. This patch is to remove that.
>
> Fixes: a1166b2653db ("ath10k: add CCMP PN replay protection for fragmented
> frames for PCIe")
> Signed-off-by: Abhishek Kumar <kuabhs@chromium.org>
Fixed already by another identical commit:
https://git.kernel.org/linus/e0a6120f6816
Patch set to Superseded.
--
https://patchwork.kernel.org/project/linux-wireless/patch/20210514220644.1.Iad576de95836b74aba80a5fc28d7131940eca190@changeid/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ath10k: remove unused variable in ath10k_htt_rx_h_frag_pn_check
2021-05-14 22:07 ` Abhishek Kumar
(?)
(?)
@ 2021-06-24 6:13 ` Kalle Valo
-1 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2021-06-24 6:13 UTC (permalink / raw)
To: Abhishek Kumar
Cc: Johannes Berg, briannorris, ath10k, linux-wireless,
Jouni Malinen, Wen Gong, kuabhs, David S. Miller, Jakub Kicinski,
linux-kernel, netdev
Abhishek Kumar <kuabhs@chromium.org> wrote:
> The local variable more_frags in ath10k_htt_rx_h_frag_pn_check is not
> used. This patch is to remove that.
>
> Fixes: a1166b2653db ("ath10k: add CCMP PN replay protection for fragmented
> frames for PCIe")
> Signed-off-by: Abhishek Kumar <kuabhs@chromium.org>
Fixed already by another identical commit:
https://git.kernel.org/linus/e0a6120f6816
Patch set to Superseded.
--
https://patchwork.kernel.org/project/linux-wireless/patch/20210514220644.1.Iad576de95836b74aba80a5fc28d7131940eca190@changeid/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-06-24 6:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-14 22:07 [PATCH] ath10k: remove unused variable in ath10k_htt_rx_h_frag_pn_check Abhishek Kumar
2021-05-14 22:07 ` Abhishek Kumar
2021-06-24 6:13 ` Kalle Valo
2021-06-24 6:13 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.