All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Alistair Francis" <alistair.francis@wdc.com>,
	qemu-riscv@nongnu.org, "Bin Meng" <bin.meng@windriver.com>,
	qemu-arm@nongnu.org, qemu-ppc@nongnu.org,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"David Gibson" <david@gibson.dropbear.id.au>
Subject: [PATCH v2 06/12] hw/riscv/Kconfig: Add missing dependency MICROCHIP_PFSOC -> SERIAL
Date: Sat, 15 May 2021 19:37:10 +0200	[thread overview]
Message-ID: <20210515173716.358295-7-philmd@redhat.com> (raw)
In-Reply-To: <20210515173716.358295-1-philmd@redhat.com>

Commit a8fb0a500a6 ("hw/char: Add Microchip PolarFire SoC MMUART
emulation") added a dependency on the SERIAL model, but forgot to
add the Kconfig selector.
Add the dependency to the MCHP_PFSOC_MMUART symbol to fix when
building the MICROCHIP_PFSOC machine stand-alone:

  /usr/bin/ld: libcommon.fa.p/hw_char_mchp_pfsoc_mmuart.c.o: in function `mchp_pfsoc_mmuart_create':
  hw/char/mchp_pfsoc_mmuart.c:79: undefined reference to `serial_mm_init'

Fixes: a8fb0a500a6 ("hw/char: Add Microchip PolarFire SoC MMUART emulation")
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
Cc: Bin Meng <bin.meng@windriver.com>
Cc: Alistair Francis <alistair.francis@wdc.com>
---
 hw/char/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/char/Kconfig b/hw/char/Kconfig
index 4cf36ac637b..2e4f620b13e 100644
--- a/hw/char/Kconfig
+++ b/hw/char/Kconfig
@@ -61,6 +61,7 @@ config AVR_USART
 
 config MCHP_PFSOC_MMUART
     bool
+    select SERIAL
 
 config SIFIVE_UART
     bool
-- 
2.26.3



WARNING: multiple messages have this Message-ID (diff)
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Bin Meng" <bin.meng@windriver.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	qemu-riscv@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org,
	"BALATON Zoltan" <balaton@eik.bme.hu>,
	"David Gibson" <david@gibson.dropbear.id.au>,
	"Alistair Francis" <alistair.francis@wdc.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [PATCH v2 06/12] hw/riscv/Kconfig: Add missing dependency MICROCHIP_PFSOC -> SERIAL
Date: Sat, 15 May 2021 19:37:10 +0200	[thread overview]
Message-ID: <20210515173716.358295-7-philmd@redhat.com> (raw)
In-Reply-To: <20210515173716.358295-1-philmd@redhat.com>

Commit a8fb0a500a6 ("hw/char: Add Microchip PolarFire SoC MMUART
emulation") added a dependency on the SERIAL model, but forgot to
add the Kconfig selector.
Add the dependency to the MCHP_PFSOC_MMUART symbol to fix when
building the MICROCHIP_PFSOC machine stand-alone:

  /usr/bin/ld: libcommon.fa.p/hw_char_mchp_pfsoc_mmuart.c.o: in function `mchp_pfsoc_mmuart_create':
  hw/char/mchp_pfsoc_mmuart.c:79: undefined reference to `serial_mm_init'

Fixes: a8fb0a500a6 ("hw/char: Add Microchip PolarFire SoC MMUART emulation")
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
Cc: Bin Meng <bin.meng@windriver.com>
Cc: Alistair Francis <alistair.francis@wdc.com>
---
 hw/char/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/char/Kconfig b/hw/char/Kconfig
index 4cf36ac637b..2e4f620b13e 100644
--- a/hw/char/Kconfig
+++ b/hw/char/Kconfig
@@ -61,6 +61,7 @@ config AVR_USART
 
 config MCHP_PFSOC_MMUART
     bool
+    select SERIAL
 
 config SIFIVE_UART
     bool
-- 
2.26.3



  parent reply	other threads:[~2021-05-15 17:45 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-15 17:37 [PATCH v2 00/12] hw: Various Kconfig fixes Philippe Mathieu-Daudé
2021-05-15 17:37 ` Philippe Mathieu-Daudé
2021-05-15 17:37 ` [PATCH v2 01/12] hw/mem/nvdimm: Use Kconfig 'imply' instead of 'depends on' Philippe Mathieu-Daudé
2021-05-15 17:37   ` Philippe Mathieu-Daudé
2021-05-17  2:33   ` Bin Meng
2021-05-17  2:33     ` Bin Meng
2021-05-15 17:37 ` [PATCH v2 02/12] hw/ide/Kconfig: Add missing dependency PCI -> IDE_QDEV Philippe Mathieu-Daudé
2021-05-15 17:37   ` Philippe Mathieu-Daudé
2021-05-18 19:09   ` John Snow
2021-05-18 19:09     ` John Snow
2021-05-15 17:37 ` [PATCH v2 03/12] hw/arm/Kconfig: Add missing dependency NPCM7XX -> SMBUS Philippe Mathieu-Daudé
2021-05-15 17:37   ` Philippe Mathieu-Daudé
2021-05-15 17:37 ` [PATCH v2 04/12] hw/arm/Kconfig: Remove unused DS1338 symbol from i.MX25 PDK Board Philippe Mathieu-Daudé
2021-05-15 17:37   ` Philippe Mathieu-Daudé
2021-05-15 17:37 ` [PATCH v2 05/12] hw/arm/Kconfig: Add missing SDHCI symbol to FSL_IMX25 Philippe Mathieu-Daudé
2021-05-15 17:37   ` Philippe Mathieu-Daudé
2021-05-15 17:37 ` Philippe Mathieu-Daudé [this message]
2021-05-15 17:37   ` [PATCH v2 06/12] hw/riscv/Kconfig: Add missing dependency MICROCHIP_PFSOC -> SERIAL Philippe Mathieu-Daudé
2021-05-16 22:45   ` Alistair Francis
2021-05-16 22:45     ` Alistair Francis
2021-05-17  1:55   ` Bin Meng
2021-05-17  1:55     ` Bin Meng
2021-05-15 17:37 ` [PATCH v2 07/12] hw/riscv/Kconfig: Restrict NUMA to Virt & Spike machines Philippe Mathieu-Daudé
2021-05-15 17:37   ` Philippe Mathieu-Daudé
2021-05-16 22:46   ` Alistair Francis
2021-05-16 22:46     ` Alistair Francis
2021-05-15 17:37 ` [PATCH v2 08/12] hw/ppc/Kconfig: Add missing dependency E500 -> DS1338 RTC Philippe Mathieu-Daudé
2021-05-15 17:37   ` Philippe Mathieu-Daudé
2021-05-15 17:37 ` [PATCH v2 09/12] hw/pci-host/Kconfig: Add missing dependency MV64361 -> I8259 Philippe Mathieu-Daudé
2021-05-15 17:37   ` Philippe Mathieu-Daudé
2021-05-15 19:46   ` BALATON Zoltan
2021-05-15 19:46     ` BALATON Zoltan
2021-05-17  2:49   ` Bin Meng
2021-05-17  2:49     ` Bin Meng
2021-05-17  5:10     ` Philippe Mathieu-Daudé
2021-05-17  5:10       ` Philippe Mathieu-Daudé
2021-05-17  3:13   ` David Gibson
2021-05-17  3:13     ` David Gibson
2021-05-15 17:37 ` [PATCH v2 10/12] hw/isa/vt82c686: Add missing Kconfig dependencies (build error) Philippe Mathieu-Daudé
2021-05-15 17:37   ` Philippe Mathieu-Daudé
2021-05-15 19:42   ` BALATON Zoltan
2021-05-15 19:42     ` BALATON Zoltan
2021-05-17  2:50   ` Bin Meng
2021-05-17  2:50     ` Bin Meng
2021-05-15 17:37 ` [PATCH v2 11/12] hw/isa/vt82c686: Add missing Kconfig dependency (runtime error) Philippe Mathieu-Daudé
2021-05-15 17:37   ` Philippe Mathieu-Daudé
2021-05-15 19:36   ` BALATON Zoltan
2021-05-15 19:36     ` BALATON Zoltan
2021-05-17  2:52   ` Bin Meng
2021-05-17  2:52     ` Bin Meng
2021-05-15 17:37 ` [PATCH v2 12/12] hw/ppc/Kconfig: Add dependency PEGASOS2 -> ATI_VGA Philippe Mathieu-Daudé
2021-05-15 17:37   ` Philippe Mathieu-Daudé
2021-05-15 19:41   ` BALATON Zoltan
2021-05-15 19:41     ` BALATON Zoltan
2021-05-15 19:58     ` Philippe Mathieu-Daudé
2021-05-15 19:58       ` Philippe Mathieu-Daudé
2021-05-17  2:54     ` Bin Meng
2021-05-17  2:54       ` Bin Meng
2021-05-17  3:14   ` David Gibson
2021-05-17  3:14     ` David Gibson
2021-05-17 19:18 ` [PATCH v2 00/12] hw: Various Kconfig fixes Eduardo Habkost
2021-05-17 19:18   ` Eduardo Habkost
2021-05-17 20:04   ` Eduardo Habkost
2021-05-17 20:04     ` Eduardo Habkost
2021-05-18 20:11     ` Philippe Mathieu-Daudé
2021-05-18 20:11       ` Philippe Mathieu-Daudé
2021-06-03 16:40       ` Alex Bennée
2021-06-03 16:40         ` Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210515173716.358295-7-philmd@redhat.com \
    --to=philmd@redhat.com \
    --cc=alistair.francis@wdc.com \
    --cc=bin.meng@windriver.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.