From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: BALATON Zoltan <balaton@eik.bme.hu>
Cc: "Alistair Francis" <alistair.francis@wdc.com>,
qemu-riscv@nongnu.org, "Bin Meng" <bin.meng@windriver.com>,
qemu-devel@nongnu.org, "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Greg Kurz" <groug@kaod.org>,
qemu-arm@nongnu.org, qemu-ppc@nongnu.org,
"Paolo Bonzini" <pbonzini@redhat.com>,
"David Gibson" <david@gibson.dropbear.id.au>
Subject: Re: [PATCH v2 12/12] hw/ppc/Kconfig: Add dependency PEGASOS2 -> ATI_VGA
Date: Sat, 15 May 2021 21:58:46 +0200 [thread overview]
Message-ID: <eae396ff-4223-a1c2-d90c-55059a9a86b1@amsat.org> (raw)
In-Reply-To: <e164f246-80a6-d65b-3dc-8b9cb16d0e8@eik.bme.hu>
On 5/15/21 9:41 PM, BALATON Zoltan wrote:
> On Sat, 15 May 2021, Philippe Mathieu-Daudé wrote:
>> From: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>
>> While the ATI VGA device isn't a requisite (no crash without it):
>>
>> $ qemu-system-ppc -M pegasos2
>> qemu-system-ppc: standard VGA not available
>>
>> it is useful to have it with the Pegasos2 machine:
>>
>> $ qemu-system-ppc -M pegasos2 -vga none -bios pegasos2.rom -device
>> ati-vga,romfile=
>> qemu-system-ppc: -device ati-vga,romfile=: 'ati-vga' is not a valid
>> device model name
>>
>> Add it as an implicit Kconfig dependency.
>>
>> Fixes: ba7e5ac18e7 ("hw/ppc: Add emulation of Genesi/bPlan Pegasos II")
>
> You can list it as a fix but I regard this more an enhancement or
> amandment to that commit as it was not broken in this regard as the
> commit message above also explains. To me Fixes tag means more that
> something was broken in that commit that this one patches up but I don't
> care much about this tag. It would probably make more sense in your
> other commits fixing missing dependencies (although not clear which
> commit those fix as the missing dependencies were probably also missing
> before the latest clean ups).
OK, I'll reword.
Thanks for reviewing this series!
>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
> Acked-by: BALATON Zoltan <balaton@eik.bme.hu>
WARNING: multiple messages have this Message-ID (diff)
From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: BALATON Zoltan <balaton@eik.bme.hu>
Cc: qemu-devel@nongnu.org, "Bin Meng" <bin.meng@windriver.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
qemu-riscv@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org,
"David Gibson" <david@gibson.dropbear.id.au>,
"Alistair Francis" <alistair.francis@wdc.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Greg Kurz" <groug@kaod.org>
Subject: Re: [PATCH v2 12/12] hw/ppc/Kconfig: Add dependency PEGASOS2 -> ATI_VGA
Date: Sat, 15 May 2021 21:58:46 +0200 [thread overview]
Message-ID: <eae396ff-4223-a1c2-d90c-55059a9a86b1@amsat.org> (raw)
In-Reply-To: <e164f246-80a6-d65b-3dc-8b9cb16d0e8@eik.bme.hu>
On 5/15/21 9:41 PM, BALATON Zoltan wrote:
> On Sat, 15 May 2021, Philippe Mathieu-Daudé wrote:
>> From: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>
>> While the ATI VGA device isn't a requisite (no crash without it):
>>
>> $ qemu-system-ppc -M pegasos2
>> qemu-system-ppc: standard VGA not available
>>
>> it is useful to have it with the Pegasos2 machine:
>>
>> $ qemu-system-ppc -M pegasos2 -vga none -bios pegasos2.rom -device
>> ati-vga,romfile=
>> qemu-system-ppc: -device ati-vga,romfile=: 'ati-vga' is not a valid
>> device model name
>>
>> Add it as an implicit Kconfig dependency.
>>
>> Fixes: ba7e5ac18e7 ("hw/ppc: Add emulation of Genesi/bPlan Pegasos II")
>
> You can list it as a fix but I regard this more an enhancement or
> amandment to that commit as it was not broken in this regard as the
> commit message above also explains. To me Fixes tag means more that
> something was broken in that commit that this one patches up but I don't
> care much about this tag. It would probably make more sense in your
> other commits fixing missing dependencies (although not clear which
> commit those fix as the missing dependencies were probably also missing
> before the latest clean ups).
OK, I'll reword.
Thanks for reviewing this series!
>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
> Acked-by: BALATON Zoltan <balaton@eik.bme.hu>
next prev parent reply other threads:[~2021-05-15 20:00 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-15 17:37 [PATCH v2 00/12] hw: Various Kconfig fixes Philippe Mathieu-Daudé
2021-05-15 17:37 ` Philippe Mathieu-Daudé
2021-05-15 17:37 ` [PATCH v2 01/12] hw/mem/nvdimm: Use Kconfig 'imply' instead of 'depends on' Philippe Mathieu-Daudé
2021-05-15 17:37 ` Philippe Mathieu-Daudé
2021-05-17 2:33 ` Bin Meng
2021-05-17 2:33 ` Bin Meng
2021-05-15 17:37 ` [PATCH v2 02/12] hw/ide/Kconfig: Add missing dependency PCI -> IDE_QDEV Philippe Mathieu-Daudé
2021-05-15 17:37 ` Philippe Mathieu-Daudé
2021-05-18 19:09 ` John Snow
2021-05-18 19:09 ` John Snow
2021-05-15 17:37 ` [PATCH v2 03/12] hw/arm/Kconfig: Add missing dependency NPCM7XX -> SMBUS Philippe Mathieu-Daudé
2021-05-15 17:37 ` Philippe Mathieu-Daudé
2021-05-15 17:37 ` [PATCH v2 04/12] hw/arm/Kconfig: Remove unused DS1338 symbol from i.MX25 PDK Board Philippe Mathieu-Daudé
2021-05-15 17:37 ` Philippe Mathieu-Daudé
2021-05-15 17:37 ` [PATCH v2 05/12] hw/arm/Kconfig: Add missing SDHCI symbol to FSL_IMX25 Philippe Mathieu-Daudé
2021-05-15 17:37 ` Philippe Mathieu-Daudé
2021-05-15 17:37 ` [PATCH v2 06/12] hw/riscv/Kconfig: Add missing dependency MICROCHIP_PFSOC -> SERIAL Philippe Mathieu-Daudé
2021-05-15 17:37 ` Philippe Mathieu-Daudé
2021-05-16 22:45 ` Alistair Francis
2021-05-16 22:45 ` Alistair Francis
2021-05-17 1:55 ` Bin Meng
2021-05-17 1:55 ` Bin Meng
2021-05-15 17:37 ` [PATCH v2 07/12] hw/riscv/Kconfig: Restrict NUMA to Virt & Spike machines Philippe Mathieu-Daudé
2021-05-15 17:37 ` Philippe Mathieu-Daudé
2021-05-16 22:46 ` Alistair Francis
2021-05-16 22:46 ` Alistair Francis
2021-05-15 17:37 ` [PATCH v2 08/12] hw/ppc/Kconfig: Add missing dependency E500 -> DS1338 RTC Philippe Mathieu-Daudé
2021-05-15 17:37 ` Philippe Mathieu-Daudé
2021-05-15 17:37 ` [PATCH v2 09/12] hw/pci-host/Kconfig: Add missing dependency MV64361 -> I8259 Philippe Mathieu-Daudé
2021-05-15 17:37 ` Philippe Mathieu-Daudé
2021-05-15 19:46 ` BALATON Zoltan
2021-05-15 19:46 ` BALATON Zoltan
2021-05-17 2:49 ` Bin Meng
2021-05-17 2:49 ` Bin Meng
2021-05-17 5:10 ` Philippe Mathieu-Daudé
2021-05-17 5:10 ` Philippe Mathieu-Daudé
2021-05-17 3:13 ` David Gibson
2021-05-17 3:13 ` David Gibson
2021-05-15 17:37 ` [PATCH v2 10/12] hw/isa/vt82c686: Add missing Kconfig dependencies (build error) Philippe Mathieu-Daudé
2021-05-15 17:37 ` Philippe Mathieu-Daudé
2021-05-15 19:42 ` BALATON Zoltan
2021-05-15 19:42 ` BALATON Zoltan
2021-05-17 2:50 ` Bin Meng
2021-05-17 2:50 ` Bin Meng
2021-05-15 17:37 ` [PATCH v2 11/12] hw/isa/vt82c686: Add missing Kconfig dependency (runtime error) Philippe Mathieu-Daudé
2021-05-15 17:37 ` Philippe Mathieu-Daudé
2021-05-15 19:36 ` BALATON Zoltan
2021-05-15 19:36 ` BALATON Zoltan
2021-05-17 2:52 ` Bin Meng
2021-05-17 2:52 ` Bin Meng
2021-05-15 17:37 ` [PATCH v2 12/12] hw/ppc/Kconfig: Add dependency PEGASOS2 -> ATI_VGA Philippe Mathieu-Daudé
2021-05-15 17:37 ` Philippe Mathieu-Daudé
2021-05-15 19:41 ` BALATON Zoltan
2021-05-15 19:41 ` BALATON Zoltan
2021-05-15 19:58 ` Philippe Mathieu-Daudé [this message]
2021-05-15 19:58 ` Philippe Mathieu-Daudé
2021-05-17 2:54 ` Bin Meng
2021-05-17 2:54 ` Bin Meng
2021-05-17 3:14 ` David Gibson
2021-05-17 3:14 ` David Gibson
2021-05-17 19:18 ` [PATCH v2 00/12] hw: Various Kconfig fixes Eduardo Habkost
2021-05-17 19:18 ` Eduardo Habkost
2021-05-17 20:04 ` Eduardo Habkost
2021-05-17 20:04 ` Eduardo Habkost
2021-05-18 20:11 ` Philippe Mathieu-Daudé
2021-05-18 20:11 ` Philippe Mathieu-Daudé
2021-06-03 16:40 ` Alex Bennée
2021-06-03 16:40 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eae396ff-4223-a1c2-d90c-55059a9a86b1@amsat.org \
--to=f4bug@amsat.org \
--cc=alistair.francis@wdc.com \
--cc=balaton@eik.bme.hu \
--cc=bin.meng@windriver.com \
--cc=david@gibson.dropbear.id.au \
--cc=groug@kaod.org \
--cc=pbonzini@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.