All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: Andre Przywara <andre.przywara@arm.com>
Cc: Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Rob Herring <robh@kernel.org>, Icenowy Zheng <icenowy@aosc.io>,
	Samuel Holland <samuel@sholland.org>,
	Ondrej Jirman <megous@megous.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-sunxi@googlegroups.com, linux-sunxi@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 02/17] mfd: axp20x: Allow AXP 806 chips without interrupt lines
Date: Wed, 19 May 2021 16:01:38 +0100	[thread overview]
Message-ID: <20210519150138.GK2549456@dell> (raw)
In-Reply-To: <20210519104152.21119-3-andre.przywara@arm.com>

On Wed, 19 May 2021, Andre Przywara wrote:

> Currently the AXP chip requires to have its IRQ line connected to some
> interrupt controller, and will fail probing when this is not the case.
> 
> On a new Allwinner SoC (H616) there is no NMI pin anymore, and at
> least one board does not connect the AXP's IRQ pin to anything else,
> so the interrupt functionality of the AXP chip is simply not available.
> 
> Check whether the interrupt line number returned by the platform code is
> valid, before trying to register the irqchip. If not, we skip this
> registration, to avoid the driver to bail out completely.
> Also we need to skip the power key functionality, as this relies on
> a valid IRQ as well.
> 
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> ---
>  drivers/mfd/axp20x.c | 24 +++++++++++++++++-------
>  1 file changed, 17 insertions(+), 7 deletions(-)

Applied, thanks.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Andre Przywara <andre.przywara@arm.com>
Cc: Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Rob Herring <robh@kernel.org>, Icenowy Zheng <icenowy@aosc.io>,
	Samuel Holland <samuel@sholland.org>,
	Ondrej Jirman <megous@megous.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-sunxi@googlegroups.com, linux-sunxi@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 02/17] mfd: axp20x: Allow AXP 806 chips without interrupt lines
Date: Wed, 19 May 2021 16:01:38 +0100	[thread overview]
Message-ID: <20210519150138.GK2549456@dell> (raw)
In-Reply-To: <20210519104152.21119-3-andre.przywara@arm.com>

On Wed, 19 May 2021, Andre Przywara wrote:

> Currently the AXP chip requires to have its IRQ line connected to some
> interrupt controller, and will fail probing when this is not the case.
> 
> On a new Allwinner SoC (H616) there is no NMI pin anymore, and at
> least one board does not connect the AXP's IRQ pin to anything else,
> so the interrupt functionality of the AXP chip is simply not available.
> 
> Check whether the interrupt line number returned by the platform code is
> valid, before trying to register the irqchip. If not, we skip this
> registration, to avoid the driver to bail out completely.
> Also we need to skip the power key functionality, as this relies on
> a valid IRQ as well.
> 
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> ---
>  drivers/mfd/axp20x.c | 24 +++++++++++++++++-------
>  1 file changed, 17 insertions(+), 7 deletions(-)

Applied, thanks.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-05-19 15:01 UTC|newest]

Thread overview: 104+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-19 10:41 [PATCH v6 00/17] arm64: sunxi: Initial Allwinner H616 SoC support Andre Przywara
2021-05-19 10:41 ` Andre Przywara
2021-05-19 10:41 ` [PATCH v6 01/17] dt-bindings: mfd: axp20x: Add AXP305 compatible (plus optional IRQ) Andre Przywara
2021-05-19 10:41   ` Andre Przywara
2021-05-21  1:39   ` Rob Herring
2021-05-21  1:39     ` Rob Herring
2021-05-22 14:46   ` Samuel Holland
2021-05-22 14:46     ` Samuel Holland
2021-05-23  0:01     ` Andre Przywara
2021-05-23  0:01       ` Andre Przywara
2021-05-19 10:41 ` [PATCH v6 02/17] mfd: axp20x: Allow AXP 806 chips without interrupt lines Andre Przywara
2021-05-19 10:41   ` Andre Przywara
2021-05-19 15:01   ` Lee Jones [this message]
2021-05-19 15:01     ` Lee Jones
2021-05-19 10:41 ` [PATCH v6 03/17] dt-bindings: rtc: sun6i: Add H616 compatible string Andre Przywara
2021-05-19 10:41   ` Andre Przywara
2021-05-21  1:39   ` Rob Herring
2021-05-21  1:39     ` Rob Herring
2021-05-21  2:37   ` Samuel Holland
2021-05-21  2:37     ` Samuel Holland
2021-06-07 12:59     ` Andre Przywara
2021-06-07 12:59       ` Andre Przywara
2021-06-08  4:23       ` Samuel Holland
2021-06-08  4:23         ` Samuel Holland
2021-06-15 12:24         ` Andre Przywara
2021-06-15 12:24           ` Andre Przywara
2021-06-16  9:07           ` Maxime Ripard
2021-06-16  9:07             ` Maxime Ripard
2021-06-16 11:28             ` Andre Przywara
2021-06-16 11:28               ` Andre Przywara
2021-05-19 10:41 ` [PATCH v6 04/17] rtc: sun6i: Add support for linear day storage Andre Przywara
2021-05-19 10:41   ` Andre Przywara
2021-05-22  7:26   ` Jernej Škrabec
2021-05-22  7:26     ` Jernej Škrabec
2021-05-19 10:41 ` [PATCH v6 05/17] rtc: sun6i: Add Allwinner H616 support Andre Przywara
2021-05-19 10:41   ` Andre Przywara
2021-05-22  7:29   ` Jernej Škrabec
2021-05-22  7:29     ` Jernej Škrabec
2021-05-23  0:06     ` Andre Przywara
2021-05-23  0:06       ` Andre Przywara
2021-05-19 10:41 ` [PATCH v6 06/17] dt-bindings: net: sun8i-emac: Add H616 compatible string Andre Przywara
2021-05-19 10:41   ` Andre Przywara
2021-05-21  1:40   ` Rob Herring
2021-05-21  1:40     ` Rob Herring
2021-05-19 10:41 ` [PATCH v6 07/17] net: stmmac: dwmac-sun8i: Prepare for second EMAC clock register Andre Przywara
2021-05-19 10:41   ` Andre Przywara
2021-05-19 10:41 ` [PATCH v6 08/17] dt-bindings: usb: Add H616 compatible string Andre Przywara
2021-05-19 10:41   ` Andre Przywara
2021-05-19 10:41   ` Andre Przywara
2021-05-21  1:40   ` Rob Herring
2021-05-21  1:40     ` Rob Herring
2021-05-21  1:40     ` Rob Herring
2021-05-19 10:41 ` [PATCH v6 09/17] dt-bindings: usb: sunxi-musb: " Andre Przywara
2021-05-19 10:41   ` Andre Przywara
2021-05-21  1:40   ` Rob Herring
2021-05-21  1:40     ` Rob Herring
2021-05-19 10:41 ` [PATCH v6 10/17] phy: sun4i-usb: Rework HCI PHY (aka. "pmu_unk1") handling Andre Przywara
2021-05-19 10:41   ` Andre Przywara
2021-05-19 10:41   ` Andre Przywara
2021-05-19 10:41 ` [PATCH v6 11/17] phy: sun4i-usb: Allow reset line to be shared Andre Przywara
2021-05-19 10:41   ` Andre Przywara
2021-05-19 10:41   ` Andre Przywara
2021-05-19 10:41 ` [PATCH v6 12/17] phy: sun4i-usb: Introduce port2 SIDDQ quirk Andre Przywara
2021-05-19 10:41   ` Andre Przywara
2021-05-19 10:41   ` Andre Przywara
2021-05-24 11:59   ` Maxime Ripard
2021-05-24 11:59     ` Maxime Ripard
2021-05-24 11:59     ` Maxime Ripard
2021-05-24 12:51     ` Jernej Škrabec
2021-05-24 12:51       ` Jernej Škrabec
2021-05-24 12:51       ` Jernej Škrabec
2021-05-25 11:29     ` Andre Przywara
2021-05-25 11:29       ` Andre Przywara
2021-05-25 11:29       ` Andre Przywara
2021-06-07 13:22       ` Maxime Ripard
2021-06-07 13:22         ` Maxime Ripard
2021-06-07 13:22         ` Maxime Ripard
2021-06-07 14:17         ` Andre Przywara
2021-06-07 14:17           ` Andre Przywara
2021-06-07 14:17           ` Andre Przywara
2021-06-07 14:26           ` [linux-sunxi] " Chen-Yu Tsai
2021-06-07 14:26             ` Chen-Yu Tsai
2021-06-07 14:26             ` Chen-Yu Tsai
2021-06-07 14:26             ` Chen-Yu Tsai
2021-06-14  0:20             ` Andre Przywara
2021-06-14  0:20               ` Andre Przywara
2021-06-14  0:20               ` Andre Przywara
2021-05-19 10:41 ` [PATCH v6 13/17] phy: sun4i-usb: Add support for the H616 USB PHY Andre Przywara
2021-05-19 10:41   ` Andre Przywara
2021-05-19 10:41   ` Andre Przywara
2021-05-19 10:41 ` [PATCH v6 14/17] arm64: dts: allwinner: Add Allwinner H616 .dtsi file Andre Przywara
2021-05-19 10:41   ` Andre Przywara
2021-05-24 12:02   ` Maxime Ripard
2021-05-24 12:02     ` Maxime Ripard
2021-06-07 12:59     ` Andre Przywara
2021-06-07 12:59       ` Andre Przywara
2021-05-19 10:41 ` [PATCH v6 15/17] dt-bindings: arm: sunxi: Add OrangePi Zero 2 binding Andre Przywara
2021-05-19 10:41   ` Andre Przywara
2021-05-19 10:41 ` [PATCH v6 16/17] arm64: dts: allwinner: h616: Add OrangePi Zero 2 board support Andre Przywara
2021-05-19 10:41   ` Andre Przywara
2021-05-19 10:41 ` [PATCH v6 17/17] arm64: dts: allwinner: h616: Add X96 Mate TV box support Andre Przywara
2021-05-19 10:41   ` Andre Przywara
2021-05-22  7:32   ` Jernej Škrabec
2021-05-22  7:32     ` Jernej Škrabec

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210519150138.GK2549456@dell \
    --to=lee.jones@linaro.org \
    --cc=andre.przywara@arm.com \
    --cc=icenowy@aosc.io \
    --cc=jernej.skrabec@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=megous@megous.com \
    --cc=mripard@kernel.org \
    --cc=robh@kernel.org \
    --cc=samuel@sholland.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.