All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Morse <james.morse@arm.com>
To: x86@kernel.org, linux-kernel@vger.kernel.org
Cc: Fenghua Yu <fenghua.yu@intel.com>,
	Reinette Chatre <reinette.chatre@intel.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	H Peter Anvin <hpa@zytor.com>, Babu Moger <Babu.Moger@amd.com>,
	James Morse <james.morse@arm.com>,
	shameerali.kolothum.thodi@huawei.com,
	Jamie Iles <jamie@nuviainc.com>,
	D Scott Phillips OS <scott@os.amperecomputing.com>
Subject: [PATCH v3 10/24] x86/resctrl: Swizzle rdt_resource and resctrl_schema in pseudo_lock_region
Date: Wed, 19 May 2021 16:24:10 +0000	[thread overview]
Message-ID: <20210519162424.27654-11-james.morse@arm.com> (raw)
In-Reply-To: <20210519162424.27654-1-james.morse@arm.com>

struct pseudo_lock_region points to the rdt_resource.

Once the resources are merged, this won't be unique. The resource name
is moving into the schema, so that the filesystem portions of resctrl can
generate it.

Swap pseudo_lock_region's rdt_resource pointer for a schema pointer.

Reviewed-by: Jamie Iles <jamie@nuviainc.com>
Signed-off-by: James Morse <james.morse@arm.com>
---
Changes since v2:
 * Shuffled commit message,
---
 arch/x86/kernel/cpu/resctrl/ctrlmondata.c | 4 ++--
 arch/x86/kernel/cpu/resctrl/internal.h    | 6 +++---
 arch/x86/kernel/cpu/resctrl/pseudo_lock.c | 8 ++++----
 arch/x86/kernel/cpu/resctrl/rdtgroup.c    | 4 ++--
 4 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/arch/x86/kernel/cpu/resctrl/ctrlmondata.c b/arch/x86/kernel/cpu/resctrl/ctrlmondata.c
index dbbdd9f275e9..4428ec499037 100644
--- a/arch/x86/kernel/cpu/resctrl/ctrlmondata.c
+++ b/arch/x86/kernel/cpu/resctrl/ctrlmondata.c
@@ -227,7 +227,7 @@ static int parse_line(char *line, struct resctrl_schema *s,
 				 * the required initialization for single
 				 * region and return.
 				 */
-				rdtgrp->plr->r = r;
+				rdtgrp->plr->s = s;
 				rdtgrp->plr->d = d;
 				rdtgrp->plr->cbm = d->new_ctrl;
 				d->plr = rdtgrp->plr;
@@ -426,7 +426,7 @@ int rdtgroup_schemata_show(struct kernfs_open_file *of,
 				ret = -ENODEV;
 			} else {
 				seq_printf(s, "%s:%d=%x\n",
-					   rdtgrp->plr->r->name,
+					   rdtgrp->plr->s->res->name,
 					   rdtgrp->plr->d->id,
 					   rdtgrp->plr->cbm);
 			}
diff --git a/arch/x86/kernel/cpu/resctrl/internal.h b/arch/x86/kernel/cpu/resctrl/internal.h
index 34e90bfca2d9..a733d1d02f3f 100644
--- a/arch/x86/kernel/cpu/resctrl/internal.h
+++ b/arch/x86/kernel/cpu/resctrl/internal.h
@@ -158,8 +158,8 @@ struct mongroup {
 
 /**
  * struct pseudo_lock_region - pseudo-lock region information
- * @r:			RDT resource to which this pseudo-locked region
- *			belongs
+ * @s:			Resctrl schema for the resource to which this
+ *			pseudo-locked region belongs
  * @d:			RDT domain to which this pseudo-locked region
  *			belongs
  * @cbm:		bitmask of the pseudo-locked region
@@ -179,7 +179,7 @@ struct mongroup {
  * @pm_reqs:		Power management QoS requests related to this region
  */
 struct pseudo_lock_region {
-	struct rdt_resource	*r;
+	struct resctrl_schema	*s;
 	struct rdt_domain	*d;
 	u32			cbm;
 	wait_queue_head_t	lock_thread_wq;
diff --git a/arch/x86/kernel/cpu/resctrl/pseudo_lock.c b/arch/x86/kernel/cpu/resctrl/pseudo_lock.c
index f079561409ab..2f99210a9d69 100644
--- a/arch/x86/kernel/cpu/resctrl/pseudo_lock.c
+++ b/arch/x86/kernel/cpu/resctrl/pseudo_lock.c
@@ -246,7 +246,7 @@ static void pseudo_lock_region_clear(struct pseudo_lock_region *plr)
 	plr->line_size = 0;
 	kfree(plr->kmem);
 	plr->kmem = NULL;
-	plr->r = NULL;
+	plr->s = NULL;
 	if (plr->d)
 		plr->d->plr = NULL;
 	plr->d = NULL;
@@ -290,10 +290,10 @@ static int pseudo_lock_region_init(struct pseudo_lock_region *plr)
 
 	ci = get_cpu_cacheinfo(plr->cpu);
 
-	plr->size = rdtgroup_cbm_to_size(plr->r, plr->d, plr->cbm);
+	plr->size = rdtgroup_cbm_to_size(plr->s->res, plr->d, plr->cbm);
 
 	for (i = 0; i < ci->num_leaves; i++) {
-		if (ci->info_list[i].level == plr->r->cache_level) {
+		if (ci->info_list[i].level == plr->s->res->cache_level) {
 			plr->line_size = ci->info_list[i].coherency_line_size;
 			return 0;
 		}
@@ -796,7 +796,7 @@ bool rdtgroup_cbm_overlaps_pseudo_locked(struct rdt_domain *d, unsigned long cbm
 	unsigned long cbm_b;
 
 	if (d->plr) {
-		cbm_len = d->plr->r->cache.cbm_len;
+		cbm_len = d->plr->s->res->cache.cbm_len;
 		cbm_b = d->plr->cbm;
 		if (bitmap_intersects(&cbm, &cbm_b, cbm_len))
 			return true;
diff --git a/arch/x86/kernel/cpu/resctrl/rdtgroup.c b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
index 301a8acfaaf3..eaad9c8e6c04 100644
--- a/arch/x86/kernel/cpu/resctrl/rdtgroup.c
+++ b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
@@ -1439,8 +1439,8 @@ static int rdtgroup_size_show(struct kernfs_open_file *of,
 			ret = -ENODEV;
 		} else {
 			seq_printf(s, "%*s:", max_name_width,
-				   rdtgrp->plr->r->name);
-			size = rdtgroup_cbm_to_size(rdtgrp->plr->r,
+				   rdtgrp->plr->s->res->name);
+			size = rdtgroup_cbm_to_size(rdtgrp->plr->s->res,
 						    rdtgrp->plr->d,
 						    rdtgrp->plr->cbm);
 			seq_printf(s, "%d=%u\n", rdtgrp->plr->d->id, size);
-- 
2.30.2


  parent reply	other threads:[~2021-05-19 16:26 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-19 16:24 [PATCH v3 00/24] x86/resctrl: Merge the CDP resources James Morse
2021-05-19 16:24 ` [PATCH v3 01/24] x86/resctrl: Split struct rdt_resource James Morse
2021-05-19 16:24 ` [PATCH v3 02/24] x86/resctrl: Split struct rdt_domain James Morse
2021-05-19 16:24 ` [PATCH v3 03/24] x86/resctrl: Add a separate schema list for resctrl James Morse
2021-05-19 16:24 ` [PATCH v3 04/24] x86/resctrl: Pass the schema in info dir's private pointer James Morse
2021-05-19 16:24 ` [PATCH v3 05/24] x86/resctrl: Label the resources with their configuration type James Morse
2021-05-19 16:24 ` [PATCH v3 06/24] x86/resctrl: Walk the resctrl schema list instead of an arch list James Morse
2021-05-19 16:24 ` [PATCH v3 07/24] x86/resctrl: Store the effective num_closid in the schema James Morse
2021-05-19 16:24 ` [PATCH v3 08/24] x86/resctrl: Add resctrl_arch_get_num_closid() James Morse
2021-05-19 16:24 ` [PATCH v3 09/24] x86/resctrl: Pass the schema to resctrl filesystem functions James Morse
2021-05-19 16:24 ` James Morse [this message]
2021-05-19 16:24 ` [PATCH v3 11/24] x86/resctrl: Move the schemata names into struct resctrl_schema James Morse
2021-05-19 16:24 ` [PATCH v3 12/24] x86/resctrl: Group staged configuration into a separate struct James Morse
2021-05-19 16:24 ` [PATCH v3 13/24] x86/resctrl: Allow different CODE/DATA configurations to be staged James Morse
2021-05-19 16:24 ` [PATCH v3 14/24] x86/resctrl: Rename update_domains() resctrl_arch_update_domains() James Morse
2021-05-19 16:24 ` [PATCH v3 15/24] x86/resctrl: Add a helper to read a closid's configuration James Morse
2021-05-19 16:24 ` [PATCH v3 16/24] x86/resctrl: Add a helper to read/set the CDP configuration James Morse
2021-05-19 16:24 ` [PATCH v3 17/24] x86/resctrl: Pass configuration type to resctrl_arch_get_config() James Morse
2021-05-19 16:24 ` [PATCH v3 18/24] x86/resctrl: Make ctrlval arrays the same size James Morse
2021-05-19 16:24 ` [PATCH v3 19/24] x86/resctrl: Apply offset correction when config is staged James Morse
2021-05-19 16:24 ` [PATCH v3 20/24] x86/resctrl: Calculate the index from the configuration type James Morse
2021-05-19 16:24 ` [PATCH v3 21/24] x86/resctrl: Merge the ctrl_val arrays James Morse
2021-05-19 16:24 ` [PATCH v3 22/24] x86/resctrl: Remove rdt_cdp_peer_get() James Morse
2021-05-19 16:24 ` [PATCH v3 23/24] x86/resctrl: Expand resctrl_arch_update_domains()'s msr_param range James Morse
2021-05-19 16:24 ` [PATCH v3 24/24] x86/resctrl: Merge the CDP resources James Morse
2021-06-04 23:56 ` [PATCH v3 00/24] " Reinette Chatre
2021-06-11 18:04   ` James Morse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210519162424.27654-11-james.morse@arm.com \
    --to=james.morse@arm.com \
    --cc=Babu.Moger@amd.com \
    --cc=bp@alien8.de \
    --cc=fenghua.yu@intel.com \
    --cc=hpa@zytor.com \
    --cc=jamie@nuviainc.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=reinette.chatre@intel.com \
    --cc=scott@os.amperecomputing.com \
    --cc=shameerali.kolothum.thodi@huawei.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.