All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Morse <james.morse@arm.com>
To: x86@kernel.org, linux-kernel@vger.kernel.org
Cc: Fenghua Yu <fenghua.yu@intel.com>,
	Reinette Chatre <reinette.chatre@intel.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	H Peter Anvin <hpa@zytor.com>, Babu Moger <Babu.Moger@amd.com>,
	James Morse <james.morse@arm.com>,
	shameerali.kolothum.thodi@huawei.com,
	Jamie Iles <jamie@nuviainc.com>,
	D Scott Phillips OS <scott@os.amperecomputing.com>
Subject: [PATCH v3 23/24] x86/resctrl: Expand resctrl_arch_update_domains()'s msr_param range
Date: Wed, 19 May 2021 16:24:23 +0000	[thread overview]
Message-ID: <20210519162424.27654-24-james.morse@arm.com> (raw)
In-Reply-To: <20210519162424.27654-1-james.morse@arm.com>

resctrl_arch_update_domains() specifies the one closid that has
been modified and needs copying to the hardware.
resctrl_arch_update_domains() takes a struct rdt_resource and a
closid as arguments, but copies all the staged configurations
for that closid into the ctrl_val[] array.

resctrl_arch_update_domains() is called once per schema, but
once the resources and domains are merged, the second call of
a L2CODE/L2DATA pair will find no staged configurations, as
they were previously applied. The msr_param of the first call
only has one index, so would only have update the hardware
for the last staged configuration.

To avoid a second round of IPIs when changing L2CODE and L2DATA
in one go, expand the range of the msr_param if multiple staged
configurations are found.

Signed-off-by: James Morse <james.morse@arm.com>
---
Changes since v2:
 * This patch is new.
---
 arch/x86/kernel/cpu/resctrl/ctrlmondata.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/arch/x86/kernel/cpu/resctrl/ctrlmondata.c b/arch/x86/kernel/cpu/resctrl/ctrlmondata.c
index e384398374da..0a1b878ca0db 100644
--- a/arch/x86/kernel/cpu/resctrl/ctrlmondata.c
+++ b/arch/x86/kernel/cpu/resctrl/ctrlmondata.c
@@ -292,6 +292,7 @@ int resctrl_arch_update_domains(struct rdt_resource *r, u32 closid)
 		return -ENOMEM;
 
 	mba_sc = is_mba_sc(r);
+	msr_param.res = NULL;
 	list_for_each_entry(d, &r->domains, list) {
 		hw_dom = resctrl_to_arch_dom(d);
 		for (t = 0; t < CDP_NUM_TYPES; t++) {
@@ -303,9 +304,14 @@ int resctrl_arch_update_domains(struct rdt_resource *r, u32 closid)
 			if (!apply_config(hw_dom, cfg, idx, cpu_mask, mba_sc))
 				continue;
 
-			msr_param.low = idx;
-			msr_param.high = msr_param.low + 1;
-			msr_param.res = r;
+			if (!msr_param.res) {
+				msr_param.low = idx;
+				msr_param.high = msr_param.low + 1;
+				msr_param.res = r;
+			} else {
+				msr_param.low = min(msr_param.low, idx);
+				msr_param.high = max(msr_param.high, idx + 1);
+			}
 		}
 	}
 
-- 
2.30.2


  parent reply	other threads:[~2021-05-19 16:26 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-19 16:24 [PATCH v3 00/24] x86/resctrl: Merge the CDP resources James Morse
2021-05-19 16:24 ` [PATCH v3 01/24] x86/resctrl: Split struct rdt_resource James Morse
2021-05-19 16:24 ` [PATCH v3 02/24] x86/resctrl: Split struct rdt_domain James Morse
2021-05-19 16:24 ` [PATCH v3 03/24] x86/resctrl: Add a separate schema list for resctrl James Morse
2021-05-19 16:24 ` [PATCH v3 04/24] x86/resctrl: Pass the schema in info dir's private pointer James Morse
2021-05-19 16:24 ` [PATCH v3 05/24] x86/resctrl: Label the resources with their configuration type James Morse
2021-05-19 16:24 ` [PATCH v3 06/24] x86/resctrl: Walk the resctrl schema list instead of an arch list James Morse
2021-05-19 16:24 ` [PATCH v3 07/24] x86/resctrl: Store the effective num_closid in the schema James Morse
2021-05-19 16:24 ` [PATCH v3 08/24] x86/resctrl: Add resctrl_arch_get_num_closid() James Morse
2021-05-19 16:24 ` [PATCH v3 09/24] x86/resctrl: Pass the schema to resctrl filesystem functions James Morse
2021-05-19 16:24 ` [PATCH v3 10/24] x86/resctrl: Swizzle rdt_resource and resctrl_schema in pseudo_lock_region James Morse
2021-05-19 16:24 ` [PATCH v3 11/24] x86/resctrl: Move the schemata names into struct resctrl_schema James Morse
2021-05-19 16:24 ` [PATCH v3 12/24] x86/resctrl: Group staged configuration into a separate struct James Morse
2021-05-19 16:24 ` [PATCH v3 13/24] x86/resctrl: Allow different CODE/DATA configurations to be staged James Morse
2021-05-19 16:24 ` [PATCH v3 14/24] x86/resctrl: Rename update_domains() resctrl_arch_update_domains() James Morse
2021-05-19 16:24 ` [PATCH v3 15/24] x86/resctrl: Add a helper to read a closid's configuration James Morse
2021-05-19 16:24 ` [PATCH v3 16/24] x86/resctrl: Add a helper to read/set the CDP configuration James Morse
2021-05-19 16:24 ` [PATCH v3 17/24] x86/resctrl: Pass configuration type to resctrl_arch_get_config() James Morse
2021-05-19 16:24 ` [PATCH v3 18/24] x86/resctrl: Make ctrlval arrays the same size James Morse
2021-05-19 16:24 ` [PATCH v3 19/24] x86/resctrl: Apply offset correction when config is staged James Morse
2021-05-19 16:24 ` [PATCH v3 20/24] x86/resctrl: Calculate the index from the configuration type James Morse
2021-05-19 16:24 ` [PATCH v3 21/24] x86/resctrl: Merge the ctrl_val arrays James Morse
2021-05-19 16:24 ` [PATCH v3 22/24] x86/resctrl: Remove rdt_cdp_peer_get() James Morse
2021-05-19 16:24 ` James Morse [this message]
2021-05-19 16:24 ` [PATCH v3 24/24] x86/resctrl: Merge the CDP resources James Morse
2021-06-04 23:56 ` [PATCH v3 00/24] " Reinette Chatre
2021-06-11 18:04   ` James Morse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210519162424.27654-24-james.morse@arm.com \
    --to=james.morse@arm.com \
    --cc=Babu.Moger@amd.com \
    --cc=bp@alien8.de \
    --cc=fenghua.yu@intel.com \
    --cc=hpa@zytor.com \
    --cc=jamie@nuviainc.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=reinette.chatre@intel.com \
    --cc=scott@os.amperecomputing.com \
    --cc=shameerali.kolothum.thodi@huawei.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.