* [PATCH iproute2-next 0/2] tc: Add missing ct_state flags
@ 2021-05-21 17:07 Ariel Levkovich
2021-05-21 17:07 ` [PATCH iproute2-next 1/2] tc: f_flower: Add option to match on related ct state Ariel Levkovich
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: Ariel Levkovich @ 2021-05-21 17:07 UTC (permalink / raw)
To: netdev; +Cc: Ariel Levkovich
This short series is:
1. Adding support for matching on ct_state flag rel in tc flower
classifier.
2. Adding some missing description of ct_state flags rpl and inv.
Ariel Levkovich (2):
tc: f_flower: Add option to match on related ct state
tc: f_flower: Add missing ct_state flags to usage description
man/man8/tc-flower.8 | 2 ++
tc/f_flower.c | 3 ++-
2 files changed, 4 insertions(+), 1 deletion(-)
--
2.25.2
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH iproute2-next 1/2] tc: f_flower: Add option to match on related ct state
2021-05-21 17:07 [PATCH iproute2-next 0/2] tc: Add missing ct_state flags Ariel Levkovich
@ 2021-05-21 17:07 ` Ariel Levkovich
2021-05-21 17:07 ` [PATCH iproute2-next 2/2] tc: f_flower: Add missing ct_state flags to usage description Ariel Levkovich
2021-05-27 14:40 ` [PATCH iproute2-next 0/2] tc: Add missing ct_state flags David Ahern
2 siblings, 0 replies; 10+ messages in thread
From: Ariel Levkovich @ 2021-05-21 17:07 UTC (permalink / raw)
To: netdev; +Cc: Ariel Levkovich, Jiri Pirko
Add support for matching on ct_state flag related.
The related state indicates a packet is associated with an existing
connection.
Example:
$ tc filter add dev ens1f0_0 ingress prio 1 chain 1 proto ip flower \
ct_state -est-rel+trk \
action mirred egress redirect dev ens1f0_1
$ tc filter add dev ens1f0_0 ingress prio 1 chain 1 proto ip flower \
ct_state +rel+trk \
action mirred egress redirect dev ens1f0_1
Signed-off-by: Ariel Levkovich <lariel@nvidia.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
---
man/man8/tc-flower.8 | 2 ++
tc/f_flower.c | 3 ++-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/man/man8/tc-flower.8 b/man/man8/tc-flower.8
index f7336b62..4541d937 100644
--- a/man/man8/tc-flower.8
+++ b/man/man8/tc-flower.8
@@ -391,6 +391,8 @@ rpl - The packet is in the reply direction, meaning that it is in the opposite d
.TP
inv - The state is invalid. The packet couldn't be associated to a connection.
.TP
+rel - The packet is related to an existing connection.
+.TP
Example: +trk+est
.RE
.TP
diff --git a/tc/f_flower.c b/tc/f_flower.c
index 53822a95..29db2e23 100644
--- a/tc/f_flower.c
+++ b/tc/f_flower.c
@@ -94,7 +94,7 @@ static void explain(void)
" LSE := lse depth DEPTH { label LABEL | tc TC | bos BOS | ttl TTL }\n"
" FILTERID := X:Y:Z\n"
" MASKED_LLADDR := { LLADDR | LLADDR/MASK | LLADDR/BITS }\n"
- " MASKED_CT_STATE := combination of {+|-} and flags trk,est,new\n"
+ " MASKED_CT_STATE := combination of {+|-} and flags trk,est,new,rel\n"
" ACTION-SPEC := ... look at individual actions\n"
"\n"
"NOTE: CLASSID, IP-PROTO are parsed as hexadecimal input.\n"
@@ -345,6 +345,7 @@ static struct flower_ct_states {
{ "trk", TCA_FLOWER_KEY_CT_FLAGS_TRACKED },
{ "new", TCA_FLOWER_KEY_CT_FLAGS_NEW },
{ "est", TCA_FLOWER_KEY_CT_FLAGS_ESTABLISHED },
+ { "rel", TCA_FLOWER_KEY_CT_FLAGS_RELATED },
{ "inv", TCA_FLOWER_KEY_CT_FLAGS_INVALID },
{ "rpl", TCA_FLOWER_KEY_CT_FLAGS_REPLY },
};
--
2.25.2
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH iproute2-next 2/2] tc: f_flower: Add missing ct_state flags to usage description
2021-05-21 17:07 [PATCH iproute2-next 0/2] tc: Add missing ct_state flags Ariel Levkovich
2021-05-21 17:07 ` [PATCH iproute2-next 1/2] tc: f_flower: Add option to match on related ct state Ariel Levkovich
@ 2021-05-21 17:07 ` Ariel Levkovich
2021-05-27 14:40 ` [PATCH iproute2-next 0/2] tc: Add missing ct_state flags David Ahern
2 siblings, 0 replies; 10+ messages in thread
From: Ariel Levkovich @ 2021-05-21 17:07 UTC (permalink / raw)
To: netdev; +Cc: Ariel Levkovich, Jiri Pirko
Add ct_state flags rpl and inv to the commands usage
description
Signed-off-by: Ariel Levkovich <lariel@nvidia.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
---
tc/f_flower.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tc/f_flower.c b/tc/f_flower.c
index 29db2e23..c5af0276 100644
--- a/tc/f_flower.c
+++ b/tc/f_flower.c
@@ -94,7 +94,7 @@ static void explain(void)
" LSE := lse depth DEPTH { label LABEL | tc TC | bos BOS | ttl TTL }\n"
" FILTERID := X:Y:Z\n"
" MASKED_LLADDR := { LLADDR | LLADDR/MASK | LLADDR/BITS }\n"
- " MASKED_CT_STATE := combination of {+|-} and flags trk,est,new,rel\n"
+ " MASKED_CT_STATE := combination of {+|-} and flags trk,est,new,rel,rpl,inv\n"
" ACTION-SPEC := ... look at individual actions\n"
"\n"
"NOTE: CLASSID, IP-PROTO are parsed as hexadecimal input.\n"
--
2.25.2
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH iproute2-next 0/2] tc: Add missing ct_state flags
2021-05-21 17:07 [PATCH iproute2-next 0/2] tc: Add missing ct_state flags Ariel Levkovich
2021-05-21 17:07 ` [PATCH iproute2-next 1/2] tc: f_flower: Add option to match on related ct state Ariel Levkovich
2021-05-21 17:07 ` [PATCH iproute2-next 2/2] tc: f_flower: Add missing ct_state flags to usage description Ariel Levkovich
@ 2021-05-27 14:40 ` David Ahern
2 siblings, 0 replies; 10+ messages in thread
From: David Ahern @ 2021-05-27 14:40 UTC (permalink / raw)
To: Ariel Levkovich, netdev
On 5/21/21 11:07 AM, Ariel Levkovich wrote:
> This short series is:
>
> 1. Adding support for matching on ct_state flag rel in tc flower
> classifier.
>
> 2. Adding some missing description of ct_state flags rpl and inv.
>
> Ariel Levkovich (2):
> tc: f_flower: Add option to match on related ct state
> tc: f_flower: Add missing ct_state flags to usage description
>
> man/man8/tc-flower.8 | 2 ++
> tc/f_flower.c | 3 ++-
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
applied both to iproute-next.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH iproute2-next 0/2] tc: Add missing ct_state flags
[not found] <20210520112518.15304-1-lariel@nvidia.com>
@ 2021-05-20 12:16 ` Andrea Claudi
0 siblings, 0 replies; 10+ messages in thread
From: Andrea Claudi @ 2021-05-20 12:16 UTC (permalink / raw)
To: Ariel Levkovich; +Cc: netdev, jiri, mleitner
On Thu, May 20, 2021 at 02:25:16PM +0300, Ariel Levkovich wrote:
> This short series is:
>
> 1. Adding support for matching on ct_state flag rel in tc flower
> classifier.
>
> 2. Adding some missing description of ct_state flags rpl and inv.
>
> Ariel Levkovich (2):
> tc: f_flower: Add option to match on related ct state
> tc: f_flower: Add missing ct_state flags to usage description
>
> man/man8/tc-flower.8 | 2 ++
> tc/f_flower.c | 3 ++-
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
Thanks, Ariel.
Acked-by: Andrea Claudi <aclaudi@redhat.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH iproute2-next 0/2] ] tc: Add missing ct_state flags
2021-05-20 11:07 ` Andrea Claudi
@ 2021-05-20 11:26 ` Ariel Levkovich
0 siblings, 0 replies; 10+ messages in thread
From: Ariel Levkovich @ 2021-05-20 11:26 UTC (permalink / raw)
To: Andrea Claudi; +Cc: Marcelo Ricardo Leitner, linux-netdev, jiri
On 5/20/21 2:07 PM, Andrea Claudi wrote:
> On Thu, May 20, 2021 at 1:00 PM Ariel Levkovich <lariel@nvidia.com> wrote:
>> On 5/20/21 4:15 AM, Marcelo Ricardo Leitner wrote:
>>> On Tue, May 18, 2021 at 06:52:29PM +0300, Ariel Levkovich wrote:
>>>> This short series is:
>>>>
>>> Is it me or this series didn't get to netdev@?
>>> I can't find it in patchwork nor lore archives.
>>>
>> Neither do I. Not sure what happened.
>>
>> Should I just send it again?
>>
> Now that I look at it better, there is a double closed square bracket
> on the subject. Not sure if this is related to the issue.
> Ariel, I think you should submit this again to netdev.
>
> Cheers,
> Andrea
>
hmmm... nice catch. I hope this is it.
I re-sent it just now.
Ariel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH iproute2-next 0/2] ] tc: Add missing ct_state flags
2021-05-20 10:57 ` Ariel Levkovich
@ 2021-05-20 11:07 ` Andrea Claudi
2021-05-20 11:26 ` Ariel Levkovich
0 siblings, 1 reply; 10+ messages in thread
From: Andrea Claudi @ 2021-05-20 11:07 UTC (permalink / raw)
To: Ariel Levkovich; +Cc: Marcelo Ricardo Leitner, linux-netdev, jiri
On Thu, May 20, 2021 at 1:00 PM Ariel Levkovich <lariel@nvidia.com> wrote:
>
> On 5/20/21 4:15 AM, Marcelo Ricardo Leitner wrote:
> > On Tue, May 18, 2021 at 06:52:29PM +0300, Ariel Levkovich wrote:
> >> This short series is:
> >>
> > Is it me or this series didn't get to netdev@?
> > I can't find it in patchwork nor lore archives.
> >
> Neither do I. Not sure what happened.
>
> Should I just send it again?
>
Now that I look at it better, there is a double closed square bracket
on the subject. Not sure if this is related to the issue.
Ariel, I think you should submit this again to netdev.
Cheers,
Andrea
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH iproute2-next 0/2] ] tc: Add missing ct_state flags
2021-05-20 1:15 ` [PATCH iproute2-next 0/2] ] " Marcelo Ricardo Leitner
2021-05-20 10:54 ` Andrea Claudi
@ 2021-05-20 10:57 ` Ariel Levkovich
2021-05-20 11:07 ` Andrea Claudi
1 sibling, 1 reply; 10+ messages in thread
From: Ariel Levkovich @ 2021-05-20 10:57 UTC (permalink / raw)
To: Marcelo Ricardo Leitner; +Cc: netdev, jiri
On 5/20/21 4:15 AM, Marcelo Ricardo Leitner wrote:
> On Tue, May 18, 2021 at 06:52:29PM +0300, Ariel Levkovich wrote:
>> This short series is:
>>
> Is it me or this series didn't get to netdev@?
> I can't find it in patchwork nor lore archives.
>
Neither do I. Not sure what happened.
Should I just send it again?
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH iproute2-next 0/2] ] tc: Add missing ct_state flags
2021-05-20 1:15 ` [PATCH iproute2-next 0/2] ] " Marcelo Ricardo Leitner
@ 2021-05-20 10:54 ` Andrea Claudi
2021-05-20 10:57 ` Ariel Levkovich
1 sibling, 0 replies; 10+ messages in thread
From: Andrea Claudi @ 2021-05-20 10:54 UTC (permalink / raw)
To: Marcelo Ricardo Leitner; +Cc: Ariel Levkovich, linux-netdev, jiri
On Thu, May 20, 2021 at 3:15 AM Marcelo Ricardo Leitner
<mleitner@redhat.com> wrote:
> Is it me or this series didn't get to netdev@?
> I can't find it in patchwork nor lore archives.
I was about to ask the same question. Is this posted to a different
mailing list?
Cheers,
Andrea
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH iproute2-next 0/2] ] tc: Add missing ct_state flags
[not found] <20210518155231.38359-1-lariel@nvidia.com>
@ 2021-05-20 1:15 ` Marcelo Ricardo Leitner
2021-05-20 10:54 ` Andrea Claudi
2021-05-20 10:57 ` Ariel Levkovich
0 siblings, 2 replies; 10+ messages in thread
From: Marcelo Ricardo Leitner @ 2021-05-20 1:15 UTC (permalink / raw)
To: Ariel Levkovich; +Cc: netdev, jiri
On Tue, May 18, 2021 at 06:52:29PM +0300, Ariel Levkovich wrote:
> This short series is:
>
Is it me or this series didn't get to netdev@?
I can't find it in patchwork nor lore archives.
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2021-05-27 14:40 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-21 17:07 [PATCH iproute2-next 0/2] tc: Add missing ct_state flags Ariel Levkovich
2021-05-21 17:07 ` [PATCH iproute2-next 1/2] tc: f_flower: Add option to match on related ct state Ariel Levkovich
2021-05-21 17:07 ` [PATCH iproute2-next 2/2] tc: f_flower: Add missing ct_state flags to usage description Ariel Levkovich
2021-05-27 14:40 ` [PATCH iproute2-next 0/2] tc: Add missing ct_state flags David Ahern
[not found] <20210520112518.15304-1-lariel@nvidia.com>
2021-05-20 12:16 ` Andrea Claudi
[not found] <20210518155231.38359-1-lariel@nvidia.com>
2021-05-20 1:15 ` [PATCH iproute2-next 0/2] ] " Marcelo Ricardo Leitner
2021-05-20 10:54 ` Andrea Claudi
2021-05-20 10:57 ` Ariel Levkovich
2021-05-20 11:07 ` Andrea Claudi
2021-05-20 11:26 ` Ariel Levkovich
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.