[PATCH iproute2-next 0/2] tc: Add missing ct_state flags

[PATCH iproute2-next 0/2] tc: Add missing ct_state flags

[Ariel Levkovich]

This short series is:

1. Adding support for matching on ct_state flag rel in tc flower
classifier.

2. Adding some missing description of ct_state flags rpl and inv.

Ariel Levkovich (2):
  tc: f_flower: Add option to match on related ct state
  tc: f_flower: Add missing ct_state flags to usage description

 man/man8/tc-flower.8 | 2 ++
 tc/f_flower.c        | 3 ++-
 2 files changed, 4 insertions(+), 1 deletion(-)

-- 
2.25.2

[PATCH iproute2-next 1/2] tc: f_flower: Add option to match on related ct state

[Ariel Levkovich]

Add support for matching on ct_state flag related.
The related state indicates a packet is associated with an existing
connection.

Example:
$ tc filter add dev ens1f0_0 ingress prio 1 chain 1 proto ip flower \
  ct_state -est-rel+trk \
  action mirred egress redirect dev ens1f0_1

$ tc filter add dev ens1f0_0 ingress prio 1 chain 1 proto ip flower \
  ct_state +rel+trk \
  action mirred egress redirect dev ens1f0_1

Signed-off-by: Ariel Levkovich <lariel@nvidia.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
---
 man/man8/tc-flower.8 | 2 ++
 tc/f_flower.c        | 3 ++-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/man/man8/tc-flower.8 b/man/man8/tc-flower.8
index f7336b62..4541d937 100644
--- a/man/man8/tc-flower.8
+++ b/man/man8/tc-flower.8
@@ -391,6 +391,8 @@ rpl - The packet is in the reply direction, meaning that it is in the opposite d
 .TP
 inv - The state is invalid. The packet couldn't be associated to a connection.
 .TP
+rel - The packet is related to an existing connection.
+.TP
 Example: +trk+est
 .RE
 .TP
diff --git a/tc/f_flower.c b/tc/f_flower.c
index 53822a95..29db2e23 100644
--- a/tc/f_flower.c
+++ b/tc/f_flower.c
@@ -94,7 +94,7 @@ static void explain(void)
 		"	LSE := lse depth DEPTH { label LABEL | tc TC | bos BOS | ttl TTL }\n"
 		"	FILTERID := X:Y:Z\n"
 		"	MASKED_LLADDR := { LLADDR | LLADDR/MASK | LLADDR/BITS }\n"
-		"	MASKED_CT_STATE := combination of {+|-} and flags trk,est,new\n"
+		"	MASKED_CT_STATE := combination of {+|-} and flags trk,est,new,rel\n"
 		"	ACTION-SPEC := ... look at individual actions\n"
 		"\n"
 		"NOTE:	CLASSID, IP-PROTO are parsed as hexadecimal input.\n"
@@ -345,6 +345,7 @@ static struct flower_ct_states {
 	{ "trk", TCA_FLOWER_KEY_CT_FLAGS_TRACKED },
 	{ "new", TCA_FLOWER_KEY_CT_FLAGS_NEW },
 	{ "est", TCA_FLOWER_KEY_CT_FLAGS_ESTABLISHED },
+	{ "rel", TCA_FLOWER_KEY_CT_FLAGS_RELATED },
 	{ "inv", TCA_FLOWER_KEY_CT_FLAGS_INVALID },
 	{ "rpl", TCA_FLOWER_KEY_CT_FLAGS_REPLY },
 };
-- 
2.25.2

[PATCH iproute2-next 2/2] tc: f_flower: Add missing ct_state flags to usage description

[Ariel Levkovich]

Add ct_state flags rpl and inv to the commands usage
description

Signed-off-by: Ariel Levkovich <lariel@nvidia.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
---
 tc/f_flower.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tc/f_flower.c b/tc/f_flower.c
index 29db2e23..c5af0276 100644
--- a/tc/f_flower.c
+++ b/tc/f_flower.c
@@ -94,7 +94,7 @@ static void explain(void)
 		"	LSE := lse depth DEPTH { label LABEL | tc TC | bos BOS | ttl TTL }\n"
 		"	FILTERID := X:Y:Z\n"
 		"	MASKED_LLADDR := { LLADDR | LLADDR/MASK | LLADDR/BITS }\n"
-		"	MASKED_CT_STATE := combination of {+|-} and flags trk,est,new,rel\n"
+		"	MASKED_CT_STATE := combination of {+|-} and flags trk,est,new,rel,rpl,inv\n"
 		"	ACTION-SPEC := ... look at individual actions\n"
 		"\n"
 		"NOTE:	CLASSID, IP-PROTO are parsed as hexadecimal input.\n"
-- 
2.25.2

Re: [PATCH iproute2-next 0/2] tc: Add missing ct_state flags

[David Ahern]

On 5/21/21 11:07 AM, Ariel Levkovich wrote:
> This short series is:
> 
> 1. Adding support for matching on ct_state flag rel in tc flower
> classifier.
> 
> 2. Adding some missing description of ct_state flags rpl and inv.
> 
> Ariel Levkovich (2):
>   tc: f_flower: Add option to match on related ct state
>   tc: f_flower: Add missing ct_state flags to usage description
> 
>  man/man8/tc-flower.8 | 2 ++
>  tc/f_flower.c        | 3 ++-
>  2 files changed, 4 insertions(+), 1 deletion(-)
> 

applied both to iproute-next.

Re: [PATCH iproute2-next 0/2] tc: Add missing ct_state flags

[Andrea Claudi]

On Thu, May 20, 2021 at 02:25:16PM +0300, Ariel Levkovich wrote:
> This short series is:
> 
> 1. Adding support for matching on ct_state flag rel in tc flower
> classifier.
> 
> 2. Adding some missing description of ct_state flags rpl and inv.
> 
> Ariel Levkovich (2):
>   tc: f_flower: Add option to match on related ct state
>   tc: f_flower: Add missing ct_state flags to usage description
> 
>  man/man8/tc-flower.8 | 2 ++
>  tc/f_flower.c        | 3 ++-
>  2 files changed, 4 insertions(+), 1 deletion(-)
>
Thanks, Ariel.

Acked-by: Andrea Claudi <aclaudi@redhat.com>

Re: [PATCH iproute2-next 0/2] ] tc: Add missing ct_state flags

[Ariel Levkovich]

On 5/20/21 2:07 PM, Andrea Claudi wrote:
> On Thu, May 20, 2021 at 1:00 PM Ariel Levkovich <lariel@nvidia.com> wrote:
>> On 5/20/21 4:15 AM, Marcelo Ricardo Leitner wrote:
>>> On Tue, May 18, 2021 at 06:52:29PM +0300, Ariel Levkovich wrote:
>>>> This short series is:
>>>>
>>> Is it me or this series didn't get to netdev@?
>>> I can't find it in patchwork nor lore archives.
>>>
>> Neither do I. Not sure what happened.
>>
>> Should I just send it again?
>>
> Now that I look at it better, there is a double closed square bracket
> on the subject. Not sure if this is related to the issue.
> Ariel, I think you should submit this again to netdev.
>
> Cheers,
> Andrea
>
hmmm... nice catch. I hope this is it.

I re-sent it just now.

Ariel

Re: [PATCH iproute2-next 0/2] ] tc: Add missing ct_state flags

[Andrea Claudi]

On Thu, May 20, 2021 at 1:00 PM Ariel Levkovich <lariel@nvidia.com> wrote:
>
> On 5/20/21 4:15 AM, Marcelo Ricardo Leitner wrote:
> > On Tue, May 18, 2021 at 06:52:29PM +0300, Ariel Levkovich wrote:
> >> This short series is:
> >>
> > Is it me or this series didn't get to netdev@?
> > I can't find it in patchwork nor lore archives.
> >
> Neither do I. Not sure what happened.
>
> Should I just send it again?
>

Now that I look at it better, there is a double closed square bracket
on the subject. Not sure if this is related to the issue.
Ariel, I think you should submit this again to netdev.

Cheers,
Andrea

Re: [PATCH iproute2-next 0/2] ] tc: Add missing ct_state flags

[Ariel Levkovich]

On 5/20/21 4:15 AM, Marcelo Ricardo Leitner wrote:
> On Tue, May 18, 2021 at 06:52:29PM +0300, Ariel Levkovich wrote:
>> This short series is:
>>
> Is it me or this series didn't get to netdev@?
> I can't find it in patchwork nor lore archives.
>
Neither do I. Not sure what happened.

Should I just send it again?

Re: [PATCH iproute2-next 0/2] ] tc: Add missing ct_state flags

[Andrea Claudi]

On Thu, May 20, 2021 at 3:15 AM Marcelo Ricardo Leitner
<mleitner@redhat.com> wrote:
> Is it me or this series didn't get to netdev@?
> I can't find it in patchwork nor lore archives.

I was about to ask the same question. Is this posted to a different
mailing list?

Cheers,
Andrea

Re: [PATCH iproute2-next 0/2] ] tc: Add missing ct_state flags

[Marcelo Ricardo Leitner]

On Tue, May 18, 2021 at 06:52:29PM +0300, Ariel Levkovich wrote:
> This short series is:
>

Is it me or this series didn't get to netdev@?
I can't find it in patchwork nor lore archives.