All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: qemu-devel@nongnu.org
Cc: "Thomas Huth" <thuth@redhat.com>,
	"Daniel P . Berrange" <berrange@redhat.com>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Willian Rampazzo" <willianr@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>
Subject: [PATCH 8/9] gitlab-ci: Run Avocado tests manually (except mainstream CI)
Date: Tue, 25 May 2021 10:25:55 +0200	[thread overview]
Message-ID: <20210525082556.4011380-9-f4bug@amsat.org> (raw)
In-Reply-To: <20210525082556.4011380-1-f4bug@amsat.org>

Due to a design problem and misunderstanding between the Avocado
framework and QEMU, Avocado is fetching many asset artifacts it
shouldn't be fetching, exhausting the jobs CI timeout.

Since Avocado artifacts are cached, this is not an issue with old
forks, which already have populated the cache and do not need to
download new artifacts to run the tests.

However this is very confusing to new contributors who start to
fork the project and keep having failing CI pipelines.

As a temporary kludge, add the QEMU_CI_AVOCADO_TESTING variable
to allow old forks to keep running the Avocado tests, while still
allowing new forks to use the mainstream set of CI tests.

Keep the tests enabled by default on the mainstream namespace
which is old enough to have a populated cache, hoping we will
keep this cache long enough until the Avocado/QEMU design issue
is fixed.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
Since it is not clear which project should be modified, there is
no issue filled to track the progress on fixing this problem.
---
 .gitlab-ci.d/buildtest-template.yml | 12 ++++++++++++
 .gitlab-ci.yml                      | 24 ++++++++++++++++++++++++
 2 files changed, 36 insertions(+)

diff --git a/.gitlab-ci.d/buildtest-template.yml b/.gitlab-ci.d/buildtest-template.yml
index 180bf1aee7e..8e6321c2a38 100644
--- a/.gitlab-ci.d/buildtest-template.yml
+++ b/.gitlab-ci.d/buildtest-template.yml
@@ -67,3 +67,15 @@
   after_script:
     - cd build
     - du -chs ${CI_PROJECT_DIR}/avocado-cache
+  rules:
+    # Only run these jobs if running on the mainstream namespace,
+    # or if the user set the QEMU_CI_AVOCADO_TESTING variable (either
+    # in its namespace setting or via git-push option, see documentation
+    # in /.gitlab-ci.yml of this repository).
+    - if: '$CI_PROJECT_NAMESPACE == "qemu-project"'
+      when: always
+    - if: '$QEMU_CI_AVOCADO_TESTING'
+      when: always
+    # Otherwise, set to manual (the jobs are created but not run).
+    - when: manual
+      allow_failure: true
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 8c843e5f20e..830c5b7af97 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -12,5 +12,29 @@
 # location of your custom .gitlab-ci.yml:
 # https://docs.gitlab.com/ee/ci/pipelines/settings.html#custom-cicd-configuration-path
 #
+# ----------------------------------------------------------------------
+#
+# QEMU CI jobs are based on templates. Some templates provide
+# user-configurable options, modifiable via configuration variables.
+#
+# These variables can be set globally in the user's CI namespace
+# setting:
+# https://docs.gitlab.com/ee/ci/variables/#create-a-custom-variable-in-the-ui
+# or set manually each time a branch/tag is pushed, as a git-push
+# command line argument:
+# https://docs.gitlab.com/ee/user/project/push_options.html#push-options-for-gitlab-cicd
+#
+# Example setting the QEMU_CI_EXAMPLE_VAR variable:
+#
+#   git push -o ci.variable="QEMU_CI_EXAMPLE_VAR=value" myrepo mybranch
+#
+# ----------------------------------------------------------------------
+#
+# List of environment variables that can be use to modify the set
+# of jobs selected:
+#
+# - QEMU_CI_AVOCADO_TESTING
+#   If set, tests using the Avocado framework will be run
+
 include:
   - local: '/.gitlab-ci.d/qemu-project.yml'
-- 
2.26.3



  parent reply	other threads:[~2021-05-25  8:31 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-25  8:25 [PATCH 0/9] gitlab-ci: Make mainstream CI green again Philippe Mathieu-Daudé
2021-05-25  8:25 ` [PATCH 1/9] gitlab-ci: Extract all default build/test jobs to buildtest.yml Philippe Mathieu-Daudé
2021-05-25 11:05   ` Alex Bennée
2021-05-25  8:25 ` [PATCH 2/9] gitlab-ci: Move current job set to qemu-project.yml Philippe Mathieu-Daudé
2021-05-25 11:05   ` Alex Bennée
2021-05-25  8:25 ` [PATCH 3/9] gitlab-ci: Document how forks can use different set of jobs Philippe Mathieu-Daudé
2021-05-25 11:06   ` Alex Bennée
2021-05-25 14:30   ` Willian Rampazzo
2021-05-25  8:25 ` [PATCH 4/9] gitlab-ci: Extract cross-container jobs to container-cross.yml Philippe Mathieu-Daudé
2021-05-25 11:06   ` Alex Bennée
2021-05-25 14:32   ` Willian Rampazzo
2021-05-25  8:25 ` [PATCH 5/9] gitlab-ci: explicitly reference the upstream registry Philippe Mathieu-Daudé
2021-05-25 11:10   ` Alex Bennée
2021-05-25 11:39     ` Philippe Mathieu-Daudé
2021-05-25  8:25 ` [PATCH 6/9] gitlab-ci: Split gprof-gcov job Philippe Mathieu-Daudé
2021-05-25 10:21   ` Philippe Mathieu-Daudé
2021-05-27  6:03     ` Thomas Huth
2021-05-27 13:04       ` Alex Bennée
2021-05-25 14:34   ` Willian Rampazzo
2021-06-07 11:36   ` Alex Bennée
2021-05-25  8:25 ` [PATCH 7/9] gitlab-ci: Keep Avocado reports during 1 week Philippe Mathieu-Daudé
2021-05-25 11:11   ` Alex Bennée
2021-05-25 14:35   ` Willian Rampazzo
2021-05-25  8:25 ` Philippe Mathieu-Daudé [this message]
2021-05-25 11:25   ` [PATCH 8/9] gitlab-ci: Run Avocado tests manually (except mainstream CI) Alex Bennée
2021-05-27  6:08   ` Thomas Huth
2021-05-25  8:25 ` [PATCH 9/9] gitlab-ci: Use absolute path and simplify firmware jobs Philippe Mathieu-Daudé
2021-05-25  8:56   ` Daniel P. Berrangé
2021-05-25  9:02     ` Philippe Mathieu-Daudé
2021-05-27 16:04 ` [PATCH 0/9] gitlab-ci: Make mainstream CI green again Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210525082556.4011380-9-f4bug@amsat.org \
    --to=f4bug@amsat.org \
    --cc=alex.bennee@linaro.org \
    --cc=berrange@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    --cc=wainersm@redhat.com \
    --cc=willianr@redhat.com \
    --subject='Re: [PATCH 8/9] gitlab-ci: Run Avocado tests manually (except mainstream CI)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.