All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: "Thomas Huth" <thuth@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	qemu-devel@nongnu.org,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Willian Rampazzo" <willianr@redhat.com>,
	"Bin Meng" <bmeng.cn@gmail.com>,
	"Laszlo Ersek" <lersek@redhat.com>
Subject: Re: [PATCH 9/9] gitlab-ci: Use absolute path and simplify firmware jobs
Date: Tue, 25 May 2021 11:02:15 +0200	[thread overview]
Message-ID: <6a748bb4-d883-eb09-2280-7a4e65bc2691@amsat.org> (raw)
In-Reply-To: <YKy7uXb+lmICJVY/@redhat.com>

On 5/25/21 10:56 AM, Daniel P. Berrangé wrote:
> On Tue, May 25, 2021 at 10:25:56AM +0200, Philippe Mathieu-Daudé wrote:
>> The GitLab 'add job on file changed' feature doesn't work well
>> with relative paths: use absolute paths instead.
>>
>> Change the 'rules:' section by an 'only:' one which is easier
>> to read.
> 
> GitLab docs say "rules replaces only/except", so I'm not convinced
> we should be going back to the old syntax, especially as that means
> some jobs will use 'rules' and some jobs will use 'only'. Consistency
> across jobs wins for me and "rules" is much more expressive.

OK. I wanted to tag this patch RFC anyway, but forgot.
Please disregard it (the rest of the series doesn't rely on it).


  reply	other threads:[~2021-05-25  9:03 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-25  8:25 [PATCH 0/9] gitlab-ci: Make mainstream CI green again Philippe Mathieu-Daudé
2021-05-25  8:25 ` [PATCH 1/9] gitlab-ci: Extract all default build/test jobs to buildtest.yml Philippe Mathieu-Daudé
2021-05-25 11:05   ` Alex Bennée
2021-05-25  8:25 ` [PATCH 2/9] gitlab-ci: Move current job set to qemu-project.yml Philippe Mathieu-Daudé
2021-05-25 11:05   ` Alex Bennée
2021-05-25  8:25 ` [PATCH 3/9] gitlab-ci: Document how forks can use different set of jobs Philippe Mathieu-Daudé
2021-05-25 11:06   ` Alex Bennée
2021-05-25 14:30   ` Willian Rampazzo
2021-05-25  8:25 ` [PATCH 4/9] gitlab-ci: Extract cross-container jobs to container-cross.yml Philippe Mathieu-Daudé
2021-05-25 11:06   ` Alex Bennée
2021-05-25 14:32   ` Willian Rampazzo
2021-05-25  8:25 ` [PATCH 5/9] gitlab-ci: explicitly reference the upstream registry Philippe Mathieu-Daudé
2021-05-25 11:10   ` Alex Bennée
2021-05-25 11:39     ` Philippe Mathieu-Daudé
2021-05-25  8:25 ` [PATCH 6/9] gitlab-ci: Split gprof-gcov job Philippe Mathieu-Daudé
2021-05-25 10:21   ` Philippe Mathieu-Daudé
2021-05-27  6:03     ` Thomas Huth
2021-05-27 13:04       ` Alex Bennée
2021-05-25 14:34   ` Willian Rampazzo
2021-06-07 11:36   ` Alex Bennée
2021-05-25  8:25 ` [PATCH 7/9] gitlab-ci: Keep Avocado reports during 1 week Philippe Mathieu-Daudé
2021-05-25 11:11   ` Alex Bennée
2021-05-25 14:35   ` Willian Rampazzo
2021-05-25  8:25 ` [PATCH 8/9] gitlab-ci: Run Avocado tests manually (except mainstream CI) Philippe Mathieu-Daudé
2021-05-25 11:25   ` Alex Bennée
2021-05-27  6:08   ` Thomas Huth
2021-05-25  8:25 ` [PATCH 9/9] gitlab-ci: Use absolute path and simplify firmware jobs Philippe Mathieu-Daudé
2021-05-25  8:56   ` Daniel P. Berrangé
2021-05-25  9:02     ` Philippe Mathieu-Daudé [this message]
2021-05-27 16:04 ` [PATCH 0/9] gitlab-ci: Make mainstream CI green again Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6a748bb4-d883-eb09-2280-7a4e65bc2691@amsat.org \
    --to=f4bug@amsat.org \
    --cc=alex.bennee@linaro.org \
    --cc=berrange@redhat.com \
    --cc=bmeng.cn@gmail.com \
    --cc=lersek@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    --cc=wainersm@redhat.com \
    --cc=willianr@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.