From: "Darrick J. Wong" <djwong@kernel.org> To: Jan Kara <jack@suse.cz> Cc: Damien Le Moal <Damien.LeMoal@wdc.com>, "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>, "hch@infradead.org" <hch@infradead.org>, Dave Chinner <david@fromorbit.com>, "ceph-devel@vger.kernel.org" <ceph-devel@vger.kernel.org>, Chao Yu <yuchao0@huawei.com>, "Darrick J. Wong" <darrick.wong@oracle.com>, Jaegeuk Kim <jaegeuk@kernel.org>, Jeff Layton <jlayton@kernel.org>, Johannes Thumshirn <jth@kernel.org>, "linux-cifs@vger.kernel.org" <linux-cifs@vger.kernel.org>, "linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>, "linux-f2fs-devel@lists.sourceforge.net" <linux-f2fs-devel@lists.sourceforge.net>, "linux-mm@kvack.org" <linux-mm@kvack.org>, "linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>, Miklos Szeredi <miklos@szeredi.hu>, Steve French <sfrench@samba.org>, Ted Tso <tytso@mit.edu>, Matthew Wilcox <willy@infradead.org> Subject: Re: [PATCH 04/13] mm: Add functions to lock invalidate_lock for two mappings Date: Wed, 26 May 2021 08:25:25 -0700 [thread overview] Message-ID: <20210526152525.GY202121@locust> (raw) In-Reply-To: <20210526134518.GF30369@quack2.suse.cz> On Wed, May 26, 2021 at 03:45:18PM +0200, Jan Kara wrote: > On Wed 26-05-21 12:11:43, Damien Le Moal wrote: > > On 2021/05/26 19:07, Jan Kara wrote: > > > On Tue 25-05-21 13:48:05, Darrick J. Wong wrote: > > >> On Tue, May 25, 2021 at 03:50:41PM +0200, Jan Kara wrote: > > >>> Some operations such as reflinking blocks among files will need to lock > > >>> invalidate_lock for two mappings. Add helper functions to do that. > > >>> > > >>> Signed-off-by: Jan Kara <jack@suse.cz> > > >>> --- > > >>> include/linux/fs.h | 6 ++++++ > > >>> mm/filemap.c | 38 ++++++++++++++++++++++++++++++++++++++ > > >>> 2 files changed, 44 insertions(+) > > >>> > > >>> diff --git a/include/linux/fs.h b/include/linux/fs.h > > >>> index 897238d9f1e0..e6f7447505f5 100644 > > >>> --- a/include/linux/fs.h > > >>> +++ b/include/linux/fs.h > > >>> @@ -822,6 +822,12 @@ static inline void inode_lock_shared_nested(struct inode *inode, unsigned subcla > > >>> void lock_two_nondirectories(struct inode *, struct inode*); > > >>> void unlock_two_nondirectories(struct inode *, struct inode*); > > >>> > > >>> +void filemap_invalidate_down_write_two(struct address_space *mapping1, > > >>> + struct address_space *mapping2); > > >>> +void filemap_invalidate_up_write_two(struct address_space *mapping1, > > >> > > >> TBH I find myself wishing that the invalidate_lock used the same > > >> lock/unlock style wrappers that we use for i_rwsem. > > >> > > >> filemap_invalidate_lock(inode1->mapping); > > >> filemap_invalidate_lock_two(inode1->i_mapping, inode2->i_mapping); > > > > > > OK, and filemap_invalidate_lock_shared() for down_read()? I guess that > > > works for me. > > > > What about filemap_invalidate_lock_read() and filemap_invalidate_lock_write() ? > > That reminds the down_read()/down_write() without the slightly confusing down/up. > > Well, if we go for lock wrappers as Darrick suggested, I'd mirror naming > used for inode_lock(). That is IMO the least confusing option... And that > naming has _lock and _lock_shared suffixes. I'd like filemap_invalidate_lock and filemap_invalidate_lock_shared. --D > > Honza > > -- > Jan Kara <jack@suse.com> > SUSE Labs, CR
WARNING: multiple messages have this Message-ID (diff)
From: "Darrick J. Wong" <djwong@kernel.org> To: Jan Kara <jack@suse.cz> Cc: "linux-cifs@vger.kernel.org" <linux-cifs@vger.kernel.org>, Damien Le Moal <Damien.LeMoal@wdc.com>, "linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>, Ted Tso <tytso@mit.edu>, "Darrick J. Wong" <darrick.wong@oracle.com>, Jeff Layton <jlayton@kernel.org>, Steve French <sfrench@samba.org>, Dave Chinner <david@fromorbit.com>, Matthew Wilcox <willy@infradead.org>, "linux-f2fs-devel@lists.sourceforge.net" <linux-f2fs-devel@lists.sourceforge.net>, "hch@infradead.org" <hch@infradead.org>, "linux-mm@kvack.org" <linux-mm@kvack.org>, Miklos Szeredi <miklos@szeredi.hu>, "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>, Jaegeuk Kim <jaegeuk@kernel.org>, "ceph-devel@vger.kernel.org" <ceph-devel@vger.kernel.org>, Johannes Thumshirn <jth@kernel.org>, "linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org> Subject: Re: [f2fs-dev] [PATCH 04/13] mm: Add functions to lock invalidate_lock for two mappings Date: Wed, 26 May 2021 08:25:25 -0700 [thread overview] Message-ID: <20210526152525.GY202121@locust> (raw) In-Reply-To: <20210526134518.GF30369@quack2.suse.cz> On Wed, May 26, 2021 at 03:45:18PM +0200, Jan Kara wrote: > On Wed 26-05-21 12:11:43, Damien Le Moal wrote: > > On 2021/05/26 19:07, Jan Kara wrote: > > > On Tue 25-05-21 13:48:05, Darrick J. Wong wrote: > > >> On Tue, May 25, 2021 at 03:50:41PM +0200, Jan Kara wrote: > > >>> Some operations such as reflinking blocks among files will need to lock > > >>> invalidate_lock for two mappings. Add helper functions to do that. > > >>> > > >>> Signed-off-by: Jan Kara <jack@suse.cz> > > >>> --- > > >>> include/linux/fs.h | 6 ++++++ > > >>> mm/filemap.c | 38 ++++++++++++++++++++++++++++++++++++++ > > >>> 2 files changed, 44 insertions(+) > > >>> > > >>> diff --git a/include/linux/fs.h b/include/linux/fs.h > > >>> index 897238d9f1e0..e6f7447505f5 100644 > > >>> --- a/include/linux/fs.h > > >>> +++ b/include/linux/fs.h > > >>> @@ -822,6 +822,12 @@ static inline void inode_lock_shared_nested(struct inode *inode, unsigned subcla > > >>> void lock_two_nondirectories(struct inode *, struct inode*); > > >>> void unlock_two_nondirectories(struct inode *, struct inode*); > > >>> > > >>> +void filemap_invalidate_down_write_two(struct address_space *mapping1, > > >>> + struct address_space *mapping2); > > >>> +void filemap_invalidate_up_write_two(struct address_space *mapping1, > > >> > > >> TBH I find myself wishing that the invalidate_lock used the same > > >> lock/unlock style wrappers that we use for i_rwsem. > > >> > > >> filemap_invalidate_lock(inode1->mapping); > > >> filemap_invalidate_lock_two(inode1->i_mapping, inode2->i_mapping); > > > > > > OK, and filemap_invalidate_lock_shared() for down_read()? I guess that > > > works for me. > > > > What about filemap_invalidate_lock_read() and filemap_invalidate_lock_write() ? > > That reminds the down_read()/down_write() without the slightly confusing down/up. > > Well, if we go for lock wrappers as Darrick suggested, I'd mirror naming > used for inode_lock(). That is IMO the least confusing option... And that > naming has _lock and _lock_shared suffixes. I'd like filemap_invalidate_lock and filemap_invalidate_lock_shared. --D > > Honza > > -- > Jan Kara <jack@suse.com> > SUSE Labs, CR _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2021-05-26 15:25 UTC|newest] Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-25 13:50 [PATCH 0/13 v6] fs: Hole punch vs page cache filling races Jan Kara 2021-05-25 13:50 ` [f2fs-dev] " Jan Kara 2021-05-25 13:50 ` [PATCH 01/13] mm: Fix comments mentioning i_mutex Jan Kara 2021-05-25 13:50 ` [f2fs-dev] " Jan Kara 2021-05-25 13:50 ` [PATCH 02/13] documentation: Sync file_operations members with reality Jan Kara 2021-05-25 13:50 ` [f2fs-dev] " Jan Kara 2021-05-25 20:43 ` Darrick J. Wong 2021-05-25 20:43 ` [f2fs-dev] " Darrick J. Wong 2021-05-25 13:50 ` [PATCH 03/13] mm: Protect operations adding pages to page cache with invalidate_lock Jan Kara 2021-05-25 13:50 ` [f2fs-dev] " Jan Kara 2021-05-25 21:01 ` Darrick J. Wong 2021-05-25 21:01 ` [f2fs-dev] " Darrick J. Wong 2021-05-26 10:00 ` Jan Kara 2021-05-26 10:00 ` [f2fs-dev] " Jan Kara 2021-05-25 13:50 ` [PATCH 04/13] mm: Add functions to lock invalidate_lock for two mappings Jan Kara 2021-05-25 13:50 ` [f2fs-dev] " Jan Kara 2021-05-25 20:48 ` Darrick J. Wong 2021-05-25 20:48 ` [f2fs-dev] " Darrick J. Wong 2021-05-26 10:07 ` Jan Kara 2021-05-26 10:07 ` [f2fs-dev] " Jan Kara 2021-05-26 12:11 ` Damien Le Moal 2021-05-26 12:11 ` [f2fs-dev] " Damien Le Moal 2021-05-26 12:11 ` Damien Le Moal 2021-05-26 13:45 ` Jan Kara 2021-05-26 13:45 ` [f2fs-dev] " Jan Kara 2021-05-26 13:45 ` Jan Kara 2021-05-26 15:25 ` Darrick J. Wong [this message] 2021-05-26 15:25 ` [f2fs-dev] " Darrick J. Wong 2021-05-26 15:25 ` Darrick J. Wong 2021-05-25 13:50 ` [PATCH 05/13] ext4: Convert to use mapping->invalidate_lock Jan Kara 2021-05-25 13:50 ` [f2fs-dev] " Jan Kara 2021-05-25 13:50 ` [PATCH 06/13] ext2: Convert to using invalidate_lock Jan Kara 2021-05-25 13:50 ` [f2fs-dev] " Jan Kara 2021-05-25 13:50 ` [PATCH 07/13] xfs: Convert to use invalidate_lock Jan Kara 2021-05-25 13:50 ` [f2fs-dev] " Jan Kara 2021-05-25 21:37 ` Darrick J. Wong 2021-05-25 21:37 ` [f2fs-dev] " Darrick J. Wong 2021-05-26 10:18 ` Jan Kara 2021-05-26 10:18 ` [f2fs-dev] " Jan Kara 2021-05-26 15:32 ` Darrick J. Wong 2021-05-26 15:32 ` [f2fs-dev] " Darrick J. Wong 2021-05-27 12:01 ` Jan Kara 2021-05-27 12:01 ` [f2fs-dev] " Jan Kara 2021-05-25 21:40 ` Dave Chinner 2021-05-25 21:40 ` [f2fs-dev] " Dave Chinner 2021-05-26 10:20 ` Jan Kara 2021-05-26 10:20 ` [f2fs-dev] " Jan Kara 2021-05-26 13:42 ` Jan Kara 2021-05-26 13:42 ` [f2fs-dev] " Jan Kara 2021-05-25 13:50 ` [PATCH 08/13] xfs: Convert double locking of MMAPLOCK to use VFS helpers Jan Kara 2021-05-25 13:50 ` [f2fs-dev] " Jan Kara 2021-05-25 21:41 ` Darrick J. Wong 2021-05-25 21:41 ` [f2fs-dev] " Darrick J. Wong 2021-05-25 13:50 ` [PATCH 09/13] zonefs: Convert to using invalidate_lock Jan Kara 2021-05-25 13:50 ` [f2fs-dev] " Jan Kara 2021-05-25 13:50 ` [PATCH 10/13] f2fs: " Jan Kara 2021-05-25 13:50 ` [f2fs-dev] " Jan Kara 2021-05-26 9:55 ` Chao Yu 2021-05-26 9:55 ` [f2fs-dev] " Chao Yu 2021-05-25 13:50 ` [PATCH 11/13] fuse: " Jan Kara 2021-05-25 13:50 ` [f2fs-dev] " Jan Kara 2021-05-25 13:50 ` [PATCH 12/13] ceph: Fix race between hole punch and page fault Jan Kara 2021-05-25 13:50 ` [f2fs-dev] " Jan Kara 2021-05-25 13:50 ` [PATCH 13/13] cifs: " Jan Kara 2021-05-25 13:50 ` [f2fs-dev] " Jan Kara
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210526152525.GY202121@locust \ --to=djwong@kernel.org \ --cc=Damien.LeMoal@wdc.com \ --cc=ceph-devel@vger.kernel.org \ --cc=darrick.wong@oracle.com \ --cc=david@fromorbit.com \ --cc=hch@infradead.org \ --cc=jack@suse.cz \ --cc=jaegeuk@kernel.org \ --cc=jlayton@kernel.org \ --cc=jth@kernel.org \ --cc=linux-cifs@vger.kernel.org \ --cc=linux-ext4@vger.kernel.org \ --cc=linux-f2fs-devel@lists.sourceforge.net \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linux-xfs@vger.kernel.org \ --cc=miklos@szeredi.hu \ --cc=sfrench@samba.org \ --cc=tytso@mit.edu \ --cc=willy@infradead.org \ --cc=yuchao0@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.