From: Chao Yu <yuchao0@huawei.com>
To: Jan Kara <jack@suse.cz>, <linux-fsdevel@vger.kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Dave Chinner <david@fromorbit.com>, <ceph-devel@vger.kernel.org>,
Damien Le Moal <damien.lemoal@wdc.com>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
Jaegeuk Kim <jaegeuk@kernel.org>,
Jeff Layton <jlayton@kernel.org>,
Johannes Thumshirn <jth@kernel.org>, <linux-cifs@vger.kernel.org>,
<linux-ext4@vger.kernel.org>,
<linux-f2fs-devel@lists.sourceforge.net>, <linux-mm@kvack.org>,
<linux-xfs@vger.kernel.org>, Miklos Szeredi <miklos@szeredi.hu>,
Steve French <sfrench@samba.org>, Ted Tso <tytso@mit.edu>,
Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH 10/13] f2fs: Convert to using invalidate_lock
Date: Wed, 26 May 2021 17:55:05 +0800 [thread overview]
Message-ID: <eec8bd42-d874-93cf-23e2-b6c3997814ad@huawei.com> (raw)
In-Reply-To: <20210525135100.11221-10-jack@suse.cz>
On 2021/5/25 21:50, Jan Kara wrote:
> Use invalidate_lock instead of f2fs' private i_mmap_sem. The intended
> purpose is exactly the same. By this conversion we fix a long standing
> race between hole punching and read(2) / readahead(2) paths that can
> lead to stale page cache contents.
>
> CC: Jaegeuk Kim <jaegeuk@kernel.org>
> CC: Chao Yu <yuchao0@huawei.com>
> CC: linux-f2fs-devel@lists.sourceforge.net
> Signed-off-by: Jan Kara <jack@suse.cz>
Acked-by: Chao Yu <yuchao0@huawei.com>
Thanks,
WARNING: multiple messages have this Message-ID (diff)
From: Chao Yu <yuchao0@huawei.com>
To: Jan Kara <jack@suse.cz>, <linux-fsdevel@vger.kernel.org>
Cc: linux-cifs@vger.kernel.org,
Damien Le Moal <damien.lemoal@wdc.com>,
linux-ext4@vger.kernel.org, Ted Tso <tytso@mit.edu>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
Jeff Layton <jlayton@kernel.org>,
Steve French <sfrench@samba.org>,
Miklos Szeredi <miklos@szeredi.hu>,
Dave Chinner <david@fromorbit.com>,
Matthew Wilcox <willy@infradead.org>,
linux-f2fs-devel@lists.sourceforge.net,
Christoph Hellwig <hch@infradead.org>,
linux-mm@kvack.org, Jaegeuk Kim <jaegeuk@kernel.org>,
ceph-devel@vger.kernel.org, Johannes Thumshirn <jth@kernel.org>,
linux-xfs@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH 10/13] f2fs: Convert to using invalidate_lock
Date: Wed, 26 May 2021 17:55:05 +0800 [thread overview]
Message-ID: <eec8bd42-d874-93cf-23e2-b6c3997814ad@huawei.com> (raw)
In-Reply-To: <20210525135100.11221-10-jack@suse.cz>
On 2021/5/25 21:50, Jan Kara wrote:
> Use invalidate_lock instead of f2fs' private i_mmap_sem. The intended
> purpose is exactly the same. By this conversion we fix a long standing
> race between hole punching and read(2) / readahead(2) paths that can
> lead to stale page cache contents.
>
> CC: Jaegeuk Kim <jaegeuk@kernel.org>
> CC: Chao Yu <yuchao0@huawei.com>
> CC: linux-f2fs-devel@lists.sourceforge.net
> Signed-off-by: Jan Kara <jack@suse.cz>
Acked-by: Chao Yu <yuchao0@huawei.com>
Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2021-05-26 9:55 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 13:50 [PATCH 0/13 v6] fs: Hole punch vs page cache filling races Jan Kara
2021-05-25 13:50 ` [f2fs-dev] " Jan Kara
2021-05-25 13:50 ` [PATCH 01/13] mm: Fix comments mentioning i_mutex Jan Kara
2021-05-25 13:50 ` [f2fs-dev] " Jan Kara
2021-05-25 13:50 ` [PATCH 02/13] documentation: Sync file_operations members with reality Jan Kara
2021-05-25 13:50 ` [f2fs-dev] " Jan Kara
2021-05-25 20:43 ` Darrick J. Wong
2021-05-25 20:43 ` [f2fs-dev] " Darrick J. Wong
2021-05-25 13:50 ` [PATCH 03/13] mm: Protect operations adding pages to page cache with invalidate_lock Jan Kara
2021-05-25 13:50 ` [f2fs-dev] " Jan Kara
2021-05-25 21:01 ` Darrick J. Wong
2021-05-25 21:01 ` [f2fs-dev] " Darrick J. Wong
2021-05-26 10:00 ` Jan Kara
2021-05-26 10:00 ` [f2fs-dev] " Jan Kara
2021-05-25 13:50 ` [PATCH 04/13] mm: Add functions to lock invalidate_lock for two mappings Jan Kara
2021-05-25 13:50 ` [f2fs-dev] " Jan Kara
2021-05-25 20:48 ` Darrick J. Wong
2021-05-25 20:48 ` [f2fs-dev] " Darrick J. Wong
2021-05-26 10:07 ` Jan Kara
2021-05-26 10:07 ` [f2fs-dev] " Jan Kara
2021-05-26 12:11 ` Damien Le Moal
2021-05-26 12:11 ` [f2fs-dev] " Damien Le Moal
2021-05-26 12:11 ` Damien Le Moal
2021-05-26 13:45 ` Jan Kara
2021-05-26 13:45 ` [f2fs-dev] " Jan Kara
2021-05-26 13:45 ` Jan Kara
2021-05-26 15:25 ` Darrick J. Wong
2021-05-26 15:25 ` [f2fs-dev] " Darrick J. Wong
2021-05-26 15:25 ` Darrick J. Wong
2021-05-25 13:50 ` [PATCH 05/13] ext4: Convert to use mapping->invalidate_lock Jan Kara
2021-05-25 13:50 ` [f2fs-dev] " Jan Kara
2021-05-25 13:50 ` [PATCH 06/13] ext2: Convert to using invalidate_lock Jan Kara
2021-05-25 13:50 ` [f2fs-dev] " Jan Kara
2021-05-25 13:50 ` [PATCH 07/13] xfs: Convert to use invalidate_lock Jan Kara
2021-05-25 13:50 ` [f2fs-dev] " Jan Kara
2021-05-25 21:37 ` Darrick J. Wong
2021-05-25 21:37 ` [f2fs-dev] " Darrick J. Wong
2021-05-26 10:18 ` Jan Kara
2021-05-26 10:18 ` [f2fs-dev] " Jan Kara
2021-05-26 15:32 ` Darrick J. Wong
2021-05-26 15:32 ` [f2fs-dev] " Darrick J. Wong
2021-05-27 12:01 ` Jan Kara
2021-05-27 12:01 ` [f2fs-dev] " Jan Kara
2021-05-25 21:40 ` Dave Chinner
2021-05-25 21:40 ` [f2fs-dev] " Dave Chinner
2021-05-26 10:20 ` Jan Kara
2021-05-26 10:20 ` [f2fs-dev] " Jan Kara
2021-05-26 13:42 ` Jan Kara
2021-05-26 13:42 ` [f2fs-dev] " Jan Kara
2021-05-25 13:50 ` [PATCH 08/13] xfs: Convert double locking of MMAPLOCK to use VFS helpers Jan Kara
2021-05-25 13:50 ` [f2fs-dev] " Jan Kara
2021-05-25 21:41 ` Darrick J. Wong
2021-05-25 21:41 ` [f2fs-dev] " Darrick J. Wong
2021-05-25 13:50 ` [PATCH 09/13] zonefs: Convert to using invalidate_lock Jan Kara
2021-05-25 13:50 ` [f2fs-dev] " Jan Kara
2021-05-25 13:50 ` [PATCH 10/13] f2fs: " Jan Kara
2021-05-25 13:50 ` [f2fs-dev] " Jan Kara
2021-05-26 9:55 ` Chao Yu [this message]
2021-05-26 9:55 ` Chao Yu
2021-05-25 13:50 ` [PATCH 11/13] fuse: " Jan Kara
2021-05-25 13:50 ` [f2fs-dev] " Jan Kara
2021-05-25 13:50 ` [PATCH 12/13] ceph: Fix race between hole punch and page fault Jan Kara
2021-05-25 13:50 ` [f2fs-dev] " Jan Kara
2021-05-25 13:50 ` [PATCH 13/13] cifs: " Jan Kara
2021-05-25 13:50 ` [f2fs-dev] " Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eec8bd42-d874-93cf-23e2-b6c3997814ad@huawei.com \
--to=yuchao0@huawei.com \
--cc=ceph-devel@vger.kernel.org \
--cc=damien.lemoal@wdc.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=jaegeuk@kernel.org \
--cc=jlayton@kernel.org \
--cc=jth@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=sfrench@samba.org \
--cc=tytso@mit.edu \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.