From: Catalin Marinas <catalin.marinas@arm.com>
To: Shaokun Zhang <zhangshaokun@hisilicon.com>
Cc: linux-arm-kernel@lists.infradead.org,
Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Suzuki K Poulose <Suzuki.Poulose@arm.com>
Subject: Re: [PATCH 1/2] arm64: Change the cpuinfo_arm64 member type for some sysregs to u64
Date: Wed, 26 May 2021 17:07:32 +0100 [thread overview]
Message-ID: <20210526160732.GF19992@arm.com> (raw)
In-Reply-To: <99c5660c-fe45-144b-ce23-66ed644d10b3@hisilicon.com>
On Mon, May 24, 2021 at 09:31:24AM +0800, Shaokun Zhang wrote:
> On 2021/5/12 2:23, Catalin Marinas wrote:
> > diff --git a/arch/arm64/include/asm/cpu.h b/arch/arm64/include/asm/cpu.h
> > index 7faae6ff3ab4..fe5a8499ddc2 100644
> > --- a/arch/arm64/include/asm/cpu.h
> > +++ b/arch/arm64/include/asm/cpu.h
> > @@ -15,11 +15,11 @@
> > struct cpuinfo_arm64 {
> > struct cpu cpu;
> > struct kobject kobj;
> > - u32 reg_ctr;
> > - u32 reg_cntfrq;
> > - u32 reg_dczid;
> > - u32 reg_midr;
> > - u32 reg_revidr;
> > + u64 reg_ctr;
> > + u64 reg_cntfrq;
>
> One more question: is it ok to change the function prototype to u64 also?
> For CNTFRQ_EL0, if the Arm ARM expand the clock to more than 4GHz and it
> will also work this change (arch_timer and watchdog shall change at the
> the same time).
I think I'll keep cntfrq as u32. It matches the function prototype and
the arm32 code which shares the same driver. Also, from ARMv8.6, there's
a requirement that CNTFRQ_EL0 is standardised at 1GHz.
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-26 17:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 18:23 [PATCH 0/2] arm64: Taint the kernel on different GMID_EL1.BS Catalin Marinas
2021-05-11 18:23 ` [PATCH 1/2] arm64: Change the cpuinfo_arm64 member type for some sysregs to u64 Catalin Marinas
2021-05-12 13:29 ` Mark Rutland
2021-05-12 13:54 ` Suzuki K Poulose
2021-05-24 1:31 ` Shaokun Zhang
2021-05-26 16:07 ` Catalin Marinas [this message]
2021-05-11 18:23 ` [PATCH 2/2] arm64: Check if GMID_EL1.BS is the same on all CPUs Catalin Marinas
2021-05-12 13:33 ` Mark Rutland
2021-05-26 19:47 ` Jon Hunter
2021-05-26 19:47 ` Jon Hunter
2021-05-26 21:08 ` Will Deacon
2021-05-26 21:08 ` Will Deacon
2021-05-26 21:48 ` Catalin Marinas
2021-05-26 21:48 ` Catalin Marinas
2021-05-26 22:11 ` Jon Hunter
2021-05-26 22:11 ` Jon Hunter
2021-05-25 18:58 ` [PATCH 0/2] arm64: Taint the kernel on different GMID_EL1.BS Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210526160732.GF19992@arm.com \
--to=catalin.marinas@arm.com \
--cc=Suzuki.Poulose@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=will@kernel.org \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.