* [PATCH] pinctrl: single: Fix probe failure getting register area size
@ 2021-05-07 9:10 Vignesh Raghavendra
2021-05-17 20:15 ` Tom Rini
2021-05-27 11:41 ` Tom Rini
0 siblings, 2 replies; 4+ messages in thread
From: Vignesh Raghavendra @ 2021-05-07 9:10 UTC (permalink / raw)
To: u-boot
If reg property of pinctrl-single node requires address translation then
probe fails with following message:
single-pinctrl pinctrl at 4301c000: failed to get base register size
This is because driver uses dev_read_addr_size() to get size which also
tries to fetch untranslated addr and fails.
Fix this by using dev_read_addr_size_index() which takes care of address
translation and also makes following dev_read_addr() call redundant.
This fixes Ethernet failures on TI's AM654 based EVMs due to lack of
pinmux configuration.
Fixes: 9fd8a430f3 ("pinctrl: single: get register area size by device API")
Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
---
drivers/pinctrl/pinctrl-single.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c
index ebb7602dde..7af6c5f0b0 100644
--- a/drivers/pinctrl/pinctrl-single.c
+++ b/drivers/pinctrl/pinctrl-single.c
@@ -509,19 +509,13 @@ static int single_of_to_plat(struct udevice *dev)
return -EINVAL;
}
- addr = dev_read_addr_size(dev, "reg", &size);
+ addr = dev_read_addr_size_index(dev, 0, &size);
if (addr == FDT_ADDR_T_NONE) {
- dev_err(dev, "failed to get base register size\n");
+ dev_err(dev, "failed to get base register address\n");
return -EINVAL;
}
pdata->offset = size - pdata->width / BITS_PER_BYTE;
-
- addr = dev_read_addr(dev);
- if (addr == FDT_ADDR_T_NONE) {
- dev_dbg(dev, "no valid base register address\n");
- return -EINVAL;
- }
pdata->base = addr;
ret = dev_read_u32(dev, "pinctrl-single,function-mask", &pdata->mask);
--
2.31.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] pinctrl: single: Fix probe failure getting register area size
2021-05-07 9:10 [PATCH] pinctrl: single: Fix probe failure getting register area size Vignesh Raghavendra
@ 2021-05-17 20:15 ` Tom Rini
2021-05-18 16:16 ` Dario Binacchi
2021-05-27 11:41 ` Tom Rini
1 sibling, 1 reply; 4+ messages in thread
From: Tom Rini @ 2021-05-17 20:15 UTC (permalink / raw)
To: u-boot
On Fri, May 07, 2021 at 02:40:34PM +0530, Vignesh Raghavendra wrote:
> If reg property of pinctrl-single node requires address translation then
> probe fails with following message:
>
> single-pinctrl pinctrl at 4301c000: failed to get base register size
>
> This is because driver uses dev_read_addr_size() to get size which also
> tries to fetch untranslated addr and fails.
> Fix this by using dev_read_addr_size_index() which takes care of address
> translation and also makes following dev_read_addr() call redundant.
>
> This fixes Ethernet failures on TI's AM654 based EVMs due to lack of
> pinmux configuration.
>
> Fixes: 9fd8a430f3 ("pinctrl: single: get register area size by device API")
> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
> ---
> drivers/pinctrl/pinctrl-single.c | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c
> index ebb7602dde..7af6c5f0b0 100644
> --- a/drivers/pinctrl/pinctrl-single.c
> +++ b/drivers/pinctrl/pinctrl-single.c
> @@ -509,19 +509,13 @@ static int single_of_to_plat(struct udevice *dev)
> return -EINVAL;
> }
>
> - addr = dev_read_addr_size(dev, "reg", &size);
> + addr = dev_read_addr_size_index(dev, 0, &size);
> if (addr == FDT_ADDR_T_NONE) {
> - dev_err(dev, "failed to get base register size\n");
> + dev_err(dev, "failed to get base register address\n");
> return -EINVAL;
> }
>
> pdata->offset = size - pdata->width / BITS_PER_BYTE;
> -
> - addr = dev_read_addr(dev);
> - if (addr == FDT_ADDR_T_NONE) {
> - dev_dbg(dev, "no valid base register address\n");
> - return -EINVAL;
> - }
> pdata->base = addr;
>
> ret = dev_read_u32(dev, "pinctrl-single,function-mask", &pdata->mask);
Dario, since this has a fixes tag for a commit of yours, comments?
Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210517/b91caa00/attachment.sig>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] pinctrl: single: Fix probe failure getting register area size
2021-05-17 20:15 ` Tom Rini
@ 2021-05-18 16:16 ` Dario Binacchi
0 siblings, 0 replies; 4+ messages in thread
From: Dario Binacchi @ 2021-05-18 16:16 UTC (permalink / raw)
To: u-boot
Hi,
> Il 17/05/2021 22:15 Tom Rini <trini@konsulko.com> ha scritto:
>
>
> On Fri, May 07, 2021 at 02:40:34PM +0530, Vignesh Raghavendra wrote:
>
> > If reg property of pinctrl-single node requires address translation then
> > probe fails with following message:
> >
> > single-pinctrl pinctrl at 4301c000: failed to get base register size
> >
> > This is because driver uses dev_read_addr_size() to get size which also
> > tries to fetch untranslated addr and fails.
> > Fix this by using dev_read_addr_size_index() which takes care of address
> > translation and also makes following dev_read_addr() call redundant.
> >
> > This fixes Ethernet failures on TI's AM654 based EVMs due to lack of
> > pinmux configuration.
> >
> > Fixes: 9fd8a430f3 ("pinctrl: single: get register area size by device API")
> > Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
> > ---
> > drivers/pinctrl/pinctrl-single.c | 10 ++--------
> > 1 file changed, 2 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c
> > index ebb7602dde..7af6c5f0b0 100644
> > --- a/drivers/pinctrl/pinctrl-single.c
> > +++ b/drivers/pinctrl/pinctrl-single.c
> > @@ -509,19 +509,13 @@ static int single_of_to_plat(struct udevice *dev)
> > return -EINVAL;
> > }
> >
> > - addr = dev_read_addr_size(dev, "reg", &size);
> > + addr = dev_read_addr_size_index(dev, 0, &size);
> > if (addr == FDT_ADDR_T_NONE) {
> > - dev_err(dev, "failed to get base register size\n");
> > + dev_err(dev, "failed to get base register address\n");
> > return -EINVAL;
> > }
> >
> > pdata->offset = size - pdata->width / BITS_PER_BYTE;
> > -
> > - addr = dev_read_addr(dev);
> > - if (addr == FDT_ADDR_T_NONE) {
> > - dev_dbg(dev, "no valid base register address\n");
> > - return -EINVAL;
> > - }
> > pdata->base = addr;
> >
> > ret = dev_read_u32(dev, "pinctrl-single,function-mask", &pdata->mask);
>
> Dario, since this has a fixes tag for a commit of yours, comments?
> Thanks!
>
I applied the patch and tested it on my beaglebone black.
It is OK. As well the tests I had developed in the sandbox configuration for pinmux passed.
Thanks and regards,
Dario
> --
> Tom
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pinctrl: single: Fix probe failure getting register area size
2021-05-07 9:10 [PATCH] pinctrl: single: Fix probe failure getting register area size Vignesh Raghavendra
2021-05-17 20:15 ` Tom Rini
@ 2021-05-27 11:41 ` Tom Rini
1 sibling, 0 replies; 4+ messages in thread
From: Tom Rini @ 2021-05-27 11:41 UTC (permalink / raw)
To: Vignesh Raghavendra; +Cc: Lokesh Vutla, Dario Binacchi, u-boot
[-- Attachment #1: Type: text/plain, Size: 823 bytes --]
On Fri, May 07, 2021 at 02:40:34PM +0530, Vignesh Raghavendra wrote:
> If reg property of pinctrl-single node requires address translation then
> probe fails with following message:
>
> single-pinctrl pinctrl@4301c000: failed to get base register size
>
> This is because driver uses dev_read_addr_size() to get size which also
> tries to fetch untranslated addr and fails.
> Fix this by using dev_read_addr_size_index() which takes care of address
> translation and also makes following dev_read_addr() call redundant.
>
> This fixes Ethernet failures on TI's AM654 based EVMs due to lack of
> pinmux configuration.
>
> Fixes: 9fd8a430f3 ("pinctrl: single: get register area size by device API")
> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-27 11:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-07 9:10 [PATCH] pinctrl: single: Fix probe failure getting register area size Vignesh Raghavendra
2021-05-17 20:15 ` Tom Rini
2021-05-18 16:16 ` Dario Binacchi
2021-05-27 11:41 ` Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.