From: Rudi Heitbaum <rudi@heitbaum.com> To: Ezequiel Garcia <ezequiel@collabora.com> Cc: Peter Geis <pgwipeout@gmail.com>, devicetree@vger.kernel.org, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, "open list:ARM/Rockchip SoC..." <linux-rockchip@lists.infradead.org>, Mark Brown <broonie@kernel.org>, chenjh@rock-chips.com Subject: Re: [PATCH] regulator: fan53555: add back tcs4526 Date: Thu, 27 May 2021 12:29:15 +0000 [thread overview] Message-ID: <20210527122911.GA1640@7698f5da3a10> (raw) In-Reply-To: <462b8d80447efb6c00e93704914169bceb5adc4d.camel@collabora.com> Hi Ezequiel and Peter, Thanks for the feedback. On Thu, May 27, 2021 at 08:51:27AM -0300, Ezequiel Garcia wrote: > Hi Rudi, > > Thanks for the patch. > > On Thu, 2021-05-27 at 10:59 +0000, Rudi Heitbaum wrote: > > On Wed, May 26, 2021 at 02:41:00PM -0400, Peter Geis wrote: > > > On Wed, May 26, 2021 at 12:23 PM Rudi Heitbaum <rudi@heitbaum.com> wrote: ... > > I chose to follow the example of silergy,syr827 and silergy,syr828 for > > tcs4526 (given I made the mistake in assuming that support for tcs4525 > > meant support for tcs4525.) This would maintain consistency of naming > > of > > tcs4526 throughout the source. Is that ok? > > It's fine to have both compatibles (and avoids confusion in > device-trees), just remember to update the dt-bindings as well. > It's funny to see drivers with both schemes, so we really have to > decide which path we want to go down. > Considering the syr827/syr828 as convention, we should probably just > go down that route for consistency within the driver. Thanks Peter - I will resubmit the tcs4526 patch along these lines. > > Removal of the operating points kind of makes the gpu regulator > > moot, don't you think? > As Peter rightly said, this will prevent gpu devfreq from working. This is the draft that I have been working on within LibreELEC10, still a ways to go I'm afraid. Having decided to getting the SBC to run mainline kernel and u-boot. The regulator and subsequent regulator fix will hopefully address https://bugzilla.kernel.org/show_bug.cgi?id=212917 too. As you have identified - it is not ready for upstreaming :-) Thank you both for the direction and pointers on the dts. I will get the v2 patch going first. > Out of curiosity, why disabling the little VOP? Only disabled within my WIP dts so as to focus my attention on successful running of LE10 on the rk3399pro, before I move to attempting to enable the NPU and the other nodes. > I can be wrong, but I think regulator-compatible is deprecated. I will look it to this. Now with the addition of the regulator and Peter's fix I will start qualifing each of the dts nodes and the correct options against the schematic. > > +??????????????????????????????vsel-gpios = <&gpio1 RK_PC1 GPIO_ACTIVE_HIGH>; > > Is vsel-gpios ever used in the mainline driver? > > > +??????????????????????????????regulator-compatible = "fan53555-reg"; > > Ditto. > > > +??????????????????????????????vsel-gpios = <&gpio1 RK_PB6 GPIO_ACTIVE_HIGH>; > > Ditto. > > > +??????????????????????????????regulator-boot-on; > > Just out of curiosity, is regulator-boot-on really needed for the GPU? Will check.
WARNING: multiple messages have this Message-ID (diff)
From: Rudi Heitbaum <rudi@heitbaum.com> To: Ezequiel Garcia <ezequiel@collabora.com> Cc: Peter Geis <pgwipeout@gmail.com>, devicetree@vger.kernel.org, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, "open list:ARM/Rockchip SoC..." <linux-rockchip@lists.infradead.org>, Mark Brown <broonie@kernel.org>, chenjh@rock-chips.com Subject: Re: [PATCH] regulator: fan53555: add back tcs4526 Date: Thu, 27 May 2021 12:29:15 +0000 [thread overview] Message-ID: <20210527122911.GA1640@7698f5da3a10> (raw) In-Reply-To: <462b8d80447efb6c00e93704914169bceb5adc4d.camel@collabora.com> Hi Ezequiel and Peter, Thanks for the feedback. On Thu, May 27, 2021 at 08:51:27AM -0300, Ezequiel Garcia wrote: > Hi Rudi, > > Thanks for the patch. > > On Thu, 2021-05-27 at 10:59 +0000, Rudi Heitbaum wrote: > > On Wed, May 26, 2021 at 02:41:00PM -0400, Peter Geis wrote: > > > On Wed, May 26, 2021 at 12:23 PM Rudi Heitbaum <rudi@heitbaum.com> wrote: ... > > I chose to follow the example of silergy,syr827 and silergy,syr828 for > > tcs4526 (given I made the mistake in assuming that support for tcs4525 > > meant support for tcs4525.) This would maintain consistency of naming > > of > > tcs4526 throughout the source. Is that ok? > > It's fine to have both compatibles (and avoids confusion in > device-trees), just remember to update the dt-bindings as well. > It's funny to see drivers with both schemes, so we really have to > decide which path we want to go down. > Considering the syr827/syr828 as convention, we should probably just > go down that route for consistency within the driver. Thanks Peter - I will resubmit the tcs4526 patch along these lines. > > Removal of the operating points kind of makes the gpu regulator > > moot, don't you think? > As Peter rightly said, this will prevent gpu devfreq from working. This is the draft that I have been working on within LibreELEC10, still a ways to go I'm afraid. Having decided to getting the SBC to run mainline kernel and u-boot. The regulator and subsequent regulator fix will hopefully address https://bugzilla.kernel.org/show_bug.cgi?id=212917 too. As you have identified - it is not ready for upstreaming :-) Thank you both for the direction and pointers on the dts. I will get the v2 patch going first. > Out of curiosity, why disabling the little VOP? Only disabled within my WIP dts so as to focus my attention on successful running of LE10 on the rk3399pro, before I move to attempting to enable the NPU and the other nodes. > I can be wrong, but I think regulator-compatible is deprecated. I will look it to this. Now with the addition of the regulator and Peter's fix I will start qualifing each of the dts nodes and the correct options against the schematic. > > +??????????????????????????????vsel-gpios = <&gpio1 RK_PC1 GPIO_ACTIVE_HIGH>; > > Is vsel-gpios ever used in the mainline driver? > > > +??????????????????????????????regulator-compatible = "fan53555-reg"; > > Ditto. > > > +??????????????????????????????vsel-gpios = <&gpio1 RK_PB6 GPIO_ACTIVE_HIGH>; > > Ditto. > > > +??????????????????????????????regulator-boot-on; > > Just out of curiosity, is regulator-boot-on really needed for the GPU? Will check. _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2021-05-27 12:29 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-26 16:23 [PATCH] regulator: fan53555: add back tcs4526 Rudi Heitbaum 2021-05-26 16:23 ` Rudi Heitbaum 2021-05-26 18:41 ` Peter Geis 2021-05-26 18:41 ` Peter Geis 2021-05-27 10:59 ` Rudi Heitbaum 2021-05-27 10:59 ` Rudi Heitbaum 2021-05-27 11:26 ` Peter Geis 2021-05-27 11:26 ` Peter Geis 2021-05-27 13:03 ` Mark Brown 2021-05-27 13:03 ` Mark Brown 2021-05-27 11:51 ` Ezequiel Garcia 2021-05-27 11:51 ` Ezequiel Garcia 2021-05-27 12:29 ` Rudi Heitbaum [this message] 2021-05-27 12:29 ` Rudi Heitbaum 2021-05-27 13:05 ` Mark Brown 2021-05-27 13:05 ` Mark Brown 2021-05-28 10:27 ` Rudi Heitbaum 2021-05-28 10:27 ` Rudi Heitbaum 2021-05-28 10:19 ` [PATCH v2] regulator: fan53555: add tcs4526 Rudi Heitbaum 2021-05-28 10:19 ` Rudi Heitbaum 2021-06-01 12:56 ` Mark Brown 2021-06-01 12:56 ` Mark Brown 2021-06-04 16:32 ` Mark Brown 2021-06-04 16:32 ` Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210527122911.GA1640@7698f5da3a10 \ --to=rudi@heitbaum.com \ --cc=broonie@kernel.org \ --cc=chenjh@rock-chips.com \ --cc=devicetree@vger.kernel.org \ --cc=ezequiel@collabora.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=pgwipeout@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.