From: Mark Brown <broonie@kernel.org>
To: Ezequiel Garcia <ezequiel@collabora.com>
Cc: Rudi Heitbaum <rudi@heitbaum.com>,
Peter Geis <pgwipeout@gmail.com>,
devicetree@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
chenjh@rock-chips.com
Subject: Re: [PATCH] regulator: fan53555: add back tcs4526
Date: Thu, 27 May 2021 14:05:53 +0100 [thread overview]
Message-ID: <YK+ZMdD+7uqQwCow@sirena.org.uk> (raw)
In-Reply-To: <462b8d80447efb6c00e93704914169bceb5adc4d.camel@collabora.com>
[-- Attachment #1: Type: text/plain, Size: 951 bytes --]
On Thu, May 27, 2021 at 08:51:27AM -0300, Ezequiel Garcia wrote:
> On Thu, 2021-05-27 at 10:59 +0000, Rudi Heitbaum wrote:
> > + reg = <0x1c>;
> > + vin-supply = <&vcc5v0_sys>;
> > + regulator-compatible = "fan53555-reg";
> I can be wrong, but I think regulator-compatible is deprecated.
Yes.
> > + regulator-ramp-delay = <1000>;
> > + fcs,suspend-voltage-selector = <1>;
> > + regulator-always-on;
> > + regulator-boot-on;
> Just out of curiosity, is regulator-boot-on really needed for the GPU?
It should only be used if it's not possible to read the state of
the regulator enable from the hardware.
Please delete unneeded context from mails when replying. Doing this
makes it much easier to find your reply in the message, helping ensure
it won't be missed by people scrolling through the irrelevant quoted
material.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Ezequiel Garcia <ezequiel@collabora.com>
Cc: Rudi Heitbaum <rudi@heitbaum.com>,
Peter Geis <pgwipeout@gmail.com>,
devicetree@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
chenjh@rock-chips.com
Subject: Re: [PATCH] regulator: fan53555: add back tcs4526
Date: Thu, 27 May 2021 14:05:53 +0100 [thread overview]
Message-ID: <YK+ZMdD+7uqQwCow@sirena.org.uk> (raw)
In-Reply-To: <462b8d80447efb6c00e93704914169bceb5adc4d.camel@collabora.com>
[-- Attachment #1.1: Type: text/plain, Size: 951 bytes --]
On Thu, May 27, 2021 at 08:51:27AM -0300, Ezequiel Garcia wrote:
> On Thu, 2021-05-27 at 10:59 +0000, Rudi Heitbaum wrote:
> > + reg = <0x1c>;
> > + vin-supply = <&vcc5v0_sys>;
> > + regulator-compatible = "fan53555-reg";
> I can be wrong, but I think regulator-compatible is deprecated.
Yes.
> > + regulator-ramp-delay = <1000>;
> > + fcs,suspend-voltage-selector = <1>;
> > + regulator-always-on;
> > + regulator-boot-on;
> Just out of curiosity, is regulator-boot-on really needed for the GPU?
It should only be used if it's not possible to read the state of
the regulator enable from the hardware.
Please delete unneeded context from mails when replying. Doing this
makes it much easier to find your reply in the message, helping ensure
it won't be missed by people scrolling through the irrelevant quoted
material.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2021-05-27 13:06 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 16:23 [PATCH] regulator: fan53555: add back tcs4526 Rudi Heitbaum
2021-05-26 16:23 ` Rudi Heitbaum
2021-05-26 18:41 ` Peter Geis
2021-05-26 18:41 ` Peter Geis
2021-05-27 10:59 ` Rudi Heitbaum
2021-05-27 10:59 ` Rudi Heitbaum
2021-05-27 11:26 ` Peter Geis
2021-05-27 11:26 ` Peter Geis
2021-05-27 13:03 ` Mark Brown
2021-05-27 13:03 ` Mark Brown
2021-05-27 11:51 ` Ezequiel Garcia
2021-05-27 11:51 ` Ezequiel Garcia
2021-05-27 12:29 ` Rudi Heitbaum
2021-05-27 12:29 ` Rudi Heitbaum
2021-05-27 13:05 ` Mark Brown [this message]
2021-05-27 13:05 ` Mark Brown
2021-05-28 10:27 ` Rudi Heitbaum
2021-05-28 10:27 ` Rudi Heitbaum
2021-05-28 10:19 ` [PATCH v2] regulator: fan53555: add tcs4526 Rudi Heitbaum
2021-05-28 10:19 ` Rudi Heitbaum
2021-06-01 12:56 ` Mark Brown
2021-06-01 12:56 ` Mark Brown
2021-06-04 16:32 ` Mark Brown
2021-06-04 16:32 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YK+ZMdD+7uqQwCow@sirena.org.uk \
--to=broonie@kernel.org \
--cc=chenjh@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=ezequiel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=pgwipeout@gmail.com \
--cc=rudi@heitbaum.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.