* [PATCH v2 0/2] GPD Win Max display fixes @ 2021-05-31 20:46 ` Anisse Astier 0 siblings, 0 replies; 18+ messages in thread From: Anisse Astier @ 2021-05-31 20:46 UTC (permalink / raw) To: intel-gfx, dri-devel Cc: Jani Nikula, Hans de Goede, Uma Shankar, Anisse Astier This patch series is for making the GPD Win Max display usable with Linux. The GPD Win Max is a small laptop, and its eDP panel does not send an EDID over DPCD; the EDID is instead available in the intel opregion, in mailbox #5 [1] The first patch is based on Jani's patch series [2] adding support for the opregion, with changes. I've changed authorship, but I'd be glad to revert it The second patch is just to fix the orientation of the panel. Changes since v1: - rebased on drm-tip - squashed patch 1 & 2 - picked up Reviewed-by from Hans de Goede (thanks for the review) [1]: https://gitlab.freedesktop.org/drm/intel/-/issues/3454 [2]: https://patchwork.kernel.org/project/intel-gfx/patch/20200828061941.17051-1-jani.nikula@intel.com/ Anisse Astier (2): drm/i915/opregion: add support for mailbox #5 EDID drm: Add orientation quirk for GPD Win Max .../gpu/drm/drm_panel_orientation_quirks.c | 6 ++ drivers/gpu/drm/i915/display/intel_dp.c | 3 + drivers/gpu/drm/i915/display/intel_opregion.c | 69 ++++++++++++++++++- drivers/gpu/drm/i915/display/intel_opregion.h | 8 +++ 4 files changed, 85 insertions(+), 1 deletion(-) -- 2.31.1 ^ permalink raw reply [flat|nested] 18+ messages in thread
* [Intel-gfx] [PATCH v2 0/2] GPD Win Max display fixes @ 2021-05-31 20:46 ` Anisse Astier 0 siblings, 0 replies; 18+ messages in thread From: Anisse Astier @ 2021-05-31 20:46 UTC (permalink / raw) To: intel-gfx, dri-devel; +Cc: Jani Nikula This patch series is for making the GPD Win Max display usable with Linux. The GPD Win Max is a small laptop, and its eDP panel does not send an EDID over DPCD; the EDID is instead available in the intel opregion, in mailbox #5 [1] The first patch is based on Jani's patch series [2] adding support for the opregion, with changes. I've changed authorship, but I'd be glad to revert it The second patch is just to fix the orientation of the panel. Changes since v1: - rebased on drm-tip - squashed patch 1 & 2 - picked up Reviewed-by from Hans de Goede (thanks for the review) [1]: https://gitlab.freedesktop.org/drm/intel/-/issues/3454 [2]: https://patchwork.kernel.org/project/intel-gfx/patch/20200828061941.17051-1-jani.nikula@intel.com/ Anisse Astier (2): drm/i915/opregion: add support for mailbox #5 EDID drm: Add orientation quirk for GPD Win Max .../gpu/drm/drm_panel_orientation_quirks.c | 6 ++ drivers/gpu/drm/i915/display/intel_dp.c | 3 + drivers/gpu/drm/i915/display/intel_opregion.c | 69 ++++++++++++++++++- drivers/gpu/drm/i915/display/intel_opregion.h | 8 +++ 4 files changed, 85 insertions(+), 1 deletion(-) -- 2.31.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH v2 1/2] drm/i915/opregion: add support for mailbox #5 EDID 2021-05-31 20:46 ` [Intel-gfx] " Anisse Astier @ 2021-05-31 20:46 ` Anisse Astier -1 siblings, 0 replies; 18+ messages in thread From: Anisse Astier @ 2021-05-31 20:46 UTC (permalink / raw) To: intel-gfx, dri-devel Cc: Jani Nikula, Hans de Goede, Uma Shankar, Anisse Astier The ACPI OpRegion Mailbox #5 ASLE extension may contain an EDID to be used for the embedded display. Add support for using it via by adding the EDID to the list of available modes on the connector, and use it for eDP when available. If a panel's EDID is broken, there may be an override EDID set in the ACPI OpRegion mailbox #5. Use it if available. Fixes the GPD Win Max display. Based on original patch series by: Jani Nikula <jani.nikula@intel.com> https://patchwork.kernel.org/project/intel-gfx/patch/20200828061941.17051-1-jani.nikula@intel.com/ Changes: - EDID is copied and validated with drm_edid_is_valid - Mode is now added via drm_add_edid_modes instead of using override mechanism - squashed the two patches Cc: Jani Nikula <jani.nikula@intel.com> Cc: Uma Shankar <uma.shankar@intel.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Signed-off-by: Anisse Astier <anisse@astier.eu> --- drivers/gpu/drm/i915/display/intel_dp.c | 3 + drivers/gpu/drm/i915/display/intel_opregion.c | 69 ++++++++++++++++++- drivers/gpu/drm/i915/display/intel_opregion.h | 8 +++ 3 files changed, 79 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c index 5c9222283044..43fb485c0e02 100644 --- a/drivers/gpu/drm/i915/display/intel_dp.c +++ b/drivers/gpu/drm/i915/display/intel_dp.c @@ -5191,6 +5191,9 @@ static bool intel_edp_init_connector(struct intel_dp *intel_dp, goto out_vdd_off; } + /* Set up override EDID, if any, from ACPI OpRegion */ + intel_opregion_edid_probe(intel_connector); + mutex_lock(&dev->mode_config.mutex); edid = drm_get_edid(connector, &intel_dp->aux.ddc); if (edid) { diff --git a/drivers/gpu/drm/i915/display/intel_opregion.c b/drivers/gpu/drm/i915/display/intel_opregion.c index dfd724e506b5..ef8d38f041eb 100644 --- a/drivers/gpu/drm/i915/display/intel_opregion.c +++ b/drivers/gpu/drm/i915/display/intel_opregion.c @@ -196,6 +196,8 @@ struct opregion_asle_ext { #define ASLE_IUER_WINDOWS_BTN (1 << 1) #define ASLE_IUER_POWER_BTN (1 << 0) +#define ASLE_PHED_EDID_VALID_MASK 0x3 + /* Software System Control Interrupt (SWSCI) */ #define SWSCI_SCIC_INDICATOR (1 << 0) #define SWSCI_SCIC_MAIN_FUNCTION_SHIFT 1 @@ -909,8 +911,10 @@ int intel_opregion_setup(struct drm_i915_private *dev_priv) opregion->asle->ardy = ASLE_ARDY_NOT_READY; } - if (mboxes & MBOX_ASLE_EXT) + if (mboxes & MBOX_ASLE_EXT) { drm_dbg(&dev_priv->drm, "ASLE extension supported\n"); + opregion->asle_ext = base + OPREGION_ASLE_EXT_OFFSET; + } if (intel_load_vbt_firmware(dev_priv) == 0) goto out; @@ -1037,6 +1041,68 @@ intel_opregion_get_panel_type(struct drm_i915_private *dev_priv) return ret - 1; } +/** + * intel_opregion_edid_probe - Add EDID from ACPI OpRegion mailbox #5 + * @intel_connector: eDP connector + * + * This reads the ACPI Opregion mailbox #5 to extract the EDID that is passed + * to it. + * + * Will take a lock on the DRM mode_config to add the EDID; make sure it isn't + * called with lock taken. + * + */ +void intel_opregion_edid_probe(struct intel_connector *intel_connector) +{ + struct drm_connector *connector = &intel_connector->base; + struct drm_i915_private *i915 = to_i915(connector->dev); + struct intel_opregion *opregion = &i915->opregion; + const void *in_edid; + const struct edid *edid; + struct edid *new_edid; + int len, ret, num; + + if (!opregion->asle_ext || connector->override_edid) + return; + + in_edid = opregion->asle_ext->bddc; + + /* Validity corresponds to number of 128-byte blocks */ + len = (opregion->asle_ext->phed & ASLE_PHED_EDID_VALID_MASK) * 128; + if (!len || !memchr_inv(in_edid, 0, len)) + return; + + edid = in_edid; + + if (len < EDID_LENGTH * (1 + edid->extensions)) { + drm_dbg_kms(&i915->drm, "Invalid EDID in ACPI OpRegion (Mailbox #5)\n"); + return; + } + new_edid = drm_edid_duplicate(edid); + if (!new_edid) { + drm_err(&i915->drm, "Cannot duplicate EDID\n"); + return; + } + if (!drm_edid_is_valid(new_edid)) { + kfree(new_edid); + drm_dbg_kms(&i915->drm, "Cannot validate EDID in ACPI OpRegion (Mailbox #5)\n"); + return; + } + + ret = drm_connector_update_edid_property(connector, new_edid); + if (ret) { + kfree(new_edid); + return; + } + + mutex_lock(&connector->dev->mode_config.mutex); + num = drm_add_edid_modes(connector, new_edid); + mutex_unlock(&connector->dev->mode_config.mutex); + + drm_dbg_kms(&i915->drm, "Using OpRegion EDID for [CONNECTOR:%d:%s], added %d mode(s)\n", + connector->base.id, connector->name, num); +} + void intel_opregion_register(struct drm_i915_private *i915) { struct intel_opregion *opregion = &i915->opregion; @@ -1127,6 +1193,7 @@ void intel_opregion_unregister(struct drm_i915_private *i915) opregion->acpi = NULL; opregion->swsci = NULL; opregion->asle = NULL; + opregion->asle_ext = NULL; opregion->vbt = NULL; opregion->lid_state = NULL; } diff --git a/drivers/gpu/drm/i915/display/intel_opregion.h b/drivers/gpu/drm/i915/display/intel_opregion.h index 4aa68ffbd30e..c1ecfcbb6f55 100644 --- a/drivers/gpu/drm/i915/display/intel_opregion.h +++ b/drivers/gpu/drm/i915/display/intel_opregion.h @@ -29,12 +29,14 @@ #include <linux/pci.h> struct drm_i915_private; +struct intel_connector; struct intel_encoder; struct opregion_header; struct opregion_acpi; struct opregion_swsci; struct opregion_asle; +struct opregion_asle_ext; struct intel_opregion { struct opregion_header *header; @@ -43,6 +45,7 @@ struct intel_opregion { u32 swsci_gbda_sub_functions; u32 swsci_sbcb_sub_functions; struct opregion_asle *asle; + struct opregion_asle_ext *asle_ext; void *rvda; void *vbt_firmware; const void *vbt; @@ -71,6 +74,7 @@ int intel_opregion_notify_encoder(struct intel_encoder *intel_encoder, int intel_opregion_notify_adapter(struct drm_i915_private *dev_priv, pci_power_t state); int intel_opregion_get_panel_type(struct drm_i915_private *dev_priv); +void intel_opregion_edid_probe(struct intel_connector *connector); #else /* CONFIG_ACPI*/ @@ -117,6 +121,10 @@ static inline int intel_opregion_get_panel_type(struct drm_i915_private *dev) return -ENODEV; } +void intel_opregion_edid_probe(struct intel_connector *connector) +{ +} + #endif /* CONFIG_ACPI */ #endif -- 2.31.1 ^ permalink raw reply related [flat|nested] 18+ messages in thread
* [Intel-gfx] [PATCH v2 1/2] drm/i915/opregion: add support for mailbox #5 EDID @ 2021-05-31 20:46 ` Anisse Astier 0 siblings, 0 replies; 18+ messages in thread From: Anisse Astier @ 2021-05-31 20:46 UTC (permalink / raw) To: intel-gfx, dri-devel; +Cc: Jani Nikula The ACPI OpRegion Mailbox #5 ASLE extension may contain an EDID to be used for the embedded display. Add support for using it via by adding the EDID to the list of available modes on the connector, and use it for eDP when available. If a panel's EDID is broken, there may be an override EDID set in the ACPI OpRegion mailbox #5. Use it if available. Fixes the GPD Win Max display. Based on original patch series by: Jani Nikula <jani.nikula@intel.com> https://patchwork.kernel.org/project/intel-gfx/patch/20200828061941.17051-1-jani.nikula@intel.com/ Changes: - EDID is copied and validated with drm_edid_is_valid - Mode is now added via drm_add_edid_modes instead of using override mechanism - squashed the two patches Cc: Jani Nikula <jani.nikula@intel.com> Cc: Uma Shankar <uma.shankar@intel.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Signed-off-by: Anisse Astier <anisse@astier.eu> --- drivers/gpu/drm/i915/display/intel_dp.c | 3 + drivers/gpu/drm/i915/display/intel_opregion.c | 69 ++++++++++++++++++- drivers/gpu/drm/i915/display/intel_opregion.h | 8 +++ 3 files changed, 79 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c index 5c9222283044..43fb485c0e02 100644 --- a/drivers/gpu/drm/i915/display/intel_dp.c +++ b/drivers/gpu/drm/i915/display/intel_dp.c @@ -5191,6 +5191,9 @@ static bool intel_edp_init_connector(struct intel_dp *intel_dp, goto out_vdd_off; } + /* Set up override EDID, if any, from ACPI OpRegion */ + intel_opregion_edid_probe(intel_connector); + mutex_lock(&dev->mode_config.mutex); edid = drm_get_edid(connector, &intel_dp->aux.ddc); if (edid) { diff --git a/drivers/gpu/drm/i915/display/intel_opregion.c b/drivers/gpu/drm/i915/display/intel_opregion.c index dfd724e506b5..ef8d38f041eb 100644 --- a/drivers/gpu/drm/i915/display/intel_opregion.c +++ b/drivers/gpu/drm/i915/display/intel_opregion.c @@ -196,6 +196,8 @@ struct opregion_asle_ext { #define ASLE_IUER_WINDOWS_BTN (1 << 1) #define ASLE_IUER_POWER_BTN (1 << 0) +#define ASLE_PHED_EDID_VALID_MASK 0x3 + /* Software System Control Interrupt (SWSCI) */ #define SWSCI_SCIC_INDICATOR (1 << 0) #define SWSCI_SCIC_MAIN_FUNCTION_SHIFT 1 @@ -909,8 +911,10 @@ int intel_opregion_setup(struct drm_i915_private *dev_priv) opregion->asle->ardy = ASLE_ARDY_NOT_READY; } - if (mboxes & MBOX_ASLE_EXT) + if (mboxes & MBOX_ASLE_EXT) { drm_dbg(&dev_priv->drm, "ASLE extension supported\n"); + opregion->asle_ext = base + OPREGION_ASLE_EXT_OFFSET; + } if (intel_load_vbt_firmware(dev_priv) == 0) goto out; @@ -1037,6 +1041,68 @@ intel_opregion_get_panel_type(struct drm_i915_private *dev_priv) return ret - 1; } +/** + * intel_opregion_edid_probe - Add EDID from ACPI OpRegion mailbox #5 + * @intel_connector: eDP connector + * + * This reads the ACPI Opregion mailbox #5 to extract the EDID that is passed + * to it. + * + * Will take a lock on the DRM mode_config to add the EDID; make sure it isn't + * called with lock taken. + * + */ +void intel_opregion_edid_probe(struct intel_connector *intel_connector) +{ + struct drm_connector *connector = &intel_connector->base; + struct drm_i915_private *i915 = to_i915(connector->dev); + struct intel_opregion *opregion = &i915->opregion; + const void *in_edid; + const struct edid *edid; + struct edid *new_edid; + int len, ret, num; + + if (!opregion->asle_ext || connector->override_edid) + return; + + in_edid = opregion->asle_ext->bddc; + + /* Validity corresponds to number of 128-byte blocks */ + len = (opregion->asle_ext->phed & ASLE_PHED_EDID_VALID_MASK) * 128; + if (!len || !memchr_inv(in_edid, 0, len)) + return; + + edid = in_edid; + + if (len < EDID_LENGTH * (1 + edid->extensions)) { + drm_dbg_kms(&i915->drm, "Invalid EDID in ACPI OpRegion (Mailbox #5)\n"); + return; + } + new_edid = drm_edid_duplicate(edid); + if (!new_edid) { + drm_err(&i915->drm, "Cannot duplicate EDID\n"); + return; + } + if (!drm_edid_is_valid(new_edid)) { + kfree(new_edid); + drm_dbg_kms(&i915->drm, "Cannot validate EDID in ACPI OpRegion (Mailbox #5)\n"); + return; + } + + ret = drm_connector_update_edid_property(connector, new_edid); + if (ret) { + kfree(new_edid); + return; + } + + mutex_lock(&connector->dev->mode_config.mutex); + num = drm_add_edid_modes(connector, new_edid); + mutex_unlock(&connector->dev->mode_config.mutex); + + drm_dbg_kms(&i915->drm, "Using OpRegion EDID for [CONNECTOR:%d:%s], added %d mode(s)\n", + connector->base.id, connector->name, num); +} + void intel_opregion_register(struct drm_i915_private *i915) { struct intel_opregion *opregion = &i915->opregion; @@ -1127,6 +1193,7 @@ void intel_opregion_unregister(struct drm_i915_private *i915) opregion->acpi = NULL; opregion->swsci = NULL; opregion->asle = NULL; + opregion->asle_ext = NULL; opregion->vbt = NULL; opregion->lid_state = NULL; } diff --git a/drivers/gpu/drm/i915/display/intel_opregion.h b/drivers/gpu/drm/i915/display/intel_opregion.h index 4aa68ffbd30e..c1ecfcbb6f55 100644 --- a/drivers/gpu/drm/i915/display/intel_opregion.h +++ b/drivers/gpu/drm/i915/display/intel_opregion.h @@ -29,12 +29,14 @@ #include <linux/pci.h> struct drm_i915_private; +struct intel_connector; struct intel_encoder; struct opregion_header; struct opregion_acpi; struct opregion_swsci; struct opregion_asle; +struct opregion_asle_ext; struct intel_opregion { struct opregion_header *header; @@ -43,6 +45,7 @@ struct intel_opregion { u32 swsci_gbda_sub_functions; u32 swsci_sbcb_sub_functions; struct opregion_asle *asle; + struct opregion_asle_ext *asle_ext; void *rvda; void *vbt_firmware; const void *vbt; @@ -71,6 +74,7 @@ int intel_opregion_notify_encoder(struct intel_encoder *intel_encoder, int intel_opregion_notify_adapter(struct drm_i915_private *dev_priv, pci_power_t state); int intel_opregion_get_panel_type(struct drm_i915_private *dev_priv); +void intel_opregion_edid_probe(struct intel_connector *connector); #else /* CONFIG_ACPI*/ @@ -117,6 +121,10 @@ static inline int intel_opregion_get_panel_type(struct drm_i915_private *dev) return -ENODEV; } +void intel_opregion_edid_probe(struct intel_connector *connector) +{ +} + #endif /* CONFIG_ACPI */ #endif -- 2.31.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCH v2 1/2] drm/i915/opregion: add support for mailbox #5 EDID 2021-05-31 20:46 ` [Intel-gfx] " Anisse Astier @ 2021-06-01 15:50 ` Ville Syrjälä -1 siblings, 0 replies; 18+ messages in thread From: Ville Syrjälä @ 2021-06-01 15:50 UTC (permalink / raw) To: Anisse Astier Cc: Jani Nikula, Hans de Goede, intel-gfx, Uma Shankar, dri-devel On Mon, May 31, 2021 at 10:46:41PM +0200, Anisse Astier wrote: > The ACPI OpRegion Mailbox #5 ASLE extension may contain an EDID to be > used for the embedded display. Add support for using it via by adding > the EDID to the list of available modes on the connector, and use it for > eDP when available. > > If a panel's EDID is broken, there may be an override EDID set in the > ACPI OpRegion mailbox #5. Use it if available. Looks like Windows uses the ACPI _DDC method instead. We should probably do the same, just in case some crazy machine stores the EDID somewhere else. > > Fixes the GPD Win Max display. > > Based on original patch series by: Jani Nikula <jani.nikula@intel.com> > https://patchwork.kernel.org/project/intel-gfx/patch/20200828061941.17051-1-jani.nikula@intel.com/ > > Changes: > - EDID is copied and validated with drm_edid_is_valid > - Mode is now added via drm_add_edid_modes instead of using override > mechanism > - squashed the two patches > > Cc: Jani Nikula <jani.nikula@intel.com> > Cc: Uma Shankar <uma.shankar@intel.com> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > Signed-off-by: Anisse Astier <anisse@astier.eu> > --- > drivers/gpu/drm/i915/display/intel_dp.c | 3 + > drivers/gpu/drm/i915/display/intel_opregion.c | 69 ++++++++++++++++++- > drivers/gpu/drm/i915/display/intel_opregion.h | 8 +++ > 3 files changed, 79 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c > index 5c9222283044..43fb485c0e02 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -5191,6 +5191,9 @@ static bool intel_edp_init_connector(struct intel_dp *intel_dp, > goto out_vdd_off; > } > > + /* Set up override EDID, if any, from ACPI OpRegion */ > + intel_opregion_edid_probe(intel_connector); > + > mutex_lock(&dev->mode_config.mutex); > edid = drm_get_edid(connector, &intel_dp->aux.ddc); > if (edid) { > diff --git a/drivers/gpu/drm/i915/display/intel_opregion.c b/drivers/gpu/drm/i915/display/intel_opregion.c > index dfd724e506b5..ef8d38f041eb 100644 > --- a/drivers/gpu/drm/i915/display/intel_opregion.c > +++ b/drivers/gpu/drm/i915/display/intel_opregion.c > @@ -196,6 +196,8 @@ struct opregion_asle_ext { > #define ASLE_IUER_WINDOWS_BTN (1 << 1) > #define ASLE_IUER_POWER_BTN (1 << 0) > > +#define ASLE_PHED_EDID_VALID_MASK 0x3 > + > /* Software System Control Interrupt (SWSCI) */ > #define SWSCI_SCIC_INDICATOR (1 << 0) > #define SWSCI_SCIC_MAIN_FUNCTION_SHIFT 1 > @@ -909,8 +911,10 @@ int intel_opregion_setup(struct drm_i915_private *dev_priv) > opregion->asle->ardy = ASLE_ARDY_NOT_READY; > } > > - if (mboxes & MBOX_ASLE_EXT) > + if (mboxes & MBOX_ASLE_EXT) { > drm_dbg(&dev_priv->drm, "ASLE extension supported\n"); > + opregion->asle_ext = base + OPREGION_ASLE_EXT_OFFSET; > + } > > if (intel_load_vbt_firmware(dev_priv) == 0) > goto out; > @@ -1037,6 +1041,68 @@ intel_opregion_get_panel_type(struct drm_i915_private *dev_priv) > return ret - 1; > } > > +/** > + * intel_opregion_edid_probe - Add EDID from ACPI OpRegion mailbox #5 > + * @intel_connector: eDP connector > + * > + * This reads the ACPI Opregion mailbox #5 to extract the EDID that is passed > + * to it. > + * > + * Will take a lock on the DRM mode_config to add the EDID; make sure it isn't > + * called with lock taken. > + * > + */ > +void intel_opregion_edid_probe(struct intel_connector *intel_connector) > +{ > + struct drm_connector *connector = &intel_connector->base; > + struct drm_i915_private *i915 = to_i915(connector->dev); > + struct intel_opregion *opregion = &i915->opregion; > + const void *in_edid; > + const struct edid *edid; > + struct edid *new_edid; > + int len, ret, num; > + > + if (!opregion->asle_ext || connector->override_edid) > + return; > + > + in_edid = opregion->asle_ext->bddc; > + > + /* Validity corresponds to number of 128-byte blocks */ > + len = (opregion->asle_ext->phed & ASLE_PHED_EDID_VALID_MASK) * 128; > + if (!len || !memchr_inv(in_edid, 0, len)) > + return; > + > + edid = in_edid; > + > + if (len < EDID_LENGTH * (1 + edid->extensions)) { > + drm_dbg_kms(&i915->drm, "Invalid EDID in ACPI OpRegion (Mailbox #5)\n"); > + return; > + } > + new_edid = drm_edid_duplicate(edid); > + if (!new_edid) { > + drm_err(&i915->drm, "Cannot duplicate EDID\n"); > + return; > + } > + if (!drm_edid_is_valid(new_edid)) { > + kfree(new_edid); > + drm_dbg_kms(&i915->drm, "Cannot validate EDID in ACPI OpRegion (Mailbox #5)\n"); > + return; > + } > + > + ret = drm_connector_update_edid_property(connector, new_edid); > + if (ret) { > + kfree(new_edid); > + return; > + } > + > + mutex_lock(&connector->dev->mode_config.mutex); > + num = drm_add_edid_modes(connector, new_edid); > + mutex_unlock(&connector->dev->mode_config.mutex); > + > + drm_dbg_kms(&i915->drm, "Using OpRegion EDID for [CONNECTOR:%d:%s], added %d mode(s)\n", > + connector->base.id, connector->name, num); > +} > + > void intel_opregion_register(struct drm_i915_private *i915) > { > struct intel_opregion *opregion = &i915->opregion; > @@ -1127,6 +1193,7 @@ void intel_opregion_unregister(struct drm_i915_private *i915) > opregion->acpi = NULL; > opregion->swsci = NULL; > opregion->asle = NULL; > + opregion->asle_ext = NULL; > opregion->vbt = NULL; > opregion->lid_state = NULL; > } > diff --git a/drivers/gpu/drm/i915/display/intel_opregion.h b/drivers/gpu/drm/i915/display/intel_opregion.h > index 4aa68ffbd30e..c1ecfcbb6f55 100644 > --- a/drivers/gpu/drm/i915/display/intel_opregion.h > +++ b/drivers/gpu/drm/i915/display/intel_opregion.h > @@ -29,12 +29,14 @@ > #include <linux/pci.h> > > struct drm_i915_private; > +struct intel_connector; > struct intel_encoder; > > struct opregion_header; > struct opregion_acpi; > struct opregion_swsci; > struct opregion_asle; > +struct opregion_asle_ext; > > struct intel_opregion { > struct opregion_header *header; > @@ -43,6 +45,7 @@ struct intel_opregion { > u32 swsci_gbda_sub_functions; > u32 swsci_sbcb_sub_functions; > struct opregion_asle *asle; > + struct opregion_asle_ext *asle_ext; > void *rvda; > void *vbt_firmware; > const void *vbt; > @@ -71,6 +74,7 @@ int intel_opregion_notify_encoder(struct intel_encoder *intel_encoder, > int intel_opregion_notify_adapter(struct drm_i915_private *dev_priv, > pci_power_t state); > int intel_opregion_get_panel_type(struct drm_i915_private *dev_priv); > +void intel_opregion_edid_probe(struct intel_connector *connector); > > #else /* CONFIG_ACPI*/ > > @@ -117,6 +121,10 @@ static inline int intel_opregion_get_panel_type(struct drm_i915_private *dev) > return -ENODEV; > } > > +void intel_opregion_edid_probe(struct intel_connector *connector) > +{ > +} > + > #endif /* CONFIG_ACPI */ > > #endif > -- > 2.31.1 -- Ville Syrjälä Intel ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/opregion: add support for mailbox #5 EDID @ 2021-06-01 15:50 ` Ville Syrjälä 0 siblings, 0 replies; 18+ messages in thread From: Ville Syrjälä @ 2021-06-01 15:50 UTC (permalink / raw) To: Anisse Astier; +Cc: Jani Nikula, intel-gfx, dri-devel On Mon, May 31, 2021 at 10:46:41PM +0200, Anisse Astier wrote: > The ACPI OpRegion Mailbox #5 ASLE extension may contain an EDID to be > used for the embedded display. Add support for using it via by adding > the EDID to the list of available modes on the connector, and use it for > eDP when available. > > If a panel's EDID is broken, there may be an override EDID set in the > ACPI OpRegion mailbox #5. Use it if available. Looks like Windows uses the ACPI _DDC method instead. We should probably do the same, just in case some crazy machine stores the EDID somewhere else. > > Fixes the GPD Win Max display. > > Based on original patch series by: Jani Nikula <jani.nikula@intel.com> > https://patchwork.kernel.org/project/intel-gfx/patch/20200828061941.17051-1-jani.nikula@intel.com/ > > Changes: > - EDID is copied and validated with drm_edid_is_valid > - Mode is now added via drm_add_edid_modes instead of using override > mechanism > - squashed the two patches > > Cc: Jani Nikula <jani.nikula@intel.com> > Cc: Uma Shankar <uma.shankar@intel.com> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > Signed-off-by: Anisse Astier <anisse@astier.eu> > --- > drivers/gpu/drm/i915/display/intel_dp.c | 3 + > drivers/gpu/drm/i915/display/intel_opregion.c | 69 ++++++++++++++++++- > drivers/gpu/drm/i915/display/intel_opregion.h | 8 +++ > 3 files changed, 79 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c > index 5c9222283044..43fb485c0e02 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -5191,6 +5191,9 @@ static bool intel_edp_init_connector(struct intel_dp *intel_dp, > goto out_vdd_off; > } > > + /* Set up override EDID, if any, from ACPI OpRegion */ > + intel_opregion_edid_probe(intel_connector); > + > mutex_lock(&dev->mode_config.mutex); > edid = drm_get_edid(connector, &intel_dp->aux.ddc); > if (edid) { > diff --git a/drivers/gpu/drm/i915/display/intel_opregion.c b/drivers/gpu/drm/i915/display/intel_opregion.c > index dfd724e506b5..ef8d38f041eb 100644 > --- a/drivers/gpu/drm/i915/display/intel_opregion.c > +++ b/drivers/gpu/drm/i915/display/intel_opregion.c > @@ -196,6 +196,8 @@ struct opregion_asle_ext { > #define ASLE_IUER_WINDOWS_BTN (1 << 1) > #define ASLE_IUER_POWER_BTN (1 << 0) > > +#define ASLE_PHED_EDID_VALID_MASK 0x3 > + > /* Software System Control Interrupt (SWSCI) */ > #define SWSCI_SCIC_INDICATOR (1 << 0) > #define SWSCI_SCIC_MAIN_FUNCTION_SHIFT 1 > @@ -909,8 +911,10 @@ int intel_opregion_setup(struct drm_i915_private *dev_priv) > opregion->asle->ardy = ASLE_ARDY_NOT_READY; > } > > - if (mboxes & MBOX_ASLE_EXT) > + if (mboxes & MBOX_ASLE_EXT) { > drm_dbg(&dev_priv->drm, "ASLE extension supported\n"); > + opregion->asle_ext = base + OPREGION_ASLE_EXT_OFFSET; > + } > > if (intel_load_vbt_firmware(dev_priv) == 0) > goto out; > @@ -1037,6 +1041,68 @@ intel_opregion_get_panel_type(struct drm_i915_private *dev_priv) > return ret - 1; > } > > +/** > + * intel_opregion_edid_probe - Add EDID from ACPI OpRegion mailbox #5 > + * @intel_connector: eDP connector > + * > + * This reads the ACPI Opregion mailbox #5 to extract the EDID that is passed > + * to it. > + * > + * Will take a lock on the DRM mode_config to add the EDID; make sure it isn't > + * called with lock taken. > + * > + */ > +void intel_opregion_edid_probe(struct intel_connector *intel_connector) > +{ > + struct drm_connector *connector = &intel_connector->base; > + struct drm_i915_private *i915 = to_i915(connector->dev); > + struct intel_opregion *opregion = &i915->opregion; > + const void *in_edid; > + const struct edid *edid; > + struct edid *new_edid; > + int len, ret, num; > + > + if (!opregion->asle_ext || connector->override_edid) > + return; > + > + in_edid = opregion->asle_ext->bddc; > + > + /* Validity corresponds to number of 128-byte blocks */ > + len = (opregion->asle_ext->phed & ASLE_PHED_EDID_VALID_MASK) * 128; > + if (!len || !memchr_inv(in_edid, 0, len)) > + return; > + > + edid = in_edid; > + > + if (len < EDID_LENGTH * (1 + edid->extensions)) { > + drm_dbg_kms(&i915->drm, "Invalid EDID in ACPI OpRegion (Mailbox #5)\n"); > + return; > + } > + new_edid = drm_edid_duplicate(edid); > + if (!new_edid) { > + drm_err(&i915->drm, "Cannot duplicate EDID\n"); > + return; > + } > + if (!drm_edid_is_valid(new_edid)) { > + kfree(new_edid); > + drm_dbg_kms(&i915->drm, "Cannot validate EDID in ACPI OpRegion (Mailbox #5)\n"); > + return; > + } > + > + ret = drm_connector_update_edid_property(connector, new_edid); > + if (ret) { > + kfree(new_edid); > + return; > + } > + > + mutex_lock(&connector->dev->mode_config.mutex); > + num = drm_add_edid_modes(connector, new_edid); > + mutex_unlock(&connector->dev->mode_config.mutex); > + > + drm_dbg_kms(&i915->drm, "Using OpRegion EDID for [CONNECTOR:%d:%s], added %d mode(s)\n", > + connector->base.id, connector->name, num); > +} > + > void intel_opregion_register(struct drm_i915_private *i915) > { > struct intel_opregion *opregion = &i915->opregion; > @@ -1127,6 +1193,7 @@ void intel_opregion_unregister(struct drm_i915_private *i915) > opregion->acpi = NULL; > opregion->swsci = NULL; > opregion->asle = NULL; > + opregion->asle_ext = NULL; > opregion->vbt = NULL; > opregion->lid_state = NULL; > } > diff --git a/drivers/gpu/drm/i915/display/intel_opregion.h b/drivers/gpu/drm/i915/display/intel_opregion.h > index 4aa68ffbd30e..c1ecfcbb6f55 100644 > --- a/drivers/gpu/drm/i915/display/intel_opregion.h > +++ b/drivers/gpu/drm/i915/display/intel_opregion.h > @@ -29,12 +29,14 @@ > #include <linux/pci.h> > > struct drm_i915_private; > +struct intel_connector; > struct intel_encoder; > > struct opregion_header; > struct opregion_acpi; > struct opregion_swsci; > struct opregion_asle; > +struct opregion_asle_ext; > > struct intel_opregion { > struct opregion_header *header; > @@ -43,6 +45,7 @@ struct intel_opregion { > u32 swsci_gbda_sub_functions; > u32 swsci_sbcb_sub_functions; > struct opregion_asle *asle; > + struct opregion_asle_ext *asle_ext; > void *rvda; > void *vbt_firmware; > const void *vbt; > @@ -71,6 +74,7 @@ int intel_opregion_notify_encoder(struct intel_encoder *intel_encoder, > int intel_opregion_notify_adapter(struct drm_i915_private *dev_priv, > pci_power_t state); > int intel_opregion_get_panel_type(struct drm_i915_private *dev_priv); > +void intel_opregion_edid_probe(struct intel_connector *connector); > > #else /* CONFIG_ACPI*/ > > @@ -117,6 +121,10 @@ static inline int intel_opregion_get_panel_type(struct drm_i915_private *dev) > return -ENODEV; > } > > +void intel_opregion_edid_probe(struct intel_connector *connector) > +{ > +} > + > #endif /* CONFIG_ACPI */ > > #endif > -- > 2.31.1 -- Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v2 1/2] drm/i915/opregion: add support for mailbox #5 EDID 2021-06-01 15:50 ` [Intel-gfx] " Ville Syrjälä @ 2021-06-01 22:43 ` Anisse Astier -1 siblings, 0 replies; 18+ messages in thread From: Anisse Astier @ 2021-06-01 22:43 UTC (permalink / raw) To: Ville Syrj?l? Cc: Daniel Dadap, Jani Nikula, intel-gfx, dri-devel, Hans de Goede, Uma Shankar Le Tue, Jun 01, 2021 at 06:50:24PM +0300, Ville Syrj?l? a ?crit : > On Mon, May 31, 2021 at 10:46:41PM +0200, Anisse Astier wrote: > > The ACPI OpRegion Mailbox #5 ASLE extension may contain an EDID to be > > used for the embedded display. Add support for using it via by adding > > the EDID to the list of available modes on the connector, and use it for > > eDP when available. > > > > If a panel's EDID is broken, there may be an override EDID set in the > > ACPI OpRegion mailbox #5. Use it if available. > > Looks like Windows uses the ACPI _DDC method instead. We should probably > do the same, just in case some crazy machine stores the EDID somewhere > else. Thanks, I wouldn't have thought of this. It seems Daniel Dadap did a patch series to do just that, in a generic way: https://lore.kernel.org/amd-gfx/20200727205357.27839-1-ddadap@nvidia.com/ I've tried patch 1 & 2, and after a fix[1] was able to call the _DDC method on most devices, but without any EDID being returned. I looked at the disassembled ACPI tables[2], and could not find any device with the _DDC method. Are you sure it's the only method the Windows driver uses to get the EDID ? Regards, Anisse [1] _DOD ids should only use 16 lower bits, see table here: https://uefi.org/specs/ACPI/6.4/Apx_B_Video_Extensions/display-specific-methods.html#dod-enumerate-all-devices-attached-to-the-display-adapter [2] acpidump: https://gitlab.freedesktop.org/drm/intel/-/issues/3454#note_913970 ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/opregion: add support for mailbox #5 EDID @ 2021-06-01 22:43 ` Anisse Astier 0 siblings, 0 replies; 18+ messages in thread From: Anisse Astier @ 2021-06-01 22:43 UTC (permalink / raw) To: Ville Syrj?l?; +Cc: Daniel Dadap, Jani Nikula, intel-gfx, dri-devel Le Tue, Jun 01, 2021 at 06:50:24PM +0300, Ville Syrj?l? a ?crit : > On Mon, May 31, 2021 at 10:46:41PM +0200, Anisse Astier wrote: > > The ACPI OpRegion Mailbox #5 ASLE extension may contain an EDID to be > > used for the embedded display. Add support for using it via by adding > > the EDID to the list of available modes on the connector, and use it for > > eDP when available. > > > > If a panel's EDID is broken, there may be an override EDID set in the > > ACPI OpRegion mailbox #5. Use it if available. > > Looks like Windows uses the ACPI _DDC method instead. We should probably > do the same, just in case some crazy machine stores the EDID somewhere > else. Thanks, I wouldn't have thought of this. It seems Daniel Dadap did a patch series to do just that, in a generic way: https://lore.kernel.org/amd-gfx/20200727205357.27839-1-ddadap@nvidia.com/ I've tried patch 1 & 2, and after a fix[1] was able to call the _DDC method on most devices, but without any EDID being returned. I looked at the disassembled ACPI tables[2], and could not find any device with the _DDC method. Are you sure it's the only method the Windows driver uses to get the EDID ? Regards, Anisse [1] _DOD ids should only use 16 lower bits, see table here: https://uefi.org/specs/ACPI/6.4/Apx_B_Video_Extensions/display-specific-methods.html#dod-enumerate-all-devices-attached-to-the-display-adapter [2] acpidump: https://gitlab.freedesktop.org/drm/intel/-/issues/3454#note_913970 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v2 1/2] drm/i915/opregion: add support for mailbox #5 EDID 2021-06-01 22:43 ` [Intel-gfx] " Anisse Astier @ 2021-07-07 19:57 ` Daniel Dadap -1 siblings, 0 replies; 18+ messages in thread From: Daniel Dadap @ 2021-07-07 19:57 UTC (permalink / raw) To: Anisse Astier, Ville Syrj?l? Cc: Jani Nikula, Hans de Goede, intel-gfx, Uma Shankar, dri-devel On 6/1/21 5:43 PM, Anisse Astier wrote: > > Le Tue, Jun 01, 2021 at 06:50:24PM +0300, Ville Syrj?l? a ?crit : >> On Mon, May 31, 2021 at 10:46:41PM +0200, Anisse Astier wrote: >>> The ACPI OpRegion Mailbox #5 ASLE extension may contain an EDID to be >>> used for the embedded display. Add support for using it via by adding >>> the EDID to the list of available modes on the connector, and use it for >>> eDP when available. >>> >>> If a panel's EDID is broken, there may be an override EDID set in the >>> ACPI OpRegion mailbox #5. Use it if available. >> Looks like Windows uses the ACPI _DDC method instead. We should probably >> do the same, just in case some crazy machine stores the EDID somewhere >> else. > Thanks, I wouldn't have thought of this. It seems Daniel Dadap did a > patch series to do just that, in a generic way: > https://lore.kernel.org/amd-gfx/20200727205357.27839-1-ddadap@nvidia.com/ > > I've tried patch 1 & 2, and after a fix[1] was able to call the _DDC method > on most devices, but without any EDID being returned. > > I looked at the disassembled ACPI tables[2], and could not find any > device with the _DDC method. Are you sure it's the only method the > Windows driver uses to get the EDID ? _DDC only works on devices that actually implement it, and the vast majority of devices don't, because the display just provides an EDID normally. AIUI, usually a device will implement _DDC either because an embedded panel has no ROM of its own to deliver an EDID, or to allow the EDID to be read by either GPU on a system with a muxed display, regardless of which GPU happens to have the DDC lines (in TMDS) or DP AUX routed to it at the moment. (To my knowledge, nobody actually muxes DP AUX independently from the main link, but there were some older pre-DP designs where DDC could be muxed independently.) I'm not sure whether the comment about Windows using _DDC was meant for this device in particular, or just more generally, since DDC is part of the ACPI spec and some Windows GPU drivers *do* use it, where available. If it was meant for a particular device, then it's possible that the ACPI tables advertise different methods depending on e.g. _OSI. If you haven't already tried doing so, it might be worth overriding _OSI to spoof Windows, to see if _DDC gets advertised. I'm not sure how you were able to call _DDC without an EDID being returned as described above, if there was no _DDC method in the ACPI tables; I would expect that attempting to call _DDC would fail to locate a suitable method and do_acpi_ddc would return NULL. > Regards, > > Anisse > > [1] _DOD ids should only use 16 lower bits, see table here: > https://uefi.org/specs/ACPI/6.4/Apx_B_Video_Extensions/display-specific-methods.html#dod-enumerate-all-devices-attached-to-the-display-adapter Thanks; I don't see a version of your modified patch here, was the fix just to mask the _DOD IDs against 0xffff? > [2] acpidump: https://gitlab.freedesktop.org/drm/intel/-/issues/3454#note_913970 > ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/opregion: add support for mailbox #5 EDID @ 2021-07-07 19:57 ` Daniel Dadap 0 siblings, 0 replies; 18+ messages in thread From: Daniel Dadap @ 2021-07-07 19:57 UTC (permalink / raw) To: Anisse Astier, Ville Syrj?l?; +Cc: Jani Nikula, intel-gfx, dri-devel On 6/1/21 5:43 PM, Anisse Astier wrote: > > Le Tue, Jun 01, 2021 at 06:50:24PM +0300, Ville Syrj?l? a ?crit : >> On Mon, May 31, 2021 at 10:46:41PM +0200, Anisse Astier wrote: >>> The ACPI OpRegion Mailbox #5 ASLE extension may contain an EDID to be >>> used for the embedded display. Add support for using it via by adding >>> the EDID to the list of available modes on the connector, and use it for >>> eDP when available. >>> >>> If a panel's EDID is broken, there may be an override EDID set in the >>> ACPI OpRegion mailbox #5. Use it if available. >> Looks like Windows uses the ACPI _DDC method instead. We should probably >> do the same, just in case some crazy machine stores the EDID somewhere >> else. > Thanks, I wouldn't have thought of this. It seems Daniel Dadap did a > patch series to do just that, in a generic way: > https://lore.kernel.org/amd-gfx/20200727205357.27839-1-ddadap@nvidia.com/ > > I've tried patch 1 & 2, and after a fix[1] was able to call the _DDC method > on most devices, but without any EDID being returned. > > I looked at the disassembled ACPI tables[2], and could not find any > device with the _DDC method. Are you sure it's the only method the > Windows driver uses to get the EDID ? _DDC only works on devices that actually implement it, and the vast majority of devices don't, because the display just provides an EDID normally. AIUI, usually a device will implement _DDC either because an embedded panel has no ROM of its own to deliver an EDID, or to allow the EDID to be read by either GPU on a system with a muxed display, regardless of which GPU happens to have the DDC lines (in TMDS) or DP AUX routed to it at the moment. (To my knowledge, nobody actually muxes DP AUX independently from the main link, but there were some older pre-DP designs where DDC could be muxed independently.) I'm not sure whether the comment about Windows using _DDC was meant for this device in particular, or just more generally, since DDC is part of the ACPI spec and some Windows GPU drivers *do* use it, where available. If it was meant for a particular device, then it's possible that the ACPI tables advertise different methods depending on e.g. _OSI. If you haven't already tried doing so, it might be worth overriding _OSI to spoof Windows, to see if _DDC gets advertised. I'm not sure how you were able to call _DDC without an EDID being returned as described above, if there was no _DDC method in the ACPI tables; I would expect that attempting to call _DDC would fail to locate a suitable method and do_acpi_ddc would return NULL. > Regards, > > Anisse > > [1] _DOD ids should only use 16 lower bits, see table here: > https://uefi.org/specs/ACPI/6.4/Apx_B_Video_Extensions/display-specific-methods.html#dod-enumerate-all-devices-attached-to-the-display-adapter Thanks; I don't see a version of your modified patch here, was the fix just to mask the _DOD IDs against 0xffff? > [2] acpidump: https://gitlab.freedesktop.org/drm/intel/-/issues/3454#note_913970 > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v2 1/2] drm/i915/opregion: add support for mailbox #5 EDID 2021-07-07 19:57 ` [Intel-gfx] " Daniel Dadap @ 2021-07-07 21:30 ` Anisse Astier -1 siblings, 0 replies; 18+ messages in thread From: Anisse Astier @ 2021-07-07 21:30 UTC (permalink / raw) To: Daniel Dadap Cc: Jani Nikula, intel-gfx, dri-devel, Hans de Goede, Uma Shankar Le Wed, Jul 07, 2021 at 02:57:47PM -0500, Daniel Dadap a écrit : > On 6/1/21 5:43 PM, Anisse Astier wrote: > > > > Le Tue, Jun 01, 2021 at 06:50:24PM +0300, Ville Syrj?l? a ?crit : > > > On Mon, May 31, 2021 at 10:46:41PM +0200, Anisse Astier wrote: > > > > The ACPI OpRegion Mailbox #5 ASLE extension may contain an EDID to be > > > > used for the embedded display. Add support for using it via by adding > > > > the EDID to the list of available modes on the connector, and use it for > > > > eDP when available. > > > > > > > > If a panel's EDID is broken, there may be an override EDID set in the > > > > ACPI OpRegion mailbox #5. Use it if available. > > > Looks like Windows uses the ACPI _DDC method instead. We should probably > > > do the same, just in case some crazy machine stores the EDID somewhere > > > else. > > Thanks, I wouldn't have thought of this. It seems Daniel Dadap did a > > patch series to do just that, in a generic way: > > https://lore.kernel.org/amd-gfx/20200727205357.27839-1-ddadap@nvidia.com/ > > > > I've tried patch 1 & 2, and after a fix[1] was able to call the _DDC method > > on most devices, but without any EDID being returned. > > > > I looked at the disassembled ACPI tables[2], and could not find any > > device with the _DDC method. Are you sure it's the only method the > > Windows driver uses to get the EDID ? > > > _DDC only works on devices that actually implement it, and the vast majority > of devices don't, because the display just provides an EDID normally. AIUI, > usually a device will implement _DDC either because an embedded panel has no > ROM of its own to deliver an EDID, or to allow the EDID to be read by either > GPU on a system with a muxed display, regardless of which GPU happens to > have the DDC lines (in TMDS) or DP AUX routed to it at the moment. (To my > knowledge, nobody actually muxes DP AUX independently from the main link, > but there were some older pre-DP designs where DDC could be muxed > independently.) > > I'm not sure whether the comment about Windows using _DDC was meant for this > device in particular, or just more generally, since DDC is part of the ACPI > spec and some Windows GPU drivers *do* use it, where available. If it was > meant for a particular device, then it's possible that the ACPI tables > advertise different methods depending on e.g. _OSI. If you haven't already > tried doing so, it might be worth overriding _OSI to spoof Windows, to see > if _DDC gets advertised. I think it's already the default Linux behaviour according to https://www.kernel.org/doc/html/latest/firmware-guide/acpi/osi.html I added a few specific Windows versions (2007 - 2020), but did not see any difference. > > I'm not sure how you were able to call _DDC without an EDID being returned > as described above, if there was no _DDC method in the ACPI tables; I would > expect that attempting to call _DDC would fail to locate a suitable method > and do_acpi_ddc would return NULL. I wasn't, I just tried calling the method on all devices (removing the _DOD id check), but obviously it failed because it did not exist. > > > > Regards, > > > > Anisse > > > > [1] _DOD ids should only use 16 lower bits, see table here: > > https://uefi.org/specs/ACPI/6.4/Apx_B_Video_Extensions/display-specific-methods.html#dod-enumerate-all-devices-attached-to-the-display-adapter > > > Thanks; I don't see a version of your modified patch here, was the fix just > to mask the _DOD IDs against 0xffff? Yes, nothing fancy: - if (adr == dod_entries[i]) { + if (adr == (dod_entries[i] & 0xFFFF) ) { Regards, Anisse ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/opregion: add support for mailbox #5 EDID @ 2021-07-07 21:30 ` Anisse Astier 0 siblings, 0 replies; 18+ messages in thread From: Anisse Astier @ 2021-07-07 21:30 UTC (permalink / raw) To: Daniel Dadap; +Cc: Jani Nikula, intel-gfx, dri-devel Le Wed, Jul 07, 2021 at 02:57:47PM -0500, Daniel Dadap a écrit : > On 6/1/21 5:43 PM, Anisse Astier wrote: > > > > Le Tue, Jun 01, 2021 at 06:50:24PM +0300, Ville Syrj?l? a ?crit : > > > On Mon, May 31, 2021 at 10:46:41PM +0200, Anisse Astier wrote: > > > > The ACPI OpRegion Mailbox #5 ASLE extension may contain an EDID to be > > > > used for the embedded display. Add support for using it via by adding > > > > the EDID to the list of available modes on the connector, and use it for > > > > eDP when available. > > > > > > > > If a panel's EDID is broken, there may be an override EDID set in the > > > > ACPI OpRegion mailbox #5. Use it if available. > > > Looks like Windows uses the ACPI _DDC method instead. We should probably > > > do the same, just in case some crazy machine stores the EDID somewhere > > > else. > > Thanks, I wouldn't have thought of this. It seems Daniel Dadap did a > > patch series to do just that, in a generic way: > > https://lore.kernel.org/amd-gfx/20200727205357.27839-1-ddadap@nvidia.com/ > > > > I've tried patch 1 & 2, and after a fix[1] was able to call the _DDC method > > on most devices, but without any EDID being returned. > > > > I looked at the disassembled ACPI tables[2], and could not find any > > device with the _DDC method. Are you sure it's the only method the > > Windows driver uses to get the EDID ? > > > _DDC only works on devices that actually implement it, and the vast majority > of devices don't, because the display just provides an EDID normally. AIUI, > usually a device will implement _DDC either because an embedded panel has no > ROM of its own to deliver an EDID, or to allow the EDID to be read by either > GPU on a system with a muxed display, regardless of which GPU happens to > have the DDC lines (in TMDS) or DP AUX routed to it at the moment. (To my > knowledge, nobody actually muxes DP AUX independently from the main link, > but there were some older pre-DP designs where DDC could be muxed > independently.) > > I'm not sure whether the comment about Windows using _DDC was meant for this > device in particular, or just more generally, since DDC is part of the ACPI > spec and some Windows GPU drivers *do* use it, where available. If it was > meant for a particular device, then it's possible that the ACPI tables > advertise different methods depending on e.g. _OSI. If you haven't already > tried doing so, it might be worth overriding _OSI to spoof Windows, to see > if _DDC gets advertised. I think it's already the default Linux behaviour according to https://www.kernel.org/doc/html/latest/firmware-guide/acpi/osi.html I added a few specific Windows versions (2007 - 2020), but did not see any difference. > > I'm not sure how you were able to call _DDC without an EDID being returned > as described above, if there was no _DDC method in the ACPI tables; I would > expect that attempting to call _DDC would fail to locate a suitable method > and do_acpi_ddc would return NULL. I wasn't, I just tried calling the method on all devices (removing the _DOD id check), but obviously it failed because it did not exist. > > > > Regards, > > > > Anisse > > > > [1] _DOD ids should only use 16 lower bits, see table here: > > https://uefi.org/specs/ACPI/6.4/Apx_B_Video_Extensions/display-specific-methods.html#dod-enumerate-all-devices-attached-to-the-display-adapter > > > Thanks; I don't see a version of your modified patch here, was the fix just > to mask the _DOD IDs against 0xffff? Yes, nothing fancy: - if (adr == dod_entries[i]) { + if (adr == (dod_entries[i] & 0xFFFF) ) { Regards, Anisse _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH v2 2/2] drm: Add orientation quirk for GPD Win Max 2021-05-31 20:46 ` [Intel-gfx] " Anisse Astier @ 2021-05-31 20:46 ` Anisse Astier -1 siblings, 0 replies; 18+ messages in thread From: Anisse Astier @ 2021-05-31 20:46 UTC (permalink / raw) To: intel-gfx, dri-devel Cc: Jani Nikula, Hans de Goede, Uma Shankar, Anisse Astier Panel is 800x1280, but mounted on a laptop form factor, sideways. Reviewed-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Anisse Astier <anisse@astier.eu> --- drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c index f6bdec7fa925..3c3f4ed89173 100644 --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c @@ -148,6 +148,12 @@ static const struct dmi_system_id orientation_data[] = { DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "MicroPC"), }, .driver_data = (void *)&lcd720x1280_rightside_up, + }, { /* GPD Win Max */ + .matches = { + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "GPD"), + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "G1619-01"), + }, + .driver_data = (void *)&lcd800x1280_rightside_up, }, { /* * GPD Pocket, note that the the DMI data is less generic then * it seems, devices with a board-vendor of "AMI Corporation" -- 2.31.1 ^ permalink raw reply related [flat|nested] 18+ messages in thread
* [Intel-gfx] [PATCH v2 2/2] drm: Add orientation quirk for GPD Win Max @ 2021-05-31 20:46 ` Anisse Astier 0 siblings, 0 replies; 18+ messages in thread From: Anisse Astier @ 2021-05-31 20:46 UTC (permalink / raw) To: intel-gfx, dri-devel; +Cc: Jani Nikula Panel is 800x1280, but mounted on a laptop form factor, sideways. Reviewed-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Anisse Astier <anisse@astier.eu> --- drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c index f6bdec7fa925..3c3f4ed89173 100644 --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c @@ -148,6 +148,12 @@ static const struct dmi_system_id orientation_data[] = { DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "MicroPC"), }, .driver_data = (void *)&lcd720x1280_rightside_up, + }, { /* GPD Win Max */ + .matches = { + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "GPD"), + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "G1619-01"), + }, + .driver_data = (void *)&lcd800x1280_rightside_up, }, { /* * GPD Pocket, note that the the DMI data is less generic then * it seems, devices with a board-vendor of "AMI Corporation" -- 2.31.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 18+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for GPD Win Max display fixes (rev2) 2021-05-31 20:46 ` [Intel-gfx] " Anisse Astier ` (2 preceding siblings ...) (?) @ 2021-05-31 20:58 ` Patchwork -1 siblings, 0 replies; 18+ messages in thread From: Patchwork @ 2021-05-31 20:58 UTC (permalink / raw) To: Anisse Astier; +Cc: intel-gfx == Series Details == Series: GPD Win Max display fixes (rev2) URL : https://patchwork.freedesktop.org/series/90483/ State : warning == Summary == $ dim checkpatch origin/drm-tip 8d4543be1dff drm/i915/opregion: add support for mailbox #5 EDID -:20: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #20: https://patchwork.kernel.org/project/intel-gfx/patch/20200828061941.17051-1-jani.nikula@intel.com/ total: 0 errors, 1 warnings, 0 checks, 141 lines checked 8873d6deae22 drm: Add orientation quirk for GPD Win Max _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 18+ messages in thread
* [Intel-gfx] ✗ Fi.CI.SPARSE: warning for GPD Win Max display fixes (rev2) 2021-05-31 20:46 ` [Intel-gfx] " Anisse Astier ` (3 preceding siblings ...) (?) @ 2021-05-31 20:59 ` Patchwork -1 siblings, 0 replies; 18+ messages in thread From: Patchwork @ 2021-05-31 20:59 UTC (permalink / raw) To: Anisse Astier; +Cc: intel-gfx == Series Details == Series: GPD Win Max display fixes (rev2) URL : https://patchwork.freedesktop.org/series/90483/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +drivers/gpu/drm/i915/display/intel_display.c:1893:21: expected struct i915_vma *[assigned] vma +drivers/gpu/drm/i915/display/intel_display.c:1893:21: got void [noderef] __iomem *[assigned] iomem +drivers/gpu/drm/i915/display/intel_display.c:1893:21: warning: incorrect type in assignment (different address spaces) +drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:32:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:32:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:56:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:56:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_reset.c:1396:5: warning: context imbalance in 'intel_gt_reset_trylock' - different lock contexts for basic block +drivers/gpu/drm/i915/gt/intel_ring_submission.c:1207:24: warning: Using plain integer as NULL pointer +drivers/gpu/drm/i915/i915_perf.c:1434:15: warning: memset with byte count of 16777216 +drivers/gpu/drm/i915/i915_perf.c:1488:15: warning: memset with byte count of 16777216 +./include/asm-generic/bitops/find.h:112:45: warning: shift count is negative (-262080) +./include/asm-generic/bitops/find.h:32:31: warning: shift count is negative (-262080) +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read64' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read64' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read64' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read64' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write8' - different lock contexts for basic block _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 18+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for GPD Win Max display fixes (rev2) 2021-05-31 20:46 ` [Intel-gfx] " Anisse Astier ` (4 preceding siblings ...) (?) @ 2021-05-31 21:27 ` Patchwork -1 siblings, 0 replies; 18+ messages in thread From: Patchwork @ 2021-05-31 21:27 UTC (permalink / raw) To: Anisse Astier; +Cc: intel-gfx [-- Attachment #1.1: Type: text/plain, Size: 6478 bytes --] == Series Details == Series: GPD Win Max display fixes (rev2) URL : https://patchwork.freedesktop.org/series/90483/ State : success == Summary == CI Bug Log - changes from CI_DRM_10153 -> Patchwork_20241 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/index.html Known issues ------------ Here are the changes found in Patchwork_20241 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@core_hotunplug@unbind-rebind: - fi-bdw-5557u: NOTRUN -> [WARN][1] ([i915#2283]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/fi-bdw-5557u/igt@core_hotunplug@unbind-rebind.html * igt@i915_selftest@live@execlists: - fi-bdw-5557u: NOTRUN -> [DMESG-FAIL][2] ([i915#3462]) [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/fi-bdw-5557u/igt@i915_selftest@live@execlists.html * igt@kms_chamelium@dp-crc-fast: - fi-bdw-5557u: NOTRUN -> [SKIP][3] ([fdo#109271] / [fdo#111827]) +8 similar issues [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/fi-bdw-5557u/igt@kms_chamelium@dp-crc-fast.html * igt@kms_frontbuffer_tracking@basic: - fi-tgl-u2: [PASS][4] -> [FAIL][5] ([i915#2416]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10153/fi-tgl-u2/igt@kms_frontbuffer_tracking@basic.html [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/fi-tgl-u2/igt@kms_frontbuffer_tracking@basic.html * igt@kms_psr@cursor_plane_move: - fi-bdw-5557u: NOTRUN -> [SKIP][6] ([fdo#109271]) +9 similar issues [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/fi-bdw-5557u/igt@kms_psr@cursor_plane_move.html #### Possible fixes #### * igt@i915_selftest@live@hangcheck: - {fi-hsw-gt1}: [DMESG-WARN][7] ([i915#3303]) -> [PASS][8] [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10153/fi-hsw-gt1/igt@i915_selftest@live@hangcheck.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/fi-hsw-gt1/igt@i915_selftest@live@hangcheck.html #### Warnings #### * igt@i915_pm_rpm@basic-pci-d3-state: - fi-kbl-guc: [FAIL][9] ([i915#3049]) -> [SKIP][10] ([fdo#109271]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10153/fi-kbl-guc/igt@i915_pm_rpm@basic-pci-d3-state.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/fi-kbl-guc/igt@i915_pm_rpm@basic-pci-d3-state.html * igt@i915_selftest@live@execlists: - fi-bsw-nick: [INCOMPLETE][11] ([i915#2782] / [i915#2940] / [i915#3462]) -> [DMESG-FAIL][12] ([i915#3462]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10153/fi-bsw-nick/igt@i915_selftest@live@execlists.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/fi-bsw-nick/igt@i915_selftest@live@execlists.html - fi-tgl-u2: [DMESG-FAIL][13] ([i915#3462]) -> [INCOMPLETE][14] ([i915#3462]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10153/fi-tgl-u2/igt@i915_selftest@live@execlists.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/fi-tgl-u2/igt@i915_selftest@live@execlists.html * igt@runner@aborted: - fi-glk-dsi: [FAIL][15] ([i915#2426] / [i915#3363] / [k.org#202321]) -> [FAIL][16] ([i915#3363] / [k.org#202321]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10153/fi-glk-dsi/igt@runner@aborted.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/fi-glk-dsi/igt@runner@aborted.html - fi-bdw-5557u: [FAIL][17] ([i915#1602] / [i915#2029]) -> [FAIL][18] ([i915#3462]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10153/fi-bdw-5557u/igt@runner@aborted.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/fi-bdw-5557u/igt@runner@aborted.html - fi-bxt-dsi: [FAIL][19] ([i915#2426] / [i915#3363]) -> [FAIL][20] ([i915#3363]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10153/fi-bxt-dsi/igt@runner@aborted.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/fi-bxt-dsi/igt@runner@aborted.html - fi-skl-6700k2: [FAIL][21] ([i915#1436] / [i915#3363]) -> [FAIL][22] ([i915#1436] / [i915#2426] / [i915#3363]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10153/fi-skl-6700k2/igt@runner@aborted.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/fi-skl-6700k2/igt@runner@aborted.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436 [i915#1602]: https://gitlab.freedesktop.org/drm/intel/issues/1602 [i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029 [i915#2283]: https://gitlab.freedesktop.org/drm/intel/issues/2283 [i915#2416]: https://gitlab.freedesktop.org/drm/intel/issues/2416 [i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426 [i915#2782]: https://gitlab.freedesktop.org/drm/intel/issues/2782 [i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940 [i915#3049]: https://gitlab.freedesktop.org/drm/intel/issues/3049 [i915#3303]: https://gitlab.freedesktop.org/drm/intel/issues/3303 [i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363 [i915#3462]: https://gitlab.freedesktop.org/drm/intel/issues/3462 [k.org#202321]: https://bugzilla.kernel.org/show_bug.cgi?id=202321 Participating hosts (46 -> 41) ------------------------------ Missing (5): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-bdw-samus Build changes ------------- * Linux: CI_DRM_10153 -> Patchwork_20241 CI-20190529: 20190529 CI_DRM_10153: 51cde10d0ff6d09afa365e7cf31d1ef44a8fa174 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_6097: f823d8ec14b34a6dd2c0804c684b07b0a50f7bb7 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_20241: 8873d6deae22283e316c65936ee5432a2ca91cab @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 8873d6deae22 drm: Add orientation quirk for GPD Win Max 8d4543be1dff drm/i915/opregion: add support for mailbox #5 EDID == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/index.html [-- Attachment #1.2: Type: text/html, Size: 8399 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 18+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for GPD Win Max display fixes (rev2) 2021-05-31 20:46 ` [Intel-gfx] " Anisse Astier ` (5 preceding siblings ...) (?) @ 2021-05-31 22:52 ` Patchwork -1 siblings, 0 replies; 18+ messages in thread From: Patchwork @ 2021-05-31 22:52 UTC (permalink / raw) To: Anisse Astier; +Cc: intel-gfx [-- Attachment #1.1: Type: text/plain, Size: 30255 bytes --] == Series Details == Series: GPD Win Max display fixes (rev2) URL : https://patchwork.freedesktop.org/series/90483/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10153_full -> Patchwork_20241_full ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with Patchwork_20241_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_20241_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_20241_full: ### IGT changes ### #### Possible regressions #### * igt@kms_plane_lowres@pipe-a-tiling-y: - shard-iclb: NOTRUN -> [SKIP][1] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-iclb5/igt@kms_plane_lowres@pipe-a-tiling-y.html Known issues ------------ Here are the changes found in Patchwork_20241_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_ctx_isolation@preservation-s3@bcs0: - shard-kbl: [PASS][2] -> [DMESG-WARN][3] ([i915#180]) +4 similar issues [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10153/shard-kbl7/igt@gem_ctx_isolation@preservation-s3@bcs0.html [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-kbl7/igt@gem_ctx_isolation@preservation-s3@bcs0.html * igt@gem_ctx_persistence@legacy-engines-mixed: - shard-snb: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#1099]) +9 similar issues [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-snb6/igt@gem_ctx_persistence@legacy-engines-mixed.html * igt@gem_exec_fair@basic-deadline: - shard-kbl: NOTRUN -> [FAIL][5] ([i915#2846]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-kbl4/igt@gem_exec_fair@basic-deadline.html * igt@gem_exec_fair@basic-none-vip@rcs0: - shard-glk: NOTRUN -> [FAIL][6] ([i915#2842]) [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-glk4/igt@gem_exec_fair@basic-none-vip@rcs0.html * igt@gem_exec_fair@basic-throttle@rcs0: - shard-glk: [PASS][7] -> [FAIL][8] ([i915#2842]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10153/shard-glk2/igt@gem_exec_fair@basic-throttle@rcs0.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-glk1/igt@gem_exec_fair@basic-throttle@rcs0.html - shard-iclb: [PASS][9] -> [FAIL][10] ([i915#2849]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10153/shard-iclb7/igt@gem_exec_fair@basic-throttle@rcs0.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-iclb6/igt@gem_exec_fair@basic-throttle@rcs0.html * igt@gem_exec_params@secure-non-master: - shard-iclb: NOTRUN -> [SKIP][11] ([fdo#112283]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-iclb5/igt@gem_exec_params@secure-non-master.html * igt@gem_exec_reloc@basic-wide-active@vcs1: - shard-iclb: NOTRUN -> [FAIL][12] ([i915#2389]) [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-iclb2/igt@gem_exec_reloc@basic-wide-active@vcs1.html * igt@gem_media_vme: - shard-skl: NOTRUN -> [SKIP][13] ([fdo#109271]) +37 similar issues [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-skl2/igt@gem_media_vme.html * igt@gem_mmap_gtt@cpuset-basic-small-copy: - shard-apl: NOTRUN -> [INCOMPLETE][14] ([i915#3468]) +1 similar issue [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-apl3/igt@gem_mmap_gtt@cpuset-basic-small-copy.html - shard-skl: [PASS][15] -> [INCOMPLETE][16] ([i915#198] / [i915#3468]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10153/shard-skl1/igt@gem_mmap_gtt@cpuset-basic-small-copy.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-skl3/igt@gem_mmap_gtt@cpuset-basic-small-copy.html * igt@gem_mmap_gtt@cpuset-big-copy-xy: - shard-iclb: [PASS][17] -> [FAIL][18] ([i915#307]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10153/shard-iclb8/igt@gem_mmap_gtt@cpuset-big-copy-xy.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-iclb3/igt@gem_mmap_gtt@cpuset-big-copy-xy.html * igt@gem_mmap_gtt@fault-concurrent-y: - shard-snb: NOTRUN -> [INCOMPLETE][19] ([i915#3468]) +1 similar issue [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-snb6/igt@gem_mmap_gtt@fault-concurrent-y.html * igt@gem_pread@exhaustion: - shard-snb: NOTRUN -> [WARN][20] ([i915#2658]) [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-snb5/igt@gem_pread@exhaustion.html - shard-skl: NOTRUN -> [WARN][21] ([i915#2658]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-skl2/igt@gem_pread@exhaustion.html * igt@gem_userptr_blits@input-checking: - shard-apl: NOTRUN -> [DMESG-WARN][22] ([i915#3002]) [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-apl2/igt@gem_userptr_blits@input-checking.html - shard-snb: NOTRUN -> [DMESG-WARN][23] ([i915#3002]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-snb6/igt@gem_userptr_blits@input-checking.html * igt@gem_userptr_blits@invalid-mmap-offset-unsync: - shard-iclb: NOTRUN -> [SKIP][24] ([i915#3297]) [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-iclb5/igt@gem_userptr_blits@invalid-mmap-offset-unsync.html * igt@gem_userptr_blits@unsync-overlap: - shard-tglb: NOTRUN -> [SKIP][25] ([i915#3297]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-tglb8/igt@gem_userptr_blits@unsync-overlap.html * igt@gem_userptr_blits@vma-merge: - shard-glk: NOTRUN -> [FAIL][26] ([i915#3318]) [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-glk9/igt@gem_userptr_blits@vma-merge.html * igt@gen9_exec_parse@batch-invalid-length: - shard-snb: NOTRUN -> [SKIP][27] ([fdo#109271]) +523 similar issues [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-snb6/igt@gen9_exec_parse@batch-invalid-length.html * igt@gen9_exec_parse@batch-zero-length: - shard-iclb: NOTRUN -> [SKIP][28] ([fdo#112306]) [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-iclb5/igt@gen9_exec_parse@batch-zero-length.html * igt@gen9_exec_parse@bb-large: - shard-glk: NOTRUN -> [FAIL][29] ([i915#3296]) [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-glk4/igt@gen9_exec_parse@bb-large.html * igt@i915_pm_rpm@modeset-lpsp-stress: - shard-apl: NOTRUN -> [SKIP][30] ([fdo#109271]) +222 similar issues [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-apl7/igt@i915_pm_rpm@modeset-lpsp-stress.html * igt@i915_pm_rpm@pc8-residency: - shard-tglb: NOTRUN -> [SKIP][31] ([fdo#109506] / [i915#2411]) [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-tglb8/igt@i915_pm_rpm@pc8-residency.html * igt@kms_async_flips@alternate-sync-async-flip: - shard-skl: NOTRUN -> [FAIL][32] ([i915#2521]) [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-skl2/igt@kms_async_flips@alternate-sync-async-flip.html * igt@kms_big_fb@linear-16bpp-rotate-90: - shard-iclb: NOTRUN -> [SKIP][33] ([fdo#110725] / [fdo#111614]) [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-iclb5/igt@kms_big_fb@linear-16bpp-rotate-90.html * igt@kms_chamelium@hdmi-edid-change-during-suspend: - shard-apl: NOTRUN -> [SKIP][34] ([fdo#109271] / [fdo#111827]) +19 similar issues [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-apl6/igt@kms_chamelium@hdmi-edid-change-during-suspend.html * igt@kms_color@pipe-b-ctm-max: - shard-skl: NOTRUN -> [DMESG-WARN][35] ([i915#1982]) [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-skl2/igt@kms_color@pipe-b-ctm-max.html * igt@kms_color_chamelium@pipe-a-ctm-0-25: - shard-snb: NOTRUN -> [SKIP][36] ([fdo#109271] / [fdo#111827]) +30 similar issues [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-snb6/igt@kms_color_chamelium@pipe-a-ctm-0-25.html * igt@kms_color_chamelium@pipe-a-ctm-blue-to-red: - shard-kbl: NOTRUN -> [SKIP][37] ([fdo#109271] / [fdo#111827]) [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-kbl4/igt@kms_color_chamelium@pipe-a-ctm-blue-to-red.html - shard-iclb: NOTRUN -> [SKIP][38] ([fdo#109284] / [fdo#111827]) [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-iclb5/igt@kms_color_chamelium@pipe-a-ctm-blue-to-red.html * igt@kms_color_chamelium@pipe-b-ctm-0-5: - shard-glk: NOTRUN -> [SKIP][39] ([fdo#109271] / [fdo#111827]) +5 similar issues [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-glk9/igt@kms_color_chamelium@pipe-b-ctm-0-5.html * igt@kms_color_chamelium@pipe-d-ctm-0-75: - shard-skl: NOTRUN -> [SKIP][40] ([fdo#109271] / [fdo#111827]) +2 similar issues [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-skl2/igt@kms_color_chamelium@pipe-d-ctm-0-75.html * igt@kms_color_chamelium@pipe-invalid-degamma-lut-sizes: - shard-tglb: NOTRUN -> [SKIP][41] ([fdo#109284] / [fdo#111827]) +2 similar issues [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-tglb8/igt@kms_color_chamelium@pipe-invalid-degamma-lut-sizes.html * igt@kms_content_protection@atomic-dpms: - shard-apl: NOTRUN -> [TIMEOUT][42] ([i915#1319]) +2 similar issues [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-apl2/igt@kms_content_protection@atomic-dpms.html * igt@kms_cursor_crc@pipe-a-cursor-max-size-offscreen: - shard-tglb: NOTRUN -> [SKIP][43] ([i915#3359]) [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-tglb8/igt@kms_cursor_crc@pipe-a-cursor-max-size-offscreen.html * igt@kms_cursor_crc@pipe-b-cursor-512x170-random: - shard-iclb: NOTRUN -> [SKIP][44] ([fdo#109278] / [fdo#109279]) [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-iclb5/igt@kms_cursor_crc@pipe-b-cursor-512x170-random.html * igt@kms_cursor_crc@pipe-c-cursor-suspend: - shard-kbl: NOTRUN -> [DMESG-WARN][45] ([i915#180]) [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-kbl1/igt@kms_cursor_crc@pipe-c-cursor-suspend.html * igt@kms_cursor_crc@pipe-d-cursor-512x512-sliding: - shard-glk: NOTRUN -> [SKIP][46] ([fdo#109271]) +50 similar issues [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-glk9/igt@kms_cursor_crc@pipe-d-cursor-512x512-sliding.html * igt@kms_cursor_legacy@2x-cursor-vs-flip-legacy: - shard-iclb: NOTRUN -> [SKIP][47] ([fdo#109274] / [fdo#109278]) [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-iclb5/igt@kms_cursor_legacy@2x-cursor-vs-flip-legacy.html * igt@kms_fbcon_fbt@fbc-suspend: - shard-kbl: [PASS][48] -> [INCOMPLETE][49] ([i915#155] / [i915#180] / [i915#636]) [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10153/shard-kbl2/igt@kms_fbcon_fbt@fbc-suspend.html [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-kbl3/igt@kms_fbcon_fbt@fbc-suspend.html * igt@kms_flip@2x-flip-vs-dpms-off-vs-modeset-interruptible: - shard-iclb: NOTRUN -> [SKIP][50] ([fdo#109274]) [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-iclb5/igt@kms_flip@2x-flip-vs-dpms-off-vs-modeset-interruptible.html * igt@kms_flip@plain-flip-ts-check@c-edp1: - shard-skl: [PASS][51] -> [FAIL][52] ([i915#2122]) [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10153/shard-skl7/igt@kms_flip@plain-flip-ts-check@c-edp1.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-skl6/igt@kms_flip@plain-flip-ts-check@c-edp1.html * igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile: - shard-glk: NOTRUN -> [SKIP][53] ([fdo#109271] / [i915#2642]) [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-glk4/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile.html * igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-shrfb-msflip-blt: - shard-iclb: NOTRUN -> [SKIP][54] ([fdo#109280]) +3 similar issues [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-iclb5/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-shrfb-msflip-blt.html * igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-mmap-gtt: - shard-tglb: NOTRUN -> [SKIP][55] ([fdo#111825]) +3 similar issues [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-tglb8/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-mmap-gtt.html * igt@kms_hdr@bpc-switch-dpms: - shard-skl: [PASS][56] -> [FAIL][57] ([i915#1188]) +1 similar issue [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10153/shard-skl7/igt@kms_hdr@bpc-switch-dpms.html [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-skl8/igt@kms_hdr@bpc-switch-dpms.html * igt@kms_pipe_b_c_ivb@enable-pipe-c-while-b-has-3-lanes: - shard-kbl: NOTRUN -> [SKIP][58] ([fdo#109271]) +29 similar issues [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-kbl1/igt@kms_pipe_b_c_ivb@enable-pipe-c-while-b-has-3-lanes.html * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d: - shard-apl: NOTRUN -> [SKIP][59] ([fdo#109271] / [i915#533]) +2 similar issues [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-apl3/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html * igt@kms_pipe_crc_basic@read-crc-pipe-d: - shard-kbl: NOTRUN -> [SKIP][60] ([fdo#109271] / [i915#533]) [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-kbl4/igt@kms_pipe_crc_basic@read-crc-pipe-d.html * igt@kms_pipe_crc_basic@read-crc-pipe-d-frame-sequence: - shard-skl: NOTRUN -> [SKIP][61] ([fdo#109271] / [i915#533]) [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-skl2/igt@kms_pipe_crc_basic@read-crc-pipe-d-frame-sequence.html * igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb: - shard-apl: NOTRUN -> [FAIL][62] ([i915#265]) [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-apl2/igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb.html * igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max: - shard-apl: NOTRUN -> [FAIL][63] ([fdo#108145] / [i915#265]) +1 similar issue [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-apl6/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max.html * igt@kms_plane_alpha_blend@pipe-c-alpha-7efc: - shard-skl: NOTRUN -> [FAIL][64] ([fdo#108145] / [i915#265]) [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-skl2/igt@kms_plane_alpha_blend@pipe-c-alpha-7efc.html * igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb: - shard-kbl: NOTRUN -> [FAIL][65] ([i915#265]) [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-kbl4/igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb.html * igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min: - shard-skl: [PASS][66] -> [FAIL][67] ([fdo#108145] / [i915#265]) [66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10153/shard-skl9/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-skl9/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html * igt@kms_plane_alpha_blend@pipe-d-alpha-transparent-fb: - shard-iclb: NOTRUN -> [SKIP][68] ([fdo#109278]) +9 similar issues [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-iclb5/igt@kms_plane_alpha_blend@pipe-d-alpha-transparent-fb.html * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2: - shard-apl: NOTRUN -> [SKIP][69] ([fdo#109271] / [i915#658]) +6 similar issues [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-apl7/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2.html * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3: - shard-skl: NOTRUN -> [SKIP][70] ([fdo#109271] / [i915#658]) [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-skl2/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3.html * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4: - shard-glk: NOTRUN -> [SKIP][71] ([fdo#109271] / [i915#658]) +1 similar issue [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-glk4/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4.html * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1: - shard-iclb: NOTRUN -> [SKIP][72] ([i915#658]) [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-iclb5/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1.html - shard-kbl: NOTRUN -> [SKIP][73] ([fdo#109271] / [i915#658]) [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-kbl4/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1.html * igt@kms_psr@psr2_primary_mmap_cpu: - shard-iclb: [PASS][74] -> [SKIP][75] ([fdo#109441]) +1 similar issue [74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10153/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-iclb5/igt@kms_psr@psr2_primary_mmap_cpu.html * igt@kms_psr@psr2_suspend: - shard-tglb: NOTRUN -> [FAIL][76] ([i915#132]) [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-tglb8/igt@kms_psr@psr2_suspend.html * igt@kms_vblank@pipe-a-ts-continuation-suspend: - shard-kbl: [PASS][77] -> [DMESG-WARN][78] ([i915#180] / [i915#295]) [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10153/shard-kbl3/igt@kms_vblank@pipe-a-ts-continuation-suspend.html [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-kbl2/igt@kms_vblank@pipe-a-ts-continuation-suspend.html * igt@kms_vblank@pipe-d-wait-idle: - shard-glk: NOTRUN -> [SKIP][79] ([fdo#109271] / [i915#533]) [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-glk9/igt@kms_vblank@pipe-d-wait-idle.html * igt@nouveau_crc@pipe-a-ctx-flip-skip-current-frame: - shard-iclb: NOTRUN -> [SKIP][80] ([i915#2530]) [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-iclb5/igt@nouveau_crc@pipe-a-ctx-flip-skip-current-frame.html * igt@perf@per-context-mode-unprivileged: - shard-iclb: NOTRUN -> [SKIP][81] ([fdo#109289]) [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-iclb5/igt@perf@per-context-mode-unprivileged.html * igt@prime_nv_api@nv_self_import_to_different_fd: - shard-tglb: NOTRUN -> [SKIP][82] ([fdo#109291]) [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-tglb8/igt@prime_nv_api@nv_self_import_to_different_fd.html * igt@sysfs_clients@create: - shard-apl: NOTRUN -> [SKIP][83] ([fdo#109271] / [i915#2994]) +3 similar issues [83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-apl2/igt@sysfs_clients@create.html * igt@sysfs_clients@fair-7: - shard-skl: NOTRUN -> [SKIP][84] ([fdo#109271] / [i915#2994]) [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-skl2/igt@sysfs_clients@fair-7.html #### Possible fixes #### * igt@gem_eio@unwedge-stress: - shard-tglb: [TIMEOUT][85] ([i915#2369] / [i915#3063]) -> [PASS][86] [85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10153/shard-tglb2/igt@gem_eio@unwedge-stress.html [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-tglb3/igt@gem_eio@unwedge-stress.html - shard-skl: [TIMEOUT][87] ([i915#2369] / [i915#3063]) -> [PASS][88] [87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10153/shard-skl9/igt@gem_eio@unwedge-stress.html [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-skl9/igt@gem_eio@unwedge-stress.html * igt@gem_exec_fair@basic-none-share@rcs0: - shard-iclb: [FAIL][89] ([i915#2842]) -> [PASS][90] [89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10153/shard-iclb3/igt@gem_exec_fair@basic-none-share@rcs0.html [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-iclb5/igt@gem_exec_fair@basic-none-share@rcs0.html * igt@gem_exec_fair@basic-none-solo@rcs0: - shard-glk: [FAIL][91] ([i915#2842]) -> [PASS][92] [91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10153/shard-glk1/igt@gem_exec_fair@basic-none-solo@rcs0.html [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-glk7/igt@gem_exec_fair@basic-none-solo@rcs0.html * igt@gem_exec_fair@basic-pace-solo@rcs0: - shard-kbl: [FAIL][93] ([i915#2842]) -> [PASS][94] [93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10153/shard-kbl2/igt@gem_exec_fair@basic-pace-solo@rcs0.html [94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-kbl7/igt@gem_exec_fair@basic-pace-solo@rcs0.html * igt@gem_exec_whisper@basic-contexts-priority: - shard-iclb: [INCOMPLETE][95] ([i915#1895]) -> [PASS][96] [95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10153/shard-iclb5/igt@gem_exec_whisper@basic-contexts-priority.html [96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-iclb5/igt@gem_exec_whisper@basic-contexts-priority.html * igt@gem_exec_whisper@basic-fds-forked: - shard-glk: [DMESG-WARN][97] ([i915#118] / [i915#95]) -> [PASS][98] [97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10153/shard-glk5/igt@gem_exec_whisper@basic-fds-forked.html [98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-glk9/igt@gem_exec_whisper@basic-fds-forked.html * igt@gem_huc_copy@huc-copy: - shard-tglb: [SKIP][99] ([i915#2190]) -> [PASS][100] [99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10153/shard-tglb6/igt@gem_huc_copy@huc-copy.html [100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-tglb5/igt@gem_huc_copy@huc-copy.html * igt@gem_mmap_gtt@big-copy: - shard-skl: [FAIL][101] ([i915#307]) -> [PASS][102] [101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10153/shard-skl3/igt@gem_mmap_gtt@big-copy.html [102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-skl2/igt@gem_mmap_gtt@big-copy.html * igt@gem_mmap_gtt@cpuset-basic-small-copy: - shard-glk: [INCOMPLETE][103] ([i915#2055] / [i915#3468]) -> [PASS][104] +1 similar issue [103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10153/shard-glk4/igt@gem_mmap_gtt@cpuset-basic-small-copy.html [104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-glk9/igt@gem_mmap_gtt@cpuset-basic-small-copy.html * igt@gem_mmap_gtt@cpuset-basic-small-copy-odd: - shard-tglb: [INCOMPLETE][105] ([i915#2910] / [i915#3468]) -> [PASS][106] [105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10153/shard-tglb5/igt@gem_mmap_gtt@cpuset-basic-small-copy-odd.html [106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-tglb8/igt@gem_mmap_gtt@cpuset-basic-small-copy-odd.html * igt@kms_color@pipe-c-ctm-max: - shard-skl: [DMESG-WARN][107] ([i915#1982]) -> [PASS][108] [107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10153/shard-skl4/igt@kms_color@pipe-c-ctm-max.html [108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-skl10/igt@kms_color@pipe-c-ctm-max.html * igt@kms_cursor_edge_walk@pipe-a-256x256-left-edge: - shard-glk: [DMESG-FAIL][109] ([i915#118] / [i915#70] / [i915#95]) -> [PASS][110] [109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10153/shard-glk8/igt@kms_cursor_edge_walk@pipe-a-256x256-left-edge.html [110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-glk8/igt@kms_cursor_edge_walk@pipe-a-256x256-left-edge.html * igt@kms_flip@flip-vs-suspend-interruptible@a-dp1: - shard-kbl: [DMESG-WARN][111] ([i915#180]) -> [PASS][112] +4 similar issues [111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10153/shard-kbl4/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html [112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-kbl2/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html * igt@kms_flip@plain-flip-ts-check-interruptible@c-edp1: - shard-skl: [FAIL][113] ([i915#2122]) -> [PASS][114] +1 similar issue [113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10153/shard-skl3/igt@kms_flip@plain-flip-ts-check-interruptible@c-edp1.html [114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-skl5/igt@kms_flip@plain-flip-ts-check-interruptible@c-edp1.html * igt@kms_hdr@bpc-switch: - shard-skl: [FAIL][115] ([i915#1188]) -> [PASS][116] [115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10153/shard-skl3/igt@kms_hdr@bpc-switch.html [116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-skl6/igt@kms_hdr@bpc-switch.html * igt@kms_plane@pixel-format-source-clamping@pipe-a-planes: - shard-skl: [INCOMPLETE][117] ([i915#1982]) -> [PASS][118] [117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10153/shard-skl8/igt@kms_plane@pixel-format-source-clamping@pipe-a-planes.html [118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-skl2/igt@kms_plane@pixel-format-source-clamping@pipe-a-planes.html * igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min: - shard-skl: [FAIL][119] ([fdo#108145] / [i915#265]) -> [PASS][120] [119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10153/shard-skl4/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html [120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-skl10/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html * igt@kms_psr@psr2_dpms: - shard-iclb: [SKIP][121] ([fdo#109441]) -> [PASS][122] +1 similar issue [121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10153/shard-iclb3/igt@kms_psr@psr2_dpms.html [122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-iclb2/igt@kms_psr@psr2_dpms.html * igt@perf@polling-parameterized: - shard-skl: [FAIL][123] ([i915#1542]) -> [PASS][124] [123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10153/shard-skl6/igt@perf@polling-parameterized.html [124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-skl3/igt@perf@polling-parameterized.html * igt@perf@polling-small-buf: - shard-skl: [FAIL][125] ([i915#1722]) -> [PASS][126] [125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10153/shard-skl3/igt@perf@polling-small-buf.html [126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-skl5/igt@perf@polling-small-buf.html #### Warnings #### * igt@gem_exec_fair@basic-none-rrul@rcs0: - shard-iclb: [FAIL][127] ([i915#2852]) -> [FAIL][128] ([i915#2842]) [127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10153/shard-iclb2/igt@gem_exec_fair@basic-none-rrul@rcs0.html [128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-iclb2/igt@gem_exec_fair@basic-none-rrul@rcs0.html * igt@gem_mmap_gtt@cpuset-basic-small-copy-odd: - shard-skl: [INCOMPLETE][129] ([i915#198] / [i915#2910] / [i915#3468]) -> [INCOMPLETE][130] ([i915#198] / [i915#2910]) [129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10153/shard-skl6/igt@gem_mmap_gtt@cpuset-basic-small-copy-odd.html [130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-skl6/igt@gem_mmap_gtt@cpuset-basic-small-copy-odd.html * igt@gem_mmap_gtt@cpuset-basic-small-copy-xy: - shard-skl: [INCOMPLETE][131] ([i915#198] / [i915#3468]) -> [INCOMPLETE][132] ([i915#198]) [131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10153/shard-skl9/igt@gem_mmap_gtt@cpuset-basic-small-copy-xy.html [132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-skl9/igt@gem_mmap_gtt@cpuset-basic-small-copy-xy.html * igt@i915_pm_dc@dc3co-vpb-simulation: - shard-iclb: [SKIP][133] ([i915#588]) -> [SKIP][134] ([i915#658]) [133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10153/shard-iclb2/igt@i915_pm_dc@dc3co-vpb-simulation.html [134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-iclb5/igt@i915_pm_dc@dc3co-vpb-simulation.html * igt@i915_pm_rc6_residency@rc6-fence: - shard-iclb: [WARN][135] ([i915#2684]) -> [WARN][136] ([i915#1804] / [i915#2684]) +1 similar issue [135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10153/shard-iclb8/igt@i915_pm_rc6_residency@rc6-fence.html [136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-iclb3/igt@i915_pm_rc6_residency@rc6-fence.html * igt@i915_selftest@live@execlists: - shard-tglb: [DMESG-FAIL][137] ([i915#3462]) -> [INCOMPLETE][138] ([i915#3462]) [137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10153/shard-tglb2/igt@i915_selftest@live@execlists.html [138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/shard-tglb8/igt@i915_selftest@live@execlists.html * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4: - shard-iclb: [SKIP][139] ([i915#658]) -> [SKIP][140] ([i915#2920]) +1 similar issue [139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10153/shard == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20241/index.html [-- Attachment #1.2: Type: text/html, Size: 33604 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2021-07-08 7:08 UTC | newest] Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-05-31 20:46 [PATCH v2 0/2] GPD Win Max display fixes Anisse Astier 2021-05-31 20:46 ` [Intel-gfx] " Anisse Astier 2021-05-31 20:46 ` [PATCH v2 1/2] drm/i915/opregion: add support for mailbox #5 EDID Anisse Astier 2021-05-31 20:46 ` [Intel-gfx] " Anisse Astier 2021-06-01 15:50 ` Ville Syrjälä 2021-06-01 15:50 ` [Intel-gfx] " Ville Syrjälä 2021-06-01 22:43 ` Anisse Astier 2021-06-01 22:43 ` [Intel-gfx] " Anisse Astier 2021-07-07 19:57 ` Daniel Dadap 2021-07-07 19:57 ` [Intel-gfx] " Daniel Dadap 2021-07-07 21:30 ` Anisse Astier 2021-07-07 21:30 ` [Intel-gfx] " Anisse Astier 2021-05-31 20:46 ` [PATCH v2 2/2] drm: Add orientation quirk for GPD Win Max Anisse Astier 2021-05-31 20:46 ` [Intel-gfx] " Anisse Astier 2021-05-31 20:58 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for GPD Win Max display fixes (rev2) Patchwork 2021-05-31 20:59 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork 2021-05-31 21:27 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2021-05-31 22:52 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.