* [Buildroot] [URGENT] [PATCH 0/1] Fix Buildroot Makefile failure on lvm2
@ 2021-06-03 0:58 Giulio Benetti
2021-06-03 0:58 ` [Buildroot] [PATCH 1/1] package/lvm2: remove endif that prevents Buildroot to use Makefiles at all Giulio Benetti
2021-06-03 7:32 ` [Buildroot] [URGENT] [PATCH 0/1] Fix Buildroot Makefile failure on lvm2 Arnout Vandecappelle
0 siblings, 2 replies; 5+ messages in thread
From: Giulio Benetti @ 2021-06-03 0:58 UTC (permalink / raw)
To: buildroot
Commit 8a313b019c7d7e898186a8b08f9c25ae0194fa16 prevents Buildroot to
make any target due to a endif left behing in lvm2.mk. Following patch
removes it and make Buildroot to work again.
Giulio Benetti (1):
package/lvm2: remove endif that prevents Buildroot to use Makefiles at
all
package/lvm2/lvm2.mk | 2 --
1 file changed, 2 deletions(-)
--
2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] package/lvm2: remove endif that prevents Buildroot to use Makefiles at all
2021-06-03 0:58 [Buildroot] [URGENT] [PATCH 0/1] Fix Buildroot Makefile failure on lvm2 Giulio Benetti
@ 2021-06-03 0:58 ` Giulio Benetti
2021-06-03 7:32 ` [Buildroot] [URGENT] [PATCH 0/1] Fix Buildroot Makefile failure on lvm2 Arnout Vandecappelle
1 sibling, 0 replies; 5+ messages in thread
From: Giulio Benetti @ 2021-06-03 0:58 UTC (permalink / raw)
To: buildroot
Commit [1] breaks Buildroot Makefile since a Makefile endif has been left
with no sense giving following error:
package/lvm2/lvm2.mk:61: *** extraneous 'endif'. Stop.
So let's remove that forgotten endif.
[1]: https://git.buildroot.net/buildroot/commit/?id=8a313b019c7d7e898186a8b08f9c25ae0194fa16
Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
package/lvm2/lvm2.mk | 2 --
1 file changed, 2 deletions(-)
diff --git a/package/lvm2/lvm2.mk b/package/lvm2/lvm2.mk
index 70787fe91b..5ce79768b6 100644
--- a/package/lvm2/lvm2.mk
+++ b/package/lvm2/lvm2.mk
@@ -58,8 +58,6 @@ LVM2_INSTALL_STAGING_OPTS += install_device-mapper
LVM2_INSTALL_TARGET_OPTS += install_device-mapper
endif
-endif
-
ifeq ($(BR2_TOOLCHAIN_SUPPORTS_PIE),)
LVM2_CONF_ENV += ac_cv_flag_HAVE_PIE=no
endif
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [URGENT] [PATCH 0/1] Fix Buildroot Makefile failure on lvm2
2021-06-03 0:58 [Buildroot] [URGENT] [PATCH 0/1] Fix Buildroot Makefile failure on lvm2 Giulio Benetti
2021-06-03 0:58 ` [Buildroot] [PATCH 1/1] package/lvm2: remove endif that prevents Buildroot to use Makefiles at all Giulio Benetti
@ 2021-06-03 7:32 ` Arnout Vandecappelle
2021-06-03 10:05 ` Giulio Benetti
1 sibling, 1 reply; 5+ messages in thread
From: Arnout Vandecappelle @ 2021-06-03 7:32 UTC (permalink / raw)
To: buildroot
On 03/06/2021 02:58, Giulio Benetti wrote:
> Commit 8a313b019c7d7e898186a8b08f9c25ae0194fa16 prevents Buildroot to
> make any target due to a endif left behing in lvm2.mk. Following patch
> removes it and make Buildroot to work again.
Gah. I had first applied it to next and tested it there, and then I saw that it
was actually a fix so I cherry-picked it on master. There was a merge conflict
but it got resolved automatically so I didn't look at it :-(
Thanks for the quick fix!
Applied to master, thanks.
Regards,
Arnout
>
> Giulio Benetti (1):
> package/lvm2: remove endif that prevents Buildroot to use Makefiles at
> all
>
> package/lvm2/lvm2.mk | 2 --
> 1 file changed, 2 deletions(-)
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [URGENT] [PATCH 0/1] Fix Buildroot Makefile failure on lvm2
2021-06-03 7:32 ` [Buildroot] [URGENT] [PATCH 0/1] Fix Buildroot Makefile failure on lvm2 Arnout Vandecappelle
@ 2021-06-03 10:05 ` Giulio Benetti
2021-06-03 10:18 ` Arnout Vandecappelle
0 siblings, 1 reply; 5+ messages in thread
From: Giulio Benetti @ 2021-06-03 10:05 UTC (permalink / raw)
To: buildroot
On 6/3/21 9:32 AM, Arnout Vandecappelle wrote:
>
>
> On 03/06/2021 02:58, Giulio Benetti wrote:
>> Commit 8a313b019c7d7e898186a8b08f9c25ae0194fa16 prevents Buildroot to
>> make any target due to a endif left behing in lvm2.mk. Following patch
>> removes it and make Buildroot to work again.
>
> Gah. I had first applied it to next and tested it there, and then I saw that it
> was actually a fix so I cherry-picked it on master. There was a merge conflict
> but it got resolved automatically so I didn't look at it :-(
It happens :-)
> Thanks for the quick fix!
>
> Applied to master, thanks.
I see you didn't push, or am I wrong? My worry is that autobuilders
start to fail every build. I don't know how often they pull master.
Best regards
--
Giulio Benetti
Benetti Engineering sas
> Regards,
> Arnout
>
>>
>> Giulio Benetti (1):
>> package/lvm2: remove endif that prevents Buildroot to use Makefiles at
>> all
>>
>> package/lvm2/lvm2.mk | 2 --
>> 1 file changed, 2 deletions(-)
>>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [URGENT] [PATCH 0/1] Fix Buildroot Makefile failure on lvm2
2021-06-03 10:05 ` Giulio Benetti
@ 2021-06-03 10:18 ` Arnout Vandecappelle
0 siblings, 0 replies; 5+ messages in thread
From: Arnout Vandecappelle @ 2021-06-03 10:18 UTC (permalink / raw)
To: buildroot
On 03/06/2021 12:05, Giulio Benetti wrote:
> On 6/3/21 9:32 AM, Arnout Vandecappelle wrote:
>>
>>
>> On 03/06/2021 02:58, Giulio Benetti wrote:
>>> Commit 8a313b019c7d7e898186a8b08f9c25ae0194fa16 prevents Buildroot to
>>> make any target due to a endif left behing in lvm2.mk. Following patch
>>> removes it and make Buildroot to work again.
>>
>> ? Gah. I had first applied it to next and tested it there, and then I saw that it
>> was actually a fix so I cherry-picked it on master. There was a merge conflict
>> but it got resolved automatically so I didn't look at it :-(
>
> It happens :-)
>
>> ? Thanks for the quick fix!
>>
>> ? Applied to master, thanks.
>
> I see you didn't push, or am I wrong? My worry is that autobuilders start to
> fail every build. I don't know how often they pull master.
Indeed I forgot to push. Concentrate, Arnout!
Regards,
Arnout
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-06-03 10:18 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-03 0:58 [Buildroot] [URGENT] [PATCH 0/1] Fix Buildroot Makefile failure on lvm2 Giulio Benetti
2021-06-03 0:58 ` [Buildroot] [PATCH 1/1] package/lvm2: remove endif that prevents Buildroot to use Makefiles at all Giulio Benetti
2021-06-03 7:32 ` [Buildroot] [URGENT] [PATCH 0/1] Fix Buildroot Makefile failure on lvm2 Arnout Vandecappelle
2021-06-03 10:05 ` Giulio Benetti
2021-06-03 10:18 ` Arnout Vandecappelle
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.