[Buildroot] [URGENT] [PATCH 0/1] Fix Buildroot Makefile failure on lvm2

[Buildroot] [URGENT] [PATCH 0/1] Fix Buildroot Makefile failure on lvm2

[Giulio Benetti]

Commit 8a313b019c7d7e898186a8b08f9c25ae0194fa16 prevents Buildroot to
make any target due to a endif left behing in lvm2.mk. Following patch
removes it and make Buildroot to work again.

Giulio Benetti (1):
  package/lvm2: remove endif that prevents Buildroot to use Makefiles at
    all

 package/lvm2/lvm2.mk | 2 --
 1 file changed, 2 deletions(-)

-- 
2.25.1

[Buildroot] [PATCH 1/1] package/lvm2: remove endif that prevents Buildroot to use Makefiles at all

[Giulio Benetti]

Commit [1] breaks Buildroot Makefile since a Makefile endif has been left
with no sense giving following error:
package/lvm2/lvm2.mk:61: *** extraneous 'endif'.  Stop.

So let's remove that forgotten endif.

[1]: https://git.buildroot.net/buildroot/commit/?id=8a313b019c7d7e898186a8b08f9c25ae0194fa16

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 package/lvm2/lvm2.mk | 2 --
 1 file changed, 2 deletions(-)

diff --git a/package/lvm2/lvm2.mk b/package/lvm2/lvm2.mk
index 70787fe91b..5ce79768b6 100644
--- a/package/lvm2/lvm2.mk
+++ b/package/lvm2/lvm2.mk
@@ -58,8 +58,6 @@ LVM2_INSTALL_STAGING_OPTS += install_device-mapper
 LVM2_INSTALL_TARGET_OPTS += install_device-mapper
 endif
 
-endif
-
 ifeq ($(BR2_TOOLCHAIN_SUPPORTS_PIE),)
 LVM2_CONF_ENV += ac_cv_flag_HAVE_PIE=no
 endif
-- 
2.25.1

[Buildroot] [URGENT] [PATCH 0/1] Fix Buildroot Makefile failure on lvm2

[Arnout Vandecappelle]

On 03/06/2021 02:58, Giulio Benetti wrote:
> Commit 8a313b019c7d7e898186a8b08f9c25ae0194fa16 prevents Buildroot to
> make any target due to a endif left behing in lvm2.mk. Following patch
> removes it and make Buildroot to work again.

 Gah. I had first applied it to next and tested it there, and then I saw that it
was actually a fix so I cherry-picked it on master. There was a merge conflict
but it got resolved automatically so I didn't look at it :-(

 Thanks for the quick fix!

 Applied to master, thanks.

 Regards,
 Arnout

> 
> Giulio Benetti (1):
>   package/lvm2: remove endif that prevents Buildroot to use Makefiles at
>     all
> 
>  package/lvm2/lvm2.mk | 2 --
>  1 file changed, 2 deletions(-)
> 

[Buildroot] [URGENT] [PATCH 0/1] Fix Buildroot Makefile failure on lvm2

[Giulio Benetti]

On 6/3/21 9:32 AM, Arnout Vandecappelle wrote:
> 
> 
> On 03/06/2021 02:58, Giulio Benetti wrote:
>> Commit 8a313b019c7d7e898186a8b08f9c25ae0194fa16 prevents Buildroot to
>> make any target due to a endif left behing in lvm2.mk. Following patch
>> removes it and make Buildroot to work again.
> 
>   Gah. I had first applied it to next and tested it there, and then I saw that it
> was actually a fix so I cherry-picked it on master. There was a merge conflict
> but it got resolved automatically so I didn't look at it :-(

It happens :-)

>   Thanks for the quick fix!
> 
>   Applied to master, thanks.

I see you didn't push, or am I wrong? My worry is that autobuilders 
start to fail every build. I don't know how often they pull master.

Best regards
-- 
Giulio Benetti
Benetti Engineering sas

>   Regards,
>   Arnout
> 
>>
>> Giulio Benetti (1):
>>    package/lvm2: remove endif that prevents Buildroot to use Makefiles at
>>      all
>>
>>   package/lvm2/lvm2.mk | 2 --
>>   1 file changed, 2 deletions(-)
>>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
> 

[Buildroot] [URGENT] [PATCH 0/1] Fix Buildroot Makefile failure on lvm2

[Arnout Vandecappelle]

On 03/06/2021 12:05, Giulio Benetti wrote:
> On 6/3/21 9:32 AM, Arnout Vandecappelle wrote:
>>
>>
>> On 03/06/2021 02:58, Giulio Benetti wrote:
>>> Commit 8a313b019c7d7e898186a8b08f9c25ae0194fa16 prevents Buildroot to
>>> make any target due to a endif left behing in lvm2.mk. Following patch
>>> removes it and make Buildroot to work again.
>>
>> ? Gah. I had first applied it to next and tested it there, and then I saw that it
>> was actually a fix so I cherry-picked it on master. There was a merge conflict
>> but it got resolved automatically so I didn't look at it :-(
> 
> It happens :-)
> 
>> ? Thanks for the quick fix!
>>
>> ? Applied to master, thanks.
> 
> I see you didn't push, or am I wrong? My worry is that autobuilders start to
> fail every build. I don't know how often they pull master.

 Indeed I forgot to push. Concentrate, Arnout!

 Regards,
 Arnout