All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: "Geoffrey D. Bennett" <g@b4.vu>,
	alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.de>
Cc: Daniel Sales <daniel.sales.z@gmail.com>,
	Markus Schroetter <project.m.schroetter@gmail.com>,
	kbuild-all@lists.01.org, Vladimir Sadovnikov <sadko4u@gmail.com>,
	Alex Fellows <alex.fellows@gmail.com>
Subject: Re: [PATCH 1/2] ALSA: usb-audio: scarlett2: Read mixer volumes at init time
Date: Mon, 7 Jun 2021 13:23:25 +0800	[thread overview]
Message-ID: <202106071344.mIPQV62F-lkp@intel.com> (raw)
In-Reply-To: <68f57d71862e1c858e48dd6c0a6c68342ac53fc9.1622974661.git.g@b4.vu>

[-- Attachment #1: Type: text/plain, Size: 3877 bytes --]

Hi "Geoffrey,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on v5.13-rc4]
[also build test WARNING on next-20210604]
[cannot apply to sound/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Geoffrey-D-Bennett/ALSA-usb-audio-scarlett2-Read-all-configuration-at-init-time/20210606-222037
base:    8124c8a6b35386f73523d27eacb71b5364a68c4c
config: xtensa-randconfig-s032-20210607 (attached as .config)
compiler: xtensa-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.3-341-g8af24329-dirty
        # https://github.com/0day-ci/linux/commit/4cd436ec424b3564c2dcf9b3b8fd83c8894051f1
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Geoffrey-D-Bennett/ALSA-usb-audio-scarlett2-Read-all-configuration-at-init-time/20210606-222037
        git checkout 4cd436ec424b3564c2dcf9b3b8fd83c8894051f1
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=xtensa 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)
>> sound/usb/mixer_scarlett_gen2.c:809:21: sparse: sparse: incorrect type in assignment (different base types) @@     expected restricted __le16 [usertype] mix_num @@     got int mix_num @@
   sound/usb/mixer_scarlett_gen2.c:809:21: sparse:     expected restricted __le16 [usertype] mix_num
   sound/usb/mixer_scarlett_gen2.c:809:21: sparse:     got int mix_num
>> sound/usb/mixer_scarlett_gen2.c:810:19: sparse: sparse: incorrect type in assignment (different base types) @@     expected restricted __le16 [usertype] count @@     got int num_mixer_in @@
   sound/usb/mixer_scarlett_gen2.c:810:19: sparse:     expected restricted __le16 [usertype] count
   sound/usb/mixer_scarlett_gen2.c:810:19: sparse:     got int num_mixer_in

vim +809 sound/usb/mixer_scarlett_gen2.c

   788	
   789	/* Send a USB message to get the volumes for all inputs of one mix
   790	 * and put the values into private->mix[]
   791	 */
   792	static int scarlett2_usb_get_mix(struct usb_mixer_interface *mixer,
   793					 int mix_num)
   794	{
   795		struct scarlett2_mixer_data *private = mixer->private_data;
   796		const struct scarlett2_device_info *info = private->info;
   797	
   798		int num_mixer_in =
   799			info->ports[SCARLETT2_PORT_TYPE_MIX].num[SCARLETT2_PORT_OUT];
   800		int err, i, j, k;
   801	
   802		struct {
   803			__le16 mix_num;
   804			__le16 count;
   805		} __packed req;
   806	
   807		__le16 data[SCARLETT2_INPUT_MIX_MAX];
   808	
 > 809		req.mix_num = mix_num;
 > 810		req.count = num_mixer_in;
   811	
   812		err = scarlett2_usb(mixer, SCARLETT2_USB_GET_MIX,
   813				    &req, sizeof(req),
   814				    data, num_mixer_in * sizeof(u16));
   815		if (err < 0)
   816			return err;
   817	
   818		for (i = 0, j = mix_num * num_mixer_in; i < num_mixer_in; i++, j++) {
   819			u16 mixer_value = le16_to_cpu(data[i]);
   820	
   821			for (k = 0; k < SCARLETT2_MIXER_VALUE_COUNT; k++)
   822				if (scarlett2_mixer_values[k] >= mixer_value)
   823					break;
   824			if (k == SCARLETT2_MIXER_VALUE_COUNT)
   825				k = SCARLETT2_MIXER_MAX_VALUE;
   826			private->mix[j] = k;
   827		}
   828	
   829		return 0;
   830	}
   831	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 28418 bytes --]

WARNING: multiple messages have this Message-ID
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 1/2] ALSA: usb-audio: scarlett2: Read mixer volumes at init time
Date: Mon, 07 Jun 2021 13:23:25 +0800	[thread overview]
Message-ID: <202106071344.mIPQV62F-lkp@intel.com> (raw)
In-Reply-To: <68f57d71862e1c858e48dd6c0a6c68342ac53fc9.1622974661.git.g@b4.vu>

[-- Attachment #1: Type: text/plain, Size: 3968 bytes --]

Hi "Geoffrey,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on v5.13-rc4]
[also build test WARNING on next-20210604]
[cannot apply to sound/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Geoffrey-D-Bennett/ALSA-usb-audio-scarlett2-Read-all-configuration-at-init-time/20210606-222037
base:    8124c8a6b35386f73523d27eacb71b5364a68c4c
config: xtensa-randconfig-s032-20210607 (attached as .config)
compiler: xtensa-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.3-341-g8af24329-dirty
        # https://github.com/0day-ci/linux/commit/4cd436ec424b3564c2dcf9b3b8fd83c8894051f1
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Geoffrey-D-Bennett/ALSA-usb-audio-scarlett2-Read-all-configuration-at-init-time/20210606-222037
        git checkout 4cd436ec424b3564c2dcf9b3b8fd83c8894051f1
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=xtensa 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)
>> sound/usb/mixer_scarlett_gen2.c:809:21: sparse: sparse: incorrect type in assignment (different base types) @@     expected restricted __le16 [usertype] mix_num @@     got int mix_num @@
   sound/usb/mixer_scarlett_gen2.c:809:21: sparse:     expected restricted __le16 [usertype] mix_num
   sound/usb/mixer_scarlett_gen2.c:809:21: sparse:     got int mix_num
>> sound/usb/mixer_scarlett_gen2.c:810:19: sparse: sparse: incorrect type in assignment (different base types) @@     expected restricted __le16 [usertype] count @@     got int num_mixer_in @@
   sound/usb/mixer_scarlett_gen2.c:810:19: sparse:     expected restricted __le16 [usertype] count
   sound/usb/mixer_scarlett_gen2.c:810:19: sparse:     got int num_mixer_in

vim +809 sound/usb/mixer_scarlett_gen2.c

   788	
   789	/* Send a USB message to get the volumes for all inputs of one mix
   790	 * and put the values into private->mix[]
   791	 */
   792	static int scarlett2_usb_get_mix(struct usb_mixer_interface *mixer,
   793					 int mix_num)
   794	{
   795		struct scarlett2_mixer_data *private = mixer->private_data;
   796		const struct scarlett2_device_info *info = private->info;
   797	
   798		int num_mixer_in =
   799			info->ports[SCARLETT2_PORT_TYPE_MIX].num[SCARLETT2_PORT_OUT];
   800		int err, i, j, k;
   801	
   802		struct {
   803			__le16 mix_num;
   804			__le16 count;
   805		} __packed req;
   806	
   807		__le16 data[SCARLETT2_INPUT_MIX_MAX];
   808	
 > 809		req.mix_num = mix_num;
 > 810		req.count = num_mixer_in;
   811	
   812		err = scarlett2_usb(mixer, SCARLETT2_USB_GET_MIX,
   813				    &req, sizeof(req),
   814				    data, num_mixer_in * sizeof(u16));
   815		if (err < 0)
   816			return err;
   817	
   818		for (i = 0, j = mix_num * num_mixer_in; i < num_mixer_in; i++, j++) {
   819			u16 mixer_value = le16_to_cpu(data[i]);
   820	
   821			for (k = 0; k < SCARLETT2_MIXER_VALUE_COUNT; k++)
   822				if (scarlett2_mixer_values[k] >= mixer_value)
   823					break;
   824			if (k == SCARLETT2_MIXER_VALUE_COUNT)
   825				k = SCARLETT2_MIXER_MAX_VALUE;
   826			private->mix[j] = k;
   827		}
   828	
   829		return 0;
   830	}
   831	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 28418 bytes --]

  parent reply	other threads:[~2021-06-07  5:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-06 14:16 [PATCH 0/2] ALSA: usb-audio: scarlett2: Read all configuration at init time Geoffrey D. Bennett
2021-06-06 14:16 ` [PATCH 1/2] ALSA: usb-audio: scarlett2: Read mixer volumes " Geoffrey D. Bennett
2021-06-06 14:32   ` Markus
2021-06-07  5:23   ` kernel test robot [this message]
2021-06-07  5:23     ` kernel test robot
2021-06-06 14:17 ` [PATCH 2/2] ALSA: usb-audio: scarlett2: Read mux " Geoffrey D. Bennett
2021-06-06 14:33   ` Markus
2021-06-07  7:23 ` [PATCH 0/2] ALSA: usb-audio: scarlett2: Read all configuration " Takashi Iwai
     [not found]   ` <3c7a458a-a5cd-08e4-a462-293c5bf633ec@gmail.com>
2021-06-07 15:12     ` Takashi Iwai
2021-06-07 17:18       ` Markus Schroetter
2021-06-07 19:51   ` Geoffrey D. Bennett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202106071344.mIPQV62F-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=alex.fellows@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=daniel.sales.z@gmail.com \
    --cc=g@b4.vu \
    --cc=kbuild-all@lists.01.org \
    --cc=project.m.schroetter@gmail.com \
    --cc=sadko4u@gmail.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.