From: Jiang Wang <jiang.wang@bytedance.com> To: sgarzare@redhat.com Cc: virtualization@lists.linux-foundation.org, stefanha@redhat.com, mst@redhat.com, arseny.krasnov@kaspersky.com, jhansen@vmware.comments, cong.wang@bytedance.com, duanxiongchun@bytedance.com, xieyongji@bytedance.com, chaiwen.cc@bytedance.com, Jason Wang <jasowang@redhat.com>, "David S. Miller" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org>, Steven Rostedt <rostedt@goodmis.org>, Ingo Molnar <mingo@redhat.com>, Colin Ian King <colin.king@canonical.com>, Norbert Slusarek <nslusarek@gmx.net>, Andra Paraschiv <andraprs@amazon.com>, Lu Wei <luwei32@huawei.com>, Alexander Popov <alex.popov@linux.com>, kvm@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RFC v1 6/6] virtio/vsock: add sysfs for rx buf len for dgram Date: Wed, 9 Jun 2021 23:24:58 +0000 [thread overview] Message-ID: <20210609232501.171257-7-jiang.wang@bytedance.com> (raw) In-Reply-To: <20210609232501.171257-1-jiang.wang@bytedance.com> Make rx buf len configurable via sysfs Signed-off-by: Jiang Wang <jiang.wang@bytedance.com> --- net/vmw_vsock/virtio_transport.c | 37 +++++++++++++++++++++++++++++++++++-- 1 file changed, 35 insertions(+), 2 deletions(-) diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c index cf47aadb0c34..2e4dd9c48472 100644 --- a/net/vmw_vsock/virtio_transport.c +++ b/net/vmw_vsock/virtio_transport.c @@ -29,6 +29,14 @@ static struct virtio_vsock __rcu *the_virtio_vsock; static struct virtio_vsock *the_virtio_vsock_dgram; static DEFINE_MUTEX(the_virtio_vsock_mutex); /* protects the_virtio_vsock */ +static int rx_buf_len = VIRTIO_VSOCK_DEFAULT_RX_BUF_SIZE; +static struct kobject *kobj_ref; +static ssize_t sysfs_show(struct kobject *kobj, + struct kobj_attribute *attr, char *buf); +static ssize_t sysfs_store(struct kobject *kobj, + struct kobj_attribute *attr, const char *buf, size_t count); +static struct kobj_attribute rxbuf_attr = __ATTR(rx_buf_value, 0660, sysfs_show, sysfs_store); + struct virtio_vsock { struct virtio_device *vdev; struct virtqueue **vqs; @@ -360,7 +368,7 @@ virtio_transport_cancel_pkt(struct vsock_sock *vsk) static void virtio_vsock_rx_fill(struct virtio_vsock *vsock, bool is_dgram) { - int buf_len = VIRTIO_VSOCK_DEFAULT_RX_BUF_SIZE; + int buf_len = rx_buf_len; struct virtio_vsock_pkt *pkt; struct scatterlist hdr, buf, *sgs[2]; struct virtqueue *vq; @@ -1003,6 +1011,22 @@ static struct virtio_driver virtio_vsock_driver = { .remove = virtio_vsock_remove, }; +static ssize_t sysfs_show(struct kobject *kobj, + struct kobj_attribute *attr, char *buf) +{ + return sprintf(buf, "%d", rx_buf_len); +} + +static ssize_t sysfs_store(struct kobject *kobj, + struct kobj_attribute *attr, const char *buf, size_t count) +{ + if (kstrtou32(buf, 0, &rx_buf_len) < 0) + return -EINVAL; + if (rx_buf_len < 1024) + rx_buf_len = 1024; + return count; +} + static int __init virtio_vsock_init(void) { int ret; @@ -1020,8 +1044,17 @@ static int __init virtio_vsock_init(void) if (ret) goto out_vci; - return 0; + kobj_ref = kobject_create_and_add("vsock", kernel_kobj); + /*Creating sysfs file for etx_value*/ + ret = sysfs_create_file(kobj_ref, &rxbuf_attr.attr); + if (ret) + goto out_sysfs; + + return 0; +out_sysfs: + kobject_put(kobj_ref); + sysfs_remove_file(kernel_kobj, &rxbuf_attr.attr); out_vci: vsock_core_unregister(&virtio_transport.transport); out_wq: -- 2.11.0
WARNING: multiple messages have this Message-ID (diff)
From: Jiang Wang <jiang.wang@bytedance.com> To: sgarzare@redhat.com Cc: cong.wang@bytedance.com, Andra Paraschiv <andraprs@amazon.com>, kvm@vger.kernel.org, mst@redhat.com, virtualization@lists.linux-foundation.org, Norbert Slusarek <nslusarek@gmx.net>, jhansen@vmware.comments, duanxiongchun@bytedance.com, xieyongji@bytedance.com, Ingo Molnar <mingo@redhat.com>, Jakub Kicinski <kuba@kernel.org>, Alexander Popov <alex.popov@linux.com>, Steven Rostedt <rostedt@goodmis.org>, chaiwen.cc@bytedance.com, stefanha@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Lu Wei <luwei32@huawei.com>, Colin Ian King <colin.king@canonical.com>, arseny.krasnov@kaspersky.com, "David S. Miller" <davem@davemloft.net> Subject: [RFC v1 6/6] virtio/vsock: add sysfs for rx buf len for dgram Date: Wed, 9 Jun 2021 23:24:58 +0000 [thread overview] Message-ID: <20210609232501.171257-7-jiang.wang@bytedance.com> (raw) In-Reply-To: <20210609232501.171257-1-jiang.wang@bytedance.com> Make rx buf len configurable via sysfs Signed-off-by: Jiang Wang <jiang.wang@bytedance.com> --- net/vmw_vsock/virtio_transport.c | 37 +++++++++++++++++++++++++++++++++++-- 1 file changed, 35 insertions(+), 2 deletions(-) diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c index cf47aadb0c34..2e4dd9c48472 100644 --- a/net/vmw_vsock/virtio_transport.c +++ b/net/vmw_vsock/virtio_transport.c @@ -29,6 +29,14 @@ static struct virtio_vsock __rcu *the_virtio_vsock; static struct virtio_vsock *the_virtio_vsock_dgram; static DEFINE_MUTEX(the_virtio_vsock_mutex); /* protects the_virtio_vsock */ +static int rx_buf_len = VIRTIO_VSOCK_DEFAULT_RX_BUF_SIZE; +static struct kobject *kobj_ref; +static ssize_t sysfs_show(struct kobject *kobj, + struct kobj_attribute *attr, char *buf); +static ssize_t sysfs_store(struct kobject *kobj, + struct kobj_attribute *attr, const char *buf, size_t count); +static struct kobj_attribute rxbuf_attr = __ATTR(rx_buf_value, 0660, sysfs_show, sysfs_store); + struct virtio_vsock { struct virtio_device *vdev; struct virtqueue **vqs; @@ -360,7 +368,7 @@ virtio_transport_cancel_pkt(struct vsock_sock *vsk) static void virtio_vsock_rx_fill(struct virtio_vsock *vsock, bool is_dgram) { - int buf_len = VIRTIO_VSOCK_DEFAULT_RX_BUF_SIZE; + int buf_len = rx_buf_len; struct virtio_vsock_pkt *pkt; struct scatterlist hdr, buf, *sgs[2]; struct virtqueue *vq; @@ -1003,6 +1011,22 @@ static struct virtio_driver virtio_vsock_driver = { .remove = virtio_vsock_remove, }; +static ssize_t sysfs_show(struct kobject *kobj, + struct kobj_attribute *attr, char *buf) +{ + return sprintf(buf, "%d", rx_buf_len); +} + +static ssize_t sysfs_store(struct kobject *kobj, + struct kobj_attribute *attr, const char *buf, size_t count) +{ + if (kstrtou32(buf, 0, &rx_buf_len) < 0) + return -EINVAL; + if (rx_buf_len < 1024) + rx_buf_len = 1024; + return count; +} + static int __init virtio_vsock_init(void) { int ret; @@ -1020,8 +1044,17 @@ static int __init virtio_vsock_init(void) if (ret) goto out_vci; - return 0; + kobj_ref = kobject_create_and_add("vsock", kernel_kobj); + /*Creating sysfs file for etx_value*/ + ret = sysfs_create_file(kobj_ref, &rxbuf_attr.attr); + if (ret) + goto out_sysfs; + + return 0; +out_sysfs: + kobject_put(kobj_ref); + sysfs_remove_file(kernel_kobj, &rxbuf_attr.attr); out_vci: vsock_core_unregister(&virtio_transport.transport); out_wq: -- 2.11.0 _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2021-06-09 23:28 UTC|newest] Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-09 23:24 [RFC v1 0/6] virtio/vsock: introduce SOCK_DGRAM support Jiang Wang 2021-06-09 23:24 ` Jiang Wang 2021-06-09 23:24 ` [RFC v1 1/6] virtio/vsock: add VIRTIO_VSOCK_F_DGRAM feature bit Jiang Wang 2021-06-09 23:24 ` Jiang Wang 2021-06-18 9:39 ` Stefano Garzarella 2021-06-18 9:39 ` Stefano Garzarella 2021-06-21 17:24 ` [External] " Jiang Wang . 2021-06-21 17:24 ` Jiang Wang . 2021-06-22 10:50 ` Stefano Garzarella 2021-06-22 10:50 ` Stefano Garzarella 2021-06-09 23:24 ` [RFC v1 2/6] virtio/vsock: add support for virtio datagram Jiang Wang 2021-06-09 23:24 ` Jiang Wang 2021-06-16 9:06 ` kernel test robot 2021-06-16 9:17 ` kernel test robot 2021-06-16 11:18 ` kernel test robot 2021-06-16 17:54 ` kernel test robot 2021-06-18 9:52 ` Stefano Garzarella 2021-06-18 9:52 ` Stefano Garzarella 2021-06-18 10:11 ` Stefano Garzarella 2021-06-18 10:11 ` Stefano Garzarella 2021-06-09 23:24 ` [RFC v1 3/6] vhost/vsock: add support for vhost dgram Jiang Wang 2021-06-09 23:24 ` Jiang Wang 2021-06-16 12:33 ` kernel test robot 2021-06-18 10:13 ` Stefano Garzarella 2021-06-18 10:13 ` Stefano Garzarella 2021-06-21 17:32 ` [External] " Jiang Wang . 2021-06-21 17:32 ` Jiang Wang . 2021-06-09 23:24 ` [RFC v1 4/6] vsock_test: add tests for vsock dgram Jiang Wang 2021-06-09 23:24 ` Jiang Wang 2021-06-09 23:24 ` [RFC v1 5/6] vhost/vsock: add kconfig for vhost dgram support Jiang Wang 2021-06-09 23:24 ` Jiang Wang 2021-06-18 9:54 ` Stefano Garzarella 2021-06-18 9:54 ` Stefano Garzarella 2021-06-21 17:25 ` [External] " Jiang Wang . 2021-06-21 17:25 ` Jiang Wang . 2021-06-09 23:24 ` Jiang Wang [this message] 2021-06-09 23:24 ` [RFC v1 6/6] virtio/vsock: add sysfs for rx buf len for dgram Jiang Wang 2021-06-18 10:04 ` Stefano Garzarella 2021-06-18 10:04 ` Stefano Garzarella 2021-06-21 17:27 ` [External] " Jiang Wang . 2021-06-21 17:27 ` Jiang Wang . 2021-06-10 1:50 ` [RFC v1 0/6] virtio/vsock: introduce SOCK_DGRAM support Jason Wang 2021-06-10 1:50 ` Jason Wang 2021-06-10 3:43 ` Jiang Wang . 2021-06-10 3:43 ` Jiang Wang . 2021-06-10 4:02 ` Jason Wang 2021-06-10 4:02 ` Jason Wang 2021-06-10 7:23 ` Stefano Garzarella 2021-06-10 7:23 ` Stefano Garzarella 2021-06-10 7:46 ` Jason Wang 2021-06-10 7:46 ` Jason Wang 2021-06-10 9:51 ` Stefano Garzarella 2021-06-10 9:51 ` Stefano Garzarella 2021-06-10 16:44 ` Jiang Wang . 2021-06-10 16:44 ` Jiang Wang . 2021-06-18 9:35 ` Stefano Garzarella 2021-06-18 9:35 ` Stefano Garzarella 2021-06-21 17:21 ` [External] " Jiang Wang . 2021-06-21 17:21 ` Jiang Wang .
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210609232501.171257-7-jiang.wang@bytedance.com \ --to=jiang.wang@bytedance.com \ --cc=alex.popov@linux.com \ --cc=andraprs@amazon.com \ --cc=arseny.krasnov@kaspersky.com \ --cc=chaiwen.cc@bytedance.com \ --cc=colin.king@canonical.com \ --cc=cong.wang@bytedance.com \ --cc=davem@davemloft.net \ --cc=duanxiongchun@bytedance.com \ --cc=jasowang@redhat.com \ --cc=jhansen@vmware.comments \ --cc=kuba@kernel.org \ --cc=kvm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=luwei32@huawei.com \ --cc=mingo@redhat.com \ --cc=mst@redhat.com \ --cc=netdev@vger.kernel.org \ --cc=nslusarek@gmx.net \ --cc=rostedt@goodmis.org \ --cc=sgarzare@redhat.com \ --cc=stefanha@redhat.com \ --cc=virtualization@lists.linux-foundation.org \ --cc=xieyongji@bytedance.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.