From: Jason Wang <jasowang@redhat.com> To: "Jiang Wang ." <jiang.wang@bytedance.com> Cc: "Stefano Garzarella" <sgarzare@redhat.com>, virtualization@lists.linux-foundation.org, "Stefan Hajnoczi" <stefanha@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, "Arseny Krasnov" <arseny.krasnov@kaspersky.com>, jhansen@vmware.comments, cong.wang@bytedance.com, "Xiongchun Duan" <duanxiongchun@bytedance.com>, "Yongji Xie" <xieyongji@bytedance.com>, 柴稳 <chaiwen.cc@bytedance.com>, "David S. Miller" <davem@davemloft.net>, "Jakub Kicinski" <kuba@kernel.org>, "Steven Rostedt" <rostedt@goodmis.org>, "Ingo Molnar" <mingo@redhat.com>, "Colin Ian King" <colin.king@canonical.com>, "Jorgen Hansen" <jhansen@vmware.com>, "Andra Paraschiv" <andraprs@amazon.com>, "Norbert Slusarek" <nslusarek@gmx.net>, "Lu Wei" <luwei32@huawei.com>, "Alexander Popov" <alex.popov@linux.com>, kvm@vger.kernel.org, Networking <netdev@vger.kernel.org>, linux-kernel@vger.kernel.org Subject: Re: [RFC v1 0/6] virtio/vsock: introduce SOCK_DGRAM support Date: Thu, 10 Jun 2021 12:02:35 +0800 [thread overview] Message-ID: <ac0c241c-1013-1304-036f-504d0edc5fd7@redhat.com> (raw) In-Reply-To: <CAP_N_Z_VDd+JUJ_Y-peOEc7FgwNGB8O3uZpVumQT_DbW62Jpjw@mail.gmail.com> 在 2021/6/10 上午11:43, Jiang Wang . 写道: > On Wed, Jun 9, 2021 at 6:51 PM Jason Wang <jasowang@redhat.com> wrote: >> >> 在 2021/6/10 上午7:24, Jiang Wang 写道: >>> This patchset implements support of SOCK_DGRAM for virtio >>> transport. >>> >>> Datagram sockets are connectionless and unreliable. To avoid unfair contention >>> with stream and other sockets, add two more virtqueues and >>> a new feature bit to indicate if those two new queues exist or not. >>> >>> Dgram does not use the existing credit update mechanism for >>> stream sockets. When sending from the guest/driver, sending packets >>> synchronously, so the sender will get an error when the virtqueue is full. >>> When sending from the host/device, send packets asynchronously >>> because the descriptor memory belongs to the corresponding QEMU >>> process. >> >> What's the use case for the datagram vsock? >> > One use case is for non critical info logging from the guest > to the host, such as the performance data of some applications. Anything that prevents you from using the stream socket? > > It can also be used to replace UDP communications between > the guest and the host. Any advantage for VSOCK in this case? Is it for performance (I guess not since I don't exepct vsock will be faster). An obvious drawback is that it breaks the migration. Using UDP you can have a very rich features support from the kernel where vsock can't. > >>> The virtio spec patch is here: >>> https://www.spinics.net/lists/linux-virtualization/msg50027.html >> >> Have a quick glance, I suggest to split mergeable rx buffer into an >> separate patch. > Sure. > >> But I think it's time to revisit the idea of unifying the virtio-net and >> virtio-vsock. Otherwise we're duplicating features and bugs. > For mergeable rxbuf related code, I think a set of common helper > functions can be used by both virtio-net and virtio-vsock. For other > parts, that may not be very beneficial. I will think about more. > > If there is a previous email discussion about this topic, could you send me > some links? I did a quick web search but did not find any related > info. Thanks. We had a lot: [1] https://patchwork.kernel.org/project/kvm/patch/5BDFF537.3050806@huawei.com/ [2] https://lists.linuxfoundation.org/pipermail/virtualization/2018-November/039798.html [3] https://www.lkml.org/lkml/2020/1/16/2043 Thanks > >> Thanks >> >> >>> For those who prefer git repo, here is the link for the linux kernel: >>> https://github.com/Jiang1155/linux/tree/vsock-dgram-v1 >>> >>> qemu patch link: >>> https://github.com/Jiang1155/qemu/tree/vsock-dgram-v1 >>> >>> >>> To do: >>> 1. use skb when receiving packets >>> 2. support multiple transport >>> 3. support mergeable rx buffer >>> >>> >>> Jiang Wang (6): >>> virtio/vsock: add VIRTIO_VSOCK_F_DGRAM feature bit >>> virtio/vsock: add support for virtio datagram >>> vhost/vsock: add support for vhost dgram. >>> vsock_test: add tests for vsock dgram >>> vhost/vsock: add kconfig for vhost dgram support >>> virtio/vsock: add sysfs for rx buf len for dgram >>> >>> drivers/vhost/Kconfig | 8 + >>> drivers/vhost/vsock.c | 207 ++++++++-- >>> include/linux/virtio_vsock.h | 9 + >>> include/net/af_vsock.h | 1 + >>> .../trace/events/vsock_virtio_transport_common.h | 5 +- >>> include/uapi/linux/virtio_vsock.h | 4 + >>> net/vmw_vsock/af_vsock.c | 12 + >>> net/vmw_vsock/virtio_transport.c | 433 ++++++++++++++++++--- >>> net/vmw_vsock/virtio_transport_common.c | 184 ++++++++- >>> tools/testing/vsock/util.c | 105 +++++ >>> tools/testing/vsock/util.h | 4 + >>> tools/testing/vsock/vsock_test.c | 195 ++++++++++ >>> 12 files changed, 1070 insertions(+), 97 deletions(-) >>>
WARNING: multiple messages have this Message-ID (diff)
From: Jason Wang <jasowang@redhat.com> To: "Jiang Wang ." <jiang.wang@bytedance.com> Cc: cong.wang@bytedance.com, "Andra Paraschiv" <andraprs@amazon.com>, kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>, virtualization@lists.linux-foundation.org, "Norbert Slusarek" <nslusarek@gmx.net>, jhansen@vmware.comments, "Xiongchun Duan" <duanxiongchun@bytedance.com>, "Yongji Xie" <xieyongji@bytedance.com>, "Ingo Molnar" <mingo@redhat.com>, "Jakub Kicinski" <kuba@kernel.org>, "Alexander Popov" <alex.popov@linux.com>, "Steven Rostedt" <rostedt@goodmis.org>, 柴稳 <chaiwen.cc@bytedance.com>, "Stefan Hajnoczi" <stefanha@redhat.com>, Networking <netdev@vger.kernel.org>, linux-kernel@vger.kernel.org, "Lu Wei" <luwei32@huawei.com>, "Colin Ian King" <colin.king@canonical.com>, "Arseny Krasnov" <arseny.krasnov@kaspersky.com>, "David S. Miller" <davem@davemloft.net>, "Jorgen Hansen" <jhansen@vmware.com> Subject: Re: [RFC v1 0/6] virtio/vsock: introduce SOCK_DGRAM support Date: Thu, 10 Jun 2021 12:02:35 +0800 [thread overview] Message-ID: <ac0c241c-1013-1304-036f-504d0edc5fd7@redhat.com> (raw) In-Reply-To: <CAP_N_Z_VDd+JUJ_Y-peOEc7FgwNGB8O3uZpVumQT_DbW62Jpjw@mail.gmail.com> 在 2021/6/10 上午11:43, Jiang Wang . 写道: > On Wed, Jun 9, 2021 at 6:51 PM Jason Wang <jasowang@redhat.com> wrote: >> >> 在 2021/6/10 上午7:24, Jiang Wang 写道: >>> This patchset implements support of SOCK_DGRAM for virtio >>> transport. >>> >>> Datagram sockets are connectionless and unreliable. To avoid unfair contention >>> with stream and other sockets, add two more virtqueues and >>> a new feature bit to indicate if those two new queues exist or not. >>> >>> Dgram does not use the existing credit update mechanism for >>> stream sockets. When sending from the guest/driver, sending packets >>> synchronously, so the sender will get an error when the virtqueue is full. >>> When sending from the host/device, send packets asynchronously >>> because the descriptor memory belongs to the corresponding QEMU >>> process. >> >> What's the use case for the datagram vsock? >> > One use case is for non critical info logging from the guest > to the host, such as the performance data of some applications. Anything that prevents you from using the stream socket? > > It can also be used to replace UDP communications between > the guest and the host. Any advantage for VSOCK in this case? Is it for performance (I guess not since I don't exepct vsock will be faster). An obvious drawback is that it breaks the migration. Using UDP you can have a very rich features support from the kernel where vsock can't. > >>> The virtio spec patch is here: >>> https://www.spinics.net/lists/linux-virtualization/msg50027.html >> >> Have a quick glance, I suggest to split mergeable rx buffer into an >> separate patch. > Sure. > >> But I think it's time to revisit the idea of unifying the virtio-net and >> virtio-vsock. Otherwise we're duplicating features and bugs. > For mergeable rxbuf related code, I think a set of common helper > functions can be used by both virtio-net and virtio-vsock. For other > parts, that may not be very beneficial. I will think about more. > > If there is a previous email discussion about this topic, could you send me > some links? I did a quick web search but did not find any related > info. Thanks. We had a lot: [1] https://patchwork.kernel.org/project/kvm/patch/5BDFF537.3050806@huawei.com/ [2] https://lists.linuxfoundation.org/pipermail/virtualization/2018-November/039798.html [3] https://www.lkml.org/lkml/2020/1/16/2043 Thanks > >> Thanks >> >> >>> For those who prefer git repo, here is the link for the linux kernel: >>> https://github.com/Jiang1155/linux/tree/vsock-dgram-v1 >>> >>> qemu patch link: >>> https://github.com/Jiang1155/qemu/tree/vsock-dgram-v1 >>> >>> >>> To do: >>> 1. use skb when receiving packets >>> 2. support multiple transport >>> 3. support mergeable rx buffer >>> >>> >>> Jiang Wang (6): >>> virtio/vsock: add VIRTIO_VSOCK_F_DGRAM feature bit >>> virtio/vsock: add support for virtio datagram >>> vhost/vsock: add support for vhost dgram. >>> vsock_test: add tests for vsock dgram >>> vhost/vsock: add kconfig for vhost dgram support >>> virtio/vsock: add sysfs for rx buf len for dgram >>> >>> drivers/vhost/Kconfig | 8 + >>> drivers/vhost/vsock.c | 207 ++++++++-- >>> include/linux/virtio_vsock.h | 9 + >>> include/net/af_vsock.h | 1 + >>> .../trace/events/vsock_virtio_transport_common.h | 5 +- >>> include/uapi/linux/virtio_vsock.h | 4 + >>> net/vmw_vsock/af_vsock.c | 12 + >>> net/vmw_vsock/virtio_transport.c | 433 ++++++++++++++++++--- >>> net/vmw_vsock/virtio_transport_common.c | 184 ++++++++- >>> tools/testing/vsock/util.c | 105 +++++ >>> tools/testing/vsock/util.h | 4 + >>> tools/testing/vsock/vsock_test.c | 195 ++++++++++ >>> 12 files changed, 1070 insertions(+), 97 deletions(-) >>> _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2021-06-10 4:02 UTC|newest] Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-09 23:24 [RFC v1 0/6] virtio/vsock: introduce SOCK_DGRAM support Jiang Wang 2021-06-09 23:24 ` Jiang Wang 2021-06-09 23:24 ` [RFC v1 1/6] virtio/vsock: add VIRTIO_VSOCK_F_DGRAM feature bit Jiang Wang 2021-06-09 23:24 ` Jiang Wang 2021-06-18 9:39 ` Stefano Garzarella 2021-06-18 9:39 ` Stefano Garzarella 2021-06-21 17:24 ` [External] " Jiang Wang . 2021-06-21 17:24 ` Jiang Wang . 2021-06-22 10:50 ` Stefano Garzarella 2021-06-22 10:50 ` Stefano Garzarella 2021-06-09 23:24 ` [RFC v1 2/6] virtio/vsock: add support for virtio datagram Jiang Wang 2021-06-09 23:24 ` Jiang Wang 2021-06-16 9:06 ` kernel test robot 2021-06-16 9:17 ` kernel test robot 2021-06-16 11:18 ` kernel test robot 2021-06-16 17:54 ` kernel test robot 2021-06-18 9:52 ` Stefano Garzarella 2021-06-18 9:52 ` Stefano Garzarella 2021-06-18 10:11 ` Stefano Garzarella 2021-06-18 10:11 ` Stefano Garzarella 2021-06-09 23:24 ` [RFC v1 3/6] vhost/vsock: add support for vhost dgram Jiang Wang 2021-06-09 23:24 ` Jiang Wang 2021-06-16 12:33 ` kernel test robot 2021-06-18 10:13 ` Stefano Garzarella 2021-06-18 10:13 ` Stefano Garzarella 2021-06-21 17:32 ` [External] " Jiang Wang . 2021-06-21 17:32 ` Jiang Wang . 2021-06-09 23:24 ` [RFC v1 4/6] vsock_test: add tests for vsock dgram Jiang Wang 2021-06-09 23:24 ` Jiang Wang 2021-06-09 23:24 ` [RFC v1 5/6] vhost/vsock: add kconfig for vhost dgram support Jiang Wang 2021-06-09 23:24 ` Jiang Wang 2021-06-18 9:54 ` Stefano Garzarella 2021-06-18 9:54 ` Stefano Garzarella 2021-06-21 17:25 ` [External] " Jiang Wang . 2021-06-21 17:25 ` Jiang Wang . 2021-06-09 23:24 ` [RFC v1 6/6] virtio/vsock: add sysfs for rx buf len for dgram Jiang Wang 2021-06-09 23:24 ` Jiang Wang 2021-06-18 10:04 ` Stefano Garzarella 2021-06-18 10:04 ` Stefano Garzarella 2021-06-21 17:27 ` [External] " Jiang Wang . 2021-06-21 17:27 ` Jiang Wang . 2021-06-10 1:50 ` [RFC v1 0/6] virtio/vsock: introduce SOCK_DGRAM support Jason Wang 2021-06-10 1:50 ` Jason Wang 2021-06-10 3:43 ` Jiang Wang . 2021-06-10 3:43 ` Jiang Wang . 2021-06-10 4:02 ` Jason Wang [this message] 2021-06-10 4:02 ` Jason Wang 2021-06-10 7:23 ` Stefano Garzarella 2021-06-10 7:23 ` Stefano Garzarella 2021-06-10 7:46 ` Jason Wang 2021-06-10 7:46 ` Jason Wang 2021-06-10 9:51 ` Stefano Garzarella 2021-06-10 9:51 ` Stefano Garzarella 2021-06-10 16:44 ` Jiang Wang . 2021-06-10 16:44 ` Jiang Wang . 2021-06-18 9:35 ` Stefano Garzarella 2021-06-18 9:35 ` Stefano Garzarella 2021-06-21 17:21 ` [External] " Jiang Wang . 2021-06-21 17:21 ` Jiang Wang .
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ac0c241c-1013-1304-036f-504d0edc5fd7@redhat.com \ --to=jasowang@redhat.com \ --cc=alex.popov@linux.com \ --cc=andraprs@amazon.com \ --cc=arseny.krasnov@kaspersky.com \ --cc=chaiwen.cc@bytedance.com \ --cc=colin.king@canonical.com \ --cc=cong.wang@bytedance.com \ --cc=davem@davemloft.net \ --cc=duanxiongchun@bytedance.com \ --cc=jhansen@vmware.com \ --cc=jhansen@vmware.comments \ --cc=jiang.wang@bytedance.com \ --cc=kuba@kernel.org \ --cc=kvm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=luwei32@huawei.com \ --cc=mingo@redhat.com \ --cc=mst@redhat.com \ --cc=netdev@vger.kernel.org \ --cc=nslusarek@gmx.net \ --cc=rostedt@goodmis.org \ --cc=sgarzare@redhat.com \ --cc=stefanha@redhat.com \ --cc=virtualization@lists.linux-foundation.org \ --cc=xieyongji@bytedance.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.