Re: [PATCH u-boot-marvell v2 5/6] arm: mvebu: dts: turris_mox: add nodes for SPI NOR partitions

["Pali Rohár" <pali@kernel.org>]

On Thursday 10 June 2021 07:12:53 Stefan Roese wrote:
> Hi Pali,
> 
> On 08.06.21 11:51, Pali Rohár wrote:
> > On Monday 07 June 2021 16:34:50 Marek Behún wrote:
> > > Add nodes for SPI NOR partitions to the device tree of Turris MOX, as
> > > are in Linux' device tree.
> > 
> > This patch is not needed (for now) as U-Boot cannot parse SPI NOR
> > partitions from DT yet. U-Boot for SPI NOR currently supports specifying
> > partitions only via CONFIG_MTDPARTS_DEFAULT compile option.
> 
> But do you agree that this patch "does not hurt"? I'm asking to check,
> if I should include this patch in a potential pull request.

Yes. This does not hurt and currently does nothing. And after patches
for SPI NOR parsing are merged then this patch can be useful.

So if you are fine with merging which which currently does noting and in
future is useful then there is no problem with it.

> 
> Thanks,
> Stefan
> 
> > > Signed-off-by: Marek Behún <marek.behun@nic.cz>
> > > ---
> > >   arch/arm/dts/armada-3720-turris-mox.dts | 31 +++++++++++++++++++++++++
> > >   1 file changed, 31 insertions(+)
> > > 
> > > diff --git a/arch/arm/dts/armada-3720-turris-mox.dts b/arch/arm/dts/armada-3720-turris-mox.dts
> > > index 741b0eeeee..f47ced05c5 100644
> > > --- a/arch/arm/dts/armada-3720-turris-mox.dts
> > > +++ b/arch/arm/dts/armada-3720-turris-mox.dts
> > > @@ -164,6 +164,37 @@
> > >   		reg = <0>;
> > >   		spi-max-frequency = <20000000>;
> > >   		m25p,fast-read;
> > > +
> > > +		partitions {
> > > +			compatible = "fixed-partitions";
> > > +			#address-cells = <1>;
> > > +			#size-cells = <1>;
> > > +
> > > +			partition@0 {
> > > +				label = "secure-firmware";
> > > +				reg = <0x0 0x20000>;
> > > +			};
> > > +
> > > +			partition@20000 {
> > > +				label = "a53-firmware";
> > > +				reg = <0x20000 0x160000>;
> > > +			};
> > > +
> > > +			partition@180000 {
> > > +				label = "u-boot-env";
> > > +				reg = <0x180000 0x10000>;
> > > +			};
> > > +
> > > +			partition@190000 {
> > > +				label = "Rescue system";
> > > +				reg = <0x190000 0x660000>;
> > > +			};
> > > +
> > > +			partition@7f0000 {
> > > +				label = "dtb";
> > > +				reg = <0x7f0000 0x10000>;
> > > +			};
> > > +		};
> > >   	};
> > >   	moxtet@1 {
> > > -- 
> > > 2.31.1
> > > 
> 
> 
> Viele Grüße,
> Stefan
> 
> -- 
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de