From: Ioana Ciornei <ciorneiioana@gmail.com> To: Grant Likely <grant.likely@arm.com>, "Rafael J . Wysocki" <rafael@kernel.org>, Jeremy Linton <jeremy.linton@arm.com>, Andrew Lunn <andrew@lunn.ch>, Andy Shevchenko <andy.shevchenko@gmail.com>, Florian Fainelli <f.fainelli@gmail.com>, Russell King - ARM Linux admin <linux@armlinux.org.uk>, Heikki Krogerus <heikki.krogerus@linux.intel.com>, Marcin Wojtas <mw@semihalf.com>, Pieter Jansen Van Vuuren <pieter.jansenvv@bamboosystems.io>, Jon <jon@solid-run.com>, Saravana Kannan <saravanak@google.com>, Randy Dunlap <rdunlap@infradead.org>, calvin.johnson@nxp.com Cc: Cristi Sovaiala <cristian.sovaiala@nxp.com>, Florin Laurentiu Chiculita <florinlaurentiu.chiculita@nxp.com>, Madalin Bucur <madalin.bucur@nxp.com>, linux-arm-kernel@lists.infradead.org, Diana Madalina Craciun <diana.craciun@nxp.com>, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux.cj@gmail.com, netdev@vger.kernel.org, Laurentiu Tudor <laurentiu.tudor@nxp.com>, Len Brown <lenb@kernel.org>, "Rafael J . Wysocki" <rjw@rjwysocki.net>, Calvin Johnson <calvin.johnson@oss.nxp.com>, Ioana Ciornei <ioana.ciornei@nxp.com> Subject: [PATCH net-next v8 05/15] net: phy: Introduce fwnode_get_phy_id() Date: Thu, 10 Jun 2021 19:39:07 +0300 [thread overview] Message-ID: <20210610163917.4138412-6-ciorneiioana@gmail.com> (raw) In-Reply-To: <20210610163917.4138412-1-ciorneiioana@gmail.com> From: Calvin Johnson <calvin.johnson@oss.nxp.com> Extract phy_id from compatible string. This will be used by fwnode_mdiobus_register_phy() to create phy device using the phy_id. Signed-off-by: Calvin Johnson <calvin.johnson@oss.nxp.com> Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com> --- Changes in v8: None Changes in v7: None Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: - Use traditional comparison pattern - Use GENMASK Changes in v2: None drivers/net/phy/phy_device.c | 21 +++++++++++++++++++++ include/linux/phy.h | 5 +++++ 2 files changed, 26 insertions(+) diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index f651c4feb49f..0ce5c7274930 100644 --- a/drivers/net/phy/phy_device.c +++ b/drivers/net/phy/phy_device.c @@ -834,6 +834,27 @@ static int get_phy_c22_id(struct mii_bus *bus, int addr, u32 *phy_id) return 0; } +/* Extract the phy ID from the compatible string of the form + * ethernet-phy-idAAAA.BBBB. + */ +int fwnode_get_phy_id(struct fwnode_handle *fwnode, u32 *phy_id) +{ + unsigned int upper, lower; + const char *cp; + int ret; + + ret = fwnode_property_read_string(fwnode, "compatible", &cp); + if (ret) + return ret; + + if (sscanf(cp, "ethernet-phy-id%4x.%4x", &upper, &lower) != 2) + return -EINVAL; + + *phy_id = ((upper & GENMASK(15, 0)) << 16) | (lower & GENMASK(15, 0)); + return 0; +} +EXPORT_SYMBOL(fwnode_get_phy_id); + /** * get_phy_device - reads the specified PHY device and returns its @phy_device * struct diff --git a/include/linux/phy.h b/include/linux/phy.h index f9b5fb099fa6..b60694734b07 100644 --- a/include/linux/phy.h +++ b/include/linux/phy.h @@ -1377,6 +1377,7 @@ struct phy_device *phy_device_create(struct mii_bus *bus, int addr, u32 phy_id, bool is_c45, struct phy_c45_device_ids *c45_ids); #if IS_ENABLED(CONFIG_PHYLIB) +int fwnode_get_phy_id(struct fwnode_handle *fwnode, u32 *phy_id); struct mdio_device *fwnode_mdio_find_device(struct fwnode_handle *fwnode); struct phy_device *fwnode_phy_find_device(struct fwnode_handle *phy_fwnode); struct phy_device *device_phy_find_device(struct device *dev); @@ -1385,6 +1386,10 @@ struct phy_device *get_phy_device(struct mii_bus *bus, int addr, bool is_c45); int phy_device_register(struct phy_device *phy); void phy_device_free(struct phy_device *phydev); #else +static inline int fwnode_get_phy_id(struct fwnode_handle *fwnode, u32 *phy_id) +{ + return 0; +} static inline struct mdio_device *fwnode_mdio_find_device(struct fwnode_handle *fwnode) { -- 2.31.1
WARNING: multiple messages have this Message-ID (diff)
From: Ioana Ciornei <ciorneiioana@gmail.com> To: Grant Likely <grant.likely@arm.com>, "Rafael J . Wysocki" <rafael@kernel.org>, Jeremy Linton <jeremy.linton@arm.com>, Andrew Lunn <andrew@lunn.ch>, Andy Shevchenko <andy.shevchenko@gmail.com>, Florian Fainelli <f.fainelli@gmail.com>, Russell King - ARM Linux admin <linux@armlinux.org.uk>, Heikki Krogerus <heikki.krogerus@linux.intel.com>, Marcin Wojtas <mw@semihalf.com>, Pieter Jansen Van Vuuren <pieter.jansenvv@bamboosystems.io>, Jon <jon@solid-run.com>, Saravana Kannan <saravanak@google.com>, Randy Dunlap <rdunlap@infradead.org>, calvin.johnson@nxp.com Cc: Cristi Sovaiala <cristian.sovaiala@nxp.com>, Florin Laurentiu Chiculita <florinlaurentiu.chiculita@nxp.com>, Madalin Bucur <madalin.bucur@nxp.com>, linux-arm-kernel@lists.infradead.org, Diana Madalina Craciun <diana.craciun@nxp.com>, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux.cj@gmail.com, netdev@vger.kernel.org, Laurentiu Tudor <laurentiu.tudor@nxp.com>, Len Brown <lenb@kernel.org>, "Rafael J . Wysocki" <rjw@rjwysocki.net>, Calvin Johnson <calvin.johnson@oss.nxp.com>, Ioana Ciornei <ioana.ciornei@nxp.com> Subject: [PATCH net-next v8 05/15] net: phy: Introduce fwnode_get_phy_id() Date: Thu, 10 Jun 2021 19:39:07 +0300 [thread overview] Message-ID: <20210610163917.4138412-6-ciorneiioana@gmail.com> (raw) In-Reply-To: <20210610163917.4138412-1-ciorneiioana@gmail.com> From: Calvin Johnson <calvin.johnson@oss.nxp.com> Extract phy_id from compatible string. This will be used by fwnode_mdiobus_register_phy() to create phy device using the phy_id. Signed-off-by: Calvin Johnson <calvin.johnson@oss.nxp.com> Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com> --- Changes in v8: None Changes in v7: None Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: - Use traditional comparison pattern - Use GENMASK Changes in v2: None drivers/net/phy/phy_device.c | 21 +++++++++++++++++++++ include/linux/phy.h | 5 +++++ 2 files changed, 26 insertions(+) diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index f651c4feb49f..0ce5c7274930 100644 --- a/drivers/net/phy/phy_device.c +++ b/drivers/net/phy/phy_device.c @@ -834,6 +834,27 @@ static int get_phy_c22_id(struct mii_bus *bus, int addr, u32 *phy_id) return 0; } +/* Extract the phy ID from the compatible string of the form + * ethernet-phy-idAAAA.BBBB. + */ +int fwnode_get_phy_id(struct fwnode_handle *fwnode, u32 *phy_id) +{ + unsigned int upper, lower; + const char *cp; + int ret; + + ret = fwnode_property_read_string(fwnode, "compatible", &cp); + if (ret) + return ret; + + if (sscanf(cp, "ethernet-phy-id%4x.%4x", &upper, &lower) != 2) + return -EINVAL; + + *phy_id = ((upper & GENMASK(15, 0)) << 16) | (lower & GENMASK(15, 0)); + return 0; +} +EXPORT_SYMBOL(fwnode_get_phy_id); + /** * get_phy_device - reads the specified PHY device and returns its @phy_device * struct diff --git a/include/linux/phy.h b/include/linux/phy.h index f9b5fb099fa6..b60694734b07 100644 --- a/include/linux/phy.h +++ b/include/linux/phy.h @@ -1377,6 +1377,7 @@ struct phy_device *phy_device_create(struct mii_bus *bus, int addr, u32 phy_id, bool is_c45, struct phy_c45_device_ids *c45_ids); #if IS_ENABLED(CONFIG_PHYLIB) +int fwnode_get_phy_id(struct fwnode_handle *fwnode, u32 *phy_id); struct mdio_device *fwnode_mdio_find_device(struct fwnode_handle *fwnode); struct phy_device *fwnode_phy_find_device(struct fwnode_handle *phy_fwnode); struct phy_device *device_phy_find_device(struct device *dev); @@ -1385,6 +1386,10 @@ struct phy_device *get_phy_device(struct mii_bus *bus, int addr, bool is_c45); int phy_device_register(struct phy_device *phy); void phy_device_free(struct phy_device *phydev); #else +static inline int fwnode_get_phy_id(struct fwnode_handle *fwnode, u32 *phy_id) +{ + return 0; +} static inline struct mdio_device *fwnode_mdio_find_device(struct fwnode_handle *fwnode) { -- 2.31.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-06-10 16:42 UTC|newest] Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-10 16:39 [PATCH net-next v8 00/15] ACPI support for dpaa2 driver Ioana Ciornei 2021-06-10 16:39 ` Ioana Ciornei 2021-06-10 16:39 ` [PATCH net-next v8 01/15] Documentation: ACPI: DSD: Document MDIO PHY Ioana Ciornei 2021-06-10 16:39 ` Ioana Ciornei 2021-06-10 18:05 ` Rafael J. Wysocki 2021-06-10 18:05 ` Rafael J. Wysocki 2021-06-10 18:23 ` Grant Likely 2021-06-10 18:23 ` Grant Likely 2021-06-10 18:31 ` Rafael J. Wysocki 2021-06-10 18:31 ` Rafael J. Wysocki 2021-06-10 18:11 ` Grant Likely 2021-06-10 18:11 ` Grant Likely 2021-06-10 16:39 ` [PATCH net-next v8 02/15] net: phy: Introduce fwnode_mdio_find_device() Ioana Ciornei 2021-06-10 16:39 ` Ioana Ciornei 2021-06-10 16:39 ` [PATCH net-next v8 03/15] net: phy: Introduce phy related fwnode functions Ioana Ciornei 2021-06-10 16:39 ` Ioana Ciornei 2021-06-10 16:39 ` [PATCH net-next v8 04/15] of: mdio: Refactor of_phy_find_device() Ioana Ciornei 2021-06-10 16:39 ` Ioana Ciornei 2021-06-10 16:39 ` Ioana Ciornei [this message] 2021-06-10 16:39 ` [PATCH net-next v8 05/15] net: phy: Introduce fwnode_get_phy_id() Ioana Ciornei 2021-06-10 16:39 ` [PATCH net-next v8 06/15] of: mdio: Refactor of_get_phy_id() Ioana Ciornei 2021-06-10 16:39 ` Ioana Ciornei 2021-06-10 16:39 ` [PATCH net-next v8 07/15] net: mii_timestamper: check NULL in unregister_mii_timestamper() Ioana Ciornei 2021-06-10 16:39 ` Ioana Ciornei 2021-06-10 16:39 ` [PATCH net-next v8 08/15] net: mdiobus: Introduce fwnode_mdiobus_register_phy() Ioana Ciornei 2021-06-10 16:39 ` Ioana Ciornei 2021-06-10 16:39 ` [PATCH net-next v8 09/15] of: mdio: Refactor of_mdiobus_register_phy() Ioana Ciornei 2021-06-10 16:39 ` Ioana Ciornei 2021-06-10 16:39 ` [PATCH net-next v8 10/15] ACPI: utils: Introduce acpi_get_local_address() Ioana Ciornei 2021-06-10 16:39 ` Ioana Ciornei 2021-06-10 18:09 ` Rafael J. Wysocki 2021-06-10 18:09 ` Rafael J. Wysocki 2021-06-10 16:39 ` [PATCH net-next v8 11/15] net: mdio: Add ACPI support code for mdio Ioana Ciornei 2021-06-10 16:39 ` Ioana Ciornei 2021-06-10 18:19 ` Rafael J. Wysocki 2021-06-10 18:19 ` Rafael J. Wysocki 2021-06-10 16:39 ` [PATCH net-next v8 12/15] net/fsl: Use [acpi|of]_mdiobus_register Ioana Ciornei 2021-06-10 16:39 ` Ioana Ciornei 2021-06-11 8:57 ` Andy Shevchenko 2021-06-11 8:57 ` Andy Shevchenko 2021-06-10 16:39 ` [PATCH net-next v8 13/15] net: phylink: introduce phylink_fwnode_phy_connect() Ioana Ciornei 2021-06-10 16:39 ` Ioana Ciornei 2021-06-10 16:39 ` [PATCH net-next v8 14/15] net: phylink: Refactor phylink_of_phy_connect() Ioana Ciornei 2021-06-10 16:39 ` Ioana Ciornei 2021-06-10 16:39 ` [PATCH net-next v8 15/15] net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver Ioana Ciornei 2021-06-10 16:39 ` Ioana Ciornei 2021-06-10 18:23 ` Rafael J. Wysocki 2021-06-10 18:23 ` Rafael J. Wysocki 2021-06-10 16:56 ` [PATCH net-next v8 00/15] ACPI support for dpaa2 driver Andrew Lunn 2021-06-10 16:56 ` Andrew Lunn 2021-06-10 17:51 ` Jon Nettleton 2021-06-10 17:51 ` Jon Nettleton 2021-06-10 18:25 ` Rafael J. Wysocki 2021-06-10 18:25 ` Rafael J. Wysocki 2021-06-10 18:27 ` Grant Likely 2021-06-10 18:27 ` Grant Likely 2021-06-10 18:40 ` Andrew Lunn 2021-06-10 18:40 ` Andrew Lunn 2021-06-10 18:19 ` Grant Likely 2021-06-10 18:19 ` Grant Likely 2021-06-11 9:00 ` Andy Shevchenko 2021-06-11 9:00 ` Andy Shevchenko 2021-06-11 9:17 ` Ioana Ciornei 2021-06-11 9:17 ` Ioana Ciornei
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210610163917.4138412-6-ciorneiioana@gmail.com \ --to=ciorneiioana@gmail.com \ --cc=andrew@lunn.ch \ --cc=andy.shevchenko@gmail.com \ --cc=calvin.johnson@nxp.com \ --cc=calvin.johnson@oss.nxp.com \ --cc=cristian.sovaiala@nxp.com \ --cc=diana.craciun@nxp.com \ --cc=f.fainelli@gmail.com \ --cc=florinlaurentiu.chiculita@nxp.com \ --cc=grant.likely@arm.com \ --cc=heikki.krogerus@linux.intel.com \ --cc=ioana.ciornei@nxp.com \ --cc=jeremy.linton@arm.com \ --cc=jon@solid-run.com \ --cc=laurentiu.tudor@nxp.com \ --cc=lenb@kernel.org \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux.cj@gmail.com \ --cc=linux@armlinux.org.uk \ --cc=madalin.bucur@nxp.com \ --cc=mw@semihalf.com \ --cc=netdev@vger.kernel.org \ --cc=pieter.jansenvv@bamboosystems.io \ --cc=rafael@kernel.org \ --cc=rdunlap@infradead.org \ --cc=rjw@rjwysocki.net \ --cc=saravanak@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.