Re: [PATCH net-next v8 12/15] net/fsl: Use [acpi|of]_mdiobus_register

From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Ioana Ciornei <ciorneiioana@gmail.com>
Cc: Grant Likely <grant.likely@arm.com>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Jeremy Linton <jeremy.linton@arm.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Russell King - ARM Linux admin <linux@armlinux.org.uk>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Marcin Wojtas <mw@semihalf.com>,
	Pieter Jansen Van Vuuren <pieter.jansenvv@bamboosystems.io>,
	Jon <jon@solid-run.com>, Saravana Kannan <saravanak@google.com>,
	Randy Dunlap <rdunlap@infradead.org>,
	Calvin Johnson <calvin.johnson@nxp.com>,
	Cristi Sovaiala <cristian.sovaiala@nxp.com>,
	Florin Laurentiu Chiculita <florinlaurentiu.chiculita@nxp.com>,
	Madalin Bucur <madalin.bucur@nxp.com>,
	linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
	Diana Madalina Craciun <diana.craciun@nxp.com>,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"linux.cj" <linux.cj@gmail.com>, netdev <netdev@vger.kernel.org>,
	Laurentiu Tudor <laurentiu.tudor@nxp.com>,
	Len Brown <lenb@kernel.org>,
	"Rafael J . Wysocki" <rjw@rjwysocki.net>,
	Calvin Johnson <calvin.johnson@oss.nxp.com>,
	Ioana Ciornei <ioana.ciornei@nxp.com>
Subject: Re: [PATCH net-next v8 12/15] net/fsl: Use [acpi|of]_mdiobus_register
Date: Fri, 11 Jun 2021 11:57:19 +0300	[thread overview]
Message-ID: <CAHp75Vcch1aO97Dg86Eo9bdrdwSfPE+p5iFJLk8Y5jx13q8Cpg@mail.gmail.com> (raw)
In-Reply-To: <20210610163917.4138412-13-ciorneiioana@gmail.com>

On Thu, Jun 10, 2021 at 7:40 PM Ioana Ciornei <ciorneiioana@gmail.com> wrote:
>
> From: Calvin Johnson <calvin.johnson@oss.nxp.com>
>
> Depending on the device node type, call the specific OF or ACPI
> mdiobus_register function.
>
> Note: For both ACPI and DT cases, endianness of MDIO controller

controllers

> need to be specified using "little-endian" property.

using the

...

> Changes in v8:
> - Directly call the OF or ACPI variants of registering the MDIO bus.
>   This is needed because the fwnode_mdio.c module should only implement
>   features which can be achieved without going back to the OF/ACPI
>   variants. Without this restrictions we directly end up in a dependency
>   cycle: of_mdio -> fwnode_mdio -> of_mdio.

Shouldn't be simple fwnode_mdio.h.
The idea of fwnode APIs that they provide a common ground for all
resource providers.

> - Changed the commit title since the fwnode_mdiobus_register() is no
>   longer available
>
> Changes in v7:
> - Include fwnode_mdio.h

> - Alphabetically sort header inclusions

I suppose this should be a separate change.

-- 
With Best Regards,
Andy Shevchenko