From: Cristian Marussi <cristian.marussi@arm.com> To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, virtualization@lists.linux-foundation.org, virtio-dev@lists.oasis-open.org Cc: sudeep.holla@arm.com, james.quinlan@broadcom.com, Jonathan.Cameron@Huawei.com, f.fainelli@gmail.com, etienne.carriere@linaro.org, vincent.guittot@linaro.org, souvik.chakravarty@arm.com, cristian.marussi@arm.com, igor.skalkin@opensynergy.com, peter.hilber@opensynergy.com, alex.bennee@linaro.org, jean-philippe@linaro.org, mikhail.golubev@opensynergy.com, anton.yakovlev@opensynergy.com, Vasyl.Vavrychuk@opensynergy.com, Andriy.Tryshnivskyy@opensynergy.com Subject: [PATCH v4 10/16] firmware: arm_scmi: Add per-device transport private info Date: Fri, 11 Jun 2021 17:59:31 +0100 [thread overview] Message-ID: <20210611165937.701-11-cristian.marussi@arm.com> (raw) In-Reply-To: <20210611165937.701-1-cristian.marussi@arm.com> From: Peter Hilber <peter.hilber@opensynergy.com> The scmi-virtio transport will link a supplier device to the arm-scmi device in the link_supplier() op. The transport should then save a pointer to the linked device. To enable this, add a transport private info to the scmi_info. (The scmi_info is already reachable through the arm-scmi device driver_data.) Signed-off-by: Peter Hilber <peter.hilber@opensynergy.com> --- drivers/firmware/arm_scmi/common.h | 2 ++ drivers/firmware/arm_scmi/driver.c | 35 ++++++++++++++++++++++++++++++ 2 files changed, 37 insertions(+) diff --git a/drivers/firmware/arm_scmi/common.h b/drivers/firmware/arm_scmi/common.h index a31194b3000a..7219970fc5eb 100644 --- a/drivers/firmware/arm_scmi/common.h +++ b/drivers/firmware/arm_scmi/common.h @@ -389,6 +389,8 @@ extern const struct scmi_desc scmi_mailbox_desc; extern const struct scmi_desc scmi_smc_desc; #endif +int scmi_set_transport_info(struct device *dev, void *transport_info); +void *scmi_get_transport_info(struct device *dev); void scmi_rx_callback(struct scmi_chan_info *cinfo, u32 msg_hdr); void scmi_free_channel(struct scmi_chan_info *cinfo, struct idr *idr, int id); diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c index 69fa97250d98..bb2de15554a9 100644 --- a/drivers/firmware/arm_scmi/driver.c +++ b/drivers/firmware/arm_scmi/driver.c @@ -138,6 +138,7 @@ struct scmi_protocol_instance { * @active_protocols: IDR storing device_nodes for protocols actually defined * in the DT and confirmed as implemented by fw. * @notify_priv: Pointer to private data structure specific to notifications. + * @transport_info: Transport private info * @node: List head * @users: Number of users of this instance */ @@ -156,6 +157,7 @@ struct scmi_info { u8 *protocols_imp; struct idr active_protocols; void *notify_priv; + void *transport_info; struct list_head node; int users; }; @@ -679,6 +681,39 @@ void scmi_rx_callback(struct scmi_chan_info *cinfo, u32 msg_hdr) } } +/** + * scmi_set_transport_info() - Set transport private info + * + * @dev: SCMI instance device + * @transport_info: transport private info + * + * Return: 0 on success, otherwise error. + */ +int scmi_set_transport_info(struct device *dev, void *transport_info) +{ + struct scmi_info *info = dev_get_drvdata(dev); + + if (!info) + return -EBADR; + + info->transport_info = transport_info; + return 0; +} + +/** + * scmi_get_transport_info() - Get transport private info + * + * @dev: SCMI instance device + * + * Return: transport private info on success, otherwise NULL. + */ +void *scmi_get_transport_info(struct device *dev) +{ + struct scmi_info *info = dev_get_drvdata(dev); + + return info ? info->transport_info : NULL; +} + /** * xfer_put() - Release a transmit message * -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Cristian Marussi <cristian.marussi@arm.com> To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, virtualization@lists.linux-foundation.org, virtio-dev@lists.oasis-open.org Cc: sudeep.holla@arm.com, james.quinlan@broadcom.com, Jonathan.Cameron@Huawei.com, f.fainelli@gmail.com, etienne.carriere@linaro.org, vincent.guittot@linaro.org, souvik.chakravarty@arm.com, cristian.marussi@arm.com, igor.skalkin@opensynergy.com, peter.hilber@opensynergy.com, alex.bennee@linaro.org, jean-philippe@linaro.org, mikhail.golubev@opensynergy.com, anton.yakovlev@opensynergy.com, Vasyl.Vavrychuk@opensynergy.com, Andriy.Tryshnivskyy@opensynergy.com Subject: [PATCH v4 10/16] firmware: arm_scmi: Add per-device transport private info Date: Fri, 11 Jun 2021 17:59:31 +0100 [thread overview] Message-ID: <20210611165937.701-11-cristian.marussi@arm.com> (raw) In-Reply-To: <20210611165937.701-1-cristian.marussi@arm.com> From: Peter Hilber <peter.hilber@opensynergy.com> The scmi-virtio transport will link a supplier device to the arm-scmi device in the link_supplier() op. The transport should then save a pointer to the linked device. To enable this, add a transport private info to the scmi_info. (The scmi_info is already reachable through the arm-scmi device driver_data.) Signed-off-by: Peter Hilber <peter.hilber@opensynergy.com> --- drivers/firmware/arm_scmi/common.h | 2 ++ drivers/firmware/arm_scmi/driver.c | 35 ++++++++++++++++++++++++++++++ 2 files changed, 37 insertions(+) diff --git a/drivers/firmware/arm_scmi/common.h b/drivers/firmware/arm_scmi/common.h index a31194b3000a..7219970fc5eb 100644 --- a/drivers/firmware/arm_scmi/common.h +++ b/drivers/firmware/arm_scmi/common.h @@ -389,6 +389,8 @@ extern const struct scmi_desc scmi_mailbox_desc; extern const struct scmi_desc scmi_smc_desc; #endif +int scmi_set_transport_info(struct device *dev, void *transport_info); +void *scmi_get_transport_info(struct device *dev); void scmi_rx_callback(struct scmi_chan_info *cinfo, u32 msg_hdr); void scmi_free_channel(struct scmi_chan_info *cinfo, struct idr *idr, int id); diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c index 69fa97250d98..bb2de15554a9 100644 --- a/drivers/firmware/arm_scmi/driver.c +++ b/drivers/firmware/arm_scmi/driver.c @@ -138,6 +138,7 @@ struct scmi_protocol_instance { * @active_protocols: IDR storing device_nodes for protocols actually defined * in the DT and confirmed as implemented by fw. * @notify_priv: Pointer to private data structure specific to notifications. + * @transport_info: Transport private info * @node: List head * @users: Number of users of this instance */ @@ -156,6 +157,7 @@ struct scmi_info { u8 *protocols_imp; struct idr active_protocols; void *notify_priv; + void *transport_info; struct list_head node; int users; }; @@ -679,6 +681,39 @@ void scmi_rx_callback(struct scmi_chan_info *cinfo, u32 msg_hdr) } } +/** + * scmi_set_transport_info() - Set transport private info + * + * @dev: SCMI instance device + * @transport_info: transport private info + * + * Return: 0 on success, otherwise error. + */ +int scmi_set_transport_info(struct device *dev, void *transport_info) +{ + struct scmi_info *info = dev_get_drvdata(dev); + + if (!info) + return -EBADR; + + info->transport_info = transport_info; + return 0; +} + +/** + * scmi_get_transport_info() - Get transport private info + * + * @dev: SCMI instance device + * + * Return: transport private info on success, otherwise NULL. + */ +void *scmi_get_transport_info(struct device *dev) +{ + struct scmi_info *info = dev_get_drvdata(dev); + + return info ? info->transport_info : NULL; +} + /** * xfer_put() - Release a transmit message * -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-06-11 17:01 UTC|newest] Thread overview: 97+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-11 16:59 [PATCH v4 00/16] Introduce SCMI VirtIO transport Cristian Marussi 2021-06-11 16:59 ` Cristian Marussi 2021-06-11 16:59 ` [PATCH v4 01/16] firmware: arm_scmi: Fix max pending messages boundary check Cristian Marussi 2021-06-11 16:59 ` Cristian Marussi 2021-07-01 8:42 ` Peter Hilber 2021-07-01 8:42 ` [virtio-dev] " Peter Hilber 2021-07-01 8:42 ` Peter Hilber 2021-07-01 10:04 ` Cristian Marussi 2021-07-01 10:04 ` Cristian Marussi 2021-06-11 16:59 ` [PATCH v4 02/16] firmware: arm_scmi: Add support for type handling in common functions Cristian Marussi 2021-06-11 16:59 ` Cristian Marussi 2021-06-11 16:59 ` [PATCH v4 03/16] firmware: arm_scmi: Add transport optional init/exit support Cristian Marussi 2021-06-11 16:59 ` Cristian Marussi 2021-06-14 13:29 ` Jonathan Cameron 2021-06-14 13:29 ` Jonathan Cameron 2021-06-16 9:04 ` Cristian Marussi 2021-06-16 9:04 ` Cristian Marussi 2021-06-11 16:59 ` [PATCH v4 04/16] firmware: arm_scmi: Introduce monotonically increasing tokens Cristian Marussi 2021-06-11 16:59 ` Cristian Marussi 2021-06-14 13:53 ` Jonathan Cameron 2021-06-14 13:53 ` Jonathan Cameron 2021-06-16 9:11 ` Cristian Marussi 2021-06-16 9:11 ` Cristian Marussi 2021-07-01 8:42 ` Peter Hilber 2021-07-01 8:42 ` [virtio-dev] " Peter Hilber 2021-07-01 8:42 ` Peter Hilber 2021-07-01 10:16 ` Cristian Marussi 2021-07-01 10:16 ` Cristian Marussi 2021-06-11 16:59 ` [PATCH v4 05/16] firmware: arm_scmi: Introduce delegated xfers support Cristian Marussi 2021-06-11 16:59 ` Cristian Marussi 2021-07-01 8:42 ` Peter Hilber 2021-07-01 8:42 ` [virtio-dev] " Peter Hilber 2021-07-01 8:42 ` Peter Hilber 2021-07-01 10:24 ` Cristian Marussi 2021-07-01 10:24 ` Cristian Marussi 2021-06-11 16:59 ` [PATCH v4 06/16] firmware: arm_scmi, smccc, mailbox: Make shmem based transports optional Cristian Marussi 2021-06-11 16:59 ` Cristian Marussi 2021-07-01 8:42 ` Peter Hilber 2021-07-01 8:42 ` [virtio-dev] " Peter Hilber 2021-07-01 8:42 ` Peter Hilber 2021-07-01 10:27 ` Cristian Marussi 2021-07-01 10:27 ` Cristian Marussi 2021-06-11 16:59 ` [PATCH v4 07/16] firmware: arm_scmi: Add op to override max message # Cristian Marussi 2021-06-11 16:59 ` Cristian Marussi 2021-06-14 14:04 ` Jonathan Cameron 2021-06-14 14:04 ` Jonathan Cameron 2021-06-16 9:13 ` Cristian Marussi 2021-06-16 9:13 ` Cristian Marussi 2021-06-11 16:59 ` [PATCH v4 08/16] [RFC][REWORK] " Cristian Marussi 2021-06-11 16:59 ` Cristian Marussi 2021-06-11 16:59 ` [PATCH v4 09/16] firmware: arm_scmi: Add optional link_supplier() transport op Cristian Marussi 2021-06-11 16:59 ` Cristian Marussi 2021-06-11 16:59 ` Cristian Marussi [this message] 2021-06-11 16:59 ` [PATCH v4 10/16] firmware: arm_scmi: Add per-device transport private info Cristian Marussi 2021-06-11 16:59 ` [PATCH v4 11/16] firmware: arm_scmi: Add is_scmi_protocol_device() Cristian Marussi 2021-06-11 16:59 ` Cristian Marussi 2021-06-11 16:59 ` [PATCH v4 12/16] firmware: arm_scmi: Add message passing abstractions for transports Cristian Marussi 2021-06-11 16:59 ` Cristian Marussi 2021-06-14 14:10 ` Jonathan Cameron 2021-06-14 14:10 ` Jonathan Cameron 2021-06-16 9:14 ` Cristian Marussi 2021-06-16 9:14 ` Cristian Marussi 2021-06-11 16:59 ` [PATCH v4 13/16] dt-bindings: arm: Add virtio transport for SCMI Cristian Marussi 2021-06-11 16:59 ` Cristian Marussi 2021-06-24 19:22 ` Rob Herring 2021-06-24 19:22 ` Rob Herring 2021-06-24 19:22 ` Rob Herring 2021-07-01 8:43 ` Peter Hilber 2021-07-01 8:43 ` [virtio-dev] " Peter Hilber 2021-07-01 8:43 ` Peter Hilber 2021-07-01 10:31 ` Cristian Marussi 2021-07-01 10:31 ` Cristian Marussi 2021-06-11 16:59 ` [PATCH v4 14/16] firmware: arm_scmi: Add virtio transport Cristian Marussi 2021-06-11 16:59 ` Cristian Marussi 2021-06-14 14:23 ` Jonathan Cameron 2021-06-14 14:23 ` Jonathan Cameron 2021-06-16 10:18 ` Cristian Marussi 2021-06-16 10:18 ` Cristian Marussi 2021-07-01 8:43 ` Peter Hilber 2021-07-01 8:43 ` [virtio-dev] " Peter Hilber 2021-07-01 8:43 ` Peter Hilber 2021-07-01 10:34 ` Cristian Marussi 2021-07-01 10:34 ` Cristian Marussi 2021-06-11 16:59 ` [PATCH v4 15/16] [RFC][REWORK] firmware: arm_scmi: make virtio-scmi use delegated xfers Cristian Marussi 2021-06-11 16:59 ` Cristian Marussi 2021-07-01 8:43 ` Peter Hilber 2021-07-01 8:43 ` [virtio-dev] " Peter Hilber 2021-07-01 8:43 ` Peter Hilber 2021-07-01 11:26 ` Cristian Marussi 2021-07-01 11:26 ` Cristian Marussi 2021-06-11 16:59 ` [PATCH v4 16/16] firmware: arm_scmi: Add polling mode to virtio transport Cristian Marussi 2021-06-11 16:59 ` Cristian Marussi 2021-06-14 11:43 ` [PATCH v4 00/16] Introduce SCMI VirtIO transport Christoph Hellwig 2021-06-14 11:43 ` Christoph Hellwig 2021-06-14 11:43 ` Christoph Hellwig 2021-06-14 14:03 ` Cristian Marussi 2021-06-14 14:03 ` Cristian Marussi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210611165937.701-11-cristian.marussi@arm.com \ --to=cristian.marussi@arm.com \ --cc=Andriy.Tryshnivskyy@opensynergy.com \ --cc=Jonathan.Cameron@Huawei.com \ --cc=Vasyl.Vavrychuk@opensynergy.com \ --cc=alex.bennee@linaro.org \ --cc=anton.yakovlev@opensynergy.com \ --cc=etienne.carriere@linaro.org \ --cc=f.fainelli@gmail.com \ --cc=igor.skalkin@opensynergy.com \ --cc=james.quinlan@broadcom.com \ --cc=jean-philippe@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mikhail.golubev@opensynergy.com \ --cc=peter.hilber@opensynergy.com \ --cc=souvik.chakravarty@arm.com \ --cc=sudeep.holla@arm.com \ --cc=vincent.guittot@linaro.org \ --cc=virtio-dev@lists.oasis-open.org \ --cc=virtualization@lists.linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.