* [Intel-gfx] [CI 0/4] Pipe DMC Support @ 2021-06-13 16:13 Anusha Srivatsa 2021-06-13 16:14 ` [Intel-gfx] [CI 1/4] drm/i915/dmc: Introduce DMC_FW_MAIN Anusha Srivatsa ` (7 more replies) 0 siblings, 8 replies; 13+ messages in thread From: Anusha Srivatsa @ 2021-06-13 16:13 UTC (permalink / raw) To: intel-gfx One change from previous verison is a fix of SKL regression. Corner cases for stepping-substepping combination was missing from fw_info_matches_stepping() helper. Luckily SKL was the only platform in CI that came under this category and DMC refused to load. v2: SKL fix tested on SKL. v3: Minor changes in Pipe DMC plugging patch as suggested by Lucas v4: Remove the sanity check for MMIO that no longer apply to newer platforms.(Anusha) Anusha Srivatsa (4): drm/i915/dmc: Introduce DMC_FW_MAIN drm/i915/xelpd: Pipe A DMC plugging drm/i915/adl_p: Pipe B DMC Support drm/i915/adl_p: Load DMC .../drm/i915/display/intel_display_debugfs.c | 6 +- .../drm/i915/display/intel_display_power.c | 5 +- drivers/gpu/drm/i915/display/intel_dmc.c | 165 ++++++++++-------- drivers/gpu/drm/i915/display/intel_dmc.h | 23 ++- drivers/gpu/drm/i915/i915_reg.h | 2 +- 5 files changed, 123 insertions(+), 78 deletions(-) -- 2.25.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 13+ messages in thread
* [Intel-gfx] [CI 1/4] drm/i915/dmc: Introduce DMC_FW_MAIN 2021-06-13 16:13 [Intel-gfx] [CI 0/4] Pipe DMC Support Anusha Srivatsa @ 2021-06-13 16:14 ` Anusha Srivatsa 2021-06-13 16:14 ` [Intel-gfx] [CI 2/4] drm/i915/xelpd: Pipe A DMC plugging Anusha Srivatsa ` (6 subsequent siblings) 7 siblings, 0 replies; 13+ messages in thread From: Anusha Srivatsa @ 2021-06-13 16:14 UTC (permalink / raw) To: intel-gfx This is a prep patch for Pipe DMC plugging. Add dmc_info struct in intel_dmc to have all common fields shared between all DMC's in the package. Add DMC_FW_MAIN(dmc_id 0) to refer to the blob. v2: Remove dmc_offset and start_mmioaddr from dmc_info struct (Jose) Cc: Souza, Jose <jose.souza@intel.com> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com> Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com> --- drivers/gpu/drm/i915/display/intel_dmc.c | 38 +++++++++++++----------- drivers/gpu/drm/i915/display/intel_dmc.h | 18 +++++++---- 2 files changed, 33 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i915/display/intel_dmc.c index 97308da28059..269a57d936ab 100644 --- a/drivers/gpu/drm/i915/display/intel_dmc.c +++ b/drivers/gpu/drm/i915/display/intel_dmc.c @@ -239,7 +239,7 @@ struct stepping_info { bool intel_dmc_has_payload(struct drm_i915_private *i915) { - return i915->dmc.dmc_payload; + return i915->dmc.dmc_info[DMC_FW_MAIN].payload; } static const struct stepping_info skl_stepping_info[] = { @@ -316,7 +316,8 @@ static void gen9_set_dc_state_debugmask(struct drm_i915_private *dev_priv) */ void intel_dmc_load_program(struct drm_i915_private *dev_priv) { - u32 *payload = dev_priv->dmc.dmc_payload; + struct intel_dmc *dmc = &dev_priv->dmc; + struct dmc_fw_info *dmc_info = &dmc->dmc_info[DMC_FW_MAIN]; u32 i, fw_size; if (!HAS_DMC(dev_priv)) { @@ -325,26 +326,26 @@ void intel_dmc_load_program(struct drm_i915_private *dev_priv) return; } - if (!intel_dmc_has_payload(dev_priv)) { + if (!dev_priv->dmc.dmc_info[DMC_FW_MAIN].payload) { drm_err(&dev_priv->drm, "Tried to program CSR with empty payload\n"); return; } - fw_size = dev_priv->dmc.dmc_fw_size; + fw_size = dmc_info->dmc_fw_size; assert_rpm_wakelock_held(&dev_priv->runtime_pm); preempt_disable(); for (i = 0; i < fw_size; i++) intel_uncore_write_fw(&dev_priv->uncore, DMC_PROGRAM(i), - payload[i]); + dmc_info->payload[i]); preempt_enable(); - for (i = 0; i < dev_priv->dmc.mmio_count; i++) { - intel_de_write(dev_priv, dev_priv->dmc.mmioaddr[i], - dev_priv->dmc.mmiodata[i]); + for (i = 0; i < dmc_info->mmio_count; i++) { + intel_de_write(dev_priv, dmc_info->mmioaddr[i], + dmc_info->mmiodata[i]); } dev_priv->dmc.dc_state = 0; @@ -401,13 +402,14 @@ static u32 parse_dmc_fw_header(struct intel_dmc *dmc, size_t rem_size) { struct drm_i915_private *i915 = container_of(dmc, typeof(*i915), dmc); + struct dmc_fw_info *dmc_info = &dmc->dmc_info[DMC_FW_MAIN]; unsigned int header_len_bytes, dmc_header_size, payload_size, i; const u32 *mmioaddr, *mmiodata; u32 mmio_count, mmio_count_max; u8 *payload; - BUILD_BUG_ON(ARRAY_SIZE(dmc->mmioaddr) < DMC_V3_MAX_MMIO_COUNT || - ARRAY_SIZE(dmc->mmioaddr) < DMC_V1_MAX_MMIO_COUNT); + BUILD_BUG_ON(ARRAY_SIZE(dmc_info->mmioaddr) < DMC_V3_MAX_MMIO_COUNT || + ARRAY_SIZE(dmc_info->mmioaddr) < DMC_V1_MAX_MMIO_COUNT); /* * Check if we can access common fields, we will checkc again below @@ -469,10 +471,10 @@ static u32 parse_dmc_fw_header(struct intel_dmc *dmc, mmioaddr[i]); return 0; } - dmc->mmioaddr[i] = _MMIO(mmioaddr[i]); - dmc->mmiodata[i] = mmiodata[i]; + dmc_info->mmioaddr[i] = _MMIO(mmioaddr[i]); + dmc_info->mmiodata[i] = mmiodata[i]; } - dmc->mmio_count = mmio_count; + dmc_info->mmio_count = mmio_count; rem_size -= header_len_bytes; @@ -485,14 +487,14 @@ static u32 parse_dmc_fw_header(struct intel_dmc *dmc, drm_err(&i915->drm, "DMC FW too big (%u bytes)\n", payload_size); return 0; } - dmc->dmc_fw_size = dmc_header->fw_size; + dmc_info->dmc_fw_size = dmc_header->fw_size; - dmc->dmc_payload = kmalloc(payload_size, GFP_KERNEL); - if (!dmc->dmc_payload) + dmc_info->payload = kmalloc(payload_size, GFP_KERNEL); + if (!dmc_info->payload) return 0; payload = (u8 *)(dmc_header) + header_len_bytes; - memcpy(dmc->dmc_payload, payload, payload_size); + memcpy(dmc_info->payload, payload, payload_size); return header_len_bytes + payload_size; @@ -827,5 +829,5 @@ void intel_dmc_ucode_fini(struct drm_i915_private *dev_priv) intel_dmc_ucode_suspend(dev_priv); drm_WARN_ON(&dev_priv->drm, dev_priv->dmc.wakeref); - kfree(dev_priv->dmc.dmc_payload); + kfree(dev_priv->dmc.dmc_info[DMC_FW_MAIN].payload); } diff --git a/drivers/gpu/drm/i915/display/intel_dmc.h b/drivers/gpu/drm/i915/display/intel_dmc.h index 4c22f567b61b..b872f3a4fd03 100644 --- a/drivers/gpu/drm/i915/display/intel_dmc.h +++ b/drivers/gpu/drm/i915/display/intel_dmc.h @@ -16,17 +16,25 @@ struct drm_i915_private; #define DMC_VERSION_MAJOR(version) ((version) >> 16) #define DMC_VERSION_MINOR(version) ((version) & 0xffff) +enum { + DMC_FW_MAIN = 0, + DMC_FW_MAX +}; + struct intel_dmc { struct work_struct work; const char *fw_path; u32 required_version; u32 max_fw_size; /* bytes */ - u32 *dmc_payload; - u32 dmc_fw_size; /* dwords */ u32 version; - u32 mmio_count; - i915_reg_t mmioaddr[20]; - u32 mmiodata[20]; + struct dmc_fw_info { + u32 mmio_count; + i915_reg_t mmioaddr[20]; + u32 mmiodata[20]; + u32 dmc_fw_size; /*dwords */ + u32 *payload; + } dmc_info[DMC_FW_MAX]; + u32 dc_state; u32 target_dc_state; u32 allowed_dc_mask; -- 2.32.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 13+ messages in thread
* [Intel-gfx] [CI 2/4] drm/i915/xelpd: Pipe A DMC plugging 2021-06-13 16:13 [Intel-gfx] [CI 0/4] Pipe DMC Support Anusha Srivatsa 2021-06-13 16:14 ` [Intel-gfx] [CI 1/4] drm/i915/dmc: Introduce DMC_FW_MAIN Anusha Srivatsa @ 2021-06-13 16:14 ` Anusha Srivatsa 2021-06-13 16:14 ` [Intel-gfx] [CI 3/4] drm/i915/adl_p: Pipe B DMC Support Anusha Srivatsa ` (5 subsequent siblings) 7 siblings, 0 replies; 13+ messages in thread From: Anusha Srivatsa @ 2021-06-13 16:14 UTC (permalink / raw) To: intel-gfx This patch adds Pipe A plumbing to the already existing parsing and loading functions which is taken care of in the prep patches. Adding MAX_DMC_FW to keep track for both Main and Pipe A DMC while loading the respective blobs. Also adding present field in dmc_info. s/find_dmc_fw_offset/csr_set_dmc_fw_offset. While at it add fw_info_matches_stepping() helper. CSR_PROGRAM() should now take the starting address of the particular blob (Main or Pipe) and not hardcode it. v2: Add dmc_offset and start_mmioaddr fields for dmc_info struct. v3: Add a missing corner cases of stepping-substepping combination in fw_info_matches_stepping() helper. v4: Add macro for start_mmioaddr for V1 package. Simplify code in dmc_set_fw_offset (Lucas) Cc: Souza, Jose <jose.souza@intel.com> Cc: Lucas De Marchi <lucas.demarchi@intel.com> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com> Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com> --- .../drm/i915/display/intel_display_debugfs.c | 4 +- .../drm/i915/display/intel_display_power.c | 5 +- drivers/gpu/drm/i915/display/intel_dmc.c | 131 ++++++++++-------- drivers/gpu/drm/i915/display/intel_dmc.h | 4 + drivers/gpu/drm/i915/i915_reg.h | 2 +- 5 files changed, 85 insertions(+), 61 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c index 88bb05d5c483..2a1c39a0e56e 100644 --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c @@ -544,6 +544,8 @@ static int i915_dmc_info(struct seq_file *m, void *unused) seq_printf(m, "fw loaded: %s\n", yesno(intel_dmc_has_payload(dev_priv))); seq_printf(m, "path: %s\n", dmc->fw_path); + seq_printf(m, "Pipe A fw support: %s\n", yesno(INTEL_GEN(dev_priv) >= 12)); + seq_printf(m, "Pipe A fw loaded: %s\n", yesno(dmc->dmc_info[DMC_FW_PIPEA].payload)); if (!intel_dmc_has_payload(dev_priv)) goto out; @@ -582,7 +584,7 @@ static int i915_dmc_info(struct seq_file *m, void *unused) out: seq_printf(m, "program base: 0x%08x\n", - intel_de_read(dev_priv, DMC_PROGRAM(0))); + intel_de_read(dev_priv, DMC_PROGRAM(dmc->dmc_info[DMC_FW_MAIN].start_mmioaddr, 0))); seq_printf(m, "ssp base: 0x%08x\n", intel_de_read(dev_priv, DMC_SSP_BASE)); seq_printf(m, "htp: 0x%08x\n", intel_de_read(dev_priv, DMC_HTP_SKL)); diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c index 4298ae684d7d..285380079aab 100644 --- a/drivers/gpu/drm/i915/display/intel_display_power.c +++ b/drivers/gpu/drm/i915/display/intel_display_power.c @@ -961,8 +961,9 @@ static void bxt_disable_dc9(struct drm_i915_private *dev_priv) static void assert_dmc_loaded(struct drm_i915_private *dev_priv) { drm_WARN_ONCE(&dev_priv->drm, - !intel_de_read(dev_priv, DMC_PROGRAM(0)), - "DMC program storage start is NULL\n"); + !intel_de_read(dev_priv, + DMC_PROGRAM(dev_priv->dmc.dmc_info[DMC_FW_MAIN].start_mmioaddr, 0)), + "DMC program storage start is NULL\n"); drm_WARN_ONCE(&dev_priv->drm, !intel_de_read(dev_priv, DMC_SSP_BASE), "DMC SSP Base Not fine\n"); drm_WARN_ONCE(&dev_priv->drm, !intel_de_read(dev_priv, DMC_HTP_SKL), diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i915/display/intel_dmc.c index 269a57d936ab..18e0d225a478 100644 --- a/drivers/gpu/drm/i915/display/intel_dmc.c +++ b/drivers/gpu/drm/i915/display/intel_dmc.c @@ -96,6 +96,7 @@ MODULE_FIRMWARE(BXT_DMC_PATH); #define PACKAGE_V2_MAX_FW_INFO_ENTRIES 32 #define DMC_V1_MAX_MMIO_COUNT 8 #define DMC_V3_MAX_MMIO_COUNT 20 +#define DMC_V1_MMIO_START_RANGE 0x80000 struct intel_css_header { /* 0x09 for DMC */ @@ -317,8 +318,7 @@ static void gen9_set_dc_state_debugmask(struct drm_i915_private *dev_priv) void intel_dmc_load_program(struct drm_i915_private *dev_priv) { struct intel_dmc *dmc = &dev_priv->dmc; - struct dmc_fw_info *dmc_info = &dmc->dmc_info[DMC_FW_MAIN]; - u32 i, fw_size; + u32 id, i; if (!HAS_DMC(dev_priv)) { drm_err(&dev_priv->drm, @@ -332,20 +332,25 @@ void intel_dmc_load_program(struct drm_i915_private *dev_priv) return; } - fw_size = dmc_info->dmc_fw_size; assert_rpm_wakelock_held(&dev_priv->runtime_pm); preempt_disable(); - for (i = 0; i < fw_size; i++) - intel_uncore_write_fw(&dev_priv->uncore, DMC_PROGRAM(i), - dmc_info->payload[i]); + for (id = 0; id < DMC_FW_MAX; id++) { + for (i = 0; i < dmc->dmc_info[id].dmc_fw_size; i++) { + intel_uncore_write_fw(&dev_priv->uncore, + DMC_PROGRAM(dmc->dmc_info[id].start_mmioaddr, i), + dmc->dmc_info[id].payload[i]); + } + } preempt_enable(); - for (i = 0; i < dmc_info->mmio_count; i++) { - intel_de_write(dev_priv, dmc_info->mmioaddr[i], - dmc_info->mmiodata[i]); + for (id = 0; id < DMC_FW_MAX; id++) { + for (i = 0; i < dmc->dmc_info[id].mmio_count; i++) { + intel_de_write(dev_priv, dmc->dmc_info[id].mmioaddr[i], + dmc->dmc_info[id].mmiodata[i]); + } } dev_priv->dmc.dc_state = 0; @@ -353,59 +358,68 @@ void intel_dmc_load_program(struct drm_i915_private *dev_priv) gen9_set_dc_state_debugmask(dev_priv); } +static bool fw_info_matches_stepping(const struct intel_fw_info *fw_info, + const struct stepping_info *si) +{ + if ((fw_info->substepping == '*' && si->stepping == fw_info->stepping) || + (si->stepping == fw_info->stepping && si->substepping == fw_info->substepping) || + /* + * If we don't find a more specific one from above two checks, we + * then check for the generic one to be sure to work even with + * "broken firmware" + */ + (si->stepping == '*' && si->substepping == fw_info->substepping) || + (fw_info->stepping == '*' && fw_info->substepping == '*')) + return true; + + return false; +} + /* * Search fw_info table for dmc_offset to find firmware binary: num_entries is * already sanitized. */ -static u32 find_dmc_fw_offset(const struct intel_fw_info *fw_info, +static void dmc_set_fw_offset(struct intel_dmc *dmc, + const struct intel_fw_info *fw_info, unsigned int num_entries, const struct stepping_info *si, u8 package_ver) { - u32 dmc_offset = DMC_DEFAULT_FW_OFFSET; - unsigned int i; + unsigned int i, id; + + struct drm_i915_private *i915 = container_of(dmc, typeof(*i915), dmc); for (i = 0; i < num_entries; i++) { - if (package_ver > 1 && fw_info[i].dmc_id != 0) - continue; + id = package_ver <= 1 ? DMC_FW_MAIN : fw_info[i].dmc_id; - if (fw_info[i].substepping == '*' && - si->stepping == fw_info[i].stepping) { - dmc_offset = fw_info[i].offset; - break; + if (id >= DMC_FW_MAX) { + drm_dbg(&i915->drm, "Unsupported firmware id: %u\n", id); + continue; } - if (si->stepping == fw_info[i].stepping && - si->substepping == fw_info[i].substepping) { - dmc_offset = fw_info[i].offset; - break; - } + /* More specific versions come first, so we don't even have to + * check for the stepping since we already found a previous FW + * for this id. + */ + if (dmc->dmc_info[id].present) + continue; - if (fw_info[i].stepping == '*' && - fw_info[i].substepping == '*') { - /* - * In theory we should stop the search as generic - * entries should always come after the more specific - * ones, but let's continue to make sure to work even - * with "broken" firmwares. If we don't find a more - * specific one, then we use this entry - */ - dmc_offset = fw_info[i].offset; + if (fw_info_matches_stepping(&fw_info[i], si)) { + dmc->dmc_info[id].present = true; + dmc->dmc_info[id].dmc_offset = fw_info[i].offset; } } - - return dmc_offset; } static u32 parse_dmc_fw_header(struct intel_dmc *dmc, const struct intel_dmc_header_base *dmc_header, - size_t rem_size) + size_t rem_size, u8 dmc_id) { struct drm_i915_private *i915 = container_of(dmc, typeof(*i915), dmc); - struct dmc_fw_info *dmc_info = &dmc->dmc_info[DMC_FW_MAIN]; + struct dmc_fw_info *dmc_info = &dmc->dmc_info[dmc_id]; unsigned int header_len_bytes, dmc_header_size, payload_size, i; const u32 *mmioaddr, *mmiodata; - u32 mmio_count, mmio_count_max; + u32 mmio_count, mmio_count_max, start_mmioaddr; u8 *payload; BUILD_BUG_ON(ARRAY_SIZE(dmc_info->mmioaddr) < DMC_V3_MAX_MMIO_COUNT || @@ -432,6 +446,7 @@ static u32 parse_dmc_fw_header(struct intel_dmc *dmc, mmio_count_max = DMC_V3_MAX_MMIO_COUNT; /* header_len is in dwords */ header_len_bytes = dmc_header->header_len * 4; + start_mmioaddr = v3->start_mmioaddr; dmc_header_size = sizeof(*v3); } else if (dmc_header->header_ver == 1) { const struct intel_dmc_header_v1 *v1 = @@ -445,6 +460,7 @@ static u32 parse_dmc_fw_header(struct intel_dmc *dmc, mmio_count = v1->mmio_count; mmio_count_max = DMC_V1_MAX_MMIO_COUNT; header_len_bytes = dmc_header->header_len; + start_mmioaddr = DMC_V1_MMIO_START_RANGE; dmc_header_size = sizeof(*v1); } else { drm_err(&i915->drm, "Unknown DMC fw header version: %u\n", @@ -465,16 +481,11 @@ static u32 parse_dmc_fw_header(struct intel_dmc *dmc, } for (i = 0; i < mmio_count; i++) { - if (mmioaddr[i] < DMC_MMIO_START_RANGE || - mmioaddr[i] > DMC_MMIO_END_RANGE) { - drm_err(&i915->drm, "DMC firmware has wrong mmio address 0x%x\n", - mmioaddr[i]); - return 0; - } dmc_info->mmioaddr[i] = _MMIO(mmioaddr[i]); dmc_info->mmiodata[i] = mmiodata[i]; } dmc_info->mmio_count = mmio_count; + dmc_info->start_mmioaddr = start_mmioaddr; rem_size -= header_len_bytes; @@ -511,7 +522,7 @@ parse_dmc_fw_package(struct intel_dmc *dmc, { struct drm_i915_private *i915 = container_of(dmc, typeof(*i915), dmc); u32 package_size = sizeof(struct intel_package_header); - u32 num_entries, max_entries, dmc_offset; + u32 num_entries, max_entries; const struct intel_fw_info *fw_info; if (rem_size < package_size) @@ -547,16 +558,11 @@ parse_dmc_fw_package(struct intel_dmc *dmc, fw_info = (const struct intel_fw_info *) ((u8 *)package_header + sizeof(*package_header)); - dmc_offset = find_dmc_fw_offset(fw_info, num_entries, si, - package_header->header_ver); - if (dmc_offset == DMC_DEFAULT_FW_OFFSET) { - drm_err(&i915->drm, "DMC firmware not supported for %c stepping\n", - si->stepping); - return 0; - } + dmc_set_fw_offset(dmc, fw_info, num_entries, si, + package_header->header_ver); /* dmc_offset is in dwords */ - return package_size + dmc_offset * 4; + return package_size; error_truncated: drm_err(&i915->drm, "Truncated DMC firmware, refusing.\n"); @@ -608,7 +614,8 @@ static void parse_dmc_fw(struct drm_i915_private *dev_priv, struct intel_dmc *dmc = &dev_priv->dmc; const struct stepping_info *si = intel_get_stepping_info(dev_priv); u32 readcount = 0; - u32 r; + u32 r, offset; + int id; if (!fw) return; @@ -629,9 +636,19 @@ static void parse_dmc_fw(struct drm_i915_private *dev_priv, readcount += r; - /* Extract dmc_header information */ - dmc_header = (struct intel_dmc_header_base *)&fw->data[readcount]; - parse_dmc_fw_header(dmc, dmc_header, fw->size - readcount); + for (id = 0; id < DMC_FW_MAX; id++) { + if (!dev_priv->dmc.dmc_info[id].present) + continue; + + offset = readcount + dmc->dmc_info[id].dmc_offset * 4; + if (fw->size - offset < 0) { + drm_err(&dev_priv->drm, "Reading beyond the fw_size\n"); + continue; + } + + dmc_header = (struct intel_dmc_header_base *)&fw->data[offset]; + parse_dmc_fw_header(dmc, dmc_header, fw->size - offset, id); + } } static void intel_dmc_runtime_pm_get(struct drm_i915_private *dev_priv) diff --git a/drivers/gpu/drm/i915/display/intel_dmc.h b/drivers/gpu/drm/i915/display/intel_dmc.h index b872f3a4fd03..007a284b0ef0 100644 --- a/drivers/gpu/drm/i915/display/intel_dmc.h +++ b/drivers/gpu/drm/i915/display/intel_dmc.h @@ -18,6 +18,7 @@ struct drm_i915_private; enum { DMC_FW_MAIN = 0, + DMC_FW_PIPEA, DMC_FW_MAX }; @@ -31,8 +32,11 @@ struct intel_dmc { u32 mmio_count; i915_reg_t mmioaddr[20]; u32 mmiodata[20]; + u32 dmc_offset; + u32 start_mmioaddr; u32 dmc_fw_size; /*dwords */ u32 *payload; + bool present; } dmc_info[DMC_FW_MAX]; u32 dc_state; diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index e915ec034c98..fb5e8e12ff49 100644 --- a/drivers/gpu/drm/i915/i915_reg.h +++ b/drivers/gpu/drm/i915/i915_reg.h @@ -7751,7 +7751,7 @@ enum { #define GAMMA_MODE_MODE_12BIT_MULTI_SEGMENTED (3 << 0) /* icl + */ /* DMC */ -#define DMC_PROGRAM(i) _MMIO(0x80000 + (i) * 4) +#define DMC_PROGRAM(addr, i) _MMIO((addr) + (i) * 4) #define DMC_SSP_BASE_ADDR_GEN9 0x00002FC0 #define DMC_HTP_ADDR_SKL 0x00500034 #define DMC_SSP_BASE _MMIO(0x8F074) -- 2.32.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 13+ messages in thread
* [Intel-gfx] [CI 3/4] drm/i915/adl_p: Pipe B DMC Support 2021-06-13 16:13 [Intel-gfx] [CI 0/4] Pipe DMC Support Anusha Srivatsa 2021-06-13 16:14 ` [Intel-gfx] [CI 1/4] drm/i915/dmc: Introduce DMC_FW_MAIN Anusha Srivatsa 2021-06-13 16:14 ` [Intel-gfx] [CI 2/4] drm/i915/xelpd: Pipe A DMC plugging Anusha Srivatsa @ 2021-06-13 16:14 ` Anusha Srivatsa 2021-06-13 16:14 ` [Intel-gfx] [CI 4/4] drm/i915/adl_p: Load DMC Anusha Srivatsa ` (4 subsequent siblings) 7 siblings, 0 replies; 13+ messages in thread From: Anusha Srivatsa @ 2021-06-13 16:14 UTC (permalink / raw) To: intel-gfx ADLP requires us to load both Pipe A and Pipe B. Plug Pipe B loading support. Cc: Lucas De Marchi <lucas.demarchi@intel.com> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com> Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com> --- drivers/gpu/drm/i915/display/intel_display_debugfs.c | 2 ++ drivers/gpu/drm/i915/display/intel_dmc.h | 1 + 2 files changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c index 2a1c39a0e56e..db38891a9ef0 100644 --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c @@ -546,6 +546,8 @@ static int i915_dmc_info(struct seq_file *m, void *unused) seq_printf(m, "path: %s\n", dmc->fw_path); seq_printf(m, "Pipe A fw support: %s\n", yesno(INTEL_GEN(dev_priv) >= 12)); seq_printf(m, "Pipe A fw loaded: %s\n", yesno(dmc->dmc_info[DMC_FW_PIPEA].payload)); + seq_printf(m, "Pipe B fw support: %s\n", yesno(IS_ALDERLAKE_P(dev_priv))); + seq_printf(m, "Pipe B fw loaded: %s\n", yesno(dmc->dmc_info[DMC_FW_PIPEB].payload)); if (!intel_dmc_has_payload(dev_priv)) goto out; diff --git a/drivers/gpu/drm/i915/display/intel_dmc.h b/drivers/gpu/drm/i915/display/intel_dmc.h index 007a284b0ef0..c3c00ff03869 100644 --- a/drivers/gpu/drm/i915/display/intel_dmc.h +++ b/drivers/gpu/drm/i915/display/intel_dmc.h @@ -19,6 +19,7 @@ struct drm_i915_private; enum { DMC_FW_MAIN = 0, DMC_FW_PIPEA, + DMC_FW_PIPEB, DMC_FW_MAX }; -- 2.32.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 13+ messages in thread
* [Intel-gfx] [CI 4/4] drm/i915/adl_p: Load DMC 2021-06-13 16:13 [Intel-gfx] [CI 0/4] Pipe DMC Support Anusha Srivatsa ` (2 preceding siblings ...) 2021-06-13 16:14 ` [Intel-gfx] [CI 3/4] drm/i915/adl_p: Pipe B DMC Support Anusha Srivatsa @ 2021-06-13 16:14 ` Anusha Srivatsa 2021-06-13 16:23 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Pipe DMC Support (rev8) Patchwork ` (3 subsequent siblings) 7 siblings, 0 replies; 13+ messages in thread From: Anusha Srivatsa @ 2021-06-13 16:14 UTC (permalink / raw) To: intel-gfx Load DMC v2.10 on ADLP. The release notes mention that this version enables few power savings features. v2: Add DMC_PATH() for ADLP (Lucas) Cc: Lucas De Marchi <lucas.demarchi@intel.com> Cc: Clint Taylor <clinton.a.taylor@intel.com> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com> Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com> --- drivers/gpu/drm/i915/display/intel_dmc.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i915/display/intel_dmc.c index 18e0d225a478..f8789d4543bf 100644 --- a/drivers/gpu/drm/i915/display/intel_dmc.c +++ b/drivers/gpu/drm/i915/display/intel_dmc.c @@ -45,6 +45,10 @@ #define GEN12_DMC_MAX_FW_SIZE ICL_DMC_MAX_FW_SIZE +#define ADLP_DMC_PATH DMC_PATH(adlp, 2, 10) +#define ADLP_DMC_VERSION_REQUIRED DMC_VERSION(2, 10) +MODULE_FIRMWARE(ADLP_DMC_PATH); + #define ADLS_DMC_PATH DMC_PATH(adls, 2, 01) #define ADLS_DMC_VERSION_REQUIRED DMC_VERSION(2, 1) MODULE_FIRMWARE(ADLS_DMC_PATH); @@ -724,7 +728,11 @@ void intel_dmc_ucode_init(struct drm_i915_private *dev_priv) */ intel_dmc_runtime_pm_get(dev_priv); - if (IS_ALDERLAKE_S(dev_priv)) { + if (IS_ALDERLAKE_P(dev_priv)) { + dmc->fw_path = ADLP_DMC_PATH; + dmc->required_version = ADLP_DMC_VERSION_REQUIRED; + dmc->max_fw_size = GEN12_DMC_MAX_FW_SIZE; + } else if (IS_ALDERLAKE_S(dev_priv)) { dmc->fw_path = ADLS_DMC_PATH; dmc->required_version = ADLS_DMC_VERSION_REQUIRED; dmc->max_fw_size = GEN12_DMC_MAX_FW_SIZE; -- 2.32.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 13+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Pipe DMC Support (rev8) 2021-06-13 16:13 [Intel-gfx] [CI 0/4] Pipe DMC Support Anusha Srivatsa ` (3 preceding siblings ...) 2021-06-13 16:14 ` [Intel-gfx] [CI 4/4] drm/i915/adl_p: Load DMC Anusha Srivatsa @ 2021-06-13 16:23 ` Patchwork 2021-06-13 16:24 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork ` (2 subsequent siblings) 7 siblings, 0 replies; 13+ messages in thread From: Patchwork @ 2021-06-13 16:23 UTC (permalink / raw) To: Anusha Srivatsa; +Cc: intel-gfx == Series Details == Series: Pipe DMC Support (rev8) URL : https://patchwork.freedesktop.org/series/90445/ State : warning == Summary == $ dim checkpatch origin/drm-tip ee2ef4cb584b drm/i915/dmc: Introduce DMC_FW_MAIN 29dfec8e2a62 drm/i915/xelpd: Pipe A DMC plugging -:49: WARNING:LONG_LINE: line length of 103 exceeds 100 columns #49: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:587: + intel_de_read(dev_priv, DMC_PROGRAM(dmc->dmc_info[DMC_FW_MAIN].start_mmioaddr, 0))); -:64: WARNING:LONG_LINE: line length of 105 exceeds 100 columns #64: FILE: drivers/gpu/drm/i915/display/intel_display_power.c:965: + DMC_PROGRAM(dev_priv->dmc.dmc_info[DMC_FW_MAIN].start_mmioaddr, 0)), total: 0 errors, 2 warnings, 0 checks, 287 lines checked 26bb71c1dd6f drm/i915/adl_p: Pipe B DMC Support e3931c5ff892 drm/i915/adl_p: Load DMC _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 13+ messages in thread
* [Intel-gfx] ✗ Fi.CI.SPARSE: warning for Pipe DMC Support (rev8) 2021-06-13 16:13 [Intel-gfx] [CI 0/4] Pipe DMC Support Anusha Srivatsa ` (4 preceding siblings ...) 2021-06-13 16:23 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Pipe DMC Support (rev8) Patchwork @ 2021-06-13 16:24 ` Patchwork 2021-06-13 16:53 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2021-06-13 18:04 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 7 siblings, 0 replies; 13+ messages in thread From: Patchwork @ 2021-06-13 16:24 UTC (permalink / raw) To: Anusha Srivatsa; +Cc: intel-gfx == Series Details == Series: Pipe DMC Support (rev8) URL : https://patchwork.freedesktop.org/series/90445/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +drivers/gpu/drm/i915/display/intel_display.c:1893:21: expected struct i915_vma *[assigned] vma +drivers/gpu/drm/i915/display/intel_display.c:1893:21: got void [noderef] __iomem *[assigned] iomem +drivers/gpu/drm/i915/display/intel_display.c:1893:21: warning: incorrect type in assignment (different address spaces) +drivers/gpu/drm/i915/gem/i915_gem_ttm.c:564:38: warning: symbol 'i915_gem_ttm_obj_ops' was not declared. Should it be static? +drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:32:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:32:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:56:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:56:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_reset.c:1396:5: warning: context imbalance in 'intel_gt_reset_trylock' - different lock contexts for basic block +drivers/gpu/drm/i915/gt/intel_ring_submission.c:1207:24: warning: Using plain integer as NULL pointer +drivers/gpu/drm/i915/i915_perf.c:1434:15: warning: memset with byte count of 16777216 +drivers/gpu/drm/i915/i915_perf.c:1488:15: warning: memset with byte count of 16777216 +./include/asm-generic/bitops/find.h:112:45: warning: shift count is negative (-262080) +./include/asm-generic/bitops/find.h:32:31: warning: shift count is negative (-262080) +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read64' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read64' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read64' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read64' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write8' - different lock contexts for basic block _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 13+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for Pipe DMC Support (rev8) 2021-06-13 16:13 [Intel-gfx] [CI 0/4] Pipe DMC Support Anusha Srivatsa ` (5 preceding siblings ...) 2021-06-13 16:24 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork @ 2021-06-13 16:53 ` Patchwork 2021-06-13 18:04 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 7 siblings, 0 replies; 13+ messages in thread From: Patchwork @ 2021-06-13 16:53 UTC (permalink / raw) To: Anusha Srivatsa; +Cc: intel-gfx [-- Attachment #1.1: Type: text/plain, Size: 3802 bytes --] == Series Details == Series: Pipe DMC Support (rev8) URL : https://patchwork.freedesktop.org/series/90445/ State : success == Summary == CI Bug Log - changes from CI_DRM_10214 -> Patchwork_20353 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/index.html Known issues ------------ Here are the changes found in Patchwork_20353 that come from known issues: ### IGT changes ### #### Warnings #### * igt@i915_selftest@live@execlists: - fi-icl-u2: [INCOMPLETE][1] ([i915#2782] / [i915#3462]) -> [DMESG-FAIL][2] ([i915#3462]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/fi-icl-u2/igt@i915_selftest@live@execlists.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/fi-icl-u2/igt@i915_selftest@live@execlists.html * igt@runner@aborted: - fi-icl-u2: [FAIL][3] ([i915#2782] / [i915#3363]) -> [FAIL][4] ([i915#2426] / [i915#2782] / [i915#3363]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/fi-icl-u2/igt@runner@aborted.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/fi-icl-u2/igt@runner@aborted.html - fi-glk-dsi: [FAIL][5] ([i915#3363] / [k.org#202321]) -> [FAIL][6] ([i915#2426] / [i915#3363] / [k.org#202321]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/fi-glk-dsi/igt@runner@aborted.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/fi-glk-dsi/igt@runner@aborted.html - fi-kbl-guc: [FAIL][7] ([i915#1436] / [i915#3363]) -> [FAIL][8] ([i915#1436] / [i915#2426] / [i915#3363]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/fi-kbl-guc/igt@runner@aborted.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/fi-kbl-guc/igt@runner@aborted.html - fi-kbl-7567u: [FAIL][9] ([i915#1436] / [i915#2426] / [i915#3363]) -> [FAIL][10] ([i915#1436] / [i915#3363]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/fi-kbl-7567u/igt@runner@aborted.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/fi-kbl-7567u/igt@runner@aborted.html - fi-skl-6700k2: [FAIL][11] ([i915#1436] / [i915#2426] / [i915#3363]) -> [FAIL][12] ([i915#1436] / [i915#3363]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/fi-skl-6700k2/igt@runner@aborted.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/fi-skl-6700k2/igt@runner@aborted.html [i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436 [i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426 [i915#2782]: https://gitlab.freedesktop.org/drm/intel/issues/2782 [i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363 [i915#3462]: https://gitlab.freedesktop.org/drm/intel/issues/3462 [k.org#202321]: https://bugzilla.kernel.org/show_bug.cgi?id=202321 Participating hosts (43 -> 39) ------------------------------ Missing (4): fi-ilk-m540 fi-bsw-cyan fi-bdw-samus fi-hsw-4200u Build changes ------------- * Linux: CI_DRM_10214 -> Patchwork_20353 CI-20190529: 20190529 CI_DRM_10214: 2bba812cf661cf2ffa2874a30d4a2c8fcb3937cc @ git://anongit.freedesktop.org/gfx-ci/linux IGT_6104: f8f81bd3752f3126a47d9dbba2d0ab29f7c17a19 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_20353: e3931c5ff89282bfaada1ce484055600b7223938 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == e3931c5ff892 drm/i915/adl_p: Load DMC 26bb71c1dd6f drm/i915/adl_p: Pipe B DMC Support 29dfec8e2a62 drm/i915/xelpd: Pipe A DMC plugging ee2ef4cb584b drm/i915/dmc: Introduce DMC_FW_MAIN == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/index.html [-- Attachment #1.2: Type: text/html, Size: 5934 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 13+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for Pipe DMC Support (rev8) 2021-06-13 16:13 [Intel-gfx] [CI 0/4] Pipe DMC Support Anusha Srivatsa ` (6 preceding siblings ...) 2021-06-13 16:53 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork @ 2021-06-13 18:04 ` Patchwork 7 siblings, 0 replies; 13+ messages in thread From: Patchwork @ 2021-06-13 18:04 UTC (permalink / raw) To: Anusha Srivatsa; +Cc: intel-gfx [-- Attachment #1.1: Type: text/plain, Size: 30246 bytes --] == Series Details == Series: Pipe DMC Support (rev8) URL : https://patchwork.freedesktop.org/series/90445/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10214_full -> Patchwork_20353_full ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with Patchwork_20353_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_20353_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_20353_full: ### IGT changes ### #### Possible regressions #### * igt@i915_pm_dc@dc6-psr: - shard-iclb: [PASS][1] -> [DMESG-WARN][2] +1 similar issue [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-iclb1/igt@i915_pm_dc@dc6-psr.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-iclb7/igt@i915_pm_dc@dc6-psr.html * igt@kms_flip@2x-flip-vs-suspend@ab-hdmi-a1-hdmi-a2: - shard-glk: [PASS][3] -> [INCOMPLETE][4] [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-glk9/igt@kms_flip@2x-flip-vs-suspend@ab-hdmi-a1-hdmi-a2.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-glk7/igt@kms_flip@2x-flip-vs-suspend@ab-hdmi-a1-hdmi-a2.html #### Warnings #### * igt@runner@aborted: - shard-iclb: ([FAIL][5], [FAIL][6], [FAIL][7]) ([i915#2782] / [i915#3002]) -> ([FAIL][8], [FAIL][9], [FAIL][10], [FAIL][11], [FAIL][12]) ([i915#1814] / [i915#2782] / [i915#3002]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-iclb6/igt@runner@aborted.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-iclb6/igt@runner@aborted.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-iclb7/igt@runner@aborted.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-iclb7/igt@runner@aborted.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-iclb4/igt@runner@aborted.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-iclb2/igt@runner@aborted.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-iclb4/igt@runner@aborted.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-iclb5/igt@runner@aborted.html Known issues ------------ Here are the changes found in Patchwork_20353_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_create@create-massive: - shard-snb: NOTRUN -> [DMESG-WARN][13] ([i915#3002]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-snb7/igt@gem_create@create-massive.html * igt@gem_ctx_persistence@legacy-engines-hang@blt: - shard-skl: NOTRUN -> [SKIP][14] ([fdo#109271]) +100 similar issues [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-skl5/igt@gem_ctx_persistence@legacy-engines-hang@blt.html * igt@gem_ctx_persistence@legacy-engines-queued: - shard-snb: NOTRUN -> [SKIP][15] ([fdo#109271] / [i915#1099]) +5 similar issues [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-snb7/igt@gem_ctx_persistence@legacy-engines-queued.html * igt@gem_ctx_persistence@many-contexts: - shard-tglb: [PASS][16] -> [FAIL][17] ([i915#2410]) [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-tglb3/igt@gem_ctx_persistence@many-contexts.html [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-tglb3/igt@gem_ctx_persistence@many-contexts.html * igt@gem_eio@unwedge-stress: - shard-iclb: [PASS][18] -> [TIMEOUT][19] ([i915#2369] / [i915#2481] / [i915#3070]) [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-iclb5/igt@gem_eio@unwedge-stress.html [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-iclb1/igt@gem_eio@unwedge-stress.html * igt@gem_exec_fair@basic-none@vcs1: - shard-iclb: NOTRUN -> [FAIL][20] ([i915#2842]) [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-iclb1/igt@gem_exec_fair@basic-none@vcs1.html * igt@gem_exec_fair@basic-throttle@rcs0: - shard-iclb: [PASS][21] -> [FAIL][22] ([i915#2849]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-iclb7/igt@gem_exec_fair@basic-throttle@rcs0.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-iclb6/igt@gem_exec_fair@basic-throttle@rcs0.html * igt@gem_exec_reloc@basic-wide-active@bcs0: - shard-apl: NOTRUN -> [FAIL][23] ([i915#2389]) +3 similar issues [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-apl1/igt@gem_exec_reloc@basic-wide-active@bcs0.html * igt@gem_huc_copy@huc-copy: - shard-tglb: [PASS][24] -> [SKIP][25] ([i915#2190]) [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-tglb7/igt@gem_huc_copy@huc-copy.html [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-tglb6/igt@gem_huc_copy@huc-copy.html * igt@gem_mmap_gtt@cpuset-medium-copy-odd: - shard-iclb: [PASS][26] -> [FAIL][27] ([i915#307]) [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-iclb4/igt@gem_mmap_gtt@cpuset-medium-copy-odd.html [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-iclb6/igt@gem_mmap_gtt@cpuset-medium-copy-odd.html * igt@gem_pwrite@basic-exhaustion: - shard-apl: NOTRUN -> [WARN][28] ([i915#2658]) [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-apl1/igt@gem_pwrite@basic-exhaustion.html * igt@gem_softpin@noreloc-s3: - shard-apl: [PASS][29] -> [DMESG-WARN][30] ([i915#180]) [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-apl2/igt@gem_softpin@noreloc-s3.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-apl2/igt@gem_softpin@noreloc-s3.html * igt@gem_userptr_blits@vma-merge: - shard-snb: NOTRUN -> [FAIL][31] ([i915#2724]) [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-snb7/igt@gem_userptr_blits@vma-merge.html - shard-kbl: NOTRUN -> [FAIL][32] ([i915#3318]) [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-kbl3/igt@gem_userptr_blits@vma-merge.html * igt@gen9_exec_parse@batch-invalid-length: - shard-snb: NOTRUN -> [SKIP][33] ([fdo#109271]) +322 similar issues [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-snb7/igt@gen9_exec_parse@batch-invalid-length.html * igt@i915_pm_dc@dc6-psr: - shard-skl: [PASS][34] -> [FAIL][35] ([i915#454]) [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-skl5/igt@i915_pm_dc@dc6-psr.html [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-skl3/igt@i915_pm_dc@dc6-psr.html * igt@i915_pm_dc@dc9-dpms: - shard-apl: NOTRUN -> [FAIL][36] ([i915#3343]) [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-apl7/igt@i915_pm_dc@dc9-dpms.html * igt@i915_pm_rpm@system-suspend: - shard-skl: NOTRUN -> [INCOMPLETE][37] ([i915#151]) [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-skl7/igt@i915_pm_rpm@system-suspend.html * igt@kms_async_flips@alternate-sync-async-flip: - shard-skl: [PASS][38] -> [FAIL][39] ([i915#2521]) [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-skl6/igt@kms_async_flips@alternate-sync-async-flip.html [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-skl1/igt@kms_async_flips@alternate-sync-async-flip.html * igt@kms_chamelium@dp-crc-multiple: - shard-skl: NOTRUN -> [SKIP][40] ([fdo#109271] / [fdo#111827]) +12 similar issues [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-skl7/igt@kms_chamelium@dp-crc-multiple.html * igt@kms_chamelium@hdmi-edid-change-during-suspend: - shard-apl: NOTRUN -> [SKIP][41] ([fdo#109271] / [fdo#111827]) +18 similar issues [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-apl1/igt@kms_chamelium@hdmi-edid-change-during-suspend.html * igt@kms_color@pipe-c-ctm-0-5: - shard-skl: [PASS][42] -> [DMESG-WARN][43] ([i915#1982]) [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-skl4/igt@kms_color@pipe-c-ctm-0-5.html [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-skl5/igt@kms_color@pipe-c-ctm-0-5.html * igt@kms_color_chamelium@pipe-b-ctm-0-25: - shard-snb: NOTRUN -> [SKIP][44] ([fdo#109271] / [fdo#111827]) +18 similar issues [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-snb7/igt@kms_color_chamelium@pipe-b-ctm-0-25.html * igt@kms_color_chamelium@pipe-b-degamma: - shard-kbl: NOTRUN -> [SKIP][45] ([fdo#109271] / [fdo#111827]) +2 similar issues [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-kbl6/igt@kms_color_chamelium@pipe-b-degamma.html * igt@kms_content_protection@atomic-dpms: - shard-apl: NOTRUN -> [TIMEOUT][46] ([i915#1319]) +1 similar issue [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-apl1/igt@kms_content_protection@atomic-dpms.html * igt@kms_draw_crc@draw-method-rgb565-blt-ytiled: - shard-skl: [PASS][47] -> [FAIL][48] ([i915#3451]) +1 similar issue [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-skl3/igt@kms_draw_crc@draw-method-rgb565-blt-ytiled.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-skl7/igt@kms_draw_crc@draw-method-rgb565-blt-ytiled.html * igt@kms_draw_crc@draw-method-rgb565-mmap-wc-untiled: - shard-glk: [PASS][49] -> [FAIL][50] ([i915#3451]) [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-glk3/igt@kms_draw_crc@draw-method-rgb565-mmap-wc-untiled.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-glk4/igt@kms_draw_crc@draw-method-rgb565-mmap-wc-untiled.html * igt@kms_flip@flip-vs-suspend-interruptible@c-dp1: - shard-apl: NOTRUN -> [DMESG-WARN][51] ([i915#180]) [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-apl3/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html * igt@kms_flip@plain-flip-ts-check@b-edp1: - shard-skl: [PASS][52] -> [FAIL][53] ([i915#2122]) [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-skl9/igt@kms_flip@plain-flip-ts-check@b-edp1.html [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-skl6/igt@kms_flip@plain-flip-ts-check@b-edp1.html * igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs: - shard-apl: NOTRUN -> [SKIP][54] ([fdo#109271] / [i915#2672]) [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-apl1/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html * igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs: - shard-skl: NOTRUN -> [SKIP][55] ([fdo#109271] / [i915#2672]) [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-skl5/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs.html * igt@kms_frontbuffer_tracking@fbc-rgb565-draw-mmap-gtt: - shard-snb: [PASS][56] -> [SKIP][57] ([fdo#109271]) [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-snb5/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-mmap-gtt.html [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-snb2/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-mmap-gtt.html * igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-shrfb-draw-mmap-wc: - shard-kbl: NOTRUN -> [SKIP][58] ([fdo#109271]) +45 similar issues [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-kbl3/igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-shrfb-draw-mmap-wc.html * igt@kms_hdr@bpc-switch-dpms: - shard-skl: [PASS][59] -> [FAIL][60] ([i915#1188]) [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-skl4/igt@kms_hdr@bpc-switch-dpms.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-skl5/igt@kms_hdr@bpc-switch-dpms.html * igt@kms_hdr@bpc-switch-suspend: - shard-skl: NOTRUN -> [FAIL][61] ([i915#1188]) [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-skl5/igt@kms_hdr@bpc-switch-suspend.html * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a: - shard-kbl: [PASS][62] -> [DMESG-WARN][63] ([i915#180]) +8 similar issues [62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-kbl2/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-kbl7/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html * igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb: - shard-apl: NOTRUN -> [FAIL][64] ([i915#265]) [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-apl1/igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb.html * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max: - shard-skl: NOTRUN -> [FAIL][65] ([fdo#108145] / [i915#265]) [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-skl2/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max.html * igt@kms_plane_alpha_blend@pipe-c-alpha-basic: - shard-apl: NOTRUN -> [FAIL][66] ([fdo#108145] / [i915#265]) [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-apl1/igt@kms_plane_alpha_blend@pipe-c-alpha-basic.html * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc: - shard-skl: [PASS][67] -> [FAIL][68] ([fdo#108145] / [i915#265]) +2 similar issues [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-skl6/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-skl1/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4: - shard-apl: NOTRUN -> [SKIP][69] ([fdo#109271] / [i915#658]) +3 similar issues [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-apl3/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4.html * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1: - shard-kbl: NOTRUN -> [SKIP][70] ([fdo#109271] / [i915#658]) [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-kbl3/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1.html * igt@kms_psr2_su@frontbuffer: - shard-skl: NOTRUN -> [SKIP][71] ([fdo#109271] / [i915#658]) [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-skl2/igt@kms_psr2_su@frontbuffer.html * igt@kms_psr@psr2_dpms: - shard-iclb: [PASS][72] -> [SKIP][73] ([fdo#109441]) +1 similar issue [72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-iclb2/igt@kms_psr@psr2_dpms.html [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-iclb4/igt@kms_psr@psr2_dpms.html * igt@kms_vblank@pipe-a-ts-continuation-suspend: - shard-kbl: [PASS][74] -> [DMESG-WARN][75] ([i915#180] / [i915#295]) [74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-kbl2/igt@kms_vblank@pipe-a-ts-continuation-suspend.html [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-kbl4/igt@kms_vblank@pipe-a-ts-continuation-suspend.html * igt@kms_vblank@pipe-d-wait-forked-hang: - shard-apl: NOTRUN -> [SKIP][76] ([fdo#109271]) +206 similar issues [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-apl1/igt@kms_vblank@pipe-d-wait-forked-hang.html * igt@kms_vblank@pipe-d-wait-idle: - shard-apl: NOTRUN -> [SKIP][77] ([fdo#109271] / [i915#533]) +2 similar issues [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-apl1/igt@kms_vblank@pipe-d-wait-idle.html * igt@kms_writeback@writeback-pixel-formats: - shard-apl: NOTRUN -> [SKIP][78] ([fdo#109271] / [i915#2437]) [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-apl1/igt@kms_writeback@writeback-pixel-formats.html * igt@perf@polling-small-buf: - shard-skl: [PASS][79] -> [FAIL][80] ([i915#1722]) [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-skl6/igt@perf@polling-small-buf.html [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-skl9/igt@perf@polling-small-buf.html * igt@sysfs_clients@fair-7: - shard-apl: NOTRUN -> [SKIP][81] ([fdo#109271] / [i915#2994]) +3 similar issues [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-apl1/igt@sysfs_clients@fair-7.html * igt@sysfs_clients@recycle-many: - shard-skl: NOTRUN -> [SKIP][82] ([fdo#109271] / [i915#2994]) +1 similar issue [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-skl7/igt@sysfs_clients@recycle-many.html #### Possible fixes #### * igt@gem_ctx_isolation@preservation-s3@bcs0: - shard-apl: [DMESG-WARN][83] ([i915#180]) -> [PASS][84] +1 similar issue [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-apl7/igt@gem_ctx_isolation@preservation-s3@bcs0.html [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-apl3/igt@gem_ctx_isolation@preservation-s3@bcs0.html * igt@gem_exec_fair@basic-flow@rcs0: - shard-tglb: [FAIL][85] ([i915#2842]) -> [PASS][86] +1 similar issue [85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-tglb2/igt@gem_exec_fair@basic-flow@rcs0.html [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-tglb7/igt@gem_exec_fair@basic-flow@rcs0.html * igt@gem_exec_fair@basic-none-share@rcs0: - shard-iclb: [FAIL][87] ([i915#2842]) -> [PASS][88] [87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-iclb7/igt@gem_exec_fair@basic-none-share@rcs0.html [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-iclb7/igt@gem_exec_fair@basic-none-share@rcs0.html * igt@gem_exec_fair@basic-throttle@rcs0: - shard-glk: [FAIL][89] ([i915#2842]) -> [PASS][90] +1 similar issue [89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-glk6/igt@gem_exec_fair@basic-throttle@rcs0.html [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-glk2/igt@gem_exec_fair@basic-throttle@rcs0.html * igt@gem_exec_whisper@basic-fds-forked: - shard-glk: [DMESG-WARN][91] ([i915#118] / [i915#95]) -> [PASS][92] [91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-glk6/igt@gem_exec_whisper@basic-fds-forked.html [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-glk4/igt@gem_exec_whisper@basic-fds-forked.html * igt@gem_mmap_gtt@cpuset-big-copy-xy: - shard-iclb: [FAIL][93] ([i915#307]) -> [PASS][94] [93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-iclb4/igt@gem_mmap_gtt@cpuset-big-copy-xy.html [94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-iclb2/igt@gem_mmap_gtt@cpuset-big-copy-xy.html * igt@gem_mmap_gtt@cpuset-medium-copy-xy: - shard-glk: [FAIL][95] ([i915#307]) -> [PASS][96] [95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-glk7/igt@gem_mmap_gtt@cpuset-medium-copy-xy.html [96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-glk5/igt@gem_mmap_gtt@cpuset-medium-copy-xy.html * igt@i915_selftest@live@hangcheck: - shard-snb: [INCOMPLETE][97] ([i915#2782]) -> [PASS][98] [97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-snb7/igt@i915_selftest@live@hangcheck.html [98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-snb2/igt@i915_selftest@live@hangcheck.html * igt@kms_color@pipe-c-ctm-negative: - shard-skl: [DMESG-WARN][99] ([i915#1982]) -> [PASS][100] [99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-skl3/igt@kms_color@pipe-c-ctm-negative.html [100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-skl7/igt@kms_color@pipe-c-ctm-negative.html * igt@kms_cursor_crc@pipe-a-cursor-suspend: - shard-kbl: [DMESG-WARN][101] ([i915#180]) -> [PASS][102] +5 similar issues [101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-kbl7/igt@kms_cursor_crc@pipe-a-cursor-suspend.html [102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-kbl6/igt@kms_cursor_crc@pipe-a-cursor-suspend.html * igt@kms_cursor_crc@pipe-c-cursor-64x64-onscreen: - shard-glk: [FAIL][103] ([i915#3444]) -> [PASS][104] [103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-glk5/igt@kms_cursor_crc@pipe-c-cursor-64x64-onscreen.html [104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-glk9/igt@kms_cursor_crc@pipe-c-cursor-64x64-onscreen.html * igt@kms_flip@plain-flip-fb-recreate-interruptible@a-edp1: - shard-skl: [FAIL][105] ([i915#2122]) -> [PASS][106] [105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-skl6/igt@kms_flip@plain-flip-fb-recreate-interruptible@a-edp1.html [106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-skl1/igt@kms_flip@plain-flip-fb-recreate-interruptible@a-edp1.html * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-indfb-plflip-blt: - shard-glk: [FAIL][107] ([i915#49]) -> [PASS][108] [107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-glk1/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-indfb-plflip-blt.html [108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-glk8/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-indfb-plflip-blt.html * igt@kms_psr@psr2_cursor_render: - shard-iclb: [SKIP][109] ([fdo#109441]) -> [PASS][110] [109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-iclb1/igt@kms_psr@psr2_cursor_render.html [110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-iclb2/igt@kms_psr@psr2_cursor_render.html * igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend: - shard-kbl: [INCOMPLETE][111] ([i915#155]) -> [PASS][112] [111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-kbl4/igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend.html [112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-kbl1/igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend.html * igt@kms_vblank@pipe-b-ts-continuation-suspend: - shard-skl: [INCOMPLETE][113] ([i915#198] / [i915#2828]) -> [PASS][114] [113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-skl4/igt@kms_vblank@pipe-b-ts-continuation-suspend.html [114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-skl2/igt@kms_vblank@pipe-b-ts-continuation-suspend.html #### Warnings #### * igt@i915_pm_dc@dc3co-vpb-simulation: - shard-iclb: [SKIP][115] ([i915#588]) -> [SKIP][116] ([i915#658]) [115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-iclb2/igt@i915_pm_dc@dc3co-vpb-simulation.html [116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-iclb4/igt@i915_pm_dc@dc3co-vpb-simulation.html * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1: - shard-iclb: [SKIP][117] ([i915#658]) -> [SKIP][118] ([i915#2920]) +4 similar issues [117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-iclb8/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1.html [118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1.html * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2: - shard-iclb: [SKIP][119] ([i915#2920]) -> [SKIP][120] ([i915#658]) [119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2.html [120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-iclb7/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2.html * igt@runner@aborted: - shard-kbl: ([FAIL][121], [FAIL][122], [FAIL][123], [FAIL][124], [FAIL][125], [FAIL][126], [FAIL][127], [FAIL][128]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#3002] / [i915#3363]) -> ([FAIL][129], [FAIL][130], [FAIL][131], [FAIL][132], [FAIL][133], [FAIL][134], [FAIL][135], [FAIL][136], [FAIL][137], [FAIL][138], [FAIL][139]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#2292] / [i915#3002] / [i915#3363] / [i915#602]) [121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-kbl4/igt@runner@aborted.html [122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-kbl4/igt@runner@aborted.html [123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-kbl3/igt@runner@aborted.html [124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-kbl4/igt@runner@aborted.html [125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-kbl4/igt@runner@aborted.html [126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-kbl3/igt@runner@aborted.html [127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-kbl7/igt@runner@aborted.html [128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-kbl1/igt@runner@aborted.html [129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-kbl2/igt@runner@aborted.html [130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-kbl7/igt@runner@aborted.html [131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-kbl1/igt@runner@aborted.html [132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-kbl3/igt@runner@aborted.html [133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-kbl4/igt@runner@aborted.html [134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-kbl4/igt@runner@aborted.html [135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-kbl4/igt@runner@aborted.html [136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-kbl2/igt@runner@aborted.html [137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-kbl2/igt@runner@aborted.html [138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-kbl2/igt@runner@aborted.html [139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-kbl2/igt@runner@aborted.html - shard-apl: ([FAIL][140], [FAIL][141], [FAIL][142], [FAIL][143], [FAIL][144], [FAIL][145]) ([fdo#109271] / [i915#180] / [i915#1814] / [i915#3002] / [i915#3363]) -> ([FAIL][146], [FAIL][147], [FAIL][148], [FAIL][149]) ([fdo#109271] / [i915#180] / [i915#3002] / [i915#3363]) [140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-apl1/igt@runner@aborted.html [141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-apl8/igt@runner@aborted.html [142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-apl6/igt@runner@aborted.html [143]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-apl8/igt@runner@aborted.html [144]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-apl7/igt@runner@aborted.html [145]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-apl1/igt@runner@aborted.html [146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-apl3/igt@runner@aborted.html [147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-apl8/igt@runner@aborted.html [148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-apl2/igt@runner@aborted.html [149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-apl3/igt@runner@aborted.html - shard-snb: [FAIL][150] ([i915#3002] / [i915#698]) -> [FAIL][151] ([i915#3002]) [150]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-snb7/igt@runner@aborted.html [151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-snb7/igt@runner@aborted.html - shard-skl: ([FAIL][152], [FAIL][153]) ([i915#3002] / [i915#3363]) -> ([FAIL][154], [FAIL][155], [FAIL][156]) ([i915#1436] / [i915#3002] / [i915#3363]) [152]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-skl4/igt@runner@aborted.html [153]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10214/shard-skl6/igt@runner@aborted.html [154]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-skl9/igt@runner@aborted.html [155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-skl4/igt@runner@aborted.html [156]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/shard-skl5/igt@runner@aborted.html [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099 [i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118 [i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188 [i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319 [i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436 [i915#151]: https://gitlab.freedesktop.org/drm/intel/issues/151 [i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155 [i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814 [i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#2 == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20353/index.html [-- Attachment #1.2: Type: text/html, Size: 35988 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 13+ messages in thread
* [Intel-gfx] [CI 0/4] Pipe DMC Support @ 2021-06-11 19:43 Anusha Srivatsa 0 siblings, 0 replies; 13+ messages in thread From: Anusha Srivatsa @ 2021-06-11 19:43 UTC (permalink / raw) To: intel-gfx One change from previous verison is a fix of SKL regression. Corner cases for stepping-substepping combination was missing from fw_info_matches_stepping() helper. Luckily SKL was the only platform in CI that came under this category and DMC refused to load. v2: SKL fix tested on SKL. v3: Minor changes in Pipe DMC plugging patch as suggested by Lucas v4: Remove the sanity check for MMIO that no longer apply to newer platforms.(Anusha) Anusha Srivatsa (4): drm/i915/dmc: Introduce DMC_FW_MAIN drm/i915/xelpd: Pipe A DMC plugging drm/i915/adl_p: Pipe B DMC Support drm/i915/adl_p: Load DMC .../drm/i915/display/intel_display_debugfs.c | 6 +- .../drm/i915/display/intel_display_power.c | 5 +- drivers/gpu/drm/i915/display/intel_dmc.c | 165 ++++++++++-------- drivers/gpu/drm/i915/display/intel_dmc.h | 23 ++- drivers/gpu/drm/i915/i915_reg.h | 2 +- 5 files changed, 123 insertions(+), 78 deletions(-) -- 2.25.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 13+ messages in thread
* [Intel-gfx] [CI 0/4] Pipe DMC Support @ 2021-06-10 19:13 Anusha Srivatsa 0 siblings, 0 replies; 13+ messages in thread From: Anusha Srivatsa @ 2021-06-10 19:13 UTC (permalink / raw) To: intel-gfx With all DMC cleanup patches merged, sending the rebased version of actual Pipe DMC bits. One change from previous verison is a fix of SKL regression. Corner cases for stepping-substepping combination was missing from fw_info_matches_stepping() helper. Luckily SKL was the only platform in CI that came under this category and DMC refused to load. v2: SKL fix tested on SKL. v3: Minor changes in Pipe DMC plugging patch as suggested by Lucas Anusha Srivatsa (4): drm/i915/dmc: Introduce DMC_FW_MAIN drm/i915/xelpd: Pipe A DMC plugging drm/i915/adl_p: Pipe B DMC Support drm/i915/adl_p: Load DMC .../drm/i915/display/intel_display_debugfs.c | 6 +- .../drm/i915/display/intel_display_power.c | 5 +- drivers/gpu/drm/i915/display/intel_dmc.c | 162 +++++++++++------- drivers/gpu/drm/i915/display/intel_dmc.h | 23 ++- drivers/gpu/drm/i915/i915_reg.h | 2 +- 5 files changed, 124 insertions(+), 74 deletions(-) -- 2.25.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 13+ messages in thread
* [Intel-gfx] [CI 0/4] Pipe DMC Support @ 2021-06-04 19:01 Anusha Srivatsa 0 siblings, 0 replies; 13+ messages in thread From: Anusha Srivatsa @ 2021-06-04 19:01 UTC (permalink / raw) To: intel-gfx With all DMC cleanup patches merged, sending the rebased version of actual Pipe DMC bits. One change from previous verison is a fix of SKL regression. Corner cases for stepping-substepping combination was missing from fw_info_matches_stepping() helper. Luckily SKL was the only platform in CI that came under this category and DMC refused to load. This fix is tested on SKL. Anusha Srivatsa (4): drm/i915/dmc: Introduce DMC_FW_MAIN xdrm/i915/xelpd: Pipe A DMC plugging drm/i915/adl_p: Pipe B DMC Support drm/i915/adl_p: Load DMC .../drm/i915/display/intel_display_debugfs.c | 6 +- .../drm/i915/display/intel_display_power.c | 5 +- drivers/gpu/drm/i915/display/intel_dmc.c | 170 ++++++++++-------- drivers/gpu/drm/i915/display/intel_dmc.h | 23 ++- drivers/gpu/drm/i915/i915_reg.h | 2 +- 5 files changed, 127 insertions(+), 79 deletions(-) -- 2.25.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 13+ messages in thread
* [Intel-gfx] [CI 0/4] Pipe DMC Support @ 2021-06-04 18:58 Anusha Srivatsa 0 siblings, 0 replies; 13+ messages in thread From: Anusha Srivatsa @ 2021-06-04 18:58 UTC (permalink / raw) To: intel-gfx With all DMC cleanup patches merged, sending the rebased version of actual Pipe DMC bits. One change from previous verison is a fix of SKL regression. Corner cases for stepping-substepping combination was missing from fw_info_matches_stepping() helper. Luckily SKL was the only platform in CI that came under this category and DMC refused to load. This fix is tested on SKL. Anusha Srivatsa (4): drm/i915/dmc: Introduce DMC_FW_MAIN xdrm/i915/xelpd: Pipe A DMC plugging drm/i915/adl_p: Pipe B DMC Support drm/i915/adl_p: Load DMC .../drm/i915/display/intel_display_debugfs.c | 6 +- .../drm/i915/display/intel_display_power.c | 5 +- drivers/gpu/drm/i915/display/intel_dmc.c | 170 ++++++++++-------- drivers/gpu/drm/i915/display/intel_dmc.h | 23 ++- drivers/gpu/drm/i915/i915_reg.h | 2 +- 5 files changed, 127 insertions(+), 79 deletions(-) -- 2.25.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2021-06-13 18:04 UTC | newest] Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-06-13 16:13 [Intel-gfx] [CI 0/4] Pipe DMC Support Anusha Srivatsa 2021-06-13 16:14 ` [Intel-gfx] [CI 1/4] drm/i915/dmc: Introduce DMC_FW_MAIN Anusha Srivatsa 2021-06-13 16:14 ` [Intel-gfx] [CI 2/4] drm/i915/xelpd: Pipe A DMC plugging Anusha Srivatsa 2021-06-13 16:14 ` [Intel-gfx] [CI 3/4] drm/i915/adl_p: Pipe B DMC Support Anusha Srivatsa 2021-06-13 16:14 ` [Intel-gfx] [CI 4/4] drm/i915/adl_p: Load DMC Anusha Srivatsa 2021-06-13 16:23 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Pipe DMC Support (rev8) Patchwork 2021-06-13 16:24 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork 2021-06-13 16:53 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2021-06-13 18:04 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork -- strict thread matches above, loose matches on Subject: below -- 2021-06-11 19:43 [Intel-gfx] [CI 0/4] Pipe DMC Support Anusha Srivatsa 2021-06-10 19:13 Anusha Srivatsa 2021-06-04 19:01 Anusha Srivatsa 2021-06-04 18:58 Anusha Srivatsa
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.