From: Mark Brown <broonie@kernel.org>
To: Claudius Heine <ch@denx.de>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, Marek Vasut <marex@denx.de>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Sia Jee Heng <jee.heng.sia@intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Michael Sit Wei Hong <michael.wei.hong.sit@intel.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Annaliese McDermond <nh6z@nh6z.net>,
Matthias Schiffer <matthias.schiffer@ew.tq-group.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] ASoC: tlv320aic32x4: prepare driver for different device variants
Date: Tue, 15 Jun 2021 13:30:08 +0100 [thread overview]
Message-ID: <20210615123008.GF5149@sirena.org.uk> (raw)
In-Reply-To: <32b82dae-45ea-c6d4-77b7-c8a234cbf803@denx.de>
[-- Attachment #1: Type: text/plain, Size: 790 bytes --]
On Tue, Jun 15, 2021 at 02:06:30PM +0200, Claudius Heine wrote:
> On 2021-06-15 13:54, Mark Brown wrote:
> > On Tue, Jun 15, 2021 at 11:49:30AM +0200, Claudius Heine wrote:
> > > With this change it will be possible to add different code paths for
> > > similar devices.
> > > - { "tlv320aic32x4", 0 },
> > > - { "tlv320aic32x6", 1 },
> > > + { "tlv320aic32x4", (kernel_ulong_t)AIC32X4_TYPE_AIC32X4 },
> > > + { "tlv320aic32x6", (kernel_ulong_t)AIC32X4_TYPE_AIC32X6 },
> > > { /* sentinel */ }
> > It appears that the device already supports multiple variants?
> Those values aren't used anywhere as far as I can see.
The point here is that you need a better changelog, the driver clearly
already supports multiple devices so we need a few more words to explain
what this is doing.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Claudius Heine <ch@denx.de>
Cc: Marek Vasut <marex@denx.de>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
alsa-devel@alsa-project.org,
Matthias Schiffer <matthias.schiffer@ew.tq-group.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
open list <linux-kernel@vger.kernel.org>,
Takashi Iwai <tiwai@suse.com>,
Sia Jee Heng <jee.heng.sia@intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Annaliese McDermond <nh6z@nh6z.net>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Michael Sit Wei Hong <michael.wei.hong.sit@intel.com>
Subject: Re: [PATCH 1/3] ASoC: tlv320aic32x4: prepare driver for different device variants
Date: Tue, 15 Jun 2021 13:30:08 +0100 [thread overview]
Message-ID: <20210615123008.GF5149@sirena.org.uk> (raw)
In-Reply-To: <32b82dae-45ea-c6d4-77b7-c8a234cbf803@denx.de>
[-- Attachment #1: Type: text/plain, Size: 790 bytes --]
On Tue, Jun 15, 2021 at 02:06:30PM +0200, Claudius Heine wrote:
> On 2021-06-15 13:54, Mark Brown wrote:
> > On Tue, Jun 15, 2021 at 11:49:30AM +0200, Claudius Heine wrote:
> > > With this change it will be possible to add different code paths for
> > > similar devices.
> > > - { "tlv320aic32x4", 0 },
> > > - { "tlv320aic32x6", 1 },
> > > + { "tlv320aic32x4", (kernel_ulong_t)AIC32X4_TYPE_AIC32X4 },
> > > + { "tlv320aic32x6", (kernel_ulong_t)AIC32X4_TYPE_AIC32X6 },
> > > { /* sentinel */ }
> > It appears that the device already supports multiple variants?
> Those values aren't used anywhere as far as I can see.
The point here is that you need a better changelog, the driver clearly
already supports multiple devices so we need a few more words to explain
what this is doing.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-06-15 12:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 9:49 [PATCH 0/3] ASoC: tlv320aic32x4: Add support for TAS2505 Claudius Heine
2021-06-15 9:49 ` [PATCH 1/3] ASoC: tlv320aic32x4: prepare driver for different device variants Claudius Heine
2021-06-15 11:54 ` Mark Brown
2021-06-15 11:54 ` Mark Brown
2021-06-15 12:06 ` Claudius Heine
2021-06-15 12:06 ` Claudius Heine
2021-06-15 12:30 ` Mark Brown [this message]
2021-06-15 12:30 ` Mark Brown
2021-06-15 9:49 ` [PATCH 2/3] ASoC: tlv320aic32x4: add support for TAS2505 Claudius Heine
2021-06-15 11:59 ` Claudius Heine
2021-06-15 12:22 ` Mark Brown
2021-06-15 12:22 ` Mark Brown
2021-06-15 12:39 ` Claudius Heine
2021-06-15 12:39 ` Claudius Heine
2021-06-15 9:49 ` [PATCH 3/3] ASoC: tlv320aic32x4: dt-bindings: add TAS2505 to compatible Claudius Heine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210615123008.GF5149@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=ch@denx.de \
--cc=jee.heng.sia@intel.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=matthias.schiffer@ew.tq-group.com \
--cc=michael.wei.hong.sit@intel.com \
--cc=miquel.raynal@bootlin.com \
--cc=nh6z@nh6z.net \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.