All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anson Jacob <Anson.Jacob@amd.com>
To: igt-dev@lists.freedesktop.org
Cc: Petri Latvala <petri.latvala@intel.com>,
	Anson Jacob <Anson.Jacob@amd.com>,
	Victor Lu <victorchengchi.lu@amd.com>,
	Mark Yacoub <markyacoub@google.com>
Subject: [igt-dev] [PATCH i-g-t 1/4] lib/igt_kms: Fix test_init() crash when <6 pipes
Date: Fri, 18 Jun 2021 10:28:52 -0400	[thread overview]
Message-ID: <20210618142855.5750-2-Anson.Jacob@amd.com> (raw)
In-Reply-To: <20210618142855.5750-1-Anson.Jacob@amd.com>

From: Victor Lu <victorchengchi.lu@amd.com>

[why & how]
An upstream change is causing the common amdgpu test_init() to crash on
ASICs with <6 pipes.

Signed-off-by: Victor Lu <victorchengchi.lu@amd.com>
Acked-by: Anson Jacob <Anson.Jacob@amd.com>
Cc: Petri Latvala <petri.latvala@intel.com>
Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Cc: Harry Wentland <harry.wentland@amd.com>
Cc: Mark Yacoub <markyacoub@google.com>
---
 lib/igt_kms.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index c7c69b6ea0eb..26c51a384918 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -2164,8 +2164,8 @@ void igt_display_require(igt_display_t *display, int drm_fd)
 	 * pipe display and reading pipe enum for a crtc using GET_PIPE_FROM_CRTC_ID ioctl
 	 * for a pipe to do pipe ordering with respect to crtc list.
 	 */
-	display->n_pipes = IGT_MAX_PIPES;
-	display->pipes = calloc(sizeof(igt_pipe_t), display->n_pipes);
+	display->n_pipes = resources->count_crtcs;
+	display->pipes = calloc(sizeof(igt_pipe_t), IGT_MAX_PIPES);
 	igt_assert_f(display->pipes, "Failed to allocate memory for %d pipes\n", display->n_pipes);
 
 	for (i = 0; i < resources->count_crtcs; i++) {
-- 
2.25.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2021-06-18 14:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-18 14:28 [igt-dev] [PATCH i-g-t 0/4] IGT Patches Jun 18, 2021 Anson Jacob
2021-06-18 14:28 ` Anson Jacob [this message]
2021-06-21  8:41   ` [igt-dev] [PATCH i-g-t 1/4] lib/igt_kms: Fix test_init() crash when <6 pipes Petri Latvala
2021-06-18 14:28 ` [igt-dev] [PATCH i-g-t 2/4] tests/kms_content_protection: Enable Primary plane for CRTC Anson Jacob
2021-06-18 14:28 ` [igt-dev] [PATCH i-g-t 3/4] tests/kms_plane_multiple: Start continuous CRC capture after commit Anson Jacob
2021-06-18 14:28 ` [igt-dev] [PATCH i-g-t 4/4] tests/kms_plane_multiple: Disable CRTC if no planes Anson Jacob
2021-06-18 16:45   ` Mark Yacoub
2021-06-18 15:24 ` [igt-dev] ✓ Fi.CI.BAT: success for IGT Patches Jun 18, 2021 Patchwork
2021-06-18 17:06 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210618142855.5750-2-Anson.Jacob@amd.com \
    --to=anson.jacob@amd.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=markyacoub@google.com \
    --cc=petri.latvala@intel.com \
    --cc=victorchengchi.lu@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.