All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anson Jacob <Anson.Jacob@amd.com>
To: igt-dev@lists.freedesktop.org
Cc: Petri Latvala <petri.latvala@intel.com>,
	Anson Jacob <Anson.Jacob@amd.com>,
	Victor Lu <victorchengchi.lu@amd.com>,
	Mark Yacoub <markyacoub@google.com>
Subject: [igt-dev] [PATCH i-g-t 4/4] tests/kms_plane_multiple: Disable CRTC if no planes
Date: Fri, 18 Jun 2021 10:28:55 -0400	[thread overview]
Message-ID: <20210618142855.5750-5-Anson.Jacob@amd.com> (raw)
In-Reply-To: <20210618142855.5750-1-Anson.Jacob@amd.com>

From: Victor Lu <victorchengchi.lu@amd.com>

[why]
amdgpu will reject commits where the CRTC is enabled and there are no
active planes.

[how]
Disable the CRTC when committing with no active planes.

Signed-off-by: Victor Lu <victorchengchi.lu@amd.com>
Acked-by: Anson Jacob <Anson.Jacob@amd.com>
Cc: Petri Latvala <petri.latvala@intel.com>
Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Cc: Harry Wentland <harry.wentland@amd.com>
Cc: Mark Yacoub <markyacoub@google.com>
---
 tests/kms_plane_multiple.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tests/kms_plane_multiple.c b/tests/kms_plane_multiple.c
index 4424b864b2d6..805c2a2130d7 100644
--- a/tests/kms_plane_multiple.c
+++ b/tests/kms_plane_multiple.c
@@ -315,6 +315,8 @@ test_plane_position_with_output(data_t *data, enum pipe pipe,
 		for_each_plane_on_pipe(&data->display, pipe, plane)
 			igt_plane_set_fb(plane, NULL);
 
+		/* Disable CRTC if no active planes */
+		igt_output_set_pipe(output, PIPE_NONE);
 		igt_display_commit2(&data->display, COMMIT_ATOMIC);
 
 		for (int x = 0; x < c; x++)
@@ -344,6 +346,8 @@ test_plane_position_with_output(data_t *data, enum pipe pipe,
 		for_each_plane_on_pipe(&data->display, pipe, plane)
 			igt_plane_set_fb(plane, NULL);
 
+		/* Disable CRTC if no active planes */
+		igt_output_set_pipe(output, PIPE_NONE);
 		igt_display_commit2(&data->display, COMMIT_ATOMIC);
 
 		for (int x = 0; x < c; x++)
-- 
2.25.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2021-06-18 14:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-18 14:28 [igt-dev] [PATCH i-g-t 0/4] IGT Patches Jun 18, 2021 Anson Jacob
2021-06-18 14:28 ` [igt-dev] [PATCH i-g-t 1/4] lib/igt_kms: Fix test_init() crash when <6 pipes Anson Jacob
2021-06-21  8:41   ` Petri Latvala
2021-06-18 14:28 ` [igt-dev] [PATCH i-g-t 2/4] tests/kms_content_protection: Enable Primary plane for CRTC Anson Jacob
2021-06-18 14:28 ` [igt-dev] [PATCH i-g-t 3/4] tests/kms_plane_multiple: Start continuous CRC capture after commit Anson Jacob
2021-06-18 14:28 ` Anson Jacob [this message]
2021-06-18 16:45   ` [igt-dev] [PATCH i-g-t 4/4] tests/kms_plane_multiple: Disable CRTC if no planes Mark Yacoub
2021-06-18 15:24 ` [igt-dev] ✓ Fi.CI.BAT: success for IGT Patches Jun 18, 2021 Patchwork
2021-06-18 17:06 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210618142855.5750-5-Anson.Jacob@amd.com \
    --to=anson.jacob@amd.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=markyacoub@google.com \
    --cc=petri.latvala@intel.com \
    --cc=victorchengchi.lu@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.