From: Anson Jacob <Anson.Jacob@amd.com>
To: igt-dev@lists.freedesktop.org
Cc: Petri Latvala <petri.latvala@intel.com>,
Anson Jacob <Anson.Jacob@amd.com>,
Victor Lu <victorchengchi.lu@amd.com>,
Mark Yacoub <markyacoub@google.com>
Subject: [igt-dev] [PATCH i-g-t 3/4] tests/kms_plane_multiple: Start continuous CRC capture after commit
Date: Fri, 18 Jun 2021 10:28:54 -0400 [thread overview]
Message-ID: <20210618142855.5750-4-Anson.Jacob@amd.com> (raw)
In-Reply-To: <20210618142855.5750-1-Anson.Jacob@amd.com>
From: Victor Lu <victorchengchi.lu@amd.com>
atomic-pipe-a-tiling-none fails on Raven because it fails to read the
CRC when there is no CRC generated (zeroed framebuffer). Move
igt_pipe_crc_start to be after the first nonzero FB commit.
Signed-off-by: Victor Lu <victorchengchi.lu@amd.com>
Acked-by: Anson Jacob <Anson.Jacob@amd.com>
Cc: Petri Latvala <petri.latvala@intel.com>
Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Cc: Harry Wentland <harry.wentland@amd.com>
Cc: Mark Yacoub <markyacoub@google.com>
---
tests/kms_plane_multiple.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/tests/kms_plane_multiple.c b/tests/kms_plane_multiple.c
index 93c6ea7d269d..4424b864b2d6 100644
--- a/tests/kms_plane_multiple.c
+++ b/tests/kms_plane_multiple.c
@@ -288,6 +288,7 @@ test_plane_position_with_output(data_t *data, enum pipe pipe,
igt_plane_t *plane;
int i;
int err, c = 0;
+ int crc_enabled = 0;
int iterations = opt.iterations < 1 ? 1 : opt.iterations;
bool loop_forever;
char info[256];
@@ -327,14 +328,16 @@ test_plane_position_with_output(data_t *data, enum pipe pipe,
igt_output_name(output), kmstest_pipe_name(pipe), c,
info, opt.seed);
- igt_pipe_crc_start(data->pipe_crc);
-
i = 0;
while (i < iterations || loop_forever) {
/* randomize planes and set up the holes */
prepare_planes(data, pipe, &blue, tiling, c, output);
igt_display_commit2(&data->display, COMMIT_ATOMIC);
+ if (!crc_enabled) {
+ igt_pipe_crc_start(data->pipe_crc);
+ crc_enabled = 1;
+ }
igt_pipe_crc_get_current(data->display.drm_fd, data->pipe_crc, &crc);
--
2.25.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2021-06-18 14:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 14:28 [igt-dev] [PATCH i-g-t 0/4] IGT Patches Jun 18, 2021 Anson Jacob
2021-06-18 14:28 ` [igt-dev] [PATCH i-g-t 1/4] lib/igt_kms: Fix test_init() crash when <6 pipes Anson Jacob
2021-06-21 8:41 ` Petri Latvala
2021-06-18 14:28 ` [igt-dev] [PATCH i-g-t 2/4] tests/kms_content_protection: Enable Primary plane for CRTC Anson Jacob
2021-06-18 14:28 ` Anson Jacob [this message]
2021-06-18 14:28 ` [igt-dev] [PATCH i-g-t 4/4] tests/kms_plane_multiple: Disable CRTC if no planes Anson Jacob
2021-06-18 16:45 ` Mark Yacoub
2021-06-18 15:24 ` [igt-dev] ✓ Fi.CI.BAT: success for IGT Patches Jun 18, 2021 Patchwork
2021-06-18 17:06 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210618142855.5750-4-Anson.Jacob@amd.com \
--to=anson.jacob@amd.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=markyacoub@google.com \
--cc=petri.latvala@intel.com \
--cc=victorchengchi.lu@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.