* [PATCH v2 0/2] Add Ethernet DTS for Actions Semi Owl S500 SoCs @ 2021-06-11 9:11 ` Cristian Ciocaltea 0 siblings, 0 replies; 24+ messages in thread From: Cristian Ciocaltea @ 2021-06-11 9:11 UTC (permalink / raw) To: Rob Herring, Andreas Färber, Manivannan Sadhasivam Cc: devicetree, linux-arm-kernel, linux-actions, linux-kernel This patchset adds the required DTS changes for providing the ethernet functionality on the Actions S500 SoCs family. For the moment I have been able to test the Ethernet MAC on the RoseaplePi SBC only. Also, please note the patches depend on some clock changes that are currently under review: https://lore.kernel.org/lkml/cover.1623354574.git.cristian.ciocaltea@gmail.com/ Thanks, Cristi Changes in v2: - Added Reviewed-by tag from Mani in patch 1/2 - Joined the groups sharing common function "eth_rmii" and switch the order of "ref_clk-pinconf" and "phy_clk-pinmux", per Mani's review, in patch 2/2 Cristian Ciocaltea (2): ARM: dts: owl-s500: Add ethernet support ARM: dts: owl-s500-roseapplepi: Add ethernet support arch/arm/boot/dts/owl-s500-roseapplepi.dts | 45 ++++++++++++++++++++++ arch/arm/boot/dts/owl-s500.dtsi | 10 +++++ 2 files changed, 55 insertions(+) -- 2.32.0 ^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH v2 0/2] Add Ethernet DTS for Actions Semi Owl S500 SoCs @ 2021-06-11 9:11 ` Cristian Ciocaltea 0 siblings, 0 replies; 24+ messages in thread From: Cristian Ciocaltea @ 2021-06-11 9:11 UTC (permalink / raw) To: Rob Herring, Andreas Färber, Manivannan Sadhasivam Cc: devicetree, linux-arm-kernel, linux-actions, linux-kernel This patchset adds the required DTS changes for providing the ethernet functionality on the Actions S500 SoCs family. For the moment I have been able to test the Ethernet MAC on the RoseaplePi SBC only. Also, please note the patches depend on some clock changes that are currently under review: https://lore.kernel.org/lkml/cover.1623354574.git.cristian.ciocaltea@gmail.com/ Thanks, Cristi Changes in v2: - Added Reviewed-by tag from Mani in patch 1/2 - Joined the groups sharing common function "eth_rmii" and switch the order of "ref_clk-pinconf" and "phy_clk-pinmux", per Mani's review, in patch 2/2 Cristian Ciocaltea (2): ARM: dts: owl-s500: Add ethernet support ARM: dts: owl-s500-roseapplepi: Add ethernet support arch/arm/boot/dts/owl-s500-roseapplepi.dts | 45 ++++++++++++++++++++++ arch/arm/boot/dts/owl-s500.dtsi | 10 +++++ 2 files changed, 55 insertions(+) -- 2.32.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH v2 1/2] ARM: dts: owl-s500: Add ethernet support 2021-06-11 9:11 ` Cristian Ciocaltea @ 2021-06-11 9:11 ` Cristian Ciocaltea -1 siblings, 0 replies; 24+ messages in thread From: Cristian Ciocaltea @ 2021-06-11 9:11 UTC (permalink / raw) To: Rob Herring, Andreas Färber, Manivannan Sadhasivam Cc: devicetree, linux-arm-kernel, linux-actions, linux-kernel, Manivannan Sadhasivam Add Ethernet MAC device tree node for Actions Semi S500 SoC. Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> --- arch/arm/boot/dts/owl-s500.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/boot/dts/owl-s500.dtsi b/arch/arm/boot/dts/owl-s500.dtsi index cd635f222d26..739b4b9cec8c 100644 --- a/arch/arm/boot/dts/owl-s500.dtsi +++ b/arch/arm/boot/dts/owl-s500.dtsi @@ -324,5 +324,15 @@ mmc2: mmc@b0238000 { dma-names = "mmc"; status = "disabled"; }; + + ethernet: ethernet@b0310000 { + compatible = "actions,s500-emac", "actions,owl-emac"; + reg = <0xb0310000 0x10000>; + interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cmu CLK_ETHERNET>, <&cmu CLK_RMII_REF>; + clock-names = "eth", "rmii"; + resets = <&cmu RESET_ETHERNET>; + status = "disabled"; + }; }; }; -- 2.32.0 ^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH v2 1/2] ARM: dts: owl-s500: Add ethernet support @ 2021-06-11 9:11 ` Cristian Ciocaltea 0 siblings, 0 replies; 24+ messages in thread From: Cristian Ciocaltea @ 2021-06-11 9:11 UTC (permalink / raw) To: Rob Herring, Andreas Färber, Manivannan Sadhasivam Cc: devicetree, linux-arm-kernel, linux-actions, linux-kernel, Manivannan Sadhasivam Add Ethernet MAC device tree node for Actions Semi S500 SoC. Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> --- arch/arm/boot/dts/owl-s500.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/boot/dts/owl-s500.dtsi b/arch/arm/boot/dts/owl-s500.dtsi index cd635f222d26..739b4b9cec8c 100644 --- a/arch/arm/boot/dts/owl-s500.dtsi +++ b/arch/arm/boot/dts/owl-s500.dtsi @@ -324,5 +324,15 @@ mmc2: mmc@b0238000 { dma-names = "mmc"; status = "disabled"; }; + + ethernet: ethernet@b0310000 { + compatible = "actions,s500-emac", "actions,owl-emac"; + reg = <0xb0310000 0x10000>; + interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cmu CLK_ETHERNET>, <&cmu CLK_RMII_REF>; + clock-names = "eth", "rmii"; + resets = <&cmu RESET_ETHERNET>; + status = "disabled"; + }; }; }; -- 2.32.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 24+ messages in thread
* Re: [PATCH v2 1/2] ARM: dts: owl-s500: Add ethernet support 2021-06-11 9:11 ` Cristian Ciocaltea (?) @ 2021-06-16 13:30 ` kernel test robot -1 siblings, 0 replies; 24+ messages in thread From: kernel test robot @ 2021-06-16 13:30 UTC (permalink / raw) To: Cristian Ciocaltea, Rob Herring, Andreas Färber, Manivannan Sadhasivam Cc: kbuild-all, devicetree, linux-arm-kernel, linux-actions, linux-kernel [-- Attachment #1: Type: text/plain, Size: 1682 bytes --] Hi Cristian, I love your patch! Yet something to improve: [auto build test ERROR on robh/for-next] [also build test ERROR on v5.13-rc6 next-20210615] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Cristian-Ciocaltea/Add-Ethernet-DTS-for-Actions-Semi-Owl-S500-SoCs/20210616-121106 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next config: arm-randconfig-r025-20210615 (attached as .config) compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/87e17f86112592e0805d0a081914f7b2eeb2770d git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Cristian-Ciocaltea/Add-Ethernet-DTS-for-Actions-Semi-Owl-S500-SoCs/20210616-121106 git checkout 87e17f86112592e0805d0a081914f7b2eeb2770d # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All errors (new ones prefixed by >>): >> Error: arch/arm/boot/dts/owl-s500.dtsi:332.19-20 syntax error >> FATAL ERROR: Unable to parse input tree --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 30716 bytes --] ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v2 1/2] ARM: dts: owl-s500: Add ethernet support @ 2021-06-16 13:30 ` kernel test robot 0 siblings, 0 replies; 24+ messages in thread From: kernel test robot @ 2021-06-16 13:30 UTC (permalink / raw) To: kbuild-all [-- Attachment #1: Type: text/plain, Size: 1719 bytes --] Hi Cristian, I love your patch! Yet something to improve: [auto build test ERROR on robh/for-next] [also build test ERROR on v5.13-rc6 next-20210615] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Cristian-Ciocaltea/Add-Ethernet-DTS-for-Actions-Semi-Owl-S500-SoCs/20210616-121106 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next config: arm-randconfig-r025-20210615 (attached as .config) compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/87e17f86112592e0805d0a081914f7b2eeb2770d git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Cristian-Ciocaltea/Add-Ethernet-DTS-for-Actions-Semi-Owl-S500-SoCs/20210616-121106 git checkout 87e17f86112592e0805d0a081914f7b2eeb2770d # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All errors (new ones prefixed by >>): >> Error: arch/arm/boot/dts/owl-s500.dtsi:332.19-20 syntax error >> FATAL ERROR: Unable to parse input tree --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org [-- Attachment #2: config.gz --] [-- Type: application/gzip, Size: 30716 bytes --] ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v2 1/2] ARM: dts: owl-s500: Add ethernet support @ 2021-06-16 13:30 ` kernel test robot 0 siblings, 0 replies; 24+ messages in thread From: kernel test robot @ 2021-06-16 13:30 UTC (permalink / raw) To: Cristian Ciocaltea, Rob Herring, Andreas Färber, Manivannan Sadhasivam Cc: kbuild-all, devicetree, linux-arm-kernel, linux-actions, linux-kernel [-- Attachment #1: Type: text/plain, Size: 1682 bytes --] Hi Cristian, I love your patch! Yet something to improve: [auto build test ERROR on robh/for-next] [also build test ERROR on v5.13-rc6 next-20210615] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Cristian-Ciocaltea/Add-Ethernet-DTS-for-Actions-Semi-Owl-S500-SoCs/20210616-121106 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next config: arm-randconfig-r025-20210615 (attached as .config) compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/87e17f86112592e0805d0a081914f7b2eeb2770d git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Cristian-Ciocaltea/Add-Ethernet-DTS-for-Actions-Semi-Owl-S500-SoCs/20210616-121106 git checkout 87e17f86112592e0805d0a081914f7b2eeb2770d # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All errors (new ones prefixed by >>): >> Error: arch/arm/boot/dts/owl-s500.dtsi:332.19-20 syntax error >> FATAL ERROR: Unable to parse input tree --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 30716 bytes --] [-- Attachment #3: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v2 1/2] ARM: dts: owl-s500: Add ethernet support 2021-06-16 13:30 ` kernel test robot (?) @ 2021-06-28 6:22 ` Manivannan Sadhasivam -1 siblings, 0 replies; 24+ messages in thread From: Manivannan Sadhasivam @ 2021-06-28 6:22 UTC (permalink / raw) To: kernel test robot Cc: Cristian Ciocaltea, Rob Herring, Andreas Färber, kbuild-all, devicetree, linux-arm-kernel, linux-actions, linux-kernel Hi Cristi, On Wed, Jun 16, 2021 at 09:30:13PM +0800, kernel test robot wrote: > Hi Cristian, > > I love your patch! Yet something to improve: > > [auto build test ERROR on robh/for-next] > [also build test ERROR on v5.13-rc6 next-20210615] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: https://github.com/0day-ci/linux/commits/Cristian-Ciocaltea/Add-Ethernet-DTS-for-Actions-Semi-Owl-S500-SoCs/20210616-121106 > base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next > config: arm-randconfig-r025-20210615 (attached as .config) > compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0 > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/0day-ci/linux/commit/87e17f86112592e0805d0a081914f7b2eeb2770d > git remote add linux-review https://github.com/0day-ci/linux > git fetch --no-tags linux-review Cristian-Ciocaltea/Add-Ethernet-DTS-for-Actions-Semi-Owl-S500-SoCs/20210616-121106 > git checkout 87e17f86112592e0805d0a081914f7b2eeb2770d > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp@intel.com> > > All errors (new ones prefixed by >>): > > >> Error: arch/arm/boot/dts/owl-s500.dtsi:332.19-20 syntax error > >> FATAL ERROR: Unable to parse input tree Did you look into this error? Looks like CLK_ETHERNET is not defined in the s500 CMU binding. Today I saw that the clk patches are applied but then it is later for me to send the dts patches for v5.14. So please fix this error and resubmit, I'll take them for v5.15. Thanks, Mani > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v2 1/2] ARM: dts: owl-s500: Add ethernet support @ 2021-06-28 6:22 ` Manivannan Sadhasivam 0 siblings, 0 replies; 24+ messages in thread From: Manivannan Sadhasivam @ 2021-06-28 6:22 UTC (permalink / raw) To: kbuild-all [-- Attachment #1: Type: text/plain, Size: 2168 bytes --] Hi Cristi, On Wed, Jun 16, 2021 at 09:30:13PM +0800, kernel test robot wrote: > Hi Cristian, > > I love your patch! Yet something to improve: > > [auto build test ERROR on robh/for-next] > [also build test ERROR on v5.13-rc6 next-20210615] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: https://github.com/0day-ci/linux/commits/Cristian-Ciocaltea/Add-Ethernet-DTS-for-Actions-Semi-Owl-S500-SoCs/20210616-121106 > base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next > config: arm-randconfig-r025-20210615 (attached as .config) > compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0 > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/0day-ci/linux/commit/87e17f86112592e0805d0a081914f7b2eeb2770d > git remote add linux-review https://github.com/0day-ci/linux > git fetch --no-tags linux-review Cristian-Ciocaltea/Add-Ethernet-DTS-for-Actions-Semi-Owl-S500-SoCs/20210616-121106 > git checkout 87e17f86112592e0805d0a081914f7b2eeb2770d > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp@intel.com> > > All errors (new ones prefixed by >>): > > >> Error: arch/arm/boot/dts/owl-s500.dtsi:332.19-20 syntax error > >> FATAL ERROR: Unable to parse input tree Did you look into this error? Looks like CLK_ETHERNET is not defined in the s500 CMU binding. Today I saw that the clk patches are applied but then it is later for me to send the dts patches for v5.14. So please fix this error and resubmit, I'll take them for v5.15. Thanks, Mani > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v2 1/2] ARM: dts: owl-s500: Add ethernet support @ 2021-06-28 6:22 ` Manivannan Sadhasivam 0 siblings, 0 replies; 24+ messages in thread From: Manivannan Sadhasivam @ 2021-06-28 6:22 UTC (permalink / raw) To: kernel test robot Cc: Cristian Ciocaltea, Rob Herring, Andreas Färber, kbuild-all, devicetree, linux-arm-kernel, linux-actions, linux-kernel Hi Cristi, On Wed, Jun 16, 2021 at 09:30:13PM +0800, kernel test robot wrote: > Hi Cristian, > > I love your patch! Yet something to improve: > > [auto build test ERROR on robh/for-next] > [also build test ERROR on v5.13-rc6 next-20210615] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: https://github.com/0day-ci/linux/commits/Cristian-Ciocaltea/Add-Ethernet-DTS-for-Actions-Semi-Owl-S500-SoCs/20210616-121106 > base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next > config: arm-randconfig-r025-20210615 (attached as .config) > compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0 > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/0day-ci/linux/commit/87e17f86112592e0805d0a081914f7b2eeb2770d > git remote add linux-review https://github.com/0day-ci/linux > git fetch --no-tags linux-review Cristian-Ciocaltea/Add-Ethernet-DTS-for-Actions-Semi-Owl-S500-SoCs/20210616-121106 > git checkout 87e17f86112592e0805d0a081914f7b2eeb2770d > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp@intel.com> > > All errors (new ones prefixed by >>): > > >> Error: arch/arm/boot/dts/owl-s500.dtsi:332.19-20 syntax error > >> FATAL ERROR: Unable to parse input tree Did you look into this error? Looks like CLK_ETHERNET is not defined in the s500 CMU binding. Today I saw that the clk patches are applied but then it is later for me to send the dts patches for v5.14. So please fix this error and resubmit, I'll take them for v5.15. Thanks, Mani > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v2 1/2] ARM: dts: owl-s500: Add ethernet support 2021-06-28 6:22 ` Manivannan Sadhasivam (?) @ 2021-06-28 7:02 ` Cristian Ciocaltea -1 siblings, 0 replies; 24+ messages in thread From: Cristian Ciocaltea @ 2021-06-28 7:02 UTC (permalink / raw) To: Manivannan Sadhasivam Cc: kernel test robot, Rob Herring, Andreas Färber, kbuild-all, devicetree, linux-arm-kernel, linux-actions, linux-kernel Hi Mani, On Mon, Jun 28, 2021 at 11:52:35AM +0530, Manivannan Sadhasivam wrote: > Hi Cristi, > > On Wed, Jun 16, 2021 at 09:30:13PM +0800, kernel test robot wrote: > > Hi Cristian, > > > > I love your patch! Yet something to improve: > > > > [auto build test ERROR on robh/for-next] > > [also build test ERROR on v5.13-rc6 next-20210615] > > [If your patch is applied to the wrong git tree, kindly drop us a note. > > And when submitting patch, we suggest to use '--base' as documented in > > https://git-scm.com/docs/git-format-patch] > > > > url: https://github.com/0day-ci/linux/commits/Cristian-Ciocaltea/Add-Ethernet-DTS-for-Actions-Semi-Owl-S500-SoCs/20210616-121106 > > base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next > > config: arm-randconfig-r025-20210615 (attached as .config) > > compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0 > > reproduce (this is a W=1 build): > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > chmod +x ~/bin/make.cross > > # https://github.com/0day-ci/linux/commit/87e17f86112592e0805d0a081914f7b2eeb2770d > > git remote add linux-review https://github.com/0day-ci/linux > > git fetch --no-tags linux-review Cristian-Ciocaltea/Add-Ethernet-DTS-for-Actions-Semi-Owl-S500-SoCs/20210616-121106 > > git checkout 87e17f86112592e0805d0a081914f7b2eeb2770d > > # save the attached .config to linux build tree > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm > > > > If you fix the issue, kindly add following tag as appropriate > > Reported-by: kernel test robot <lkp@intel.com> > > > > All errors (new ones prefixed by >>): > > > > >> Error: arch/arm/boot/dts/owl-s500.dtsi:332.19-20 syntax error > > >> FATAL ERROR: Unable to parse input tree > > Did you look into this error? Looks like CLK_ETHERNET is not defined in > the s500 CMU binding. CLK_ETHERNET is introduced through patches 5 & 6 from the patch series: "[PATCH v3 0/6] Improve clock support for Actions S500 SoC" Most probably those patches were not applied to the tested kernel tree and that's why the robot reported the error. Thanks, Cristi > Today I saw that the clk patches are applied but then it is later for me > to send the dts patches for v5.14. So please fix this error and > resubmit, I'll take them for v5.15. > > Thanks, > Mani > > > > > --- > > 0-DAY CI Kernel Test Service, Intel Corporation > > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org > > ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v2 1/2] ARM: dts: owl-s500: Add ethernet support @ 2021-06-28 7:02 ` Cristian Ciocaltea 0 siblings, 0 replies; 24+ messages in thread From: Cristian Ciocaltea @ 2021-06-28 7:02 UTC (permalink / raw) To: kbuild-all [-- Attachment #1: Type: text/plain, Size: 2627 bytes --] Hi Mani, On Mon, Jun 28, 2021 at 11:52:35AM +0530, Manivannan Sadhasivam wrote: > Hi Cristi, > > On Wed, Jun 16, 2021 at 09:30:13PM +0800, kernel test robot wrote: > > Hi Cristian, > > > > I love your patch! Yet something to improve: > > > > [auto build test ERROR on robh/for-next] > > [also build test ERROR on v5.13-rc6 next-20210615] > > [If your patch is applied to the wrong git tree, kindly drop us a note. > > And when submitting patch, we suggest to use '--base' as documented in > > https://git-scm.com/docs/git-format-patch] > > > > url: https://github.com/0day-ci/linux/commits/Cristian-Ciocaltea/Add-Ethernet-DTS-for-Actions-Semi-Owl-S500-SoCs/20210616-121106 > > base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next > > config: arm-randconfig-r025-20210615 (attached as .config) > > compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0 > > reproduce (this is a W=1 build): > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > chmod +x ~/bin/make.cross > > # https://github.com/0day-ci/linux/commit/87e17f86112592e0805d0a081914f7b2eeb2770d > > git remote add linux-review https://github.com/0day-ci/linux > > git fetch --no-tags linux-review Cristian-Ciocaltea/Add-Ethernet-DTS-for-Actions-Semi-Owl-S500-SoCs/20210616-121106 > > git checkout 87e17f86112592e0805d0a081914f7b2eeb2770d > > # save the attached .config to linux build tree > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm > > > > If you fix the issue, kindly add following tag as appropriate > > Reported-by: kernel test robot <lkp@intel.com> > > > > All errors (new ones prefixed by >>): > > > > >> Error: arch/arm/boot/dts/owl-s500.dtsi:332.19-20 syntax error > > >> FATAL ERROR: Unable to parse input tree > > Did you look into this error? Looks like CLK_ETHERNET is not defined in > the s500 CMU binding. CLK_ETHERNET is introduced through patches 5 & 6 from the patch series: "[PATCH v3 0/6] Improve clock support for Actions S500 SoC" Most probably those patches were not applied to the tested kernel tree and that's why the robot reported the error. Thanks, Cristi > Today I saw that the clk patches are applied but then it is later for me > to send the dts patches for v5.14. So please fix this error and > resubmit, I'll take them for v5.15. > > Thanks, > Mani > > > > > --- > > 0-DAY CI Kernel Test Service, Intel Corporation > > https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org > > ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v2 1/2] ARM: dts: owl-s500: Add ethernet support @ 2021-06-28 7:02 ` Cristian Ciocaltea 0 siblings, 0 replies; 24+ messages in thread From: Cristian Ciocaltea @ 2021-06-28 7:02 UTC (permalink / raw) To: Manivannan Sadhasivam Cc: kernel test robot, Rob Herring, Andreas Färber, kbuild-all, devicetree, linux-arm-kernel, linux-actions, linux-kernel Hi Mani, On Mon, Jun 28, 2021 at 11:52:35AM +0530, Manivannan Sadhasivam wrote: > Hi Cristi, > > On Wed, Jun 16, 2021 at 09:30:13PM +0800, kernel test robot wrote: > > Hi Cristian, > > > > I love your patch! Yet something to improve: > > > > [auto build test ERROR on robh/for-next] > > [also build test ERROR on v5.13-rc6 next-20210615] > > [If your patch is applied to the wrong git tree, kindly drop us a note. > > And when submitting patch, we suggest to use '--base' as documented in > > https://git-scm.com/docs/git-format-patch] > > > > url: https://github.com/0day-ci/linux/commits/Cristian-Ciocaltea/Add-Ethernet-DTS-for-Actions-Semi-Owl-S500-SoCs/20210616-121106 > > base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next > > config: arm-randconfig-r025-20210615 (attached as .config) > > compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0 > > reproduce (this is a W=1 build): > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > chmod +x ~/bin/make.cross > > # https://github.com/0day-ci/linux/commit/87e17f86112592e0805d0a081914f7b2eeb2770d > > git remote add linux-review https://github.com/0day-ci/linux > > git fetch --no-tags linux-review Cristian-Ciocaltea/Add-Ethernet-DTS-for-Actions-Semi-Owl-S500-SoCs/20210616-121106 > > git checkout 87e17f86112592e0805d0a081914f7b2eeb2770d > > # save the attached .config to linux build tree > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm > > > > If you fix the issue, kindly add following tag as appropriate > > Reported-by: kernel test robot <lkp@intel.com> > > > > All errors (new ones prefixed by >>): > > > > >> Error: arch/arm/boot/dts/owl-s500.dtsi:332.19-20 syntax error > > >> FATAL ERROR: Unable to parse input tree > > Did you look into this error? Looks like CLK_ETHERNET is not defined in > the s500 CMU binding. CLK_ETHERNET is introduced through patches 5 & 6 from the patch series: "[PATCH v3 0/6] Improve clock support for Actions S500 SoC" Most probably those patches were not applied to the tested kernel tree and that's why the robot reported the error. Thanks, Cristi > Today I saw that the clk patches are applied but then it is later for me > to send the dts patches for v5.14. So please fix this error and > resubmit, I'll take them for v5.15. > > Thanks, > Mani > > > > > --- > > 0-DAY CI Kernel Test Service, Intel Corporation > > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v2 1/2] ARM: dts: owl-s500: Add ethernet support 2021-06-28 7:02 ` Cristian Ciocaltea (?) @ 2021-06-28 7:31 ` Manivannan Sadhasivam -1 siblings, 0 replies; 24+ messages in thread From: Manivannan Sadhasivam @ 2021-06-28 7:31 UTC (permalink / raw) To: Cristian Ciocaltea Cc: kernel test robot, Rob Herring, Andreas Färber, kbuild-all, devicetree, linux-arm-kernel, linux-actions, linux-kernel On Mon, Jun 28, 2021 at 10:02:34AM +0300, Cristian Ciocaltea wrote: > Hi Mani, > > On Mon, Jun 28, 2021 at 11:52:35AM +0530, Manivannan Sadhasivam wrote: > > Hi Cristi, > > > > On Wed, Jun 16, 2021 at 09:30:13PM +0800, kernel test robot wrote: > > > Hi Cristian, > > > > > > I love your patch! Yet something to improve: > > > > > > [auto build test ERROR on robh/for-next] > > > [also build test ERROR on v5.13-rc6 next-20210615] > > > [If your patch is applied to the wrong git tree, kindly drop us a note. > > > And when submitting patch, we suggest to use '--base' as documented in > > > https://git-scm.com/docs/git-format-patch] > > > > > > url: https://github.com/0day-ci/linux/commits/Cristian-Ciocaltea/Add-Ethernet-DTS-for-Actions-Semi-Owl-S500-SoCs/20210616-121106 > > > base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next > > > config: arm-randconfig-r025-20210615 (attached as .config) > > > compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0 > > > reproduce (this is a W=1 build): > > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > > chmod +x ~/bin/make.cross > > > # https://github.com/0day-ci/linux/commit/87e17f86112592e0805d0a081914f7b2eeb2770d > > > git remote add linux-review https://github.com/0day-ci/linux > > > git fetch --no-tags linux-review Cristian-Ciocaltea/Add-Ethernet-DTS-for-Actions-Semi-Owl-S500-SoCs/20210616-121106 > > > git checkout 87e17f86112592e0805d0a081914f7b2eeb2770d > > > # save the attached .config to linux build tree > > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm > > > > > > If you fix the issue, kindly add following tag as appropriate > > > Reported-by: kernel test robot <lkp@intel.com> > > > > > > All errors (new ones prefixed by >>): > > > > > > >> Error: arch/arm/boot/dts/owl-s500.dtsi:332.19-20 syntax error > > > >> FATAL ERROR: Unable to parse input tree > > > > Did you look into this error? Looks like CLK_ETHERNET is not defined in > > the s500 CMU binding. > > CLK_ETHERNET is introduced through patches 5 & 6 from the patch series: > "[PATCH v3 0/6] Improve clock support for Actions S500 SoC" > > Most probably those patches were not applied to the tested kernel tree > and that's why the robot reported the error. > Ah, okay. I didn't see it. Then I'll just push the dts changes and see if they get applied for 5.14. Thanks, Mani > Thanks, > Cristi > > > Today I saw that the clk patches are applied but then it is later for me > > to send the dts patches for v5.14. So please fix this error and > > resubmit, I'll take them for v5.15. > > > > Thanks, > > Mani > > > > > > > > --- > > > 0-DAY CI Kernel Test Service, Intel Corporation > > > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org > > > > ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v2 1/2] ARM: dts: owl-s500: Add ethernet support @ 2021-06-28 7:31 ` Manivannan Sadhasivam 0 siblings, 0 replies; 24+ messages in thread From: Manivannan Sadhasivam @ 2021-06-28 7:31 UTC (permalink / raw) To: kbuild-all [-- Attachment #1: Type: text/plain, Size: 2946 bytes --] On Mon, Jun 28, 2021 at 10:02:34AM +0300, Cristian Ciocaltea wrote: > Hi Mani, > > On Mon, Jun 28, 2021 at 11:52:35AM +0530, Manivannan Sadhasivam wrote: > > Hi Cristi, > > > > On Wed, Jun 16, 2021 at 09:30:13PM +0800, kernel test robot wrote: > > > Hi Cristian, > > > > > > I love your patch! Yet something to improve: > > > > > > [auto build test ERROR on robh/for-next] > > > [also build test ERROR on v5.13-rc6 next-20210615] > > > [If your patch is applied to the wrong git tree, kindly drop us a note. > > > And when submitting patch, we suggest to use '--base' as documented in > > > https://git-scm.com/docs/git-format-patch] > > > > > > url: https://github.com/0day-ci/linux/commits/Cristian-Ciocaltea/Add-Ethernet-DTS-for-Actions-Semi-Owl-S500-SoCs/20210616-121106 > > > base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next > > > config: arm-randconfig-r025-20210615 (attached as .config) > > > compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0 > > > reproduce (this is a W=1 build): > > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > > chmod +x ~/bin/make.cross > > > # https://github.com/0day-ci/linux/commit/87e17f86112592e0805d0a081914f7b2eeb2770d > > > git remote add linux-review https://github.com/0day-ci/linux > > > git fetch --no-tags linux-review Cristian-Ciocaltea/Add-Ethernet-DTS-for-Actions-Semi-Owl-S500-SoCs/20210616-121106 > > > git checkout 87e17f86112592e0805d0a081914f7b2eeb2770d > > > # save the attached .config to linux build tree > > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm > > > > > > If you fix the issue, kindly add following tag as appropriate > > > Reported-by: kernel test robot <lkp@intel.com> > > > > > > All errors (new ones prefixed by >>): > > > > > > >> Error: arch/arm/boot/dts/owl-s500.dtsi:332.19-20 syntax error > > > >> FATAL ERROR: Unable to parse input tree > > > > Did you look into this error? Looks like CLK_ETHERNET is not defined in > > the s500 CMU binding. > > CLK_ETHERNET is introduced through patches 5 & 6 from the patch series: > "[PATCH v3 0/6] Improve clock support for Actions S500 SoC" > > Most probably those patches were not applied to the tested kernel tree > and that's why the robot reported the error. > Ah, okay. I didn't see it. Then I'll just push the dts changes and see if they get applied for 5.14. Thanks, Mani > Thanks, > Cristi > > > Today I saw that the clk patches are applied but then it is later for me > > to send the dts patches for v5.14. So please fix this error and > > resubmit, I'll take them for v5.15. > > > > Thanks, > > Mani > > > > > > > > --- > > > 0-DAY CI Kernel Test Service, Intel Corporation > > > https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org > > > > ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v2 1/2] ARM: dts: owl-s500: Add ethernet support @ 2021-06-28 7:31 ` Manivannan Sadhasivam 0 siblings, 0 replies; 24+ messages in thread From: Manivannan Sadhasivam @ 2021-06-28 7:31 UTC (permalink / raw) To: Cristian Ciocaltea Cc: kernel test robot, Rob Herring, Andreas Färber, kbuild-all, devicetree, linux-arm-kernel, linux-actions, linux-kernel On Mon, Jun 28, 2021 at 10:02:34AM +0300, Cristian Ciocaltea wrote: > Hi Mani, > > On Mon, Jun 28, 2021 at 11:52:35AM +0530, Manivannan Sadhasivam wrote: > > Hi Cristi, > > > > On Wed, Jun 16, 2021 at 09:30:13PM +0800, kernel test robot wrote: > > > Hi Cristian, > > > > > > I love your patch! Yet something to improve: > > > > > > [auto build test ERROR on robh/for-next] > > > [also build test ERROR on v5.13-rc6 next-20210615] > > > [If your patch is applied to the wrong git tree, kindly drop us a note. > > > And when submitting patch, we suggest to use '--base' as documented in > > > https://git-scm.com/docs/git-format-patch] > > > > > > url: https://github.com/0day-ci/linux/commits/Cristian-Ciocaltea/Add-Ethernet-DTS-for-Actions-Semi-Owl-S500-SoCs/20210616-121106 > > > base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next > > > config: arm-randconfig-r025-20210615 (attached as .config) > > > compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0 > > > reproduce (this is a W=1 build): > > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > > chmod +x ~/bin/make.cross > > > # https://github.com/0day-ci/linux/commit/87e17f86112592e0805d0a081914f7b2eeb2770d > > > git remote add linux-review https://github.com/0day-ci/linux > > > git fetch --no-tags linux-review Cristian-Ciocaltea/Add-Ethernet-DTS-for-Actions-Semi-Owl-S500-SoCs/20210616-121106 > > > git checkout 87e17f86112592e0805d0a081914f7b2eeb2770d > > > # save the attached .config to linux build tree > > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm > > > > > > If you fix the issue, kindly add following tag as appropriate > > > Reported-by: kernel test robot <lkp@intel.com> > > > > > > All errors (new ones prefixed by >>): > > > > > > >> Error: arch/arm/boot/dts/owl-s500.dtsi:332.19-20 syntax error > > > >> FATAL ERROR: Unable to parse input tree > > > > Did you look into this error? Looks like CLK_ETHERNET is not defined in > > the s500 CMU binding. > > CLK_ETHERNET is introduced through patches 5 & 6 from the patch series: > "[PATCH v3 0/6] Improve clock support for Actions S500 SoC" > > Most probably those patches were not applied to the tested kernel tree > and that's why the robot reported the error. > Ah, okay. I didn't see it. Then I'll just push the dts changes and see if they get applied for 5.14. Thanks, Mani > Thanks, > Cristi > > > Today I saw that the clk patches are applied but then it is later for me > > to send the dts patches for v5.14. So please fix this error and > > resubmit, I'll take them for v5.15. > > > > Thanks, > > Mani > > > > > > > > --- > > > 0-DAY CI Kernel Test Service, Intel Corporation > > > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH v2 2/2] ARM: dts: owl-s500-roseapplepi: Add ethernet support 2021-06-11 9:11 ` Cristian Ciocaltea @ 2021-06-11 9:11 ` Cristian Ciocaltea -1 siblings, 0 replies; 24+ messages in thread From: Cristian Ciocaltea @ 2021-06-11 9:11 UTC (permalink / raw) To: Rob Herring, Andreas Färber, Manivannan Sadhasivam Cc: devicetree, linux-arm-kernel, linux-actions, linux-kernel Add pinctrl configuration for enabling the Ethernet MAC on RoseapplePi SBC. Additionally, provide the necessary properties for the generic S500 ethernet node in order to setup PHY and MDIO. Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com> --- arch/arm/boot/dts/owl-s500-roseapplepi.dts | 45 ++++++++++++++++++++++ 1 file changed, 45 insertions(+) diff --git a/arch/arm/boot/dts/owl-s500-roseapplepi.dts b/arch/arm/boot/dts/owl-s500-roseapplepi.dts index b8c5db2344aa..eb555f385283 100644 --- a/arch/arm/boot/dts/owl-s500-roseapplepi.dts +++ b/arch/arm/boot/dts/owl-s500-roseapplepi.dts @@ -225,6 +225,27 @@ bias1-pinconf { bias-pull-down; }; }; + + ethernet_pins: ethernet-pins { + eth_rmii-pinmux { + groups = "rmii_txd0_mfp", "rmii_txd1_mfp", + "rmii_rxd0_mfp", "rmii_rxd1_mfp", + "rmii_txen_mfp", "rmii_rxen_mfp", + "rmii_crs_dv_mfp", "rmii_ref_clk_mfp"; + function = "eth_rmii"; + }; + + phy_clk-pinmux { + groups = "clko_25m_mfp"; + function = "clko_25m"; + }; + + ref_clk-pinconf { + groups = "rmii_ref_clk_drv"; + drive-strength = <2>; + }; + + }; }; /* uSD */ @@ -241,6 +262,30 @@ &mmc0 { vqmmc-supply = <&sd_vcc>; }; +ðernet { + pinctrl-names = "default"; + pinctrl-0 = <ðernet_pins>; + phy-mode = "rmii"; + phy-handle = <ð_phy>; + status = "okay"; + + mdio { + #address-cells = <1>; + #size-cells = <0>; + + reset-gpios = <&pinctrl 88 GPIO_ACTIVE_LOW>; /* GPIOC24 */ + reset-delay-us = <10000>; + reset-post-delay-us = <150000>; + + eth_phy: ethernet-phy@3 { + reg = <0x3>; + max-speed = <100>; + interrupt-parent = <&sirq>; + interrupts = <0 IRQ_TYPE_LEVEL_LOW>; + }; + }; +}; + &twd_timer { status = "okay"; }; -- 2.32.0 ^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH v2 2/2] ARM: dts: owl-s500-roseapplepi: Add ethernet support @ 2021-06-11 9:11 ` Cristian Ciocaltea 0 siblings, 0 replies; 24+ messages in thread From: Cristian Ciocaltea @ 2021-06-11 9:11 UTC (permalink / raw) To: Rob Herring, Andreas Färber, Manivannan Sadhasivam Cc: devicetree, linux-arm-kernel, linux-actions, linux-kernel Add pinctrl configuration for enabling the Ethernet MAC on RoseapplePi SBC. Additionally, provide the necessary properties for the generic S500 ethernet node in order to setup PHY and MDIO. Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com> --- arch/arm/boot/dts/owl-s500-roseapplepi.dts | 45 ++++++++++++++++++++++ 1 file changed, 45 insertions(+) diff --git a/arch/arm/boot/dts/owl-s500-roseapplepi.dts b/arch/arm/boot/dts/owl-s500-roseapplepi.dts index b8c5db2344aa..eb555f385283 100644 --- a/arch/arm/boot/dts/owl-s500-roseapplepi.dts +++ b/arch/arm/boot/dts/owl-s500-roseapplepi.dts @@ -225,6 +225,27 @@ bias1-pinconf { bias-pull-down; }; }; + + ethernet_pins: ethernet-pins { + eth_rmii-pinmux { + groups = "rmii_txd0_mfp", "rmii_txd1_mfp", + "rmii_rxd0_mfp", "rmii_rxd1_mfp", + "rmii_txen_mfp", "rmii_rxen_mfp", + "rmii_crs_dv_mfp", "rmii_ref_clk_mfp"; + function = "eth_rmii"; + }; + + phy_clk-pinmux { + groups = "clko_25m_mfp"; + function = "clko_25m"; + }; + + ref_clk-pinconf { + groups = "rmii_ref_clk_drv"; + drive-strength = <2>; + }; + + }; }; /* uSD */ @@ -241,6 +262,30 @@ &mmc0 { vqmmc-supply = <&sd_vcc>; }; +ðernet { + pinctrl-names = "default"; + pinctrl-0 = <ðernet_pins>; + phy-mode = "rmii"; + phy-handle = <ð_phy>; + status = "okay"; + + mdio { + #address-cells = <1>; + #size-cells = <0>; + + reset-gpios = <&pinctrl 88 GPIO_ACTIVE_LOW>; /* GPIOC24 */ + reset-delay-us = <10000>; + reset-post-delay-us = <150000>; + + eth_phy: ethernet-phy@3 { + reg = <0x3>; + max-speed = <100>; + interrupt-parent = <&sirq>; + interrupts = <0 IRQ_TYPE_LEVEL_LOW>; + }; + }; +}; + &twd_timer { status = "okay"; }; -- 2.32.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 24+ messages in thread
* Re: [PATCH v2 2/2] ARM: dts: owl-s500-roseapplepi: Add ethernet support 2021-06-11 9:11 ` Cristian Ciocaltea @ 2021-06-14 11:27 ` Manivannan Sadhasivam -1 siblings, 0 replies; 24+ messages in thread From: Manivannan Sadhasivam @ 2021-06-14 11:27 UTC (permalink / raw) To: Cristian Ciocaltea Cc: Rob Herring, Andreas Färber, devicetree, linux-arm-kernel, linux-actions, linux-kernel On Fri, Jun 11, 2021 at 12:11:33PM +0300, Cristian Ciocaltea wrote: > Add pinctrl configuration for enabling the Ethernet MAC on RoseapplePi > SBC. Additionally, provide the necessary properties for the generic S500 > ethernet node in order to setup PHY and MDIO. > > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Thanks, Mani > --- > arch/arm/boot/dts/owl-s500-roseapplepi.dts | 45 ++++++++++++++++++++++ > 1 file changed, 45 insertions(+) > > diff --git a/arch/arm/boot/dts/owl-s500-roseapplepi.dts b/arch/arm/boot/dts/owl-s500-roseapplepi.dts > index b8c5db2344aa..eb555f385283 100644 > --- a/arch/arm/boot/dts/owl-s500-roseapplepi.dts > +++ b/arch/arm/boot/dts/owl-s500-roseapplepi.dts > @@ -225,6 +225,27 @@ bias1-pinconf { > bias-pull-down; > }; > }; > + > + ethernet_pins: ethernet-pins { > + eth_rmii-pinmux { > + groups = "rmii_txd0_mfp", "rmii_txd1_mfp", > + "rmii_rxd0_mfp", "rmii_rxd1_mfp", > + "rmii_txen_mfp", "rmii_rxen_mfp", > + "rmii_crs_dv_mfp", "rmii_ref_clk_mfp"; > + function = "eth_rmii"; > + }; > + > + phy_clk-pinmux { > + groups = "clko_25m_mfp"; > + function = "clko_25m"; > + }; > + > + ref_clk-pinconf { > + groups = "rmii_ref_clk_drv"; > + drive-strength = <2>; > + }; > + > + }; > }; > > /* uSD */ > @@ -241,6 +262,30 @@ &mmc0 { > vqmmc-supply = <&sd_vcc>; > }; > > +ðernet { > + pinctrl-names = "default"; > + pinctrl-0 = <ðernet_pins>; > + phy-mode = "rmii"; > + phy-handle = <ð_phy>; > + status = "okay"; > + > + mdio { > + #address-cells = <1>; > + #size-cells = <0>; > + > + reset-gpios = <&pinctrl 88 GPIO_ACTIVE_LOW>; /* GPIOC24 */ > + reset-delay-us = <10000>; > + reset-post-delay-us = <150000>; > + > + eth_phy: ethernet-phy@3 { > + reg = <0x3>; > + max-speed = <100>; > + interrupt-parent = <&sirq>; > + interrupts = <0 IRQ_TYPE_LEVEL_LOW>; > + }; > + }; > +}; > + > &twd_timer { > status = "okay"; > }; > -- > 2.32.0 > ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v2 2/2] ARM: dts: owl-s500-roseapplepi: Add ethernet support @ 2021-06-14 11:27 ` Manivannan Sadhasivam 0 siblings, 0 replies; 24+ messages in thread From: Manivannan Sadhasivam @ 2021-06-14 11:27 UTC (permalink / raw) To: Cristian Ciocaltea Cc: Rob Herring, Andreas Färber, devicetree, linux-arm-kernel, linux-actions, linux-kernel On Fri, Jun 11, 2021 at 12:11:33PM +0300, Cristian Ciocaltea wrote: > Add pinctrl configuration for enabling the Ethernet MAC on RoseapplePi > SBC. Additionally, provide the necessary properties for the generic S500 > ethernet node in order to setup PHY and MDIO. > > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Thanks, Mani > --- > arch/arm/boot/dts/owl-s500-roseapplepi.dts | 45 ++++++++++++++++++++++ > 1 file changed, 45 insertions(+) > > diff --git a/arch/arm/boot/dts/owl-s500-roseapplepi.dts b/arch/arm/boot/dts/owl-s500-roseapplepi.dts > index b8c5db2344aa..eb555f385283 100644 > --- a/arch/arm/boot/dts/owl-s500-roseapplepi.dts > +++ b/arch/arm/boot/dts/owl-s500-roseapplepi.dts > @@ -225,6 +225,27 @@ bias1-pinconf { > bias-pull-down; > }; > }; > + > + ethernet_pins: ethernet-pins { > + eth_rmii-pinmux { > + groups = "rmii_txd0_mfp", "rmii_txd1_mfp", > + "rmii_rxd0_mfp", "rmii_rxd1_mfp", > + "rmii_txen_mfp", "rmii_rxen_mfp", > + "rmii_crs_dv_mfp", "rmii_ref_clk_mfp"; > + function = "eth_rmii"; > + }; > + > + phy_clk-pinmux { > + groups = "clko_25m_mfp"; > + function = "clko_25m"; > + }; > + > + ref_clk-pinconf { > + groups = "rmii_ref_clk_drv"; > + drive-strength = <2>; > + }; > + > + }; > }; > > /* uSD */ > @@ -241,6 +262,30 @@ &mmc0 { > vqmmc-supply = <&sd_vcc>; > }; > > +ðernet { > + pinctrl-names = "default"; > + pinctrl-0 = <ðernet_pins>; > + phy-mode = "rmii"; > + phy-handle = <ð_phy>; > + status = "okay"; > + > + mdio { > + #address-cells = <1>; > + #size-cells = <0>; > + > + reset-gpios = <&pinctrl 88 GPIO_ACTIVE_LOW>; /* GPIOC24 */ > + reset-delay-us = <10000>; > + reset-post-delay-us = <150000>; > + > + eth_phy: ethernet-phy@3 { > + reg = <0x3>; > + max-speed = <100>; > + interrupt-parent = <&sirq>; > + interrupts = <0 IRQ_TYPE_LEVEL_LOW>; > + }; > + }; > +}; > + > &twd_timer { > status = "okay"; > }; > -- > 2.32.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v2 0/2] Add Ethernet DTS for Actions Semi Owl S500 SoCs 2021-06-11 9:11 ` Cristian Ciocaltea @ 2021-06-14 11:28 ` Manivannan Sadhasivam -1 siblings, 0 replies; 24+ messages in thread From: Manivannan Sadhasivam @ 2021-06-14 11:28 UTC (permalink / raw) To: Cristian Ciocaltea Cc: Rob Herring, Andreas Färber, devicetree, linux-arm-kernel, linux-actions, linux-kernel On Fri, Jun 11, 2021 at 12:11:31PM +0300, Cristian Ciocaltea wrote: > This patchset adds the required DTS changes for providing the ethernet > functionality on the Actions S500 SoCs family. > > For the moment I have been able to test the Ethernet MAC on the RoseaplePi > SBC only. > > Also, please note the patches depend on some clock changes that are > currently under review: > https://lore.kernel.org/lkml/cover.1623354574.git.cristian.ciocaltea@gmail.com/ > Waiting for the clk patches to be merged... Thanks, Mani > Thanks, > Cristi > > Changes in v2: > - Added Reviewed-by tag from Mani in patch 1/2 > - Joined the groups sharing common function "eth_rmii" and switch the > order of "ref_clk-pinconf" and "phy_clk-pinmux", per Mani's review, > in patch 2/2 > > Cristian Ciocaltea (2): > ARM: dts: owl-s500: Add ethernet support > ARM: dts: owl-s500-roseapplepi: Add ethernet support > > arch/arm/boot/dts/owl-s500-roseapplepi.dts | 45 ++++++++++++++++++++++ > arch/arm/boot/dts/owl-s500.dtsi | 10 +++++ > 2 files changed, 55 insertions(+) > > -- > 2.32.0 > ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v2 0/2] Add Ethernet DTS for Actions Semi Owl S500 SoCs @ 2021-06-14 11:28 ` Manivannan Sadhasivam 0 siblings, 0 replies; 24+ messages in thread From: Manivannan Sadhasivam @ 2021-06-14 11:28 UTC (permalink / raw) To: Cristian Ciocaltea Cc: Rob Herring, Andreas Färber, devicetree, linux-arm-kernel, linux-actions, linux-kernel On Fri, Jun 11, 2021 at 12:11:31PM +0300, Cristian Ciocaltea wrote: > This patchset adds the required DTS changes for providing the ethernet > functionality on the Actions S500 SoCs family. > > For the moment I have been able to test the Ethernet MAC on the RoseaplePi > SBC only. > > Also, please note the patches depend on some clock changes that are > currently under review: > https://lore.kernel.org/lkml/cover.1623354574.git.cristian.ciocaltea@gmail.com/ > Waiting for the clk patches to be merged... Thanks, Mani > Thanks, > Cristi > > Changes in v2: > - Added Reviewed-by tag from Mani in patch 1/2 > - Joined the groups sharing common function "eth_rmii" and switch the > order of "ref_clk-pinconf" and "phy_clk-pinmux", per Mani's review, > in patch 2/2 > > Cristian Ciocaltea (2): > ARM: dts: owl-s500: Add ethernet support > ARM: dts: owl-s500-roseapplepi: Add ethernet support > > arch/arm/boot/dts/owl-s500-roseapplepi.dts | 45 ++++++++++++++++++++++ > arch/arm/boot/dts/owl-s500.dtsi | 10 +++++ > 2 files changed, 55 insertions(+) > > -- > 2.32.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v2 0/2] Add Ethernet DTS for Actions Semi Owl S500 SoCs 2021-06-14 11:28 ` Manivannan Sadhasivam @ 2021-06-14 12:11 ` Cristian Ciocaltea -1 siblings, 0 replies; 24+ messages in thread From: Cristian Ciocaltea @ 2021-06-14 12:11 UTC (permalink / raw) To: Manivannan Sadhasivam Cc: Rob Herring, Andreas Färber, devicetree, linux-arm-kernel, linux-actions, linux-kernel On Mon, Jun 14, 2021 at 04:58:31PM +0530, Manivannan Sadhasivam wrote: > On Fri, Jun 11, 2021 at 12:11:31PM +0300, Cristian Ciocaltea wrote: > > This patchset adds the required DTS changes for providing the ethernet > > functionality on the Actions S500 SoCs family. > > > > For the moment I have been able to test the Ethernet MAC on the RoseaplePi > > SBC only. > > > > Also, please note the patches depend on some clock changes that are > > currently under review: > > https://lore.kernel.org/lkml/cover.1623354574.git.cristian.ciocaltea@gmail.com/ > > > > Waiting for the clk patches to be merged... Thanks, Mani! Hopefully Stephen is going to pick them up in time.. Kind regards, Cristi > Thanks, > Mani > > > Thanks, > > Cristi > > > > Changes in v2: > > - Added Reviewed-by tag from Mani in patch 1/2 > > - Joined the groups sharing common function "eth_rmii" and switch the > > order of "ref_clk-pinconf" and "phy_clk-pinmux", per Mani's review, > > in patch 2/2 > > > > Cristian Ciocaltea (2): > > ARM: dts: owl-s500: Add ethernet support > > ARM: dts: owl-s500-roseapplepi: Add ethernet support > > > > arch/arm/boot/dts/owl-s500-roseapplepi.dts | 45 ++++++++++++++++++++++ > > arch/arm/boot/dts/owl-s500.dtsi | 10 +++++ > > 2 files changed, 55 insertions(+) > > > > -- > > 2.32.0 > > ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v2 0/2] Add Ethernet DTS for Actions Semi Owl S500 SoCs @ 2021-06-14 12:11 ` Cristian Ciocaltea 0 siblings, 0 replies; 24+ messages in thread From: Cristian Ciocaltea @ 2021-06-14 12:11 UTC (permalink / raw) To: Manivannan Sadhasivam Cc: Rob Herring, Andreas Färber, devicetree, linux-arm-kernel, linux-actions, linux-kernel On Mon, Jun 14, 2021 at 04:58:31PM +0530, Manivannan Sadhasivam wrote: > On Fri, Jun 11, 2021 at 12:11:31PM +0300, Cristian Ciocaltea wrote: > > This patchset adds the required DTS changes for providing the ethernet > > functionality on the Actions S500 SoCs family. > > > > For the moment I have been able to test the Ethernet MAC on the RoseaplePi > > SBC only. > > > > Also, please note the patches depend on some clock changes that are > > currently under review: > > https://lore.kernel.org/lkml/cover.1623354574.git.cristian.ciocaltea@gmail.com/ > > > > Waiting for the clk patches to be merged... Thanks, Mani! Hopefully Stephen is going to pick them up in time.. Kind regards, Cristi > Thanks, > Mani > > > Thanks, > > Cristi > > > > Changes in v2: > > - Added Reviewed-by tag from Mani in patch 1/2 > > - Joined the groups sharing common function "eth_rmii" and switch the > > order of "ref_clk-pinconf" and "phy_clk-pinmux", per Mani's review, > > in patch 2/2 > > > > Cristian Ciocaltea (2): > > ARM: dts: owl-s500: Add ethernet support > > ARM: dts: owl-s500-roseapplepi: Add ethernet support > > > > arch/arm/boot/dts/owl-s500-roseapplepi.dts | 45 ++++++++++++++++++++++ > > arch/arm/boot/dts/owl-s500.dtsi | 10 +++++ > > 2 files changed, 55 insertions(+) > > > > -- > > 2.32.0 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 24+ messages in thread
end of thread, other threads:[~2021-06-28 7:33 UTC | newest] Thread overview: 24+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-06-11 9:11 [PATCH v2 0/2] Add Ethernet DTS for Actions Semi Owl S500 SoCs Cristian Ciocaltea 2021-06-11 9:11 ` Cristian Ciocaltea 2021-06-11 9:11 ` [PATCH v2 1/2] ARM: dts: owl-s500: Add ethernet support Cristian Ciocaltea 2021-06-11 9:11 ` Cristian Ciocaltea 2021-06-16 13:30 ` kernel test robot 2021-06-16 13:30 ` kernel test robot 2021-06-16 13:30 ` kernel test robot 2021-06-28 6:22 ` Manivannan Sadhasivam 2021-06-28 6:22 ` Manivannan Sadhasivam 2021-06-28 6:22 ` Manivannan Sadhasivam 2021-06-28 7:02 ` Cristian Ciocaltea 2021-06-28 7:02 ` Cristian Ciocaltea 2021-06-28 7:02 ` Cristian Ciocaltea 2021-06-28 7:31 ` Manivannan Sadhasivam 2021-06-28 7:31 ` Manivannan Sadhasivam 2021-06-28 7:31 ` Manivannan Sadhasivam 2021-06-11 9:11 ` [PATCH v2 2/2] ARM: dts: owl-s500-roseapplepi: " Cristian Ciocaltea 2021-06-11 9:11 ` Cristian Ciocaltea 2021-06-14 11:27 ` Manivannan Sadhasivam 2021-06-14 11:27 ` Manivannan Sadhasivam 2021-06-14 11:28 ` [PATCH v2 0/2] Add Ethernet DTS for Actions Semi Owl S500 SoCs Manivannan Sadhasivam 2021-06-14 11:28 ` Manivannan Sadhasivam 2021-06-14 12:11 ` Cristian Ciocaltea 2021-06-14 12:11 ` Cristian Ciocaltea
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.