[Buildroot] [PATCH 1/1] package/gesftpserver: Add host-python as dependency

[Buildroot] [PATCH 1/1] package/gesftpserver: Add host-python as dependency

[Andreas Naumann]

gesftpserver needs python for the configure step.

Signed-off-by: Andreas Naumann <anaumann@ultratronik.de>
---
 package/gesftpserver/gesftpserver.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/gesftpserver/gesftpserver.mk b/package/gesftpserver/gesftpserver.mk
index 85511a3c97..c67fdb3f79 100644
--- a/package/gesftpserver/gesftpserver.mk
+++ b/package/gesftpserver/gesftpserver.mk
@@ -19,7 +19,7 @@ GESFTPSERVER_CPE_ID_PRODUCT = sftpserver
 GESFTPSERVER_CONF_ENV = LIBS=-lpthread
 
 # overwrite openssh version if enabled
-GESFTPSERVER_DEPENDENCIES += \
+GESFTPSERVER_DEPENDENCIES += host-python \
 	$(if $(BR2_ENABLE_LOCALE),,libiconv) \
 	$(if $(BR2_PACKAGE_OPENSSH),openssh)
 
-- 
2.32.0

[Buildroot] [PATCH 1/1] package/gesftpserver: Add host-python as dependency

[Baruch Siach]

Hi Andreas,

On Wed, Jun 23 2021, Andreas Naumann wrote:
> gesftpserver needs python for the configure step.
>
> Signed-off-by: Andreas Naumann <anaumann@ultratronik.de>
> ---
>  package/gesftpserver/gesftpserver.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/gesftpserver/gesftpserver.mk b/package/gesftpserver/gesftpserver.mk
> index 85511a3c97..c67fdb3f79 100644
> --- a/package/gesftpserver/gesftpserver.mk
> +++ b/package/gesftpserver/gesftpserver.mk
> @@ -19,7 +19,7 @@ GESFTPSERVER_CPE_ID_PRODUCT = sftpserver
>  GESFTPSERVER_CONF_ENV = LIBS=-lpthread
>  
>  # overwrite openssh version if enabled
> -GESFTPSERVER_DEPENDENCIES += \
> +GESFTPSERVER_DEPENDENCIES += host-python \

Does host-python3 also work? We would probably drop python2 in the near
future.

baruch

>  	$(if $(BR2_ENABLE_LOCALE),,libiconv) \
>  	$(if $(BR2_PACKAGE_OPENSSH),openssh)


-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

[Buildroot] [PATCH 1/1] package/gesftpserver: Add host-python as dependency

[Peter Korsgaard]

>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:

 > Hi Andreas,
 > On Wed, Jun 23 2021, Andreas Naumann wrote:
 >> gesftpserver needs python for the configure step.
 >> 
 >> Signed-off-by: Andreas Naumann <anaumann@ultratronik.de>
 >> ---
 >> package/gesftpserver/gesftpserver.mk | 2 +-
 >> 1 file changed, 1 insertion(+), 1 deletion(-)
 >> 
 >> diff --git a/package/gesftpserver/gesftpserver.mk b/package/gesftpserver/gesftpserver.mk
 >> index 85511a3c97..c67fdb3f79 100644
 >> --- a/package/gesftpserver/gesftpserver.mk
 >> +++ b/package/gesftpserver/gesftpserver.mk
 >> @@ -19,7 +19,7 @@ GESFTPSERVER_CPE_ID_PRODUCT = sftpserver
 >> GESFTPSERVER_CONF_ENV = LIBS=-lpthread
 >> 
 >> # overwrite openssh version if enabled
 >> -GESFTPSERVER_DEPENDENCIES += \
 >> +GESFTPSERVER_DEPENDENCIES += host-python \

 > Does host-python3 also work? We would probably drop python2 in the near
 > future.

Exactly. Looking at it, python also only seems to be used for the tests
that we do not need to run, so it is a bit silly to have to pull in
host-python3.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH 1/1] package/gesftpserver: Add host-python as dependency

[Andreas Naumann]

Hi,

On 23.06.21 11:35, Peter Korsgaard wrote:
>>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:
> 
>   > Hi Andreas,
>   > On Wed, Jun 23 2021, Andreas Naumann wrote:
>   >> gesftpserver needs python for the configure step.
>   >>
>   >> Signed-off-by: Andreas Naumann <anaumann@ultratronik.de>
>   >> ---
>   >> package/gesftpserver/gesftpserver.mk | 2 +-
>   >> 1 file changed, 1 insertion(+), 1 deletion(-)
>   >>
>   >> diff --git a/package/gesftpserver/gesftpserver.mk b/package/gesftpserver/gesftpserver.mk
>   >> index 85511a3c97..c67fdb3f79 100644
>   >> --- a/package/gesftpserver/gesftpserver.mk
>   >> +++ b/package/gesftpserver/gesftpserver.mk
>   >> @@ -19,7 +19,7 @@ GESFTPSERVER_CPE_ID_PRODUCT = sftpserver
>   >> GESFTPSERVER_CONF_ENV = LIBS=-lpthread
>   >>
>   >> # overwrite openssh version if enabled
>   >> -GESFTPSERVER_DEPENDENCIES += \
>   >> +GESFTPSERVER_DEPENDENCIES += host-python \
> 
>   > Does host-python3 also work? We would probably drop python2 in the near
>   > future.

So I just tried and yes, host-python3 does the job.

> 
> Exactly. Looking at it, python also only seems to be used for the tests
> that we do not need to run, so it is a bit silly to have to pull in
> host-python3.

Ok, i didnt look why Python is needed. Also, I never saw the problem 
until using per-package build. So buildtime-wise it's not a problem in 
my case because we pull in host-python for some other package anyway.

I will check if I can get rid of the tests though.

regards,
Andreas

> 

[Buildroot] [PATCH 1/1] package/gesftpserver: Add host-python as dependency

[Andreas Naumann]

Hi

On 23.06.21 12:00, Andreas Naumann wrote:
> Hi,
> 
> On 23.06.21 11:35, Peter Korsgaard wrote:
>>>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:
>>
>> ? > Hi Andreas,
>> ? > On Wed, Jun 23 2021, Andreas Naumann wrote:
>> ? >> gesftpserver needs python for the configure step.
>> ? >>
>> ? >> Signed-off-by: Andreas Naumann <anaumann@ultratronik.de>
>> ? >> ---
>> ? >> package/gesftpserver/gesftpserver.mk | 2 +-
>> ? >> 1 file changed, 1 insertion(+), 1 deletion(-)
>> ? >>
>> ? >> diff --git a/package/gesftpserver/gesftpserver.mk 
>> b/package/gesftpserver/gesftpserver.mk
>> ? >> index 85511a3c97..c67fdb3f79 100644
>> ? >> --- a/package/gesftpserver/gesftpserver.mk
>> ? >> +++ b/package/gesftpserver/gesftpserver.mk
>> ? >> @@ -19,7 +19,7 @@ GESFTPSERVER_CPE_ID_PRODUCT = sftpserver
>> ? >> GESFTPSERVER_CONF_ENV = LIBS=-lpthread
>> ? >>
>> ? >> # overwrite openssh version if enabled
>> ? >> -GESFTPSERVER_DEPENDENCIES += \
>> ? >> +GESFTPSERVER_DEPENDENCIES += host-python \
>>
>> ? > Does host-python3 also work? We would probably drop python2 in the 
>> near
>> ? > future.
> 
> So I just tried and yes, host-python3 does the job.
> 
>>
>> Exactly. Looking at it, python also only seems to be used for the tests
>> that we do not need to run, so it is a bit silly to have to pull in
>> host-python3.
> 
> Ok, i didnt look why Python is needed. Also, I never saw the problem 
> until using per-package build. So buildtime-wise it's not a problem in 
> my case because we pull in host-python for some other package anyway.
> 
> I will check if I can get rid of the tests though.

... The configure script does not provide an option to skip test, so I 
could patch the configure script or somehow fake that python is there 
even if it doesnt. Both solutions seem not very elegant to so if you 
agree I'd just repost the patch with host-python3 as dependency.

regards,
Andreas

> 
> regards,
> Andreas
> 
>>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
> 

[Buildroot] [PATCH 1/1] package/gesftpserver: Add host-python as dependency

[Peter Korsgaard]

>>>>> "Andreas" == Andreas Naumann <dev@andin.de> writes:

Hi,

 >> Ok, i didnt look why Python is needed. Also, I never saw the problem
 >> until using per-package build. So buildtime-wise it's not a problem
 >> in my case because we pull in host-python for some other package
 >> anyway.
 >> 
 >> I will check if I can get rid of the tests though.

 > ... The configure script does not provide an option to skip test, so I
 > could patch the configure script or somehow fake that python is there
 > even if it doesnt. Both solutions seem not very elegant to so if you
 > agree I'd just repost the patch with host-python3 as dependency.

A simple hack would just to pass rjk_cv_python24=true in
GESFTPSERVER_CONF_ENV.

The tests themselves are afaik only executed if you run 'make check'
(which we don't).

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH 1/1] package/gesftpserver: Add host-python as dependency

[Andreas Naumann]

Hi Peter,

On 23.06.21 13:45, Peter Korsgaard wrote:
>>>>>> "Andreas" == Andreas Naumann <dev@andin.de> writes:
> 
> Hi,
> 
>   >> Ok, i didnt look why Python is needed. Also, I never saw the problem
>   >> until using per-package build. So buildtime-wise it's not a problem
>   >> in my case because we pull in host-python for some other package
>   >> anyway.
>   >>
>   >> I will check if I can get rid of the tests though.
> 
>   > ... The configure script does not provide an option to skip test, so I
>   > could patch the configure script or somehow fake that python is there
>   > even if it doesnt. Both solutions seem not very elegant to so if you
>   > agree I'd just repost the patch with host-python3 as dependency.
> 
> A simple hack would just to pass rjk_cv_python24=true in
> GESFTPSERVER_CONF_ENV.

just send v2 with your suggestion, but slightly altered because telling 
configure that Python is not there also works.

regards,
Andreas

> 
> The tests themselves are afaik only executed if you run 'make check'
> (which we don't).
> 

[Buildroot] [PATCH 1/1] package/gesftpserver: Add host-python as dependency

[Thomas Petazzoni]

On Wed, 23 Jun 2021 10:36:34 +0200
Andreas Naumann <anaumann@ultratronik.de> wrote:

> gesftpserver needs python for the configure step.
> 
> Signed-off-by: Andreas Naumann <anaumann@ultratronik.de>
> ---
>  package/gesftpserver/gesftpserver.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

I've marked as Changes Requested in patchwork, since you posted v2, and
I have already applied v2.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com