From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Claudiu Beznea <claudiu.beznea@microchip.com>,
Lee Jones <lee.jones@linaro.org>,
linux-pwm@vger.kernel.org,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Ludovic Desroches <ludovic.desroches@microchip.com>,
kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] pwm: atmel: rework tracking updates pending in hardware
Date: Mon, 5 Jul 2021 09:55:47 +0200 [thread overview]
Message-ID: <20210705075547.5feystwquxamsxfr@pengutronix.de> (raw)
In-Reply-To: <20210421092606.1634092-1-u.kleine-koenig@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 1353 bytes --]
Hello Thierry,
On Wed, Apr 21, 2021 at 11:26:08AM +0200, Uwe Kleine-König wrote:
> This improves the driver's behavior in several ways:
>
> - The lock is held for shorter periods and so a channel that is currently
> waited for doesn't block disabling another channel.
>
> - It's easier to understand because the procedure is split into more
> semantic units and documentation is improved
>
> - A channel is only set to pending when such an event is actually
> scheduled in hardware (by writing the CUPD register).
>
> - Also wait in .get_state() to report the last configured state instead
> of (maybe) the previous one. This fixes the read back duty cycle and so
> prevents a warning being emitted when PWM_DEBUG is on.
>
> Tested on an AriettaG25.
On patchwork this patch is in the state "Under Review". Did you change
this? What does this mean? Does indeed someone look into this patch?
There was some discussion in reply to this patch, but that doesn't
affect correctness of it. It's just that there are still some problems
in the driver that this patch doesn't address, but the net effect of it
is still positive.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: linux-pwm@vger.kernel.org,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Ludovic Desroches <ludovic.desroches@microchip.com>,
kernel@pengutronix.de, Lee Jones <lee.jones@linaro.org>,
Claudiu Beznea <claudiu.beznea@microchip.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] pwm: atmel: rework tracking updates pending in hardware
Date: Mon, 5 Jul 2021 09:55:47 +0200 [thread overview]
Message-ID: <20210705075547.5feystwquxamsxfr@pengutronix.de> (raw)
In-Reply-To: <20210421092606.1634092-1-u.kleine-koenig@pengutronix.de>
[-- Attachment #1.1: Type: text/plain, Size: 1353 bytes --]
Hello Thierry,
On Wed, Apr 21, 2021 at 11:26:08AM +0200, Uwe Kleine-König wrote:
> This improves the driver's behavior in several ways:
>
> - The lock is held for shorter periods and so a channel that is currently
> waited for doesn't block disabling another channel.
>
> - It's easier to understand because the procedure is split into more
> semantic units and documentation is improved
>
> - A channel is only set to pending when such an event is actually
> scheduled in hardware (by writing the CUPD register).
>
> - Also wait in .get_state() to report the last configured state instead
> of (maybe) the previous one. This fixes the read back duty cycle and so
> prevents a warning being emitted when PWM_DEBUG is on.
>
> Tested on an AriettaG25.
On patchwork this patch is in the state "Under Review". Did you change
this? What does this mean? Does indeed someone look into this patch?
There was some discussion in reply to this patch, but that doesn't
affect correctness of it. It's just that there are still some problems
in the driver that this patch doesn't address, but the net effect of it
is still positive.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-07-05 7:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 9:51 [PATCH 1/2] pwm: atmel: Fix duty cycle calculation in .get_state() Uwe Kleine-König
2021-04-20 9:51 ` Uwe Kleine-König
2021-04-20 9:51 ` [PATCH 2/2] pwm: atmel: Improve duty cycle calculation in .apply() Uwe Kleine-König
2021-04-20 9:51 ` Uwe Kleine-König
2021-04-23 17:07 ` Thierry Reding
2021-04-23 17:07 ` Thierry Reding
2021-04-21 9:26 ` [PATCH] pwm: atmel: rework tracking updates pending in hardware Uwe Kleine-König
2021-04-21 9:26 ` Uwe Kleine-König
2021-04-21 11:03 ` overflow and wrong timeout errors in pwm-atmel Uwe Kleine-König
2021-04-21 13:48 ` Uwe Kleine-König
2021-04-21 13:48 ` Uwe Kleine-König
2021-04-21 14:18 ` Alexandre Belloni
2021-04-21 14:18 ` Alexandre Belloni
2021-04-21 15:26 ` Uwe Kleine-König
2021-04-21 15:26 ` Uwe Kleine-König
2021-07-05 7:55 ` Uwe Kleine-König [this message]
2021-07-05 7:55 ` [PATCH] pwm: atmel: rework tracking updates pending in hardware Uwe Kleine-König
2021-04-23 17:07 ` [PATCH 1/2] pwm: atmel: Fix duty cycle calculation in .get_state() Thierry Reding
2021-04-23 17:07 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210705075547.5feystwquxamsxfr@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@microchip.com \
--cc=kernel@pengutronix.de \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=nicolas.ferre@microchip.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.