All of lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t V2] tests/kms_plane_multiple: Start continuous CRC capture after commit
@ 2021-06-28 13:14 Anson Jacob
  2021-06-28 13:50 ` Harry Wentland
                   ` (4 more replies)
  0 siblings, 5 replies; 8+ messages in thread
From: Anson Jacob @ 2021-06-28 13:14 UTC (permalink / raw)
  To: igt-dev; +Cc: Petri Latvala, Anson Jacob, Victor Lu

From: Victor Lu <victorchengchi.lu@amd.com>

atomic-pipe-a-tiling-none fails on amdgpu(Raven) because it fails to read the
CRC when there is no CRC generated (zeroed framebuffer). Move
igt_pipe_crc_start to be called after the first nonzero FB commit.

Signed-off-by: Victor Lu <victorchengchi.lu@amd.com>
Acked-by: Anson Jacob <Anson.Jacob@amd.com>
Cc: Petri Latvala <petri.latvala@intel.com>
Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Cc: Harry Wentland <harry.wentland@amd.com>
Cc: Mark Yacoub <markyacoub@chromium.org>
---
 tests/kms_plane_multiple.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/tests/kms_plane_multiple.c b/tests/kms_plane_multiple.c
index 93c6ea7d269d..4424b864b2d6 100644
--- a/tests/kms_plane_multiple.c
+++ b/tests/kms_plane_multiple.c
@@ -288,6 +288,7 @@ test_plane_position_with_output(data_t *data, enum pipe pipe,
 	igt_plane_t *plane;
 	int i;
 	int err, c = 0;
+	int crc_enabled = 0;
 	int iterations = opt.iterations < 1 ? 1 : opt.iterations;
 	bool loop_forever;
 	char info[256];
@@ -327,14 +328,16 @@ test_plane_position_with_output(data_t *data, enum pipe pipe,
 		 igt_output_name(output), kmstest_pipe_name(pipe), c,
 		 info, opt.seed);
 
-	igt_pipe_crc_start(data->pipe_crc);
-
 	i = 0;
 	while (i < iterations || loop_forever) {
 		/* randomize planes and set up the holes */
 		prepare_planes(data, pipe, &blue, tiling, c, output);
 
 		igt_display_commit2(&data->display, COMMIT_ATOMIC);
+		if (!crc_enabled) {
+			igt_pipe_crc_start(data->pipe_crc);
+			crc_enabled = 1;
+		}
 
 		igt_pipe_crc_get_current(data->display.drm_fd, data->pipe_crc, &crc);
 
-- 
2.25.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-07-06 16:22 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-28 13:14 [igt-dev] [PATCH i-g-t V2] tests/kms_plane_multiple: Start continuous CRC capture after commit Anson Jacob
2021-06-28 13:50 ` Harry Wentland
2021-06-28 15:46 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane_multiple: Start continuous CRC capture after commit (rev2) Patchwork
2021-06-28 19:20 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2021-07-06 12:45 ` [igt-dev] [PATCH i-g-t V2] tests/kms_plane_multiple: Start continuous CRC capture after commit Rodrigo Siqueira
2021-07-06 13:47   ` Juha-Pekka Heikkila
2021-07-06 16:21     ` Vudum, Lakshminarayana
2021-07-06 16:02 ` [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_plane_multiple: Start continuous CRC capture after commit (rev2) Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.